- 28 Apr, 2018 35 commits
-
-
Emily Stark authored
This CL enables the HTTP-Bad feature by default and sets it to warn on all http:// pages, and updates tests accordingly. Bug: 837034 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I470aa09220df9e02833de8f8636ea2e66e2a6b05 Reviewed-on: https://chromium-review.googlesource.com/1029415 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#554605}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bf02b736..90942960 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I21bd1f8ac887fd53615281c1f696e03bb86536cd Reviewed-on: https://chromium-review.googlesource.com/1033933Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554604}
-
John Budorick authored
This reverts commit 13dfb327. Reason for revert: Suspected cause of many test failures in https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71676 Original change's description: > Load resources.pak earlier in service manager main > > We need to use the content in resources.pak in service manager, but at > that time resource bundle has not been initialized. Create data pack to > load resources.pak and append the data pack to resource bundle during the > initialization. > > Move path FILE_RESOURCES_PACK from chrome_paths.h to ui_base_paths.cc. > > Bug: 729596, 815230 > Change-Id: Iec3a9409cbd9c10775afb72944e66e26650f1181 > Reviewed-on: https://chromium-review.googlesource.com/962679 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Xi Han <hanxi@chromium.org> > Commit-Queue: Ran Ji <ranj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554500} TBR=sky@chromium.org,yfriedman@chromium.org,rockot@chromium.org,hanxi@chromium.org,ranj@chromium.org Change-Id: Ia23016b542b772581096492898b57f6c6ed3e075 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 729596, 815230 Reviewed-on: https://chromium-review.googlesource.com/1034132Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554603}
-
https://skia.googlesource.com/skia.git/+log/34a388edbd27..275df2e87306 $ git log 34a388edb..275df2e87 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 bungeman Just pass color glyph masks to filters. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Icabb57b36bbd525f4e585b7ac09d4ece88b37a20 Reviewed-on: https://chromium-review.googlesource.com/1034026 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554602}
-
Siddhartha authored
This reverts commit cc0afbf7. Reason for revert: Move the variable to test file and use it only on official builds. Both Chromeos component and official build works. Original change's description: > Revert "Add utils to read elf binary and get Build id" > > This reverts commit 61248f1a. > > Reason for revert: Suspected breaking component builds (bug 837817) > > Original change's description: > > Add utils to read elf binary and get Build id > > > > Adds code to parse elf binary to get build id from > > .note.gnu.build-id section. The build ID is needed to symbolize > > heap dumps from the users. > > > > BUG=734705 > > > > Change-Id: If4365e232c060ba96071ba1e1c43618f9807e39c > > Reviewed-on: https://chromium-review.googlesource.com/1028995 > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#554304} > > TBR=thestig@chromium.org,ssid@chromium.org > > Change-Id: If512434b55bcc912990e3997a86f6f93722b15fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 734705 > Reviewed-on: https://chromium-review.googlesource.com/1033795 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554532} TBR=thestig@chromium.org,ssid@chromium.org,thomasanderson@chromium.org Change-Id: Ie2fb8f7fe0759dc418a1bc4ffc57bdb4542ba606 Bug: 734705, 837817 Reviewed-on: https://chromium-review.googlesource.com/1033498 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#554601}
-
https://chromium.googlesource.com/catapult.git/+log/32f02b5d358b..a4814ecb93e6 $ git log 32f02b5d3..a4814ecb9 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 dtu [pinpoint] Refactor Job creation and /api/new handler. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I0c7778c140a2dbe12bf6876b8582e16640d2f963 Reviewed-on: https://chromium-review.googlesource.com/1033809 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554600}
-
Tommy Steimel authored
This is a reland of crrev.com/c/1028483. This CL removes a CSS rule that centered the audio element on the MediaDocument page. This fixes an issue where the overflow menu position calculation was incorrect. Bug: 835279 Change-Id: I028383f5201c5bee741a6fb5dd5a825a9a808736 Reviewed-on: https://chromium-review.googlesource.com/1033914 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#554599}
-
Scott Chen authored
This CL does the following: - add an <iron-collapse> containing <settings-personalization-options> in the sync subpage when unified-consent is enabled. - hide <settings-personalization-options> when unified-consent is enabled, and instead show description with a link to the sync subpage. screenshots: https://imgur.com/a/3keIzR3 Bug: 800973, 800975 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I94e0e2abde13c9260f5dbd8a0a444244c556f253 Reviewed-on: https://chromium-review.googlesource.com/1025314 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554598}
-
Emily Hanley authored
Bug: 836037 Change-Id: I9a927fe4655261a77965ca27cdfcf1055a9a0f1d Reviewed-on: https://chromium-review.googlesource.com/1030773 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
David Tu <dtu@chromium.org> Cr-Commit-Position: refs/heads/master@{#554597}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fd804ac5704..8c9979e745c1 $ git log 3fd804ac5..8c9979e74 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:822826 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie787ee640402b0e7427e8ee809813608f4774b5f Reviewed-on: https://chromium-review.googlesource.com/1034001Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554596}
-
https://pdfium.googlesource.com/pdfium.git/+log/65c255ad2076..7c7f78a432a4 $ git log 65c255ad2..7c7f78a43 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 tsepez Tidy cfx_gif.h. 2018-04-27 thestig Remove an obsolete TODO. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I69c67011b0219a9cb07db32dd91caca43b877934 Reviewed-on: https://chromium-review.googlesource.com/1034020 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554595}
-
Alexei Filippov authored
There were small visual misaligment issues that has been fixed. BUG=837760 Change-Id: I7724ec5165140344b966cf7133799eb1bad1f808 Reviewed-on: https://chromium-review.googlesource.com/1033588Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#554594}
-
Ted Choc authored
There has been a very long standing bug where FindToolbar#deactivate would crash because it was being called again during the initial processing. The cause of this (at least I think) is that deactivate causes some Android views to hide. That causes the parent view group to recalculate the desired focus target. In some cases, it finds the omnibox and triggers that to gain focus. When the omnibox gains focus, it tells FIP to hide itself, but since the focus happened in the original deactivate call, it has now re-entered deactivate and crashes. The solution (as proposed) is to introduce transitional states between active and deactive and handle them accordingly. If an activate call comes while processing deactive, it is postponed until the deactive fully finishes. BUG=830253,624332 Change-Id: I12eed279921667eb7340332ffb2991f256c12796 Reviewed-on: https://chromium-review.googlesource.com/1033484 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#554593}
-
Alexei Filippov authored
BUG=836030 Change-Id: I0a11b2dd04b21b06a33e0fd9e20c9cc299901c6f Reviewed-on: https://chromium-review.googlesource.com/1032232 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Alexei Filippov authored
BUG=836030 Change-Id: I8c01d3186568ac162cc1be118dd8faf06fcee074 Reviewed-on: https://chromium-review.googlesource.com/1033327Reviewed-by:
-
Tien-Ren Chen authored
This CL adds a new Blink compositing mode somewhere between SPv1.75 and SPv2. In this mode, layerization decisions will still be made by legacy PaintLayerCompositor/CompositedLayerMapping, but we won't be using the GraphicsLayer hierarchy generated in Blink. Instead, only the layers that host actual painted content will be generated, while the "meta" layers that apply properties (e.g. clip, effects) to the subtree will be gone. The cc-side property tree builder use to reverse engineer property trees from the meta layers (see cc/trees/property_tree_builder.cc). With the new compositing mode, the cc property trees will be created from the blink property trees directly by PaintArtifactCompositor (PAC). This is done by plugging all the drawable layers to PAC as foreign layers, and PAC will convert all the referenced blink property nodes to cc property nodes. This new mode can be enabled by passing a command line flag: --enable-blink-gen-property-trees Currently many critical mechanisms are still missing. Static pages are expected to display correctly, while most impl-thread mutations are likely to trigger a DCHECK or outright crash the renderer. BUG=836886 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I983f4bcd5f91440b5e11182e7cbe6313015d3fb4 Reviewed-on: https://chromium-review.googlesource.com/1031732 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554590}
-
Renee Wright authored
This CL adds a new settings section - crostini-page - to the basic settings page if --enable-features=ExperimentalCrostiniUI is set. If kCrostiniEnabled is false, crostini-page has a "TURN ON" button which launches the CrostiniInstallerView. Accepting the CrostiniInstallerView installs a new Crostini VM/Container. If kCrostiniEnabled is true crostini-page has an arrow to navigate to the subpage - crostini-subpage. On crostini-subpage there is a "REMOVE" button which launches a dialog to confirm removing the Crostini VM/Container. Confirming remove deletes the VM/Container, and navigates back to the basic settings page. Install/remove requests are all made by sending messages to CrostiniHandler via crostini_browser_proxy. -------------------------TO TEST THIS CL--------------------------- Patch this CL + this dependency CL - https://chromium-review.googlesource.com/c/chromium/src/+/1013824/ You may also want to patch the next CL in the set - https://chromium-review.googlesource.com/c/chromium/src/+/1023510 To make it possible to toggle the kCrostiniEnabled preference back to false in on ChromeOS on Linux you may need to change where we set it in CrostiniHandler.cc Build ChromeOS on Linux & run with --enable-features=ExperimentalCrostiniUI You can also test the full version by running it on an Eve ------------------------------------------------------------------ Bug: 833125 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If421b9780414336f058469f28192dd3c761cc7bf Reviewed-on: https://chromium-review.googlesource.com/1013957 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554589}
-
Daniel Kurtz authored
Currently the Microarchitecture table in cpu_identity only supports Intel Microarchitectures. In the future we will also want to support AMD microarchitectures, so rename all of the "IntelUarch" to the more generic "CpuUarch". BUG=b:69376360 TEST=unit_tests --gtest_filter="CpuIdentityTest.*" R=chongjiang@chromium.org, sque@chromium.org Change-Id: I57a7df62f86abba5203ab685cde62ee73db3da42 Reviewed-on: https://chromium-review.googlesource.com/1006372 Commit-Queue: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#554588}
-
Scott Little authored
It's possible for Frame::Detach() to be called before HTMLFrameOwnerElement::DisconnectContentFrame() is called, which means that if a lazy load is pending on that frame, this causes a DCHECK failure in debug builds and a crash in release builds. This CL changes the DCHECK asserting that there's no pending lazy load into a call to CancelPendingLazyLoad(). Bug: 837151, 773683 Change-Id: I1b4fae1a053aa57bd3f55585fddacf823ab81377 Reviewed-on: https://chromium-review.googlesource.com/1031386 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554587}
-
Kevin Bailey authored
The code has already been modified to assume this option if enabled. This CL actually removes the option. Bug: 780835 Change-Id: I6bc84f7eb7763136d1effc40659f65297396b7b8 Reviewed-on: https://chromium-review.googlesource.com/1033574 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#554586}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/179dd1e01695..65dbd539443e $ git log 179dd1e01..65dbd5394 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I227729f4c5d0cbe9977b58433eed4a2d5930b640 Reviewed-on: https://chromium-review.googlesource.com/1033723Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554585}
-
John Budorick authored
Also fix fuchsia layout test imports. TBR=dpranke@chromium.org,kmarshall@chromium.org,sahel@chromium.org Bug: 805057,837786 Change-Id: I9b90c985e95df053c2badce8038d57bef3f7cd8d Reviewed-on: https://chromium-review.googlesource.com/1034097Reviewed-by:
-
David Black authored
Part of a clean up effort to move assistant out of app_list. Bug: b:77637813 Change-Id: I5634cfb5511dfaf4bc000b3a007f4edcec1caba4 Reviewed-on: https://chromium-review.googlesource.com/1031737 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554583}
-
Thomas Guilbert authored
This fixes the crashes that have started appearing on Canary. Bug: 837836 Change-Id: I47b0b68a436fcc81970277d4cf20939d08b39bf5 Reviewed-on: https://chromium-review.googlesource.com/1034002Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#554582}
-
Bo Liu authored
Overall goal is to switch Crash related classes on Android to use content::ChildProcessTerminationInfo, which has more relevant termination information than is currently available. This is a set of related changes / fixes in order to make intentions and behaviors on Android clearer. * Change BrowserChildProcessHostImpl::OnChildDisconnected to always call BrowserChildProcessKilled (and BrowserChildProcessHostDelegate OnProcessCrashed), and explicitly document this behavior. This is because Android cannot distinguish between crashes and kills, and basing this decision on whether there was oom protection makes very little sense. Generally base::TerminationStatus does not convey much information. One concrete behavior change is that BrowserChildProcessKilled (and OnProcessCrashed) will now be called even when chrome app is in the background. * Corresponding to above, have CrashDumpObserver listen to BrowserChildProcessKilled instead of BrowserChildProcessCrashed. Crashed was never called anyway. Listening to Killed allows populating additional termination info. * Stop using base::TerminationStatus in crash, and use bool was_oom_protected_status instead, which is the only useful bit of information conveyed by TerminationStatus on Android. This also forces code to stop abusing other values of TerminationStatus for other purposes, ie added an explicit bool normal_exit instead of relying on NORMAL_EXIT. * FastShutdownStarted case is treated as a normal exit. Previously it was treated as a "normal crash", although with other fields unpopulated. components/data_reduction_proxy TBR TBR=tbansal@chromium.org Bug: 693484 Change-Id: I887dcff000ccbc38bbb9e4159c1c5bb27a0c8876 Reviewed-on: https://chromium-review.googlesource.com/1025042 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#554581}
-
Adam Langley authored
(This is a reland of 3a01c225.) Kim points out in the bug that the current logic (see https://chromium-review.googlesource.com/c/chromium/src/+/991073) doesn't allow dev tools to be focused, so it's not possible to trigger webauthn requests from the dev tools console. Nasko thought that the addition of a ContentBrowserClient API was too large a hammer too. I've not been able to come up with any cleaner solution however, but this change perhaps makes the hammer more reasonable: In order to address the devtools issue, this change switches the focus check to requiring that the tab be active in the focused window. (This also matches what the cryptotoken extension does.) This means that it has to chrome/ logic, rather than content/ logic, but we already had to add an API to ContentBrowserClient for this and we can reuse that to solve this problem too. This change also moves the final focus check when registering to the point after the press, but before any permissions bubble. This is because it turns out that we have five different UI focus behaviours across four platforms and doing the focus check after trying to close the bubble was a mistake. Additionally, this change adds an interactive_ui_test to ensure that we don't regress. TBR=thestig,nasko Bug: 827266,836203 Change-Id: I954164d79e8dd375060fcc780a800904fe547c12 Reviewed-on: https://chromium-review.googlesource.com/1033336 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#554580}
-
Jian Li authored
In DownloadController.requestFileAccess, we should check if storage permission is already granted before requesting it. Bug: 836397 Change-Id: Idadcdfc3b055696b8f7194e5d63bdee54a8d4959 Reviewed-on: https://chromium-review.googlesource.com/1029116Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554579}
-
David Benjamin authored
There are only two places left which use the notion of an "error domain", //components/error_page, and //ios. These two use them for different purposes and so they should define their own error domains. In particular, using net::kErrorDomain for NSError in iOS was never appropriate, since that string isn't globally-unique. See also: https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ErrorHandlingCocoa/ErrorObjectsDomains/ErrorObjectsDomains.html#//apple_ref/doc/uid/TP40001806-CH202-SW1 error_page_generator.mm required some care as it then took an NSError domain and passed it into //components/error_page. //components/error_page will actually DCHECK if given an unknown error domain and, in another codepath, assume all unknown error domains are HTTP error codes! Fortunately, following up the call chain a bit, ErrorPageGenerator is only called with a web::NetErrorFromError error code, so this doesn't come up. I've switched that to recognize the //net NSErrorDomain and, if not, default to net::ERR_FAILED with a NOTREACHED() to mirror the prior DCHECK. But probably that interface should be revised a bit. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I693b7e2a004bd91f852a0718b93e40b3b30f66ea Reviewed-on: https://chromium-review.googlesource.com/1017604 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554578}
-
Carlos Knippschild authored
The existing script to migrate the DB schema for Prefeching of Offline Pages from version 1 to 2 had references to code that could change as the schema evolved. This is very unsafe as changes to any exterior value should not change the migration code. This CL addresses that by making it not refer to any outside values. Bug: 701939 Change-Id: Ia0e1aff10a7fb381d9caeb747d056ff12cba2d1f Reviewed-on: https://chromium-review.googlesource.com/772975 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#554577}
-
Wez authored
Launchpad is a library provided in the Fuchsia SDK. Currently, its header files and link library are provided both in the sysroot and in an SDK package following Fucshia's standard layout (https://fuchsia.googlesource.com/docs/+/master/development/sdk/layout.md). This updates callers of the library to depend on the library through the package form so it can be removed from the sysroot. Also adds a fuchsia_sdk_lib_pkg() template, for use by SDK packages provided as pre-compiled libs. This is a rebase and extension of jamesr@'s https://chromium-review.googlesource.com/c/chromium/src/+/1026511 Bug: 707030 Change-Id: I79c6af4d63d991fe0e8e0a3285d9de815f68ce03 Reviewed-on: https://chromium-review.googlesource.com/1032854 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#554576}
-
Daniel Cheng authored
For some reason, they aren't getting captured when they're captured inside the conditional block that eventually calls DumpWithoutCrashing(). Bug: 728219 Change-Id: Ic8ec936bdac4eadfe65da836dc033ae9e7c245e5 Reviewed-on: https://chromium-review.googlesource.com/1033997 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
When we had style sharing, we could not share ComputedStyle between elements which had pseudo ::before or ::after which relied on attr() content values from the originating element. This is not necessary for MatchedPropertiesCache since we don't share the pseudo style cache like we would do for shared ComputedStyle objects. This gets rid of a dependency on mutable parent ComputedStyle. Bug: 813068 Change-Id: I4b03e5b05c9bca595188d6506fdd2907e854596a Reviewed-on: https://chromium-review.googlesource.com/1032940Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/f1bcd017c95c..696434382359 $ git log f1bcd017c..696434382 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 geofflang D3D11: Reorder VAO synchronization. 2018-04-24 geofflang D3D: Don't test for device loss as frequenty in tight loops. Created with: roll-dep src/third_party/angle BUG=chromium:837002,chromium:621240 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8a622a7902ca0130d43619a3319c7a5d32b140b5 Reviewed-on: https://chromium-review.googlesource.com/1034003 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554573}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b3c651c4ed2..7c0757b099e5 $ git log 6b3c651c4..7c0757b09 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 levarum Revert "Copy ndk-translation artifacts when uprevving android" 2018-04-24 dgarrett som: Remove Gardener SOM tree. 2018-04-13 bmgordon cbuildbot: Use previous build state for chroot reuse 2018-04-25 dgarrett config_lib: Define LUCI_BUILDER constants. 2018-04-25 jclinton appengine/cq_stats: Set the Python SSL version to latest 2018-04-26 jclinton appengine: Update the SDK version to support new SSL 2018-04-26 jclinton lib/clactions*: Refactor into separate clactions_metrics for ts_mon Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:829665,chromium:824550,chromium:826372,chromium:826372,chromium:826372 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic622485c6d32417602f5aff7bc2cc02047e49f9a Reviewed-on: https://chromium-review.googlesource.com/1033960 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554572}
-
George Burgess IV authored
This was previously split out to support defining different profiles for Chrome and Chromium. Since we no longer need to do this, it's simplest to have this all inline. (In particular, this refactor makes using this profile on Linux like, 2 lines of diff.) No functionality change is intended. Bug: 805098 Test: `rgrep fprofile-sample-use out | wc -l` gives a high number Change-Id: Ice635b71942f10ef1aed9e2fd9872ac06f598803 Reviewed-on: https://chromium-review.googlesource.com/1024637Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#554571}
-
- 27 Apr, 2018 5 commits
-
-
https://chromium.googlesource.com/catapult.git/+log/6761f26bd9da..32f02b5d358b $ git log 6761f26bd..32f02b5d3 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 estevenson [Dashboard] Add M67 to speed releasing dashboard. Created with: roll-dep src/third_party/catapult BUG=chromium:765703 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I479f2280e69e53010f02a3f557aefd6f7a23a920 Reviewed-on: https://chromium-review.googlesource.com/1033993 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Oksana Zhuravlova authored
Bug: 799482 Change-Id: I925b822f11ac2464ef25cfb77175e9beeb3fa57b Reviewed-on: https://chromium-review.googlesource.com/1033925 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
John Budorick authored
Accidentally reenabled while disabling tests on Linux. TBR=dougarnett@chromium.org,timbrown@chromium.org Bug: 831838,837822 Change-Id: I6d0f126e73ff8eac0ed1b48c2eaa149a2be70e04 Reviewed-on: https://chromium-review.googlesource.com/1034014Reviewed-by:
-
Nicholas Verne authored
This runs the uninstall flow for crostini, which now includes stopping the concierge service then unloading the cros-termina component. Bug: 822507 Change-Id: I31cc40a3ad6732a55ff3f9ae47468751d996c6cf Reviewed-on: https://chromium-review.googlesource.com/1032353 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554567}
-
Eric Orth authored
Useful to override to create specialized mocks or fakes that only care about a portion of the overall interface. Especially useful for mocks or fakes owned outside the network service code as the mocks can create an interface dependency on only the overridden methods. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id03bdcaab6d991fb1a79ddcaf4eaf0612fe64d52 Reviewed-on: https://chromium-review.googlesource.com/1026418 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554566}
-
