- 29 Nov, 2019 13 commits
-
-
Tsuyoshi Horo authored
We need to isolate Web Bundles subresources in Memory cache to avoid cache pollution attack. Bug: 1027050 Change-Id: I33994bdb3430cbd539dd3335d50aa6d104a7cba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933841Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#720098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ff24962cacae..7c62ed63ace5 git log ff24962cacae..7c62ed63ace5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 samuel.r.attard@gmail.com properly detect msys_nt as windows in the ninja script Created with: gclient setdep -r src/third_party/depot_tools@7c62ed63ace5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If14769238aafb941e4afb417d0c835606a09e5e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720097}
-
Alex Danilo authored
Selecting a file, followed by opening the search box and attempting to click 'delete' or 'open' buttons to the left of the search box failed due to a mousedown listener that removed the search box and in turn, moved the position of the 'delete' or 'open' buttons mid-click causing the user action to fail. Adds a new class to the search box 'hide-pending' that defers the shrinking of the search box until a 'click' event is received on any part of the action bar. Noted during debugging that aria-disabled wasn't being set correctly, so replace the use of 'hidden' for the <cr-input> element with 'disabled' to control show/hide of the input text area, that updates aria-hidden true || false correctly in the <cr-input>. Change the Ctrl-F/Escape open and close of the search box to set the 'disabled' property instead of 'hidden'. Bug: 668427 Tests: browser_tests --gtest_filter="*HidingTextEntryField" Change-Id: Iac5f1cc0bec31f024f397797dd9c0397a6d703e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940325 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720096}
-
Chris Lu authored
This change checks the current state of Translate and returns early if the TranslateInfobarViewDelegate action methods are attempting to execute either a translate or revert when Translate is already in that state. Bug: 1014959, 1029120 Change-Id: Ifdbfe587f215876eb09d46a4dea41e6590b0f160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940171 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#720095}
-
Maggie Cai authored
Currently when app detail view open with an invalid app id, the redirect to main view of app management doesn't work. This is due to two issues. First, the rendering of the main view is called inside the rendering of the app detail view, which causes the app detail view rendering overwrite the main view rendering. Second, the apps initialisation might not be finished when the redirect need to happen so we cannot check if the app ID exists. This CL fixes both of the two issues. BUG=1010398 Change-Id: Id7ffd16abd33af0233cfba3aed128ef7343ba46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939824 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#720094}
-
Anand K. Mistry authored
TBR=yamaguchi@chromium.org # for file_system_provider Bug: 1007832 Change-Id: I713339420b703843475c97e07e5dfbd1c67f8b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930241 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8c96d8e6116..2792515dab7c git log e8c96d8e6116..2792515dab7c --date=short --first-parent --format='%ad %ae %s' 2019-11-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2792515dab7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I94b83676d07155440b7055a305e1aadd1b2493d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943589Reviewed-by:
-
Jeremie Boulic authored
The volume space info item of the gear menu is linking to the storage settings page that display local storage statistics. Only enable this link when the user is navigating within local folders (i.e. within My files, Play files or Linux files). browser_tests --gtest_filter="*enableDisableStorageSettingsLink" Bug: 999825 Test: Change-Id: I2eff9f0453f4a60ddef5e03676573c2ebb588eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935772 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#720091}
-
Jonathan Backer authored
SkiaRenderer finch was getting crashes in GLSurfacePresentationHelper::PreSwapBuffers on timer->QueryTimeStamp() on Mali 7XX and Mali 8XX GPUs with a particular driver version. This is likely a driver bug. GLRenderer uses EGL timestamps via [1] and [2]. This CL is a speculative fix that makes SkiaRenderer use EGL timestamps as well. [1] https://cs.chromium.org/chromium/src/components/viz/service/display_embedder/viz_process_context_provider.cc?rcl=4fe1de2e621ff1a3e006346958e3738008fba47f&l=87 [2] https://cs.chromium.org/chromium/src/gpu/ipc/in_process_command_buffer.cc?rcl=6fdb06906234ae45000d1226aea10261f1788e53&l=596 Change-Id: I5fc006bd34d3136015e5f73c5be01cac28fabba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943372 Auto-Submit: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720090}
-
Luciano Pacheco authored
Add tooltip and aria-label to breadcrumbs. This fixes 3 issues: 1. Make the collapsed breadcrumb accessible to Chromevox issue:1029245 2. Show tooltip for breadcrumbs useful for: 2.1 When hovering a collapsed breadcrumb, which displays "..." as content. 2.2 When the name is too long and part of the content shows as ellipses. Change variable to const where enforced by presubmit. Change param from HTMLElement to EventTarget, because it only uses the addEventListener() and closure failed in the new call to addTarget(). Fix test filesTooltipFocus() which expected breadcrumb to not have tooltip, but setting the focus to file list instead. Test: browser_tests --gtest_filter="*breadcrumbsTooltip" Bug: 1029245, 951305 Change-Id: I74ba38519ac70b1e210f55e1979a862841b13b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941533 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#720089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/278d2d006e50..5a493efee284 Created with: gclient setdep -r src-internal@5a493efee284 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib440c3f93689897ba9dc99ee4bc6fd2cdc72e409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943569Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720088}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1bfe890bd8fc..ff24962cacae git log 1bfe890bd8fc..ff24962cacae --date=short --first-parent --format='%ad %ae %s' 2019-11-28 hferreiro@igalia.com Save .git_cl_description_backup in the working dir Created with: gclient setdep -r src/third_party/depot_tools@ff24962cacae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: agable@chromium.org Change-Id: I1a2a7b1d3c48a971f16722a1c46d9b1f5040a27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943568Reviewed-by:
-
Aaron Leventhal authored
Expose role kRowGroup for role="rowgroup" and HTML's thead/tbody/tfoot. Bug: 1028219 Change-Id: Ied076f233048c69f623aa42a336392d8c20dcf1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927029 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720086}
-
- 28 Nov, 2019 27 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9e80f699..26500402 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9372d315ad65517358f3b8734a72a48d5c160911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942994Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720085}
-
Ian Clelland authored
This brings FeaturePolicy in line with the recent changes to the WebIDL spec, and addresses https://github.com/w3c/webappsec-feature-policy/pull/352. (This just formalizes the existing exposure set, as 'Window' is the default in bindings generation code if [Exposed] is not set, so there should be no visible changes resulting from this CL) Bug: 1029342 Change-Id: Ibf5d7d1962bea3e9d6d8f8e3b69b4b1778a4e325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942771Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#720084}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/82219d287b57..bc82fb14aab4 git log 82219d287b57..bc82fb14aab4 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 jonahr@google.com Suppress failing end2end tests for ASAN builds Created with: gclient setdep -r src/third_party/angle@bc82fb14aab4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029378 Tbr: cwallez@google.com Change-Id: I440e10c74e50c91e3f293b96d83a097a8d6ce6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943428Reviewed-by:
-
Noel Gordon authored
When we update many properties of some Polymer custom element for some definition of "many", using Polymer setProperties() is faster. There's one place in the metadata box controller that sets "many": fixit. No change in behavior, covered by existing borwser_tests. Fixed: 1029211 Bug: 1029211 Change-Id: I0c1d4d8ed6f14f4135cfc851091a5414648e6542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943487 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Jonathan Backer authored
SkiaOutputSurfaceImpl owns the SkiaOutputSurfaceDependency. After Impl goes out of scope, there is no more Dependency. We reference the Dependency when we call CreateSafe{Once,Repeating}Callback for things like presentation feedback callbacks. It is possible for presentation feedback to occur after Impl is gone, in which case we can no longer use Dependency. Bug: 1020699 Change-Id: I54a13f1d65c2b2e8603883457bdd2e1195a3f9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943047 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#720081}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/72e6f396eec5..fb7ca1d5aca5 git log 72e6f396eec5..fb7ca1d5aca5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com SpirvShaderEnumNames: Use spirv-tools' spvOpcodeString() Created with: gclient setdep -r src/third_party/swiftshader@fb7ca1d5aca5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/145351270 Tbr: swiftshader-team+autoroll@google.com Change-Id: If118c3b7727c91aa0a7b73a4646cc96b75ffaa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943387Reviewed-by:
-
Jay Harris authored
Previously, the names of the methods in web_app_file_handler_registration implied it was the sole place where file handler registrations occurred. This was confusing, as Chrome OS directly interfaces with the registry of installed apps, so these methods were no-ops while it seemed like they should have been doing something. Functionally, this also reverts https://crrev.com/c/1935296, as it doesn't align with new aim of the interface. Bug: 1028448 Change-Id: I8630f31ee7829165ffaef39374ea286cc85caaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941528Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#720079}
-
Noel Gordon authored
CL:1924341 limited the horizontal scroll of the directorytree to 0, to resolve issue 1025581, and needs a test of this behavior. Create a nested tree of test folders. Expand the directory tree to the last folder, verify the navigation, and that the directory tree is not horizontally scrolled (directorytree.scrollLeft should be 0). The test passes with CL:1924341 and fails before that CL (good). Tbr: anyone Test: browser_tests --gtest_filter="*TreeExpandHorizontal*" Bug: 1029019 Change-Id: I609b06ddfc3d18cf24cf5b5c3e4e118c06989c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942667Reviewed-by:
-
Jonathan Backer authored
This is similar to the bypass in RealGLApi::glDrawArraysFn. It is necessary to avoid timeouts in content_browsertests running under TSAN. Bug: 967716 Change-Id: Ifd35f188b878fb15b8eb909574e31de370e12045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942772Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720077}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0279cf266561..278d2d006e50 Created with: gclient setdep -r src-internal@278d2d006e50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I9c47dd27949e3db754585b3b4c7f1ee18fb66634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943307Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6ba572f..9e80f699 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7c8585ad6c7a89e677fa49df65500c67ff7bfad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942992Reviewed-by:
-
Andrew Grieve authored
Adds GN arg: java_warnings_as_errors = !is_java_debug And sets the arg on our trybot that runs errorprone. TBR=jbudorick # Expedite fixing local dev flow. Bug: 1029357 Change-Id: I817931328dc56ca67d7047d711fa60ba38e21fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943014 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720074}
-
Peter Wen authored
Allow //src/build/android/OWNERS to own all gn-related files under //src/chrome/android/. Bug: None Change-Id: Icbb98b2cef2869024045a736c2e5f1b21820b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942876 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720073}
-
Jasper Chapman-Black authored
Bug: 978307 Change-Id: Ic2951d62e1d6a148acbee0bf9bde3c517ecae602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942943 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts all uses of EmbeddedWorkerInstanceClient interface as below, - Convert EmbeddedWorkerInstanceClientRequest to PendingReceiver<EmbeddedWorkerInstanceClient> Bug: 955171 Change-Id: Ib40dcca2e9e3caab54e1d2c22b83d17d43102ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932142Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#720071}
-
Ilya Nikolaevskiy authored
Bug: 988705,988702,988695,988683,988672,988658,988653,988647,988628,988627 Change-Id: I6ef78ae7b5601f28223c91dbebfbb6cdc6062998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940182 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#720070}
-
Greg Thompson authored
BUG=None R=gab@chromium.org, robertshield@chromium.org Change-Id: I2d5f46aa0cc04f99c59ddb3d543de6313c2183f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939287 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Robert Shield <robertshield@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#720069}
-
Kevin Ellis authored
The patch removes the last of the uses of PlayStateUpdate scope. The dead code will be removed in a followup patch. Note that a change was also required to PauseForTesting. The reason for this change is that PauseForTesting did not modify internal_play_state_. Even though the hold time was being explicitly set, the internal play state could still indicate that the animation was idle. Now that the correct play state is being used, PauseForTesting can restart a canceled animation, which is not the intended behavior. Next steps: * Remove dead code including PlayStateUpdateScope. * Remove legacy flags * Align DocumentTimeline::ServiceAnimations with spec (issue 10293484) Bug: 960944 Change-Id: Ia1472f4e769e3a7630fbc54ba2f735a4feafb91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936528 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720068}
-
danakj authored
TBR=jbroman@chromium.org Bug: 1007760 Change-Id: I75898a2a440f85cfe397e88be4d03e9c2db58a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943108Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/389749ae554d..72e6f396eec5 git log 389749ae554d..72e6f396eec5 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 bclayton@google.com Rename SpirvShader_dbg.cpp -> SpirvShaderEnumNames.cpp 2019-11-28 bclayton@google.com SpirvShader: Remove now unused includes 2019-11-28 bclayton@google.com SpirvShader: Move arithmetic ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move image handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move spec ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move group ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move memory ops to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move control flow handling to new cpp file 2019-11-28 bclayton@google.com SpirvShader: Move GLSLstd450 handling to new cpp file 2019-11-28 bclayton@google.com Pipeline: Move utility functions to ShaderCore Created with: gclient setdep -r src/third_party/swiftshader@72e6f396eec5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/145351270,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353,chromium:b/145336353 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ib9e9135c8235f46414c4c665adb7460ac50c0b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942493Reviewed-by:
-
Greg Thompson authored
BUG=546640 R=droger@chromium.org Change-Id: I6edc0f43ef922f70b060292af766d197769089c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942328 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720065}
-
Greg Thompson authored
ProtoDatabaseImplTest tests must allow posted tasks to run after closing DBs so that all files can be closed before temp dirs are cleaned up. SharedProtoDatabaseTest must keep its ScopedTempDir alive until after the TaskEnvironment is destroyed. BUG=546640 TBR=nyquist@chromium.org Change-Id: I9b07ddc31f691eb875c08eb05a1779a4614c7ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940111 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#720064}
-
Greg Thompson authored
BUG=546640 R=mark@chromium.org Change-Id: I6cb8db349fb05f2ebe7c07f86b6f127441ea91dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942428 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#720063}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3188d6f8a991..0279cf266561 Created with: gclient setdep -r src-internal@0279cf266561 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I1eb83739ae80fc472979aea7738e6bb89c72f332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942720Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0ee91fc0a1c8..77f6db7a0b78 git log 0ee91fc0a1c8..77f6db7a0b78 --date=short --first-parent --format='%ad %ae %s' 2019-11-28 rharrison@chromium.org Fix BUILD.gn issues for Android & Fuschia 2019-11-28 yunchao.he@intel.com Add memory synchronization tests - multiple write then multiple read 2019-11-28 rharrison@chromium.org Add runtime toggle for using SPVC 2019-11-28 rharrison@chromium.org Use spvc's rules for spirv-cross Created with: gclient setdep -r src/third_party/dawn@77f6db7a0b78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id4809ac096f67010f0742f4b50e233cf63d5bf7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942721Reviewed-by:
-
Morten Stenshorne authored
TBR=jfernandez@igalia.com,obrufau@igalia.com,rego@igalia.com Bug: 921722, 941987, 1027384, 1005519, 1018439 Change-Id: I2de7688a312cecb58b4976bfb5b742639234bd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943168Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#720060}
-
Jasper Chapman-Black authored
Change-Id: I5eb7006446ee403a9efe60227dba43399a135300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941187 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
-
