GitLab

https://skia.googlesource.com/skia/+log/088f4b8eb31b2af26e66dcbaae062f40b3955059..d684422f1711cbb4106a260d75ee09101065c092

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/519623002

Cr-Commit-Position: refs/heads/master@{#292581}

BUG=408520
TEST=manually tested

Review URL: https://codereview.chromium.org/514163002

Cr-Commit-Position: refs/heads/master@{#292580}

It fails there after a recent change.

NOTRY=true
TBR=zhaoqin@chromium.org
BUG=408911

Review URL: https://codereview.chromium.org/518703002

Cr-Commit-Position: refs/heads/master@{#292579}

DevTools: use explicit IPC messages for enabling/disabling tracing instead of intercepting protocol events

Added IPC plumbing that allows InspectorTracingAgent to enable/disable  browser-wide tracing. It was implemented by intercepting Tracing.started/Tracing.stopped events in the browser. Tracing.stopped event in the DevTools protocol was used by the renderer to notify the browser that it should stop trace event recording and it didn't make much sense for the client as there is already Tracing.tracingComplete event in the protocol.

BUG=398787

Committed: https://chromium.googlesource.com/chromium/src/+/a449adae35631e4791547bd0b14403d1766f9ddf

Review URL: https://codereview.chromium.org/511873002

Cr-Commit-Position: refs/heads/master@{#292578}

Instead of specifying each of the USB vendor and product ID pairs an
app has permission to open this API extension allows filtering of
devices by vendor and product IDs as well as HID usage pages and
usages. The 'vendorId' and 'productId' properties of GetDevicesOptions
are still supported for backwards compatibility.

BUG=

Review URL: https://codereview.chromium.org/514923002

Cr-Commit-Position: refs/heads/master@{#292577}

Rolling for OCSP stapling and some ASN.1 changes. Brings in the following
commits:

6c7aed0 Client-side OCSP stapling support.
e098ec2 Test client auth under TLS 1.2 hash mismatch and SSL 3.
ed6eb66 Add CBS_ASN1_ENUMERATED to bytestring.h.
9b04d65 Export CBS_get_any_asn1_element.
041b58a Remove session_ctx macro.
457112e unifdef a bunch of OPENSSL_NO_* ifdefs.

BUG=408687

Review URL: https://codereview.chromium.org/522513002

Cr-Commit-Position: refs/heads/master@{#292576}

https://chromium.googlesource.com/chromium/blink/+log/78d2b11092668ed42fc97d9a81290a3e226bed43..0b1c83564fc6d6e5518f711306b85553a01e19b9
TBR=mlamouri@chromium.org,hclam@chromium.org

Review URL: https://codereview.chromium.org/520523002

Cr-Commit-Position: refs/heads/master@{#292575}

Revert of Replace NPObject usage in ppapi with gin (patchset #27 of https://codereview.chromium.org/459553003/)

Reason for revert:
Failed memory tests:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6791

Original issue's description:
> Replace NPObject usage in ppapi with gin
>
> This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.
>
> There are 4 major parts to this CL:
> 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
> 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
> 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
> 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.
>
>
> BUG=351636
>
> Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa

TBR=jochen@chromium.org,dmichael@chromium.org,kolczyk@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=351636

Review URL: https://codereview.chromium.org/522583002

Cr-Commit-Position: refs/heads/master@{#292574}

After few experiments/crashes it seems that some users have enormous number of fonts in the registry. On suspect that we have for failing to load collection is that direct write cache is unable to load/handle those many fonts. In this CL we are trying to see if we can put arbitrary limit on number of fonts that could be loaded. We also added a fallback mechanism where in if loading from registry fails, we will try to load only default fonts. Definition of 'default' is taken from file prefs_tab_helper.cc ~ kDefaultFonts.

R=ananta,scottmg,cpu
BUG=399233

Review URL: https://codereview.chromium.org/521483002

Cr-Commit-Position: refs/heads/master@{#292573}

This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.

BUG=407376
TEST=this may crash for a few people

Review URL: https://codereview.chromium.org/517813002

Cr-Commit-Position: refs/heads/master@{#292572}

http://msdn.microsoft.com/en-us/library/dn642448.aspx

This makes Release .objs smaller and so links faster. It was added in
Update 2, but caused the compiler to crash on Chrome building LTCG. It
seems to be OK after Update 3.

As the depot_tools Express toolchain is not yet Update 3, we don't add
the flag there.

R=jam@chromium.org
BUG=350018,402270

Review URL: https://codereview.chromium.org/474463002

Cr-Commit-Position: refs/heads/master@{#292571}

Move gestureCreated, touchMaxDistance and touchDuration UMA logs into gesture provider, so that they can also record data from other platforms, such as Android, Windows, not only from ChromeOS.

BUG=352654

Review URL: https://codereview.chromium.org/501553004

Cr-Commit-Position: refs/heads/master@{#292570}

This CL removes the magnifying glass icon from the experimental app
list. The normal app list should be unaffected

BUG=406222

Review URL: https://codereview.chromium.org/503693002

Cr-Commit-Position: refs/heads/master@{#292569}

TBR=zhaoqin@chromium.org
NOTRY=true
BUG=315328

Review URL: https://codereview.chromium.org/517813003

Cr-Commit-Position: refs/heads/master@{#292568}

- Move ImageDetails from chrome to extensions.

BUG=352290

Review URL: https://codereview.chromium.org/487533005

Cr-Commit-Position: refs/heads/master@{#292567}

This patch and https://codereview.chromium.org/514113003 will fix the wrong size of blob which can be get by calling FetchEvent.request.body.asBody() of the fetch event which body includes a file item.

BUG=402387

Review URL: https://codereview.chromium.org/517543002

Cr-Commit-Position: refs/heads/master@{#292566}

Previously, when user clicked the audio file on Files.app, the track list was updated unexpectedly and the current track index was set to the default (the first file) for a very short time just before the index was updated to the selected file. This unexpected change in short period made the playback time reset and caused the issue (crbug.com/395868). This patch fixes this issue.

BUG=395868
TEST=none

Review URL: https://codereview.chromium.org/515443002

Cr-Commit-Position: refs/heads/master@{#292565}

BUG=110610

Review URL: https://codereview.chromium.org/523463003

Cr-Commit-Position: refs/heads/master@{#292564}

When a new version of Chrome has been downloaded but the old version is
still running, any app shims that start will load the new framework version.
This is problematic as the IPC codes (See ipc_message_start.h) may not match.

With this CL, app shims will check a version file written by the Chrome
process and load the corresponding framework version.

This also increments kCurrentAppShortcutsVersion, which causes all app
shims to be rebuilt.

This also moves AppModeChromeLocatorTest to browser_tests. It's not really
necessary for them to have their own target (app_mode_app_tests), and this
way they actually get run.

BUG=405347

Review URL: https://codereview.chromium.org/501303002

Cr-Commit-Position: refs/heads/master@{#292563}

BUG=324071,374440,408737

Review URL: https://codereview.chromium.org/522463002

Cr-Commit-Position: refs/heads/master@{#292562}

BUG=170859
TBR=sgurun, yzshen

Review URL: https://codereview.chromium.org/516833002

Cr-Commit-Position: refs/heads/master@{#292561}

With the switch to pure frame-based calculation of time in 5b6ce11b,
these methods are no longer used.

BUG=370634

Review URL: https://codereview.chromium.org/516113002

Cr-Commit-Position: refs/heads/master@{#292560}

Enabling /Zc:inline on static release build results in

FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True chrome.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:chrome.dll.lib /DLL /OUT:chrome.dll @chrome.dll.rsp" 2 mt.exe rc.exe "obj\chrome\chrome_main_dll.chrome.dll.intermediate.manifest" obj\chrome\chrome_main_dll.chrome.dll.generated.manifest ..\..\chrome\app\chrome.dll.manifest
browser_2.lib(browser_2.character_encoding.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z) referenced in function "void __cdecl std::_Adjust_heap<struct CharacterEncoding::EncodingInfo *,__int64,struct CharacterEncoding::EncodingInfo,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo> >(struct CharacterEncoding::EncodingInfo *,__int64,__int64,struct CharacterEncoding::EncodingInfo &&,class l10n_util::StringComparator<struct CharacterEncoding::EncodingInfo>)" (??$_Adjust_heap@PEAUEncodingInfo@CharacterEncoding@@_JU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@std@@YAXPEAUEncodingInfo@CharacterEncoding@@_J1$$QEAU12@V?$StringComparator@UEncodingInfo@CharacterEncoding@@@l10n_util@@@Z)

browser_1.lib(browser_1.background_application_list_model.obj) : error LNK2001: unresolved external symbol "public: bool __cdecl l10n_util::StringComparator<class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > >::operator()(class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &,class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > const &)" (??R?$StringComparator@V?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@@l10n_util@@QEAA_NAEBV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@0@Z)

So, move StringComparator<base::string16>::operator() into header and
mark it inline, so that it's available in all translation units where it's
used. The previous code was correct, but this makes all compilers happy.

/Zc:inline ref: http://msdn.microsoft.com/en-us/library/dn642448.aspx

R=rnk@chromium.org
TBR=jshin@chromium.org
BUG=350018

Review URL: https://codereview.chromium.org/518533002

Cr-Commit-Position: refs/heads/master@{#292559}

BUG=377978

Review URL: https://codereview.chromium.org/492133002

Cr-Commit-Position: refs/heads/master@{#292558}

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#292557}

needed for this CL
https://codereview.chromium.org/517123002/

TBR=

Review URL: https://codereview.chromium.org/517803002

Cr-Commit-Position: refs/heads/master@{#292556}

BUG=407974

Review URL: https://codereview.chromium.org/510353003

Cr-Commit-Position: refs/heads/master@{#292555}

We don't support msvs any more anyway, and clobbering all of build/ is
always a bad idea. (I'm not sure this'll fix anything, but maybe we'll
get a better error.)

R=kbr@chromium.org,iannucci@chromium.org
BUG=408839

Review URL: https://codereview.chromium.org/519503002

Cr-Commit-Position: refs/heads/master@{#292554}

MIDI port id must be unique, as specified in the spec.

BUG=341423

Review URL: https://codereview.chromium.org/516893002

Cr-Commit-Position: refs/heads/master@{#292553}

The new icon is a better fit in terms of size compared to the previous one.

Review URL: https://codereview.chromium.org/518493002

Cr-Commit-Position: refs/heads/master@{#292552}

Chromium shares a message loop with Android on the browser UI thread.
This can cause problems when the associated Looper has a sync barrier,
preventing posted Chromium tasks from being dispatched until the
barrier is removed. Make this sharing more fair by marking all Chromium
Message tasks as asynchronous, avoiding stalls when there is a sync
barrier.

Note: This change is for gathering data about the perf impact and we'll
revert it before cutting a release branch.

BUG=407149,380781,407133

Review URL: https://codereview.chromium.org/512333002

Cr-Commit-Position: refs/heads/master@{#292551}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#292550}

NOTRY=true

Review URL: https://codereview.chromium.org/524433003

Cr-Commit-Position: refs/heads/master@{#292549}

This teaches the native viewport service to accept a surface id from its
client and draw it into the native viewport. This won't work if the
client also tries to bind an onscreen context to the native viewport's
view id, so the surface initialization is lazy and only happens when
the client specifies a surface id. If a client does both it'll blow up.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/510553002

Cr-Commit-Position: refs/heads/master@{#292548}

This test should now be working after the fixes to the screenshotting code
that initialy had made it fail.

Also adding an OWNERS file for the Feedback API directory.

R=kalman@chromium.org
BUG=369886

Review URL: https://codereview.chromium.org/516083002

Cr-Commit-Position: refs/heads/master@{#292547}

Instead of explicitly depending on specific browser threads the USB
service can assume that it is instantiated on BrowserThread::FILE (or
equivalent) and save a TaskRunner reference from this instantiation for
later use when called from other threads.

To reach BrowserThread::UI (required for DBus on Chrome OS) a reference
to the appropriate TaskRunner must be provided when calling
UsbService::GetInstance().

BUG=

Review URL: https://codereview.chromium.org/507503002

Cr-Commit-Position: refs/heads/master@{#292546}

The current warning is the generic "Read your browsing history"
warning. The new warning for topSites will be suppressed by
read only and read/write history warnings, and all hosts warning.

BUG=404334

Review URL: https://codereview.chromium.org/482953003

Cr-Commit-Position: refs/heads/master@{#292545}

In preparation for changing how we compute media time, add some tests to
verify the current behaviour.

BUG=370634

Review URL: https://codereview.chromium.org/517843003

Cr-Commit-Position: refs/heads/master@{#292544}

This is in preparation for implementing the Trepn profiler.

BUG=

Review URL: https://codereview.chromium.org/510943002

Cr-Commit-Position: refs/heads/master@{#292543}

Now we pass Demuxer and Renderer directly into Pipeline, and create TextRenderer
directly in Pipeline. As a result, we don't need FilterCollection anymore.

BUG=408602
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/511323003

Cr-Commit-Position: refs/heads/master@{#292542}