GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283985 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283984 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3f376a55002c205aacacc4cb16ed745e3afbad31..384b0202c040034ba1e8f2e3789a01e4b05a6a2b

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=halcanary@google.com
BUG=

Review URL: https://codereview.chromium.org/401713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283983 0039d316-1c4b-4281-b951-d872f2087c98

patch broke windows

BUG=391316,394666

Review URL: https://codereview.chromium.org/391343010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283982 0039d316-1c4b-4281-b951-d872f2087c98

scoped_ptr<> only calls the deleter when the data is non-null

Review URL: https://codereview.chromium.org/357783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283980 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a construct and a construct and iterate tests for
layer level eviction iterators.

Initial runs:
[ RUN      ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstructAndIterate
*RESULT layer_eviction_tile_iterator_construct_and_iterate: 32_100x100= 47900.80859375 runs/s
*RESULT layer_eviction_tile_iterator_construct_and_iterate: 32_500x500= 50885.39453125 runs/s
*RESULT layer_eviction_tile_iterator_construct_and_iterate: 64_100x100= 49707.58984375 runs/s
*RESULT layer_eviction_tile_iterator_construct_and_iterate: 64_500x500= 49089.5078125 runs/s
[       OK ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstructAndIterate (8069 ms)
[ RUN      ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstruct
*RESULT layer_eviction_tile_iterator_construct: 0_0_100x100= 52248.0390625 runs/s
*RESULT layer_eviction_tile_iterator_construct: 5000_0_100x100= 28544.1015625 runs/s
*RESULT layer_eviction_tile_iterator_construct: 9999_0_100x100= 29921.828125 runs/s
[       OK ] PictureLayerImplPerfTest.LayerEvictionTileIteratorConstruct (6042 ms)


R=reveman

Review URL: https://codereview.chromium.org/404583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283979 0039d316-1c4b-4281-b951-d872f2087c98

This causes build failure by macro redefinition on ASan-enabled build without -w flag.

BUG=162783

Review URL: https://codereview.chromium.org/389313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283978 0039d316-1c4b-4281-b951-d872f2087c98

The code used wrong function to clear preference.

BUG=381896

Review URL: https://codereview.chromium.org/397343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283977 0039d316-1c4b-4281-b951-d872f2087c98

It is unused, so we just delete it.

BUG=338338
TEST=None
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/395023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283976 0039d316-1c4b-4281-b951-d872f2087c98

This adds both a perftest for constructing the iterator (which is
very cheap) and accessing it, which is fairly heavy.

Initial runs:
[ RUN      ] PictureLayerTilingPerfTest.TilingEvictionTileIteratorConstruction
*RESULT tiling_eviction_tile_iterator_construction: 0_0_100x100= 17806804 runs/s
*RESULT tiling_eviction_tile_iterator_construction: 50_0_100x100= 17840996 runs/s
*RESULT tiling_eviction_tile_iterator_construction: 100_0_100x100= 17842676 runs/s
*RESULT tiling_eviction_tile_iterator_construction: 150_0_100x100= 17710480 runs/s
[       OK ] PictureLayerTilingPerfTest.TilingEvictionTileIteratorConstruction (25206 ms)
[ RUN      ] PictureLayerTilingPerfTest.TilingEvictionTileIterator
*RESULT tiling_eviction_tile_iterator: 32_100x100= 66903.9296875 runs/s
*RESULT tiling_eviction_tile_iterator: 32_500x500= 64616.3828125 runs/s
*RESULT tiling_eviction_tile_iterator: 64_100x100= 66526.5078125 runs/s
*RESULT tiling_eviction_tile_iterator: 64_500x500= 65154.87109375 runs/s
[       OK ] PictureLayerTilingPerfTest.TilingEvictionTileIterator (8086 ms)

R=reveman

Review URL: https://codereview.chromium.org/392413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283975 0039d316-1c4b-4281-b951-d872f2087c98

The profiler records UMA metrics for several key phases in Chrome startup.

BUG=393819

Review URL: https://codereview.chromium.org/393753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283974 0039d316-1c4b-4281-b951-d872f2087c98

This allows the connect job to leverage any auth cache credentials the profile
has, including those the user gets prompted for as part of loading a page
while behind an authenticated proxy. GCM continues to use its own network
session for creating the connections, but at connection time the HttpAuthCache
is coped over from the profile's http network session (if available).

BUG=385748

Review URL: https://codereview.chromium.org/375663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283973 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes a related bug involving exiting full-screen. If the window was previously maximized when it is full-screened, then ChromeOS sometimes generates an onMaximized event when exiting full-screen, which triggers the app to re-enter full-screen mode. The fix is to explicitly unmaximize the window before going full-screen (which also has the nice benefit of making the double restore() calls unnecessary).

BUG=384678

Review URL: https://codereview.chromium.org/398403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283972 0039d316-1c4b-4281-b951-d872f2087c98

This drops the old gyp-compatible settings and wires up the
Linux and Android toolchains to be goma-aware. Mac and Win can
follow in subsequent CLs.

R=brettw@chromium.org, thakis@chromium.org
BUG=394501

Review URL: https://codereview.chromium.org/397173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283971 0039d316-1c4b-4281-b951-d872f2087c98

RotateHidingWindowAnimationObserver is leaking from
wm::AnimateOnChildWindowVisibilityChanged() because it's not observing
animation events. The fix is to make RotateHidingWindowAnimationObserver
observe the animation events.

BUG=389296
TEST=wm_unittests:WindowAnimationsTest.RotateHideNoLeak

Review URL: https://codereview.chromium.org/343753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283970 0039d316-1c4b-4281-b951-d872f2087c98

Add some tests for FontRenderParams's interactions with
Fontconfig, which is used on desktop Linux and Chrome OS.

Also re-add platform_font_pango_unittest.cc for gn.

BUG=125235

Review URL: https://codereview.chromium.org/394963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283969 0039d316-1c4b-4281-b951-d872f2087c98

Fix extension scrollbar regression bug, and add a regression test to catch similar issues in the future.

This changes the extension_install_dialog_view permission strings layout to have a fixed width for the bullet, centered, and subtract that width from the width used to size the permission string label.

This also adds two browser tests: one to test that a scrollbar _does_ show for a very long set of permissions, and one for the specific regression case from the bug.

BUG=385570

Review URL: https://codereview.chromium.org/363523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283968 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Taking the address of a temporary
* Octal escape sequence terminated by decimal number
* Signedness mismatch
* Possibly-uninitialized local variable

This also contains a small number of cleanups to nearby code (e.g. no else after return).

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/382673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390755

Review URL: https://codereview.chromium.org/394903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283966 0039d316-1c4b-4281-b951-d872f2087c98

- Add accessors: web_frame(), routing_id(), render_view().
- Remove accessor: render_frame(). Where we do need to touch the
  RenderFrame, we'll look it up by its routing ID.
- Small change to the CompositingHelper to use the new getters.
- Add a map to allow finding a RenderFrameProxy by its associated
  blink::WebFrame.
- Introduce a second factory function and differentiate the two
  factory functions according to the two ways RenderFrameProxies will
  be created. The first is for when an extant local RenderFrame is
  being swapped out and replaced with a new RenderFrameProxy. The
  second is for when a RenderFrameProxy needs to be created without
  displacing an existing RenderFrame, as shall occur once we mirror
  the frame tree.
- This second factory function, which is uncalled at the moment, will
  create WebRemoteFrames. Also there is stubbed out code in the first
  factory function to create WebRemoteFrames. This code is in
  preparation for eliminating the RenderFrame (and its attendant
  WebLocalFrame) and having instead just a RenderFrameProxy.
- Add some defensive checks to prepare for when the render frame may
  not exist, as will happen once the second factory function
  enters use.
- Add an Init function so that code can be shared between the two
  factory functions.

As an adminstrative note, this patch is a chunk of nasko's 
larger "use RenderFrameProxyHost" effor (issue 241223002)

BUG=357747
TEST=browsertests, http://csreis.github.io/tests/cross-site-iframe.html renders after going cross-site under --site-per-process

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283572

Review URL: https://codereview.chromium.org/357043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394866

Review URL: https://codereview.chromium.org/400003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283964 0039d316-1c4b-4281-b951-d872f2087c98

ChromeExtensionWebContentsObserver to ChromeExtensionMessageFilter.

BUG=394383
R=jamescook@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/402673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47554

Review URL: https://codereview.chromium.org/394373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393019

Review URL: https://codereview.chromium.org/404573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283961 0039d316-1c4b-4281-b951-d872f2087c98

No intended behavior change.

BUG=none

Review URL: https://codereview.chromium.org/402773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393677
TEST=Ran without the pci id on daisy which bypassed the tests.

Review URL: https://codereview.chromium.org/393223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283958 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Change some !OS_ANDROID #ifdefs to ENABLE_EXTENSIONS in ChromeResourceDispatcherHostDelegate.

Review URL: https://codereview.chromium.org/405493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283954 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/403623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283953 0039d316-1c4b-4281-b951-d872f2087c98

Demonstrate in the NaCl SDK API demo for pp::Graphics3D how to
use full device resolution on HiDPI displays. For Graphics3D it
is simply a matter of sizing the texture in device pixels, by
multiplying the width/height by view.GetDeviceScale().

BUG=196253
TEST=Build NaCl SDK, run with --force-device-scale-factor=2

Review URL: https://codereview.chromium.org/398943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283952 0039d316-1c4b-4281-b951-d872f2087c98

This patch is the first part of ensuring that recycle tree does not
contain any unshared tiles.

This is done by ensuring that we invalidate the soon to become recycled
tiling while activating.

BUG=393802
R=danakj

Review URL: https://codereview.chromium.org/397303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283951 0039d316-1c4b-4281-b951-d872f2087c98

There was still a bug on the hotword extension side, and the
recent version 5023 doesn't contain the fix, which means 5023
is still 'old' in this sense :-(

BUG=393321
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/405483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394474
R=tfarina@chromium.org,gunsch@chromium.org

Review URL: https://codereview.chromium.org/399833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283949 0039d316-1c4b-4281-b951-d872f2087c98

Compilation error visible in try jobs of original review.

> GN fixes for the Windows build.
> 
> R=scottmg@chromium.org
> TBR=scottmg
> 
> Review URL: https://codereview.chromium.org/404603002

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/400493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283948 0039d316-1c4b-4281-b951-d872f2087c98

The trace comes handy when unexpected resize message triggers a main
frame.

BUG=392652
TEST=do a trace for scrolling a page on clank during which the top control
     becomes hidden, and found that at the end of scroll there is a
     RenderViewImpl::OnResize trace event.

Review URL: https://codereview.chromium.org/403593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283947 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/404603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283946 0039d316-1c4b-4281-b951-d872f2087c98

The panel's minimum size depends on whether the panel is minimized. This CL
ensures that when a panel is minimized, the X window's minimum size is first
updated, then the X window's bounds are updated (to be smaller than the
non-minimized panel minimum size allows)

BUG=382301
TEST=PanelViewTest.*
R=erg
TBR=dimich (For reenabling tests in panel_view_browsertest.cc)

Review URL: https://codereview.chromium.org/363483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283945 0039d316-1c4b-4281-b951-d872f2087c98

All SourceBufferStream string based unit tests assume that decode and
presentation timestamps are the same. This change extends the string
syntax so that buffers can be created where the presentation and
decode timestamps are different. This will make it easier to write
tests that verify proper behavior when B-frames are used.

Review URL: https://codereview.chromium.org/395303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394957
R=thestig@chromium.org
TBR=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/397373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283943 0039d316-1c4b-4281-b951-d872f2087c98

This change replaces the IdentityAccountTracker with
gaia::AccountTracker, which mostly does the same thing. The one
functional consequence of this change is that the Identity API no
longer keeps track of login token errors on its own. Instead it
relies on the underlying token services to report errors to the
user.

BUG=364203

Review URL: https://codereview.chromium.org/398573007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283942 0039d316-1c4b-4281-b951-d872f2087c98

Now that the QUnit-based unit tests are running on the bots, we can retire gtestjs unit tests.

This CL
1. Modifies remoting_webapp_unittest to include all files that are formerly covered by all_js_load.gtestjs.
2. Removes all the gtestjs files under remoting.
3. Moves run_all_remoting_unittests.cc back into the remoting directory as we no longer depends on chrome_paths.h.

Review URL: https://codereview.chromium.org/394023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283941 0039d316-1c4b-4281-b951-d872f2087c98