- 15 Sep, 2020 40 commits
-
-
Xianzhu Wang authored
This reverts commit f46065ea. Reason for revert: crbug.com/1128563 Original change's description: > Remove RuntimeFeatureEnableOptions::kEnableOnlyIfOverriddenFromCommandLine > > It was used by only one feature (Portals). It has been agreed that > kDefault can meet the requirement of the feature. > > kDefault is very much like kEnableOnlyIfOverriddenFromCommandLine. The > difference is that kDefault also respects status overridden from finch > and from --disable-features command line switch (in case the feature is > enabled by default at blink side). > > Bug: 1048656 > Change-Id: Ibb946dbdcc5ece7c5f5a08822b80825345c170e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411231 > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Jason Chase <chasej@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807045} TBR=wangxianzhu@chromium.org,chasej@chromium.org,lfg@chromium.org Change-Id: I9c8933123308e38f8bb0c822b17b47965a71bfc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048656, 1128563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412557Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807157}
-
Jimmy Gong authored
ConnectionScheduler is responsible for kicking off the connection. It will retry with initial backoff of 10 seconds with exponential retry times for each failure. Bug: 1106937 Test: unittest Change-Id: If59aed0129743402b65bb5765e0e946d69278579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402165Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#807156}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Bug: 1018739 Change-Id: If056b07757368a65e9f7c02c67939b53bb4fcb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410495 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807155}
-
Dan Harrington authored
Bug: 1119406 Change-Id: Ib6e64db692a264036d48ca168f434cfe38f534b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412549 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807154}
-
Ahmed Fakhry authored
This CL adds the necessary changes before Capture Mode is hooked to the recording servcie. It handles starting and stopping the recording, cursor-compositing state, as well as the stop-recording button visibility. BUG=1126586 TEST=Added a new test. Change-Id: I324ec678d15da877be89b7e3178c98868cdc7b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407452 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#807153}
-
Adlai Holler authored
GrContext is going away, and GrRecordingContext can do the job. Change-Id: Id0108ea8336fb6e2acb82261a8a80fa618fcf9b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411648 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#807152}
-
Mustaq Ahmed authored
Spec discussion: https://github.com/w3c/pointerevents/issues/325 Change-Id: I7c690043c2af0a80b946bc4270febde0405994a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339923 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#807151}
-
Bettina authored
Previously, the ClientPhishingRequest was passed as a raw pointer into SendClientPhishingRequest and then converted back to a unique_ptr when passed into StartClientPhishingRequest. When using a raw pointer,it has to be made sure to be deleted otherwise there is a memory leak. To make this easier to maintain, it is switched to a unique_ptr. Bug: 1122226 Change-Id: Ia344ea26661eec202cd27224889ba398f8264835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379252Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807150}
-
Dave Tapuska authored
Move the notification of DidCommitAndDrawCompositorFrame inside blink. This avoids having to iterate on the render_frames_ inside RenderWidget. BUG=1097816 Change-Id: Ia785f8482b5d420668edcbb10e2aba944b456aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410338 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807149}
-
Ken Rockot authored
All typemaps listed here are deleted and their configurations are merged into their respective mojom targets. Bug: 1059389 Change-Id: I94cd40f48f7ee80de7f284bf446d4e9e80939810 Tbr: xiyuan@chromium.org Tbr: estade@chromium.org Tbr: changwan@chromium.org Tbr: engedy@chromium.org Tbr: dschuff@chromium.org Tbr: jdoerrie@chromium.org Tbr: jds@chromium.org Tbr: megjablon@chromium.org Tbr: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405438Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#807148}
-
Julie Jeongeun Kim authored
This CL introduces AddToFixedOrStickyNodeList and InvalidateBoundingBoxForFixedOrStickyPosition to AXObjectCacheImpl to update the bounds for fixed or sticky positioned nodes on scrolling. AXObjectCacheImpl owns |fixed_or_sticky_node_ids_|, updates when AX objects retrieve their relative bounds, and clears it when layout is completed. Once the scroll position is updated, it invalidates the bounds for the fixed or sticky positioned nodes by calling InvalidateBoundingBoxForFixedOrStickyPosition and ScrollPositionChanged event sends location changes to the browser. AX-Relnotes: n/a. Bug: 1027542 Change-Id: I29a6fd1584b64f0c597f44bdacda18e6540f6d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402928 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807147}
-
Ken Rockot authored
This makes it so optional mojom values can only be read from their DataView into a destination type that supports nullability when read with the common Read[FieldName] methods. Attempting to violate this constraint will result in a compile-time assertion failure at the site of the Read[FieldName] call. Prior to this change, such instances were non-obvious and could instead result in surprising runtime behavior. Types that support nullability include anything wrapped with base::Optional, or any type for which there exists an appropriate {Struct,Union,Array,String}Traits definition with a SetToNull method. Pre-existing violations of the new constraint are corrected here either by making fields non-optional, deserializing to a base::Optional, or doing something more specialized to fix traits logic. Finally, this also removes the IsNull and SetToNull methods from StringTraits<std::string> since: (a) optional string fields are generated as base::Optional<std::string> and (b) it was not intentional for null strings and empty strings to be treated as equivalent in meaning. Fixed: 1124639 Change-Id: I0569b4b8420b4b416bd889417d9723307a880454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404478 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807146}
-
Patrick Noland authored
The accessibility attributes were placed on the wrong View, leading to the button not being clickable via accessibility events. In concordance with other instances of MenuButton, this CL moves the accessibility description and focusable/clickable attributes to the ImageButton child. Bug: 1127217 Change-Id: If71a7a328602ca31c4d3afb72ade8ad12b7ed4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405442Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#807145}
-
David Bienvenu authored
This reverts commit d01e1075. Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29> Original change's description: > [mathml] Use post.underlineThickness for the default fraction rulethickness > > MathML Core currently defines fallback values to use when no MATH table > is available. This CL performs the remaining work to ensure fractions > align with the specification. It also adds WPT test to check these > fraction fallback parameters, although testing them extensively is > difficult. > > Bug: 6606, 1058369 > Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384 > Commit-Queue: Frédéric Wang <fwang@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807083} TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 6606 Bug: 1058369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Commit-Queue: David Bienvenu <davidbienvenu@google.com> Cr-Commit-Position: refs/heads/master@{#807144}
-
Xi Han authored
The crash was caused by registering a listener to a null feedStream. Bug: 1127854 Change-Id: Ic040cf6620718e72b7f8a3faac115f7fb8799f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407093Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807143}
-
Alexander Cooper authored
Bug: 1126786 Change-Id: I8e3bd1c9bb938a54dd7bc058ae92620b15cf9f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412629 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#807142}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It lays the groundwork for hooking up more KeystoreServices APIs. Change-Id: Ic5925cdf4ce110601c2cab01d1bfdd5504d4ed12 Bug: 1127505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393004Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Native Java Unittests have all been removed, and so it's time to revert the infra changes they required. Reverted: https://crrev.com/ea65b1a1577f1fbba45e035f43e1c898a9874f9b https://crrev.com/26dc9eefadac5e70cf3789abbfb1eead7c9f7b68 https://crrev.com/1265cac9f769d0460a84e3f906b93f62290fd117 https://crrev.com/d46596b1702517799459d4b6a9a26669b187c94b https://crrev.com/04c511fd08177c915d5c267835110d0194bdd671 Bug: 1103344 Change-Id: I12ea68454c118de7860be6ba23c6e8263baceb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406692 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e049f9d1de14..b189aac83132 2020-09-15 fmayer@google.com Merge "Fix invalid CHECK in flamegraph generation." 2020-09-15 hjd@google.com Merge "ui: Fix logcat dropdown" 2020-09-15 taylori@google.com Merge "Revert "ui: Upgrade immer from 1.12.0 -> 7.0.8"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2e6c0527755ee79035f18d86828a980c119f5c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807139}
-
Eugene Zemtsov authored
N.B. libvpx will later check that frame diminsions don't exceed codec specific limits. Bug: 1127590 Change-Id: I20d635169a63e81eed40a7cc3ee4a77284a753ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411672Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#807138}
-
Nick Harper authored
The list of ssl_early_data_reason_t values why 0-RTT would be not attempted was incomplete. Change-Id: Ie067f160a8cdf751ee0e80726f831df9ab4dadaf Bug: b/168020146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410309 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#807137}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600171148-66b09300985d04c4504d7b1ddf5998f31579a7e2.profdata to chrome-linux-master-1600192792-36de61e8f764b4ecaec9d88047348ce6694afdaf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib6196544dd26209e506e2a25a3fa54a7fa4ea87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412596Reviewed-by:
-
Sonny Sasaka authored
BUG=b:166673181 Change-Id: Id5f5ef0782c6d43ea99617b66f89294b2d7d19a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380741 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#807135}
-
manukh authored
On creation (and ominbox changes), the omnibox attempts to wakeup the current profile's BitmapFetcherService by invoking BitmapFetcherService::WakeupDecoder. But incognito and guest profiles do not have a BitmapFetcherService, resulting in calling WakeupDecoder on a nullptr and crashing. The recent CL crrev.com/c/2348328 introduced this wakeup call. This CL adds a prior null check. Other usages of BitmapFetcherService don't require a null check as they're conditioned on the existence of omnibox images which requires a non-incognito/guest profile. Bug: 1115108, 1128282 Change-Id: If0c21b6743182dfb7e5ab1d3f75fc7da6ee0bad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411655 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#807134}
-
Kyle Milka authored
Extend the expiry dates by 2 milestones. Bug: 1125774 Change-Id: Id132f16f3d76a1e7308b52b78c39511d5a0f1206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410343Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#807133}
-
Daniel Rubery authored
Enabling this feature flag would cause the DownloadProtectionServiceTest to look for an AdvancedProtectionStatusManager, which did not exist. This CL fixes that. Patch set 3 demonstrates that all tests now pass with the feature flag enabled. Change-Id: I90d771b0ca7a297e7f81509019c6f6de09ded3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410847 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#807132}
-
Sonny Sasaka authored
This changes FakePowerManagerClient to allow setting specific fake battery values per device so that tests can be more controlled. Without this, all devices will trigger PeripheralBatteryStatusReceived events that are often unwanted in tests. BUG=b:166530001 Change-Id: I74ee52685a955a0996b0aef72da403ae9ea79d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410961 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Luke Zielinski authored
By formatting test output to match the metadata format we can easily diff the output against the expectation metadata to identify changes. Bug: 1127360 Change-Id: I8c9c760478b2ff73699f847510d80706d3054955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405700Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#807130}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyExclusionsTest* Change-Id: Ic0f9fbc01f2f31baa893104d93111ed486f4f20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411285 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Xing Liu authored
In devices with small screen, "page 1" can fall outside of the view port. We have to scroll to make the recycler view create the view holder in memory. About view port: 1. RecyclerView won't create view holder outside view port to save memory. 2. IsDisplay() won't check things outside view port. 3. In order to verify stuff outside view port, we have to scroll to a particular view holder or position. To scroll, there are a couple of ways: 1. Use any of 3 RecyclerViewActions.* API. 2. Implement our own ViewAction for RecyclerView, and scroll with the recycler view handle. Bug: 1039491 Change-Id: I1669370abf595140313fc8cfcf2728e12e3b3389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411557Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807128}
-
Tina Wang authored
Previously the TableViewInfoButtonCell/Item is only used by managed settings UI, so the accessibility hint is set to "This settings is managed". Since the item and cell is refactored for generic usage, the accessibility hint should be exposed and be set accordingly. Bug: 1124407 Change-Id: I292e6215c59fafb55618316ccdd176a3ae777c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391504 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#807127}
-
Jose Dapena Paz authored
Two using declarations have been added in x11.h for an unnamed struct. This is not allowed by C++ (and GCC). An example: using XErrorEvent = struct { ... }; The solution is giving a name to the struct. Bug: 819294 Change-Id: I9e77017851efe8e0a92fb37c01fdba693bb7a36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412450Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#807126}
-
Becca Hughes authored
BUG=1128462 Change-Id: I78a060c655e7ffd90a636a428e3565bd510f5c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410291 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#807125}
-
Dominic Mazzoni authored
Page info bubbles just display a single string. To match recent UX mocks, the text of these bubbles should be multi-line and the bubbles should be the minimum width for a page info bubble (currently 320px). Bug: 1124489 Change-Id: I5fbe9e3395b450d8f45b7cc55f5bb09aeb95a1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409136Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807124}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/534924ed9ee5..93d0ecf3d428 2020-09-14 dpranke@google.com Add test executable API arg equivalents to typ 2020-09-14 fancl@chromium.org auto-triage: Fix None comments in issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1127899,chromium:816629 Tbr: zhanliang@google.com Change-Id: I9f8f03ee70ff76fade8fbd1c98d468fba2ba8c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411183Reviewed-by:
-
Bo Liu authored
Set the background color on ContentViewRenderView according to the dark mode, ie set it to black if dark mode is enabled. Then also set the same background on the compositor which is the the part that actually appears to make a difference visually. This is meant to be merged back to 86. Bug: 1127873 Change-Id: Ifcb9fa47af1e578b963f3f47ba5dc2b8252b80b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412189 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#807122}
-
Christian Biesinger authored
Border and padding gets added at the end of the function. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1083010 Change-Id: Iae51e87f93f8be2906690f888dde898763457bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412128 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807121}
-
Min Qin authored
There are several issues with this download test: 1. The new download progress info bar will mess up with the duplicate infobar when trying to find the latter. 2. Download update may never go through DownloadManagerService in download's new code paths 3. Only 1 duplicate infobar will show at a time, so the AllowMultipleInfoBars test is no longer valid This CL fixes the above 3 issues. BUG=597230 Change-Id: I9cfbfcd51c040dc77bd4f6e0cb0f6bfaf967a912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411732Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
-
edchin authored
* Moves feature flag file to //ios/chrome/browser/screen_time This was placed in the wrong place to begin with. This ensures that //ios/c/b does not depend on //ios/c/b/ui. Bug: 1123704 Change-Id: I103ad33fc14b56109249ee794c1e52a92f1a8a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393300 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#807119}
-
Evan Stade authored
This change uses the pre-existing GoogleAccountsCallback API to ask the embedder for the active user's email, and extends it to also be able to ask for full name and avatar. This allows WL to identify the active user and promote the associated contact info to the top of the list. If the active user's info is not in their own contacts, the email, name and avatar are used to synthesize contact info. Bug: 1016938 Change-Id: Ib2e6ce38761fc036b2657727775627186f0e7dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392578 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#807118}
-
