- 25 Apr, 2017 40 commits
-
-
fukino authored
In the migration UI, we ask users that "Don't turn off or close your Chromebook". In addition, we can resume migration even when user shut down / suspend the device during migration. That said, it should be even safer to prevent casual shutdown and power save mode by: - Hide "Shut down" button during migration. - Block power save during migration. Note that if the user close the lid, the system will be suspended. We have heard about heat issues when the lid is closed, and the system will be heated by heavy CPU usage of migration. It should be safer not to keep the device awake when the lid is closed. BUG=711454 TEST=manually tested that the "Shut down" button was hidden and the device did not go to sleep mode during migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842433002 Cr-Commit-Position: refs/heads/master@{#466879}
-
kbr authored
(Re-land after fix to avoid deleting nonexistent textures.) Blitting from a multisampled RGB8 renderbuffer to an alpha:false WebGL back buffer is supposed to work, and from an RGBA8 renderbuffer is supposed to not work. The emulation of IOSurface-backed RGB textures using RGBA textures didn't handle this case. Add BindTexImage2DWithInternalformatCHROMIUM to the command buffer to allow internal format to be overridden; currently this is only supported on macOS. Use this to bind a second texture to the IOSurface and use it only for BlitFramebuffer calls from WebGL, fixing up the alpha channel afterward. Covered by new conformance test in https://github.com/KhronosGroup/WebGL/pull/2377 . BUG=699566 TBR=zmo@chromium.org,ccameron@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2838743002 Cr-Commit-Position: refs/heads/master@{#466878}
-
jinsukkim authored
A new test got added to render_widget_host_connector_browsertest.cc which ensures RWHVA gets connected to objects inheriting RenderWidgetHostConnector regardless of the order in which they are created. Previously this had a bug resulting in RWHVA not connected ImeAdapter if RWHVA was created first, hence keeping soft keyboard from showing up. Also removed |WebContentsObserver::RenderViewReady()| override. It was overridden to initialize rwvha in the connector after creation. But it only covers the following cases: - connector created -> rwhva created -> RenderViewReady invoked - rwhva created -> connector created -> RenderViewReady invoked Can't cover the following case: - rwhva created -> RenderViewReady invoked -> connector created Now Initialize() covers them all, the method became redundant. BUG=713924 Review-Url: https://codereview.chromium.org/2840443002 Cr-Commit-Position: refs/heads/master@{#466877}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/892a0b6a45cc..5592ae343004 $ git log 892a0b6a4..5592ae343 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 achuith Disable testTraceCaptureUponFailure on chromeos. Created with: roll-dep src/third_party/catapult BUG=647340 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1b4136ceecbac675b4997f050d54c511c0f086df Reviewed-on: https://chromium-review.googlesource.com/486165 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466876}
-
Tommy Nyquist authored
This CL adds a new interface that will be used to validate whether new events should be stored, and during DB load on startup, it is also used to check if old event should still be kept around. The production implementation of this will be FeatureConfigStorageValidator, which uses the FeatureConfig to check what should be stored, but for now, the NeverStorageValidator will be used for all things to ensure that nothing is ever stored for now. This CL sets up the ownership of the StorageValidator, but does not update the ModelImpl to use the new framework, and leaves that as TODOs. BUG=706309 Change-Id: Ic581edc73f8f059c18fb1dcb5a549c4e62f490f8 Reviewed-on: https://chromium-review.googlesource.com/484682Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#466875}
-
yhirano authored
Revert of chromeos: Add CPU temperature reader (patchset #11 id:220001 of https://codereview.chromium.org/2823583002/ ) Reason for revert: This change causes a build error. Original issue's description: > chromeos: Add CPU temperature reader > > Reads from hwmon in sysfs. > > This does the same thing as ReadCPUTempInfo() in > chrome/browser/chromeos/policy/device_status_collector.cc, but it is > available to the rest of Chrome. > > BUG=chromium:709102 > > Review-Url: https://codereview.chromium.org/2823583002 > Cr-Commit-Position: refs/heads/master@{#466858} > Committed: https://chromium.googlesource.com/chromium/src/+/745fad9fe0f68a795a191a32cb038d864bfc2dbf TBR=derat@chromium.org,stevenjb@chromium.org,sque@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2843433005 Cr-Commit-Position: refs/heads/master@{#466874}
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#466873}
-
piperc authored
Reland of Add U2F request state machines (patchset #1 id:1 of https://codereview.chromium.org/2838573002/ ) Reason for revert: Missing initialized variable can be initialized and this patchset can be merged again. Original issue's description: > Revert of Add U2F request state machines (patchset #5 id:180001 of https://codereview.chromium.org/2821263005/ ) > > Reason for revert: > Reverting because U2fRequestTest.TestBasicMachine fails consistently on MSan bots (Linux MSan, Linux ChromiumOS MSan). > > Original issue's description: > > Add U2F request state machines > > > > U2fRequest base class is extended by each type of U2F > > request. Common functions of enumeration and device iteration > > are defined in the base class. U2fSign performs an entire > > sign request on any attached U2F devices, and U2FRegister > > performs the registration request on the devices. > > > > BUG=686310 > > > > Review-Url: https://codereview.chromium.org/2821263005 > > Cr-Commit-Position: refs/heads/master@{#466529} > > Committed: https://chromium.googlesource.com/chromium/src/+/892eb34117f811aa62c821c9129dc53110266e9a > > TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc@google.com,piperc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=686310 > > Review-Url: https://codereview.chromium.org/2838573002 > Cr-Commit-Position: refs/heads/master@{#466666} > Committed: https://chromium.googlesource.com/chromium/src/+/80f6eac95d5a0b54894b1526ba505308efd5ab23 TBR=reillyg@chromium.org,kpaulhamus@chromium.org,juanlang@chromium.org,piperc@google.com,pkalinnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686310 Review-Url: https://codereview.chromium.org/2835133003 Cr-Commit-Position: refs/heads/master@{#466872}
-
dvallet authored
Revert of Add --headless flag to Windows (patchset #29 id:560001 of https://codereview.chromium.org/2762593002/ ) Reason for revert: Testing revert on --headless flag, due to increase in child_dll size: https://bugs.chromium.org/p/chromium/issues/detail?id=714841 Original issue's description: > Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916 > > Add --headless flag to Windows: > > Fix browser_tests not compiling properly on windows > Fix headless/BUILD.gn by: > - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true. > - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/) > - Disabling breakpad in windows (will fix in a separate CL) > > > BUG=686608 > > Review-Url: https://codereview.chromium.org/2762593002 > Cr-Original-Commit-Position: refs/heads/master@{#466176} > Committed: https://chromium.googlesource.com/chromium/src/+/e3c745d4b37a659afaa0358c7de7b9bc881decb5 > Review-Url: https://codereview.chromium.org/2762593002 > Cr-Commit-Position: refs/heads/master@{#466259} > Committed: https://chromium.googlesource.com/chromium/src/+/d238dae172d63175b562f99fc988e47e5213a244 TBR=alexclarke@chromium.org,sky@chromium.org,skyostil@chromium.org,wfh@chromium.org,jzfeng@chromium.org,nick@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=686608 Review-Url: https://codereview.chromium.org/2837093003 Cr-Commit-Position: refs/heads/master@{#466871}
-
rdevlin.cronin authored
We recently added a GetAll() method to retrieve all arguments from a gin::Arguments object without conversion. Use it. BUG=653596 Review-Url: https://codereview.chromium.org/2843673002 Cr-Commit-Position: refs/heads/master@{#466870}
-
dbeam authored
R=stevenjb@chromium.org BUG=714103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842543002 Cr-Commit-Position: refs/heads/master@{#466869}
-
ssid authored
The renderer OOMs on system_health.common benchmark on Android One device because of tracing and other metrics being enabled. So, reduce the number of article reads. BUG=714650 R=nednguyen@google.com,perezju@chromium.org Review-Url: https://codereview.chromium.org/2842593002 Cr-Commit-Position: refs/heads/master@{#466868}
-
rdevlin.cronin authored
There's no need to pass in the Isolate, since we already pass in the context. Remove the Isolate argument from APIBinding::CreateInstance and APIBindingsSystem::CreateAPIInstance. BUG=653596 Review-Url: https://codereview.chromium.org/2842673002 Cr-Commit-Position: refs/heads/master@{#466867}
-
sungmann.cho authored
A browser window might be positioned over the edge between two screens. In that case we try to show the drop down menu on the screen the mouse cursor is on, but this does not work as expected on Windows. To achieve this, we obtain the bounds of the screen the mouse cursor is on, and then adjust the position of the drop down menu so that the menu stays within that bounds. But on Windows, we use the bounding rectangle of all display monitors instead of a specific monitor, and this leads to a different outcome than we expected. This CL fixes this problem. BUG=713690 Review-Url: https://codereview.chromium.org/2831323002 Cr-Commit-Position: refs/heads/master@{#466866}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=dewittj@chromium.org Review-Url: https://codereview.chromium.org/2840653002 Cr-Commit-Position: refs/heads/master@{#466865}
-
mcasas authored
Bump SDK to 23 (marshmallow) and use the changes to allow retrieving fixed (exposure, white balance) controls BUG=713417 Review-Url: https://codereview.chromium.org/2841543005 Cr-Commit-Position: refs/heads/master@{#466864}
-
hayato authored
This could save 10-20ms in the case (with ShadowRoot) of the bug 699838. See bug 713562 for details. We can do the similar technique for load events on img elements. That can be done as another CL. BUG=367276 Review-Url: https://codereview.chromium.org/2833733002 Cr-Commit-Position: refs/heads/master@{#466863}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=alemate@chromium.org Review-Url: https://codereview.chromium.org/2838603003 Cr-Commit-Position: refs/heads/master@{#466862}
-
dpapad authored
BUG=714824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2836143004 Cr-Commit-Position: refs/heads/master@{#466861}
-
xiaochengh authored
The above mentioned function used to remove all markers, which is wrong. This patch fixes it to remove only spelling and grammar markers. BUG=713995 TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords Review-Url: https://codereview.chromium.org/2838733002 Cr-Commit-Position: refs/heads/master@{#466860}
-
fdoray authored
The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=alemate@chromium.org Review-Url: https://codereview.chromium.org/2841633003 Cr-Commit-Position: refs/heads/master@{#466859}
-
sque authored
Reads from hwmon in sysfs. This does the same thing as ReadCPUTempInfo() in chrome/browser/chromeos/policy/device_status_collector.cc, but it is available to the rest of Chrome. BUG=chromium:709102 Review-Url: https://codereview.chromium.org/2823583002 Cr-Commit-Position: refs/heads/master@{#466858}
-
engedy authored
For now, the list will still have exactly one Configuration, the one that is parsed from the field trial configuration. Therefore the benefits of this change for now is that tests, which change the configuration after their WebContents is created, will no longer need to inject the new configuration manually into the classes under test, because those classes can now directly work with the authoritative global state. BUG=708181 Review-Url: https://codereview.chromium.org/2831373002 Cr-Commit-Position: refs/heads/master@{#466857}
-
amaralp authored
There is a bug where after "Select All" Smart Select will suggest a different (smaller) selection. This CL checks if the selection only has one word. Since longpress/double tap only selects one word, if we have multiple words we can assume it comes from "Select All" and not do Smart Select. BUG=714106 Review-Url: https://codereview.chromium.org/2838023002 Cr-Commit-Position: refs/heads/master@{#466856}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/302cd78d00c2..ef002c855212 $ git log 302cd78d0..ef002c855 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 thestig Use fx_extension.h utilities in more places. 2017-04-24 thestig Add tests for BC_OnedCode128Writer encoding functions. 2017-04-24 tsepez Add FXSYS_wcsftime() to avoid termination on win. 2017-04-24 tsepez Use a pdfium-specific unittest main rather than gtest's 2017-04-21 tsepez Use unique_ptr in CFX_SizeGlyphCache 2017-04-24 dsinclair Nit cleanup in XFA widget code Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I363555382eeca929b42d7438a22e950abb3400d1 Reviewed-on: https://chromium-review.googlesource.com/486150 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466855}
-
watk authored
Previously, after falling back to another decoder, we had to keep the old one alive in case it owned frames that were currently being displayed. Now all decoders produce frames that outlive themselves, so we can safely delete the decoder as soon as we no longer need it. This change also includes deletion of a related, but now unused, VideoFrame metadata value called DECODER_OWNS_FRAME. BUG=663988 Review-Url: https://codereview.chromium.org/2841553003 Cr-Commit-Position: refs/heads/master@{#466854}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72d17915..c76bb271 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2843643002 Cr-Commit-Position: refs/heads/master@{#466853}
-
vovoy authored
flag --tabset-repeat multiply the tab count of benchmark tab_switching to measure metrics on different tab count. ex: add flag --tabset-repeat=2 to double the tab count. BUG=689388 Review-Url: https://codereview.chromium.org/2819423002 Cr-Commit-Position: refs/heads/master@{#466852}
-
ben authored
Eliminate ChildThread InterfaceRegistry. Also cleans up ServiceManagerConnectionImpl::IOThreadContext::OnBindInterface(). R=rockot@chromium.org Review-Url: https://codereview.chromium.org/2820883002 Cr-Commit-Position: refs/heads/master@{#466851}
-
dschuyler authored
This Cl moves UI elements in the content / site settings part of MD settings. Specifically it swaps the subpage arrow and the 'three-dots' action menu. BUG=713918 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2832153004 Cr-Commit-Position: refs/heads/master@{#466850}
-
hcarmona authored
TBR=robhogan@gmail.com BUG=714862 Review-Url: https://codereview.chromium.org/2837913003 Cr-Commit-Position: refs/heads/master@{#466849}
-
mstensho authored
BUG=700919 Review-Url: https://codereview.chromium.org/2840443003 Cr-Commit-Position: refs/heads/master@{#466848}
-
estade authored
View's native theme. This fixes a few bugs where we weren't using the right native theme, whether by not updating after the NativeTheme changes or by trying to access the NativeTheme before the View is added to a hierarchy (which yields the default NativeTheme --- for most platforms, this didn't effectively create a bug as there's only one NativeTheme). Best example is that now the sad tab respects the GTK native theme. Get rid of Ash's tray_constants::kBackgroundColor in favor of using the bubble background color from the NativeTheme. BUG=711183,693282 TBR=stevenjb@chromium.org Review-Url: https://codereview.chromium.org/2816193002 Cr-Commit-Position: refs/heads/master@{#466847}
-
avallee authored
Adding temporary logging to the test to figure out why the test is flaky. This commit will likely be reverted once it shows up as flaky. BUG=713977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2837213002 Cr-Commit-Position: refs/heads/master@{#466846}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/bb05f70b4be2..c1889823de68 $ git log bb05f70b4..c1889823d --date=short --no-merges --format='%ad %ae %s' 2017-04-24 bsalomon Add new GrVkBackendContext::Create explicitly requiring vk proc getters Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ib4c867ae1b8222aece8f92b23d0c63b68496b38a Reviewed-on: https://chromium-review.googlesource.com/486126Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466845}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f0a16108160d..892a0b6a45cc $ git log f0a161081..892a0b6a4 --date=short --no-merges --format='%ad %ae %s' 2017-04-24 nednguyen Roll WPR to the lastest commit Created with: roll-dep src/third_party/catapult BUG=702194,711634 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie143bf24f0c15a8694009dcad6f5291560c7fe15 Reviewed-on: https://chromium-review.googlesource.com/486164 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#466844}
-
lukasza authored
Previous CL (https://crrev.com/2686943002) started putting WebContents created via ctrl-click into a new process. One case that was still broken is target="_blank" (or target="non-existant-name"). At first glance, it might seem arbitrary to decide which directive (ctrl-click VS target=_blank) wins and influences 1) process allocation behavior and 2) window.opener / browsing instance behavior. In reality, ctrl-click should win because: 1. This is the behavior desired by users (e.g. see https://crbug.com/23815). 2. This is the behavior of other browsers (e.g. see https://crbug.com/658386#c9). Before this CL, FrameLoader::load would ignore ctrl-click / NavigationPolicyNewForegroundTab and go through createWindowForRequest path if the named target frame didn't exist when the navigation is initiated. After this CL, ctrl-click "wins". This CL has to tweak 2 layout tests affected by the change. In both cases, the test expectation that a background-tab-navigation is handled by createView is no longer correct - now the navigation goes through OpenURL path rather than through CreateWindowForRequest. Accomodating the 2 tests also required adding support for handling WindowOpenDisposition::NEW_BACKGROUND_TAB in content::Shell::OpenURLFromTab. NOPRESUBMIT usage has been discussed in https://crrev.com/2680353005/#msg50 BUG=23815, 658386 NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2680353005 Cr-Commit-Position: refs/heads/master@{#466843}
-
krasin authored
Revert of Enable ThinLTO and LLD for POSIX LTO by default on Linux. (patchset #4 id:60001 of https://codereview.chromium.org/2831213006/ ) Reason for revert: Code size increase: https://chromeperf.appspot.com/report?sid=7826328365affe1842778994c934cbe08c7f9b78ef5d8895ec85d3094bb8972d&start_rev=466555&end_rev=466782 Postmortem is coming. TL;DR: worse dead code elimination in ThinLTO Original issue's description: > Enable ThinLTO and LLD for POSIX LTO by default on Linux. > > Eventually, we will enable LLD on Linux even for regular > builds, but it's natural to make incremental steps here. > > ThinLTO brings multi-threaded linking for LinkTimeOptimization > builds, which allows to speed up codegen considerably (up to 4x). > ThinLTO also manages a cache inside out/<gn-config>/thinlto-cache > directory, that improves incremental linking as well. > > There's a cache pruning policy that will prevent the cache from > growing indefinitely. The policy is not yet finalized, and > complaints / suggestions are welcome. > > BUG=660216,607968 > > Review-Url: https://codereview.chromium.org/2831213006 > Cr-Commit-Position: refs/heads/master@{#466732} > Committed: https://chromium.googlesource.com/chromium/src/+/7997bbe88aef7eeca37111dcb8426f0430347fb5 TBR=dpranke@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=660216,607968 Review-Url: https://codereview.chromium.org/2842683002 Cr-Commit-Position: refs/heads/master@{#466842}
-
sammiequon authored
Removed the setup pin link and put a button inside the radio button instead to fire up the setup pin dialog. https://screenshot.googleplex.com/Yvp9brRd2wS Upstream paper-radio-button PR: https://github.com/PolymerElements/paper-radio-button/pull/119 TEST=manual BUG=703998 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2823713002 Cr-Commit-Position: refs/heads/master@{#466841}
-
martiniss authored
Looks like this was added pre-swarming. It's unused, and undocumented, so just remove it. Review-Url: https://codereview.chromium.org/2842623002 Cr-Commit-Position: refs/heads/master@{#466840}
-