GitLab

Remove noamsml@ from all OWNERS files.

NOTRY=true

Review URL: https://codereview.chromium.org/541943002

Cr-Commit-Position: refs/heads/master@{#293470}

BUG=

Review URL: https://codereview.chromium.org/537843002

Cr-Commit-Position: refs/heads/master@{#293469}

We have a plan in progress to upgrade the 'important' field to a combination
of two fields 'primary' and 'improvement_direction'. This will be a two-sided
patch that will require reworking the dashboard's handling of chart JSON. Since
the dashboard has been modified to accept chart JSON with 'important' values,
we want to update Telemetry to continue serializing values with this field for
now.

R=nednguyen

Review URL: https://codereview.chromium.org/541253002

Cr-Commit-Position: refs/heads/master@{#293468}

BUG=none

Review URL: https://codereview.chromium.org/538263003

Cr-Commit-Position: refs/heads/master@{#293467}

BUG=none
TEST=none
R=asvitkine@chromium.org, jwd@chromium.org

Review URL: https://codereview.chromium.org/541933002

Cr-Commit-Position: refs/heads/master@{#293466}

The DLL must match the executable, and the kernel driver must match the OS. Confusing, I know!

BUG=336558
TEST=python tools/telemetry/run_tests msr  # On a machine with 32-bit Python and 64-bit Windows, in a shell with Administrator privileges.
R=tonyg

Review URL: https://codereview.chromium.org/539303002

Cr-Commit-Position: refs/heads/master@{#293465}

This reverts HidService to being a singleton instance for now.

BUG=401234
TBR=rpaquay

Review URL: https://codereview.chromium.org/523743005

Cr-Commit-Position: refs/heads/master@{#293464}

BUG=397741

Review URL: https://codereview.chromium.org/540183002

Cr-Commit-Position: refs/heads/master@{#293463}

This makes it easier for automated tools such as nacl_deps_bump.py to
update the field.  It also makes it easier to search the history for
changes to the field.

The field was removed by fd5ba194,
which switched DEPS from SVN revisions to Git revisions.

BUG=263848
TEST=trybots

Committing with
NOTRY=true
due to race with updates to adjacent webkit_revision.

Review URL: https://codereview.chromium.org/546453003

Cr-Commit-Position: refs/heads/master@{#293462}

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/538863003

Cr-Commit-Position: refs/heads/master@{#293461}

Before this cl, VideoTrackAdapter.FramesReceived was logged for all types of MediaStreamVideoSources including remote video sources and pepper api sources.
The indent of this UMA stat is to track if a video capture device output video frames or not.

BUG= 409624

Review URL: https://codereview.chromium.org/529733002

Cr-Commit-Position: refs/heads/master@{#293460}

The implicit conversion operator is being removed, because of the
surprises it can cause. For example, one might write:
  scoped_refptr<Foo> CreateFoo();
to ensure that callers hold the result in a scoped_refptr. But the
implicit conversion to T* means that a caller can accidentally hold
the result in a Foo* and the compiler won't catch it.

Since there are a large number of dependencies on this implicit
conversion, the cleanup is being conducted by a combination of
automated tooling and manual cleanup. It is also being staged on a
platform by platform basis. All known dependencies on the implicit
conversion on Linux (but not ChromeOS) have been removed, so this
patch disables the conversion operator on Linux builds to prevent
new dependencies on the implicit conversion.

Finally, to help facilitate this transition, temporary operator
overloads for comparison have been added. These will eventually be
removed.

BUG=110610
R=jyasskin@chromium.org, rsleevi@chromium.org, willchan@chromium.org

Review URL: https://codereview.chromium.org/510323002

Cr-Commit-Position: refs/heads/master@{#293459}

Fix a couple more dependencies on implicit conversions that have been
checked in since this morning.

BUG=110610
R=vtl@google.com
TBR=rsleevi, vtl, yzshen

Review URL: https://codereview.chromium.org/541243003

Cr-Commit-Position: refs/heads/master@{#293458}

It isn't necessary to mess around with sharing CGLContextObjs anymore,
they were necessary only to share data between the frame subscriber
and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its
own CGLContextObj, and draw using immediate mode (using shaders
resulted in an increase in startup time).

BUG=314190
TBR=pfeldman@chromium.org
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/541663002

Cr-Commit-Position: refs/heads/master@{#293457}

This is an intermediate step, the real fix is to get rid of
ResourceLoaderBridge.

BUG=338338
TEST=None, no functional changes
R=avi@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/519333002

Cr-Commit-Position: refs/heads/master@{#293456}

*.crdownload
*.crx
*.dmg
*.exe
*.html
*.jar
*.ps
*.torrent
*.txt
*.zip

BUG=397181
TEST=manually
1.Go to chrome://histogram.
2.Open the each file.
3.Confirtm the count is increased.

Review URL: https://codereview.chromium.org/539853002

Cr-Commit-Position: refs/heads/master@{#293455}

Similar to bug 398384, but perform the same bounds check we introduced to
chrome_pdf::CopyImage() in the chrome_pdf::AlphaBlend() function.

Also change the return value from bool to void, since AlphaBlend() always
returns true, and no-one was checking the return value anyways.

BUG=384891

Review URL: https://codereview.chromium.org/544863002

Cr-Commit-Position: refs/heads/master@{#293454}

BUG=110610
TBR=caitkp, michaeln, rockot, sievers, sky, willchan

Review URL: https://codereview.chromium.org/543893002

Cr-Commit-Position: refs/heads/master@{#293453}

This required ripping out the old concept of app navigation,
since it is no longer compatible with how apps get connected
to.

BUG=

Review URL: https://codereview.chromium.org/514063003

Cr-Commit-Position: refs/heads/master@{#293452}

BUG=408189

Review URL: https://codereview.chromium.org/529223003

Cr-Commit-Position: refs/heads/master@{#293451}

Cleaning up weak_ptr_factorydestruction order in "src/ash" module.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/497733002

Cr-Commit-Position: refs/heads/master@{#293450}

It's pretty common that GUID strings express hex digits in lowercase.
This CL modifies base::IsValidGUID() to also accept GUID strings in
lowercase, so that the function can be used to validate GUIDs not
generated by base::GenerateGUID().

BUG=None
TEST=base_unittests

Review URL: https://codereview.chromium.org/546603002

Cr-Commit-Position: refs/heads/master@{#293449}

Revert of Check to ensure PowerObservers are added and removed on the same thread (patchset #7 id:120001 of https://codereview.chromium.org/502003003/)

Reason for revert:
Causing failures on Mac try jobs:
ExtensionServiceTest.ExternalExtensionAutoAcknowledgement (run #1):
[ RUN      ] ExtensionServiceTest.ExternalExtensionAutoAcknowledgement
[8427:1799:0904/211500:4724222818698:FATAL:power_monitor.cc(38)] Check failed: obs->power_monitor_thread_checker_.

Original issue's description:
> Check to ensure PowerObservers are added and removed on the same thread
>
> This behavior is required by ObserverListThreadSafe and may leads to crashes if not followed
>
> BUG=404767
>
> Committed: https://chromium.googlesource.com/chromium/src/+/518c46fbba70c91169bfc0c64b542f06e56b3915

TBR=thakis@chromium.org,brettw@chromium.org,scottmg@chromium.org,bajones@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404767

Review URL: https://codereview.chromium.org/544913003

Cr-Commit-Position: refs/heads/master@{#293448}

It reduces disk I/O cost on counting dirty trackers.

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabase*"

Review URL: https://codereview.chromium.org/536343002

Cr-Commit-Position: refs/heads/master@{#293447}

This reduces the amount of logging for most tests, which is filling up
the disk on the tryserver master, while leaving logging for bugs under
investigation.

BUG=393331,405577,407976,408358
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/541283002

Cr-Commit-Position: refs/heads/master@{#293446}

Simple cleanup to remove unneeded parts of BrowserActionsContainer
and friends. No behavioral changes, and nothing fancy.

Review URL: https://codereview.chromium.org/542493002

Cr-Commit-Position: refs/heads/master@{#293445}

Also do a bunch of other small things. See the plan at the top of
channel_endpoint.h.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/541233002

Cr-Commit-Position: refs/heads/master@{#293444}

This is a general cleanup of some minor issues, mostly style and
comments, for SSLHostStateDelegate and related classes and methods. This
was done originally as a C++ readability review request, originally
based on https://codereview.chromium.org/369703002/.

Review URL: https://codereview.chromium.org/441043005

Cr-Commit-Position: refs/heads/master@{#293443}

It's unnecessary because nothing appears to depend on it,
and it blocks use of C++11 in base.

The IRT build is still enabled because the IRT is the primary user of base_nacl.
The pnacl_newlib build is still enabled because the remoting client uses it.

BUG=360096
R=thakis@chromium.org,mseaborn@chromium.org

Review URL: https://codereview.chromium.org/540093002

Cr-Commit-Position: refs/heads/master@{#293442}

This changes the index parameters in start() and end() to size_t so that
they match what size() returns. This fixes some compiler warnings that
become errors on some of the Windows bots.

BUG=408338

Review URL: https://codereview.chromium.org/539203002

Cr-Commit-Position: refs/heads/master@{#293441}

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/542973002

Cr-Commit-Position: refs/heads/master@{#293440}

We only allow one MessageLoop instance alive at any given time on a thread. If
we use IPCTestBase::set_message_loop(), we need to do it in two steps: first set
the message loop to NULL, and then set it to a newly-created message loop.

Therefore, I changed the interface of IPCTestBase to make it a little
more friendly.

BUG=None

TEST=ipc_perftests should not crash in debug build.

Review URL: https://codereview.chromium.org/538593002

Cr-Commit-Position: refs/heads/master@{#293439}

BUG=393908
TEST=None

Review URL: https://codereview.chromium.org/531523002

Cr-Commit-Position: refs/heads/master@{#293438}

Enable the InputEventStreamValidator by default on Android. Also add
some basic unit tests, and clean up several corner cases that previously
went unnoticed.

BUG=345372

Review URL: https://codereview.chromium.org/537733003

Cr-Commit-Position: refs/heads/master@{#293437}

The code lives in src/extensions but it was running in Chrome's unit_tests.
* Switch to ExtensionsTest
* Remove unnecessary UI loop run-until-idle

Also fix uninitialized member in TestExtensionsBrowserClient.

BUG=397164
TEST=extensions_unittests Bluetooth*

Review URL: https://codereview.chromium.org/544753003

Cr-Commit-Position: refs/heads/master@{#293436}

In OOBE screen, shelf is not yet ready fully so that work_area_
isn't set well. It needs to be initialized here.

BUG=401743
R=stevenjb@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/544883002

Cr-Commit-Position: refs/heads/master@{#293435}

The CLs here
https://codereview.chromium.org/489793003
and here
https://codereview.chromium.org/395913006

In isolation look correct but taken together cause a overflow or underflow
bug. Basically the message loop was calling Time::ActivateHighResolutionTimer(false)
all the time (or very often) so the g_high_res_timer_count was underflowing
or overflowing.

Now messageloop only calls ActivateHighResolutionTimer in a balanced way.

This can make the base_unittests fail as well with
--gtest_filter=MessageLoopTest.HighResolutionTimer

BUG=153139
TEST=included, see bug for manual testing.

Review URL: https://codereview.chromium.org/541203002

Cr-Commit-Position: refs/heads/master@{#293434}

Currently, the code clamps alpha up to to 100% within the window shape and
down to 0% outside the shape. This means that windows with shape *and*
transparency enabled effectively lose their transparency.

This change makes it so that the alpha is clamped up to 0% within the window
shape, which preserves the window's transparency.

BUG=405751

Review URL: https://codereview.chromium.org/499503002

Cr-Commit-Position: refs/heads/master@{#293433}

BUG=411083

Review URL: https://codereview.chromium.org/546573003

Cr-Commit-Position: refs/heads/master@{#293432}

This fixes two related issues:
* Scrolling was broken in apps v2, due to window-body div not being
  full-height.
* Scrolling was broken post-disconnect, due to the addition of an explicit
  scroller node, separate from the body.
* The dialog screen was off by 1px, due to the addition of the window-body
  div.

Since this has broken a few times now, I plan to add a browser to test to verify
the behaviour, but I don't want to hold up this CL for that.

BUG=251443

Review URL: https://codereview.chromium.org/539403002

Cr-Commit-Position: refs/heads/master@{#293431}