Commits · e8aa4d341088f9cf57e24b3d94cfd9bd43428444 · eriksson monteiro / tangled

05 Apr, 2013 40 commits

disable CommitWhenShownInFullHeightWithoutFocus on Mac · e8aa4d34

scottmg@chromium.org authored Apr 05, 2013

Timing out on regular and ASAN bots.

Note: Google Test filter = InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from InstantExtendedTest, where TypeParam =
[ RUN      ] InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
Right after fork
Right before base::type_profiler::Controller::Stop()
Right after base::type_profiler::Controller::Stop()
Right after signal/exception handler restoration.
Right after fd_shuffle push_backs.
Right after ShuffleFileDescriptors
Right after CloseSuperfluousFds
Right before execvp
/Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /Volumes/data/b/build/third_party/twisted_10_2/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
  import pkg_resources
  /Volumes/data/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /Volumes/data/b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
    import pkg_resources
    HTTPS server started on 127.0.0.1:50602...
    sending server_data: {"host": "127.0.0.1", "port": 50602} (36 bytes)
    [0405/102718:ERROR:test_launcher.cc(365)] Test timeout (60000 ms) exceeded for InstantExtendedTest.CommitWhenShownInFullHeightWithoutFocus
    BrowserTestBase signal handler received SIGTERM. Backtrace:
    0   interactive_ui_tests                0x03a4fe9a base::debug::StackTrace::StackTrace() + 26
    1   interactive_ui_tests                0x03640083 (anonymous namespace)::DumpStackTraceSignalHandler(int) + 131
    2   libSystem.B.dylib                   0x951de05b _sigtramp + 43
    3   ???                                 0xffffffff 0x0 + 4294967295
    4   CoreFoundation                      0x97a702df __CFRunLoopRun + 2079
    5   CoreFoundation                      0x97a6f3c4 CFRunLoopRunSpecific + 452
    6   CoreFoundation                      0x97a6f1f1 CFRunLoopRunInMode + 97
    7   HIToolbox                           0x91cd1e04 RunCurrentEventLoopInMode + 392
    8   HIToolbox                           0x91cd1bb9 ReceiveNextEventCommon + 354
    9   HIToolbox                           0x91cd1a3e BlockUntilNextEventMatchingListInMode + 81
    10  AppKit                              0x980f2595 _DPSNextEvent + 847
    11  AppKit                              0x980f1dd6 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 156
    12  AppKit                              0x980b41f3 -[NSApplication run] + 821
    13  interactive_ui_tests                0x03a14a51 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 737
    14  interactive_ui_tests                0x03a136b0 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 448
    15  interactive_ui_tests                0x03ac44fa base::MessageLoop::RunInternal() + 650
    16  interactive_ui_tests                0x03b1efd5 base::RunLoop::Run() + 69
    17  interactive_ui_tests                0x0365be40 content::RunThisRunLoop(base::RunLoop*) + 144
    18  interactive_ui_tests                0x0365d343 content::WindowedNotificationObserver::Wait() + 611
    19  interactive_ui_tests                0x008f7749 InstantExtendedTest_CommitWhenShownInFullHeightWithoutFocus_Test::RunTestOnMainThread() + 12777
    20  interactive_ui_tests                0x0a6af765 InProcessBrowserTest::RunTestOnMainThreadLoop() + 581
    21  interactive_ui_tests                0x036405b9 base::internal::Invoker<1, base::internal::BindState<base::internal::RunnableAdapter<void (content::BrowserTestBase::*)()>, void ()(content::BrowserTestBase*), void ()(content::BrowserTestBase*)>, void ()(content::BrowserTestBase*)>::Run(base::internal::BindStateBase*) + 137
    22  interactive_ui_tests                0x05fd844c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 23292
    23  interactive_ui_tests                0x05fd27cc ChromeBrowserMainParts::PreMainMessageLoopRun() + 28
    24  interactive_ui_tests                0x05677805 content::BrowserMainLoop::CreateThreads() + 1813
    25  interactive_ui_tests                0x0567b058 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 1080
    26  interactive_ui_tests                0x0567441e content::BrowserMain(content::MainFunctionParams const&) + 142
    27  interactive_ui_tests                0x0363fd44 content::BrowserTestBase::SetUp() + 1076
    28  interactive_ui_tests                0x0a6abdc7 InProcessBrowserTest::SetUp() + 1943
    29  interactive_ui_tests                0x0260b299 void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 473
    30  interactive_ui_tests                0x025f0910 testing::Test::Run() + 752
    31  interactive_ui_tests                0x025f22d1 testing::TestInfo::Run() + 1601
    32  interactive_ui_tests                0x025f31ea testing::TestCase::Run() + 1418
    33  interactive_ui_tests                0x02604d83 testing::internal::UnitTestImpl::RunAllTests() + 3043
    34  interactive_ui_tests                0x0260cbd9 bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) + 473
    35  interactive_ui_tests                0x02604133 testing::UnitTest::Run() + 307
    36  interactive_ui_tests                0x04e0bb51 base::TestSuite::Run() + 673
    37  interactive_ui_tests                0x00985d94 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 132
    38  interactive_ui_tests                0x0365277c content::LaunchTests(content::TestLauncherDelegate*, int, char**) + 3884
    39  interactive_ui_tests                0x00985b8c main + 172
    40  interactive_ui_tests                0x000030a5 start + 53

R=xhwang@chromium.org
BUG=227076

Review URL: https://codereview.chromium.org/13685015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192602 0039d316-1c4b-4281-b951-d872f2087c98

e8aa4d34

Update .DEPS.git · 3dad3469

chrome-admin@google.com authored Apr 05, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192598 0039d316-1c4b-4281-b951-d872f2087c98

3dad3469

Adds dewittj to the notification owners file. · 7364abf2

mukai@chromium.org authored Apr 05, 2013

Also reorder the file alphabetically

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13704013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192597 0039d316-1c4b-4281-b951-d872f2087c98

7364abf2

Blink merge 147606:147630 · 0a60869e

japhet@chromium.org authored Apr 05, 2013

BUG=none
TEST=none
TBR=tkent
Review URL: https://codereview.chromium.org/13533018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192596 0039d316-1c4b-4281-b951-d872f2087c98

0a60869e

Crop images from custom themes before storing them into the theme pack. · 59723ccf

pkotwicz@chromium.org authored Apr 05, 2013

BUG=176857
Test=None
R=erg
TBR=sky (For ui/linux_ui/linux_ui.h)

Review URL: https://chromiumcodereview.appspot.com/13497002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192595 0039d316-1c4b-4281-b951-d872f2087c98

59723ccf

Re-Re-apply 192420: Move login switches to src/chromeos" · 931d1047

stevenjb@chromium.org authored Apr 05, 2013

Once more with feeling. This time for sure.
I correctly figured out how to do a GOOGLE_CHROME_BUILD since apparantly
this does not get defined in any of the CQ chromeos bots.

BUG=192420
TBR=ben@chromium.org, et. al.

Review URL: https://codereview.chromium.org/13730003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192594 0039d316-1c4b-4281-b951-d872f2087c98

931d1047

Update scoped_array<T>::reset logic to match scoped_ptr. · 24f7de85

dcheng@chromium.org authored Apr 05, 2013

This logic was already added in scoped_ptr::reset() in
https://src.chromium.org/viewvc/chrome?view=rev&revision=185551.
this is a straightforward port of the logic to scoped_array to
prevent any accidental regressions during the transition.

BUG=162971,176091

Review URL: https://codereview.chromium.org/13433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192590 0039d316-1c4b-4281-b951-d872f2087c98

24f7de85

Sign out when render crashes on lock screen · 2cadbff3

dpolukhin@chromium.org authored Apr 05, 2013

BUG=225967
TEST=manual, lock screen, go to second terminal, kill render process for lock screen, login screen should be shown

Review URL: https://chromiumcodereview.appspot.com/13520006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192589 0039d316-1c4b-4281-b951-d872f2087c98

2cadbff3

Make autofill's Address store country using the country code so that app... · ed005f6f

jam@chromium.org authored Apr 05, 2013

Make autofill's Address store country using the country code so that app locale isn't needed for the raw methods.

This is in preparation for removing content::GetContentClient calls outside of content.

BUG=227047
Review URL: https://codereview.chromium.org/13697002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192588 0039d316-1c4b-4281-b951-d872f2087c98

ed005f6f

Making touch target wider (35px) for the splitter in bookmark manager · 165241ab

varkha@chromium.org authored Apr 05, 2013

BUG=100083

TEST=Open bookmark manager on a touch device (such as Pixel). Confirm that the vertical splitter can be comfortably moved and tree pane resized for reasonably long folder names to fit.

Repeat with a RTL language, e.g. by running "chrome --lang=IW" confirming that the left and right padding is reversed.

Review URL: https://chromiumcodereview.appspot.com/13606002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192585 0039d316-1c4b-4281-b951-d872f2087c98

165241ab

Omnibox: Speed Up SearchProviderTest · 24dbf230

mpearson@chromium.org authored Apr 05, 2013

By reducing the time waited between sending a Autocomplete request and
SearchProvider sending the request to mocked suggest server.

The speeds up the wall time of running SearchProvider test from 30 seconds to 20 seconds.

BUG=

Review URL: https://chromiumcodereview.appspot.com/13461012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192584 0039d316-1c4b-4281-b951-d872f2087c98

24dbf230

drive: Fills no-parent entiries in "/drive/other". · 6db80f97

haruki@chromium.org authored Apr 05, 2013

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Review URL: https://chromiumcodereview.appspot.com/13456002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192583 0039d316-1c4b-4281-b951-d872f2087c98

6db80f97

Use macro to simplify gpu driver bug workaround defs and code. · 66a34ea9

zmo@chromium.org authored Apr 05, 2013

BUG=226789
TEST=no logic change, simply code refactor, so everything stays the same
Review URL: https://codereview.chromium.org/13400003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192580 0039d316-1c4b-4281-b951-d872f2087c98

66a34ea9

Revert 192563 "Fix DownloadExtensionTest_OnDeterminingFilename_I..." · 41b33504

xhwang@chromium.org authored Apr 05, 2013

This test failed on Vista Tests bot:

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/33887/steps/browser_tests/logs/DownloadExtensionTest_OnDeterminingFilename_InterruptedResume

DownloadExtensionTest.DownloadExtensionTest_OnDeterminingFilename_InterruptedResume: 
[0405/091818:ERROR:gl_surface_egl.cc(98)] eglInitialize failed with error
UNKNOWN
[0405/091818:ERROR:gl_surface_win.cc(54)] GLSurfaceEGL::InitializeOneOff failed.
HTTP server started on 127.0.0.1:51868...
sending server_data: {"host": "127.0.0.1", "port": 51868} (36 bytes)
browser\extensions\api\downloads\downloads_api_unittest.cc(3222): error: Value
of: item->GetState()
Actual: 0
Expected: DownloadItem::INTERRUPTED
Which is: 3
browser\extensions\api\downloads\downloads_api_unittest.cc(3223): error: Value
of: item->IsInterrupted()
Actual: false
Expected: true

> Fix DownloadExtensionTest_OnDeterminingFilename_InterruptedResume
> 
> Review URL: https://codereview.chromium.org/12422012

TBR=benjhayden@chromium.org
Review URL: https://codereview.chromium.org/13598016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192579 0039d316-1c4b-4281-b951-d872f2087c98

41b33504

History: Fix position of lock/unlock button · ced9eeff

sergiu@chromium.org authored Apr 05, 2013

The lock/unlock button for the managed controls in the history page has been
misplaced by one of the patches. This moves it to somewhere else so it looks
fine again.

R=dubroy@chromium.org
BUG=
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/13568003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192577 0039d316-1c4b-4281-b951-d872f2087c98

ced9eeff

Fix sizing when auto-scaling a missing resource at a non-integer scale factor.... · f0896290

kevers@chromium.org authored Apr 05, 2013

Fix sizing when auto-scaling a missing resource at a non-integer scale factor. Matches the rounding rules used by UX when scaling resources at non-integer scale factors.

BUG=223928

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190970

Review URL: https://chromiumcodereview.appspot.com/12939015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192576 0039d316-1c4b-4281-b951-d872f2087c98

f0896290

Minor Ash panel related cleanup · 0419d72d

stevenjb@chromium.org authored Apr 05, 2013

A little code cleanup I did while debugging some panel focus issues.

BUG=none

Review URL: https://codereview.chromium.org/12442009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192575 0039d316-1c4b-4281-b951-d872f2087c98

0419d72d

Temporarily disable DomSerializerTests.SerializeXMLDocWithBuiltInEntities · 0644617c

yurys@chromium.org authored Apr 05, 2013

R=vsevik,pfeldman
BUG=227030

Review URL: https://codereview.chromium.org/13674009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192574 0039d316-1c4b-4281-b951-d872f2087c98

0644617c

NTP/History: Remove comments referring to flexbox bug. · 239b0171

dubroy@chromium.org authored Apr 05, 2013

The problems were not caused by a bug, but rather a change in the
flexbox spec.

BUG=None
TEST=None, no functional change.
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/13459009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192573 0039d316-1c4b-4281-b951-d872f2087c98

239b0171

Update options UI to display "/special/drive/root" as "Google Drive". · 22ce2735

haruki@chromium.org authored Apr 05, 2013

We are introducing a new namespace "root". The "My Drive" root will be represented as
"/special/drive/root".

BUG=174233,218221
TEST=Open options UI


Review URL: https://chromiumcodereview.appspot.com/12790013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192572 0039d316-1c4b-4281-b951-d872f2087c98

22ce2735

Wrench Icon: Updated icons · 5a8790aa

sail@chromium.org authored Apr 05, 2013

New icons from sgabriel@.

BUG=180107
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/13685011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192571 0039d316-1c4b-4281-b951-d872f2087c98

5a8790aa

drive: Enable a hook to update the default download directory. · ecc9cfd6

haruki@chromium.org authored Apr 05, 2013

This enables the update logic for /drive/root namespace.

BUG=174233
TESTS=unittests


Review URL: https://chromiumcodereview.appspot.com/13586012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192570 0039d316-1c4b-4281-b951-d872f2087c98

ecc9cfd6

Support shared workers as debug targets for chrome.debugger API · ac3851fe

kaznacheev@chromium.org authored Apr 05, 2013


BUG=226014


Review URL: https://chromiumcodereview.appspot.com/13517002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192569 0039d316-1c4b-4281-b951-d872f2087c98

ac3851fe

Remove MSID and bundle from the answer as well as offer in WebRtc content_browsertest. · 22a49a3b

perkj@chromium.org authored Apr 05, 2013


BUG=175683,177443


Review URL: https://chromiumcodereview.appspot.com/13679005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192567 0039d316-1c4b-4281-b951-d872f2087c98

22a49a3b

DevTools: Enable subpixel antialiasing on Linux · 54c95981

alph@chromium.org authored Apr 05, 2013

DevTools creates RenderView before browser populates systems settings into
WebContents preferences thus the renderer gets default subpixel antialising
setting.
The fix makes it sending ViewMsg_SetRendererPrefs to the renderer when
the preferences are finally obtained by the browser.

R=pfeldman@chromium.org


Review URL: https://chromiumcodereview.appspot.com/13580007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192566 0039d316-1c4b-4281-b951-d872f2087c98

54c95981

Update .DEPS.git · 36dcc940

chrome-admin@google.com authored Apr 05, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192565 0039d316-1c4b-4281-b951-d872f2087c98

36dcc940

Swarm DEPS roll · 44a6a096

csharp@chromium.org authored Apr 05, 2013

TBR=maruel@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/13520009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192564 0039d316-1c4b-4281-b951-d872f2087c98

44a6a096

Fix DownloadExtensionTest_OnDeterminingFilename_InterruptedResume · 7761d02f

benjhayden@chromium.org authored Apr 05, 2013

Review URL: https://codereview.chromium.org/12422012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192563 0039d316-1c4b-4281-b951-d872f2087c98

7761d02f

User pods centered with any resolution. · 36843acc

dzhioev@chromium.org authored Apr 05, 2013


BUG=222217
TEST=manual
R=nkostylev


Review URL: https://chromiumcodereview.appspot.com/13194004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192562 0039d316-1c4b-4281-b951-d872f2087c98

36843acc

drive: Simplify TestFilePathWatcher in file_manager_browsertest.cc · 9713b881

satorux@chromium.org authored Apr 05, 2013

This is in preparation for porting TestKeyboard* tests to Drive.

BUG=224534
TEST=none


Review URL: https://chromiumcodereview.appspot.com/13706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192559 0039d316-1c4b-4281-b951-d872f2087c98

9713b881

Test cache creation retry via public interface only. · 88d80a10

pasko@google.com authored Apr 05, 2013

This is a cleanup after:
https://codereview.chromium.org/12794003/

One test for backend force retry is enough, the other test
(CreateBackend_MissingFile) is converted to be backend implementation specific.

The CreateCacheViaPublicInterface() is called only once, but to eliminate it
there is a need to make the cache_thread_ protected. Also, I am sure the name is
not ideal, please suggest another.

The New Eviction allows not to be very strict about version comparison as stored
in the files on disk, this allows creating the BackendImpl with no flags and
then being able to pass the common integrity check.

BUG=173384


Review URL: https://chromiumcodereview.appspot.com/13517004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192558 0039d316-1c4b-4281-b951-d872f2087c98

88d80a10

LabelButton: SetAccessibleName on SetText; update test. · 3e4efae6

msw@chromium.org authored Apr 05, 2013

SetAccessibleName to label text on SetText.
(this matches TextButtonBase::SetText behavior) 
Call SetText from LabelButton's constructor.

Use LabelButton in AccessibilityEventRouterViewsTest like: 
https://codereview.chromium.org/13584010 Patch Set 4. 

Note: This CL depends on https://codereview.chromium.org/13639003/

BUG=155363, 226814
TEST=LabelButtons have accessibility names. Tests pass. 
R=tfarina@chromium.org,sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13689002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192557 0039d316-1c4b-4281-b951-d872f2087c98

3e4efae6

browser_tests.isolate on Windows: Traced PepperContentSettingsTest.PluginSpecialCases · 4e91f326

maruel@chromium.org authored Apr 05, 2013

Autogenerated with:
  python tools\swarm_client\isolate_test_cases.py -s out\Release\browser_tests.isolated --gtest_filter=PepperContentSettingsTest.PluginSpecialCases

This should turn browser_tests_swarm completely green on Windows.

TBR=csharp@chromium.org
NOTRY=true
BUG=


Review URL: https://chromiumcodereview.appspot.com/13601007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192556 0039d316-1c4b-4281-b951-d872f2087c98

4e91f326

chromeos: Fix FilePath handling incompatibility between... · 2c5898b2

hashimoto@chromium.org authored Apr 05, 2013

chromeos: Fix FilePath handling incompatibility between FakeDriveFileSystem::GetEntryInfoByResourceId and GetEntryInfoByPath

ConvertResourceEntryToDriveEntryProto adds extensions like ".gdoc" to hosted documents.
GetEntryInfoByResourceId and GetEntryInfoByPath should handle paths in the same manner.

BUG=None
TEST=unit_tests --gtest_filter="FakeDriveFileSystemTest.GetEntryInfoByResourceId_PathCompatibleWithGetEntryInfoByPath"

Review URL: https://chromiumcodereview.appspot.com/13579005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192555 0039d316-1c4b-4281-b951-d872f2087c98

2c5898b2

drive: Use "/drive/root" namespace and fix Files app and tests. · fb041481

haruki@chromium.org authored Apr 05, 2013

Create "/drive/root" at DriveResourceMetadata initialization.
"/drive/other" is also created but is empty for now.

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Review URL: https://chromiumcodereview.appspot.com/13149003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192554 0039d316-1c4b-4281-b951-d872f2087c98

fb041481

More TSan v2 suppressions: · 1d3bef6e

glider@chromium.org authored Apr 05, 2013

 -- another race in ICU memory allocation (issue 223352)
 -- suppress a test-only race in tracked_objects::ThreadData::ShutdownSingleThreadedCleanup (issue 102327)

BUG=223352,102327,226970
Review URL: https://codereview.chromium.org/13296008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192553 0039d316-1c4b-4281-b951-d872f2087c98

1d3bef6e

History: Add search browser test. · 92820aee

sergiu@chromium.org authored Apr 05, 2013

Updated the query stub to filter by search term and added a test for searching
in the history page.

R=dubroy@chromium.org
BUG=196568


Review URL: https://chromiumcodereview.appspot.com/13523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192552 0039d316-1c4b-4281-b951-d872f2087c98

92820aee

Show only the settings pages for new managed users · d13b1c9a

sergiu@chromium.org authored Apr 05, 2013

Currently when creating a new managed user we open other tabs in addition to
the managed users settings one, which we don't want to do.

This makes sure that only that tab gets added to the list of URLs to open on
start-up by early-returning from that function.

R=ben@chromium.org
BUG=171370


Review URL: https://chromiumcodereview.appspot.com/13468005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192551 0039d316-1c4b-4281-b951-d872f2087c98

d13b1c9a

drive: Make FileManagerBrowserTest more robust · afc0bf31

satorux@chromium.org authored Apr 05, 2013

Previously, getFileList() was called directly from testFileDisplay().
This was bad, as it's not guaranteed that the file list is already rendered
by the time testFileDisplay() is called, hence the test was flaky.
We should use waitForFileListChange() instead.

Likewise, doKeyboardTest() and doKeyboardTestWithConfirmation() are fixed
in the same way.

BUG=224534

Review URL: https://chromiumcodereview.appspot.com/13450004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192550 0039d316-1c4b-4281-b951-d872f2087c98

afc0bf31

Enable the new elevation for managed users which is tied to a specific... · e951d159

akuegel@chromium.org authored Apr 05, 2013

Enable the new elevation for managed users which is tied to a specific WebContents. This replaces the old elevation which was tied to a profile.

BUG=222364
TEST=unit_tests,browser_tests

Review URL: https://chromiumcodereview.appspot.com/13119011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192549 0039d316-1c4b-4281-b951-d872f2087c98

e951d159