- 04 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84620d395a4d..e65444f91de0 2020-06-03 brucedawson@chromium.org Fix Python3 bugs in package_from_installed.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8a45c163fbf8f4332257cc93647b122d95868d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774942}
-
Anupam Snigdha authored
While updating the text input state, the VK visibility request was being set unconditionally even if the VK policy was not defined. Added checks to ensure that the VK visibility request is only set when the ExecutionContext is valid and the last request set it to value other than none. Bug: 1088364 Change-Id: Ibb62f906de4df42881028af6791b84b53b34d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224652Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774941}
-
Austin Eng authored
Backend validation layers like Vulkan Validation Layers or Metal or D3D12's debug validation are not always safe to use with ASAN. We already have coverage using the validation layers on non-ASAN bots, so remove it from the Dawn ASAN bots. Bug: dawn:376 Change-Id: I24587a880a15658d91c643fbf40844e04d6abfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219106Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#774940}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib782483745e7915a9d3457af9d5ba961e1b89296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229276Reviewed-by:
-
Evan Stade authored
Move some common boilerplate to WebLayerNotificationBuilder to streamline callsites. Bug: none Change-Id: I4b58778601967c98f801cf32428842c2a11dd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220662Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#774938}
-
Daniel Cheng authored
https://crrev.com/c/2223973 attempted to fix this check to handle UTF-8 encoded files. However, it appears that Python2's open() will sometimes return a bytestring for a file containing UTF-8 encoded text. encode() will then assume the bytestring is encoded using the default 'ascii' encoding, which then explodes upon seeing any byte with a high byte set (e.g. any character that's not representable in 7-bit ASCII). All mojom files in Chrome should be encoded as UTF-8. Since Python 2.7, io.open() has identical functionality to Python 3's open(), so by using that and specifying the encoding argument, the UTF-8 assumption can be explicitly encoded. This makes it safe to unconditionally call encode() to generate a bytestring to pass into the Mojo parser. Bonus: this CL adds some additional gymanstics for exceptions to make it easier to find the parse failure by using six.reraise(). Note: the original issue discussed in the CL description was fixed in a different way by https://crrev.com/c/2225327, which uses codecs.open(). However, Python 3's open() is an alias for io.open(), which has somewhat different behavior from codecs.open(). Change-Id: I86be3c5bc97c78078fe212162eb88e519180c3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226093Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774937}
-
Toni Barzic authored
Has shelf layout manager notify the status area widget that the locale has changed, which then forwards the notification to tray items, and unified tray items so they can update any cached strings (e.g. string used for item tooltips). This added pure virtual HandleLocaleChange() method to TrayItemView and TrayBackgroundView to make sure that tray items added in future implement this. BUG=1077147, 1076318, 1076310, 1076302, 1076301 Change-Id: I09ae5b891a383a89eb748cd27f86aab8c461f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222949Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774936}
-
Chris Hamilton authored
This adds dashed links w/ arrows to the graph, indicating opener/openee embedder/embeddee relationships. It also makes pinned nodes visually distinct by changing their stroke color. BUG=1085129 Change-Id: I0bd75a90c83a735b7d56ff2905d7d3d7b7be6e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227369 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#774935}
-
Chris McDonald authored
Use the vendored copy of the `six` library to make this code work across Python versions. Bug: 942720 Change-Id: I4bdb1032ed8e89e733b929eb13ada54efeb3b019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229335 Commit-Queue: Chris McDonald <cjmcdonald@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#774934}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f80a78602e37..c48caaae49d0 2020-06-03 jlavrova@google.com Fixing crash when some fonts are unresolved 2020-06-03 michaelludwig@google.com Add clipShader with perspective GM 2020-06-03 michaelludwig@google.com Divide by w for sample matrices 2020-06-03 herb@google.com remove SubRun from addGlyphToAtlas 2020-06-03 mtklein@google.com apply SkOpts_skx approach to SkOpts_hsw If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I2ee3f9079367dc9b4685506f4c5b3f8591726969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229226Reviewed-by:
-
Brian Sheedy authored
Temporarily disables the GPU watchdog on GPU Telemetry tests on CrOS. It is suspected that the watchdog is causing general test flakiness on CrOS, so it is being disabled for ~1 day to see if there's any noticeable impact on flakiness. Bug: 1090071 Change-Id: I13936e94798bcd71e024bf761246ed330ec5444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229436 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774932}
-
Mustafa Emre Acer authored
Pasting on a page with a delayed warning is risky as it can leak credentials (e.g. passwords in the clipboard). This CL immediately shows the interstitial when it detects a paste on the current page. Bug: 1089722 Change-Id: Ia20f0bd6d9fd197ab1dad3e13344ba9e8f876ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225462 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#774931}
-
Jia authored
This cl adds a penalty factor to SequenceMatcher so that we can penalize lots of short matching blocks. This cl also update search parameters. Bug: 1081584,1090181,1090154,1090148 Change-Id: Idd35ddd7cfbcdb3928e4b966f2ec757d0b75296c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227721 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774930}
-
Bruce Dawson authored
The results of some PDF to EMF tests change slightly when building with the Windows 10.0.19041.0 SDK. The changes are all in the sixth digit after the decimal place (all changing a 3 to a 2 oddly) and are therefore near the limits of float precision and are assumed to not be important. This change adds new expected-result files and uses them when building with the new SDK. See crrev.com/c/2225224 for the proof-of-concept that this fixes some of the SDK issues. Bug: 1089996 Change-Id: Ic35bb6d01138cf96de0639c04627a8a9bc325b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229643Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#774929}
-
Lorne Mitchell authored
dwpa: Modified PendingAppInstallTask to use a constructor provided InstallManager to support it as a test fixture. Previously PendingAppInstallTask::ContinueWebAppInstall fetched the InstallManager via the WebAppProvider via the profile. This change passes the InstallManager via the constructor and avoids this lookup. auto* provider = WebAppProviderBase::GetProviderBase(profile_); provider->install_manager().InstallWebAppWithParams( There will be a follow up CL where the system_web_app_manager_unittest.cc tests are refactored. This change to the pending_app_install_task is needed for the refactor. Bug: 1082880 Change-Id: I038f0005325c77742d15ef3d5e1673903fdf7490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229013Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774928}
-
Zhenyao Mo authored
This is for GLImageMemory's optimization path. BUG=1087047 TEST=manual R=kbr@chromium.org,khushalsagar@chromium.org Change-Id: I82d3ceeac36644f95e3a52b2a943c4ecaeb651d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226926Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Nate Chapin authored
Bug: 1090561 Test: html/semantics/scripting-1/the-template-element/template-element/template-content-in-inactive-document-crash.html Test: html/semantics/scripting-1/the-template-element/template-element/template-content-move-to-inactive-document-crash.html Change-Id: Idfdc343b177fcd81b208d98b0f66799abee5e4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229368 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774926}
-
Rachel Wong authored
These are some small modifications to allow for a new privacy notice to be added cleanly. Bug: 1079169 Change-Id: I60d4a8c7754f2573055e16990ae524876378eb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226101Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#774925}
-
Omid Tourzan authored
The warning divs get important display rule to prevent default display: none as it prevents animation. The hide action handled by visibility rule. Bug: 1083026 Change-Id: I53112d9029b2c8d621a974668cbf39a82d428420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228017Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774924}
-
Devlin Cronin authored
Extend it through 06-2021. Bug: 1072517 Change-Id: I5db65d8a091a7428f1a24ef8573f7d4947109132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229469 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774923}
-
Hitoshi Yoshida authored
This CL fixes two potential issues related to code generator's migration - Do not access Notification.vibration if it is missing - Check Notifivation.data is null or not Bug: 839389, 107964 Change-Id: If2ecbb1339bf539d52f4dad196d8aff36a7e0b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228015 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#774922}
-
Haiyang Pan authored
* content_shell_crash_test * telemetry_chromium_minidump_unittests * telemetry_perf_unittests Bug: 1084353, 1084352 Change-Id: Idfcb4c13ab3441a6aafa42986f142c7b745264e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229005 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#774921}
-
Greg Kerr authored
If the kernel supports core scheduling, Hyper-Threading is enabled by default. Users, admins and Finch may still override this setting. BUG=b:152605392 Change-Id: Iffcec33455ec277ec6f79f03908d02015c7d1f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209676Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774920}
-
Haiyang Pan authored
A wrong filter name was put in crrev.com/c/2227300. TBR=liaoyuke@chromium.org Bug: 1056330, 1022533 Change-Id: Ib042a049cefbe74c50cd7c928a1ab4c3beddc872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228350 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Nick Harper authored
The policy "public-suffix" has been in use but wasn't documented. The language for both "public-suffix" and "public-suffix-requested" is now updated to more accurately reflect how those are used. Bug: 1063653 Change-Id: Ic559a1af76ff3572fb0f249e5216407ba0a4da99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229434 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774918}
-
Sharon Yang authored
Add ComponentInspectorForProcess to manage a singleton per component. Add static functions to inspect.* as a helper to publish version and last revision. Test: Added InspectTest to cr_fuchsia_base_unittests Bug: 1061245 Change-Id: I0918b183fecedcd9a4c70685f7b7a166b2d82732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173238 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774917}
-
Antonio Gomes authored
... in webmediaplayer_ms.cc This CL: - moves the anonynous namespace declaration within the blink namespace (consistency). - removes the needless blink:: namespace declarations. BUG=704136 R=guidou@chromium.org Change-Id: Ibf54fd53633414a5e9c70c44fab8bcf205cc6abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229203 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#774916}
-
phillis authored
The launch target for file handling is pushed to M86 https://bugs.chromium.org/p/chromium/issues/detail?id=829689. Thus extending the metrics to M90. Bug: 1088559, 1088558, 1088557, 1088556, 1088555, 1088554 Change-Id: I592cb624fb2e98f4c15e51efbf813ebadf4c0615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227116 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#774915}
-
Tom Anderson authored
Fixes a regression after [1]. The issues is that xcb_request_check must be called instead of xcb_wait_for_reply when the request will not generate a reply. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220524 R=collinbaker Bug: 1066670 Change-Id: I56ffe2f4081c5b8413a47500b4cf4aca1cd9bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229721Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#774914}
-
Brian Sheedy authored
Switches most of the GPU pixel tests that are still using the extremely permissive Sobel algorithm onto less permissive parameters or onto exact matching depending on how noisy they are. Also includes an extra optimization to the parameter optimizer script to skip parameter sets that we know are guaranteed to fail. This was necessary in order to get some of the video parameter optimization runtimes down to a reasonable level. Bug: 1078914 Change-Id: Ie4b1dad447a4e35e8545756dc3482819e3d61c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228057Reviewed-by:
-
Sorin Jianu authored
Bug: 1026641 Change-Id: I14eaebf153dd419c4453cb22b9c5fb8be7f5add5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229242Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774912}
-
Megan Jablonski authored
Bug: 1089597 Change-Id: Iedc7c6eae986f5b6db73564bab6c45f5546c66b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225368Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774911}
-
siashah authored
Video: https://drive.google.com/file/d/138nyvCrRQd80CHFlAWQlE13Lkp-dFyms/view?usp=sharing Bug: 1082013 Change-Id: Icef37cfd081eb92be14fed1abe9faf90b2080508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225283Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#774910}
-
Eric Orth authored
Bug: 1088717 Change-Id: Iaea13ba81477e548bdc630b47b4a94d115ef1d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229403Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#774909}
-
Clark DuVall authored
Bug: 1084013 Change-Id: Ia3660f2bf9d6bd98d11fc31b24fe1c903cfec3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225777 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Shimi Zhang authored
- Check if the |target_url| is |kBlockedURL|, if true, call the callback with |kIgnore.| - Add regression test. Fixed: 1083819 Change-Id: I56bde76b749efa2dcaf9b3e178ace94b43aa9faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226496 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774907}
-
Mounir Lamouri authored
In addition to database read time. Bug: None Change-Id: I59bb238c5eb94de0d11a302f8e935886b231a589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213924 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774906}
-
Clark DuVall authored
A delegate interface was created to wrap chrome's NavigateParams, and provide chrome specific logic on blocked popups. Things are a bit tricky since in the original code MaybeBlockPopup may or may not take ownership of the NavigateParams (by calling std::move(*params)). The delegate is now passed as a unique_ptr to MaybeBlockPopup, and the unique_ptr is returned if the navigation should continue (nullptr if the popup should be blocked). Bug: 1084013 Change-Id: Ic05d7539c6f53927721158dfffd88b1aba7f3125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224824Reviewed-by:
-
chrome://media-appTrent Apted authored
Some tracing with performance.now() suggests this will shave about 300ms off the critical path for loading a file. We would previously wait for the window 'load' event which indicated that the <iframe> subresource (and all *its* subresources) had fully loaded. This was "safe" but too conservative. There's a tip in the spec: https://html.spec.whatwg.org/multipage/web-messaging.html#posting-messages which suggests to have the <iframe> send a message to its parent to indicate that it's ready to process messages, which this CL does (saving ~100ms). For the other ~200ms, the steps involved in handling the launch event to open the file and determine related files are now allowed to run before the iframe is ready to receive messages. Only the final postMessage that triggers the load must wait for the iframe to be ready. Sample trace for loading a file in a directory with 75 files after this change that explains the "300ms" improve: <privileged> 75~85 ms: JS starts (t=0 in privileged) t+5ms: launch message received t+80ms ms: waiting for iframe t+200ms: iframe "ready" received t+300ms: privileged 'load' event received <-- we used to start "launch" here. <unprivileged> 75~85 ms: JS starts (t=0 in unprivileged) t+50ms: iframe ready (app_main.js executed, app is still null) t+180ms: load in iframe begins t+570ms: load done [warm start] t+1050ms: load done [cold start] Covered by existing tests, which were hammered with some invocations of browser_tests --test-launcher-jobs=20 --gtest_filter='*MediaApp*' \ --gtest_repeat=10 to flush out any flakes. Bug: b/157949149 Change-Id: Ie1c3ca79bb9f7b5d323967ee653943ac7901afd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227716Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#774904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf77d6e387b6..84620d395a4d 2020-06-03 ehmaldonado@google.com gsutil.py.bat: Skip updating depot_tools if DEPOT_TOOLS_UPDATE=0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090603 Tbr: agable@chromium.org Change-Id: Ia2e529b3edd91a48f5f277e88c6d678bab6b63af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229271Reviewed-by:
-
