GitLab

r1843: Xcode: Add .xcassets = folder.assetcatalog in extension_map
r1844: Eclipse generator now uses compiler's default include dirs
r1845: Quell warnings for exclusion list dictionaries in MSVS generator
r1846: Ninja generator: support using clang-cl for Windows

BUG=

Review URL: https://codereview.chromium.org/149243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247638 0039d316-1c4b-4281-b951-d872f2087c98

Started by trying to remove only atlbase.h, but atlcrack.h (WTL)
uses CPoint/CSize, etc from ATL. So, msg_util.h is atlcrack.h,
but adapted to use gfx types, and with CR_ prefix on crack macros
for now.

R=ben@chromium.org
BUG=5027, 323300

Review URL: https://codereview.chromium.org/146833020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247637 0039d316-1c4b-4281-b951-d872f2087c98

Ozone uses clipboard_aura and DChecks in WriteObjects with type
CLIPBOARD_TYPE_SELECTION fail here as this is defined only for X11 
platform. This CL replaces the current platform checks(X11) with 
checks this shouldn't be defined on.

Review URL: https://codereview.chromium.org/148153016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247635 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247634 0039d316-1c4b-4281-b951-d872f2087c98

Use in-memory LevelDB in tests that don't test LevelDB behavior itself.

BUG=331988
R=kinuko@chromium.org, nhiroki@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/145693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247631 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the transparent background of icons generated by the "Create app
from this website" button into solid white.

BUG=315632

Review URL: https://codereview.chromium.org/148723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247629 0039d316-1c4b-4281-b951-d872f2087c98

1. Modify OnBoundsChanged() to unconditionally call SetSize() to propagate all aura::Window size changes (e.g., due to container layout) to the renderer.  There are already re-entrancy and redundancy guards in place, making this safe/sane.

2. Apply coordinate conversion for mouse events propagated to the parent->delegate.  This was previously overlooked because it was assumed WebContentsViewAura was the only parent->delegate, and WCVA does not do anything with mouse coordinates.

BUG=256870

Review URL: https://codereview.chromium.org/148613008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247628 0039d316-1c4b-4281-b951-d872f2087c98

If Send() fails in SendOrDrop(), then |message| will have been deleted,
but SendOrDrop() will still try to access its header fields.

Fixed.

BUG=338354
TEST=content_unittests

Review URL: https://codereview.chromium.org/148263009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247627 0039d316-1c4b-4281-b951-d872f2087c98

This function is just an helper/wrapper function around v8::V8::SetFlagsFromString() and used only by content.

John preferred to just remove the wrapper and call the v8 API directly in content.

Also removing it from webkit_glue.h helps with the removal of src/webkit/ directory.

BUG=265753
TEST=content_shell and content_unittests
R=jochen@chromium.org, jam@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/147973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247626 0039d316-1c4b-4281-b951-d872f2087c98

Current perf tests are not useful for profiling as output heavily
depends on kernel scheduling. An improvement in CPU time is not
guaranteed to result in a better result from these tests as they
mostly measure context switching cost.

This includes a small refactor to TaskGraphRunner that allow us
to run tests on a single thread. The result is more predictable
results and useful profiling output.

The number of tasks used in tests have also been adjusted to more
realistic values.

BUG=338355

Review URL: https://codereview.chromium.org/147883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337758

Review URL: https://codereview.chromium.org/141743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247624 0039d316-1c4b-4281-b951-d872f2087c98

This CL doesn't add any real View Management nor does it convert any apps to use this API. Mostly this is just getting the target in and doing the event interception to load the Launcher.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/145403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247623 0039d316-1c4b-4281-b951-d872f2087c98

While this change increases memory usage on non low-end devices, the
impact is small enough that we can limit the exposure surface to only
where it makes a signficant impact.

Also adds content_linker_test_apk to the android builders to ensure it
doesn't regress.

Review URL: https://codereview.chromium.org/139743011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247622 0039d316-1c4b-4281-b951-d872f2087c98

Consolidate the calls to [NSScreen screens] because this call can take
several milliseconds, and use an observer to ensure that this call is
only made when the value is changed.

Only use a single OpenGL context because using multiple contexts does
not improve performance and only adds complexity.

BUG=245900

Review URL: https://codereview.chromium.org/134753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338739
R=koz@chromium.org
TEST=unit_tests:AppListModelPicklerUnitTest.OneItem

Review URL: https://codereview.chromium.org/132743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247620 0039d316-1c4b-4281-b951-d872f2087c98

To avoid unnecessary layout (and stopping of animations) TabStrip
caches the last size it layed out. During drag and drop of tabs
SetTabBoundsForDrag may be used to force a particular tab
size/location. After a call to SetTabBoundsForDrag we need to ensure
the tabstrip does in fact relayout next time Layout() is invoked. By
clearing last_layaout_size_ we ensure this happens.

BUG=338617
TEST=see bug

Review URL: https://codereview.chromium.org/131763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338338

Review URL: https://codereview.chromium.org/146963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247618 0039d316-1c4b-4281-b951-d872f2087c98

Use parametrized tests to exercise all implementations of the
RasterWorkerPool interface.

BUG=

Review URL: https://codereview.chromium.org/143693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/141143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247615 0039d316-1c4b-4281-b951-d872f2087c98

Changing comments in test to use // rather than preprocessor directives as per https://code.google.com/p/chromium/issues/detail?id=334276

BUG=334276

Review URL: https://codereview.chromium.org/140883012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247614 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247613 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338966
TBR=andrehayden@chromium.org

Review URL: https://codereview.chromium.org/146833022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247610 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Updated expected_deps_{i386,x86_64} to match actual deps. (https://codereview.chromium.org/148583013/)

Reason for revert:
Suspected of breaking the Official builds.

Original issue's description:
> Updated expected_deps_{i386,x86_64} to match actual deps.
> 
> Dependencies added in the range 247500-247514.  I suspect 247509, a
> blink roll.
> 
> BUG=None
> NOTRY=true
> NOTREECHECKS=true
> TBR=phajdan.jr@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247567

TBR=phajdan.jr@chromium.org,shess@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/149203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247609 0039d316-1c4b-4281-b951-d872f2087c98

I've added icon files for audio player at r247591, but their permissions are 755 and it is wrong. This patch fix them to 644.

TBR=yoshiki@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/130803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247608 0039d316-1c4b-4281-b951-d872f2087c98

Before https://codereview.chromium.org/149103002/, chrome/android's default
target was 'All', so no behavior change. After that lands, the default target
is 'all', so the bots will build a few more targets (17 translation units more,
at the moment).

Together with the change linked above, this might enable the removal of
|android_app_target|.

BUG=none
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/149213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247607 0039d316-1c4b-4281-b951-d872f2087c98

To reduce the chattiness of Google Now, localStorage.debug_mode for Google Now
and showConsoleLogOutput for unit tests will control when console.log actually
outputs to the console.

BUG=338239
TEST=By default, there will be no console.log output. When
localStorage.debug_mode is true in Google Now or showConsoleLogOutput is set
to true in unit tests, console.log output will occur.

Review URL: https://codereview.chromium.org/145353010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247606 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247605 0039d316-1c4b-4281-b951-d872f2087c98

Have sideloaded extensions pull data from the webstore (a la inline install) in
order to give the users a better idea of what extension they are installing.

Images worth 1000 words: http://imgur.com/zlexZeb,VljPXLz,WzT2ZOc#0

XIB changes:
* rename 'app/nibs/ExtensionInstallPromptInline.xib' to 'app/nibs/ExtensionInstallPromptWebstoreData', since the same prompt is now used for inline prompts and for sideloaded extensions when webstore data is available.

BUG=323063

Review URL: https://codereview.chromium.org/145153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247604 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165884:165981&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/139903016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247603 0039d316-1c4b-4281-b951-d872f2087c98

For the longest time, the sync integration tests have relied on methods
that wait for sync cycle completion by polling various internal fields
in the sync session snapshot. These methods are brittle and rely on
internal state, which is not ideal.

This cl is a first step towards eliminating the use of internal state to
detect sync completion. It does the following:

1) Removes the methods IsDataSynced, IsFullySynced, IsDataSyncedImpl,
   AwaitDataSyncCompletion and AwaitFullSyncCompletion
2) Adds a method AwaitSyncSetupCompletion which waits until a client is
   ready to push local changes to the server.
3) Adds a method AwaitCommitActivityCompletion which waits until a client
   no longer has data to commit and its progress markers are updated.
4) Updates call sites to use the new methods.

BUG=94990,97780,323380
TEST=sync_integration_tests
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/148723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247599 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334876

Review URL: https://codereview.chromium.org/139763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247598 0039d316-1c4b-4281-b951-d872f2087c98

Adding a dialog which explains that the multi user session has ended because a user policy has changed.

BUG=314930
TEST=manual

Review URL: https://codereview.chromium.org/149173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247597 0039d316-1c4b-4281-b951-d872f2087c98

A fileSystem opened by chrome.fileSystem API is passable to a pepper plugin[1],
but currently we cannot open any files with CREATE/TRUNCATE flag under the
filesystem in plugin-side because the filesystem doesn't have sufficient file
permissions (CREATE_OVERWRITE_FILE_PERMISSION is missing).

To fix that, this change calls GrantCreateReadWriteFileSystem() for the
filesystem instead of GrantCreateFileForFileSystem().

(NOTE) This change works fine only when choosing a directory by the API, and
the same issue still happens when choosing a file. I'll address the case in
a separate CL.

[1] http://crbug.com/177017


BUG=336160
TEST=manual (open a file with CREATE and/or TRUNCATE flag under the passed filesystem in plugin)

Review URL: https://codereview.chromium.org/146283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247596 0039d316-1c4b-4281-b951-d872f2087c98

Local printing URL parameter names do not match those in the privet spec. Fix
this so they do match it.

BUG=338868

Review URL: https://codereview.chromium.org/148183014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247595 0039d316-1c4b-4281-b951-d872f2087c98

We hit an issue where the server protocol was updated on 10/29 to send an additional tag was not part of the original spec.  This caused all Chrome clients across all versions to simultaneously think that the server was failing to send a valid response and send an increased number of pings to the server.
    
This CL rewrites the Java parser to be more robust to random changes to the XML as a precursor to the C++ reimplementation (which is still a long ways out).  The code also gets moved upstream so that we can get it reviewed easier.

BUG=181323
TEST=ResponseParserTest

Review URL: https://codereview.chromium.org/67313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/137723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247593 0039d316-1c4b-4281-b951-d872f2087c98

SenderId can be either integer obtained from developer dashboard or
email. Android chrome invalidations uses email.
Fix double escaping so that registration server accepts senderId.

Review URL: https://codereview.chromium.org/148153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247592 0039d316-1c4b-4281-b951-d872f2087c98

This patch has only images. The code of new audio player will be committed separately.

The images are copied from
https://code.google.com/p/chromium/issues/detail?id=273308#c13

BUG=273308
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/145423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247591 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an incorrect assumption in
PasswordAutofillAgentTest.InlineAutocomplete. Previously, this code assumed
that one trip through the event loop was sufficient to ensure that style was
recalcuated. After we move recalc style to be triggered by
requestAnimationFrame, this assumption will no longer be valid. This CL changes
the test to explicitly recalc style by calling WebView::layout.

Unfortunately, we cannot simply call WebView::layout in straight-line code
because this test does some of its work off the event loop. Instead, we need to
schedule the call to layout after we schedule the other async work.

BUG=337617
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/136003013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247590 0039d316-1c4b-4281-b951-d872f2087c98

We still need to pass RWHVGuest::SelectionChanged() call to platform_view_.
This broke while adding IME support, this function doesn't seem to be required for IME (made sure by running BrowserPluginHostTest.InputMethod).

Wrote a browser_test to catch the regression.

BUG=331722
Test=Open a <webview> in a chrome app. Select some text. Observe that "Look up in dictionary" and "Speech=>Start Speaking" features work.

Review URL: https://codereview.chromium.org/148433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247589 0039d316-1c4b-4281-b951-d872f2087c98