Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 12 Mar, 2011 18 commits
  3. 11 Mar, 2011 22 commits
    • michaeln@google.com's avatar
      2011-03-11 Michael Nordman <michaeln@google.com> · d8588897
      michaeln@google.com authored 
              Reviewed by Dmitry Titov.

        Adding the '~' to the dtor (duh).

        No new tests.

        * storage/SQLCallbackWrapper.h:
        (WebCore::SQLCallbackWrapper::~SQLCallbackWrapper):


git-svn-id: svn://svn.chromium.org/blink/trunk@80897 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d8588897
    • ericu@chromium.org's avatar
      2010-3-11 Eric Uhrhane <ericu@chromium.org> · 81fb7b58
      ericu@chromium.org authored 
      Reviewed by David Levin.

Add tests for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44363

Fix small bugs in the utility functions and add setFileContents().
* fast/filesystem/resources/file-writer-utils.js:

Port the GC Blob test over to the new FileWriter utilities.
* fast/filesystem/file-writer-gc-blob-expected.txt:
* fast/filesystem/file-writer-gc-blob.html:
* fast/filesystem/resources/file-writer-gc-blob.js: Copied from LayoutTests/fast/filesystem/file-writer-gc-blob.html.

Add tests for progress events and overlapping writes [via seek].
* fast/filesystem/file-writer-events-expected.txt: Added.
* fast/filesystem/file-writer-events.html: Added.
* fast/filesystem/resources/file-writer-events.js: Added.
* fast/filesystem/file-writer-write-overlapped-expected.txt: Added.
* fast/filesystem/file-writer-write-overlapped.html: Added.
* fast/filesystem/resources/file-writer-write-overlapped.js: Added.

Worker versions of the above tests.
* fast/filesystem/workers/file-writer-events-expected.txt: Added.
* fast/filesystem/workers/file-writer-events.html: Added.
* fast/filesystem/workers/file-writer-gc-blob-expected.html: Added.
* fast/filesystem/workers/file-writer-gc-blob.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped-expected.html: Added.
* fast/filesystem/workers/file-writer-write-overlapped.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@80896 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      81fb7b58
    • carol.szabo@nokia.com's avatar
      2011-03-11 Carol Szabo <carol.szabo@nokia.com> · 82ed0cf6
      carol.szabo@nokia.com authored 
              Reviewed by David Hyatt.

        Introduced double linkage between a CounterNode and its display renderer.

        use of freed pointer in WebCore::RenderCounter::originalText()
        https://bugs.webkit.org/show_bug.cgi?id=56065

        No new tests. This bug could only be reproduced manually by
        refreshing the page during load at a critical point.
        See bug attachment for testing.

        * rendering/CounterNode.cpp:
        Introduced new member "m_owner" to store the renderer that has the
        style directives that produce the CounterNode.
        Repurposed m_renderer to reffer to the RenderCounter that shows the
        CounterNode.
        (WebCore::CounterNode::CounterNode):
        Updated member initialization.
        (WebCore::CounterNode::create):
        (WebCore::CounterNode::resetRenderer):
        (WebCore::CounterNode::resetRenderers):
        (WebCore::CounterNode::recount):
        (WebCore::CounterNode::removeChild):
        (WebCore::CounterNode::insertAfter):
        No functional changes.
        (WebCore::showTreeAndMark):
        Added flushing to ensure that the output is complete.
        * rendering/CounterNode.h:
        (WebCore::CounterNode::owner):
        Renamed from renderer()
        (WebCore::CounterNode::renderer):
        (WebCore::CounterNode::setRenderer):
        Added new accessors for the display renderer.
        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        Fixed comments. No functional changes.
        (WebCore::RenderCounter::~RenderCounter):
        Made sure that the CounterNode that this renderers displays is
        detached from this.
        (WebCore::RenderCounter::originalText):
        (WebCore::RenderCounter::invalidate):
        Added code to update m_renderer on the displayed CounterNode.
        (WebCore::destroyCounterNodeWithoutMapRemoval):
        (WebCore::RenderCounter::destroyCounterNodes):
        (WebCore::RenderCounter::destroyCounterNode):
        (WebCore::updateCounters):
        No change, just kept code in line with the changes above.
        (showCounterRendererTree):
        Added fflush to ensure complete display.
        * rendering/RenderCounter.h:
        * rendering/RenderObjectChildList.cpp:
        * rendering/RenderObjectChildList.h:
        Removed unneeded invalidateCounters related functions.

git-svn-id: svn://svn.chromium.org/blink/trunk@80895 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      82ed0cf6
    • enne@google.com's avatar
      2011-03-11 Adrienne Walker <enne@google.com> · e371c92b
      enne@google.com authored 
              Reviewed by Kenneth Russell.

        Add missing unit tests to TilingData.
        https://bugs.webkit.org/show_bug.cgi?id=54143

        * tests/TilingDataTest.cpp:
        (WebCore::TEST):

git-svn-id: svn://svn.chromium.org/blink/trunk@80894 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e371c92b
    • dglazkov@chromium.org's avatar
      2011-03-11 Luke Macpherson <macpherson@chromium.org> · 24f18706
      dglazkov@chromium.org authored 
              Reviewed by Eric Seidel.

        Introduce lookup-table based approach for applying CSS properties.
        The aim is to be a starting point for refactoring
        CSSStyleSelector::applyProperty() into more readable, maintainable code.
        https://bugs.webkit.org/show_bug.cgi?id=54707

        No new behavior / covered by existing tests.

        * css/CSSStyleApplyProperty.cpp: Added.
        (WebCore::ApplyPropertyNull):
        Class that provides empty implementations of inherit, initial, value.
        (WebCore::ApplyPropertyDefault::ApplyPropertyDefault):
        Class that calls the appropriate RenderStyle setters directly.
        (WebCore::ApplyPropertyColorBase::ApplyPropertyColorBase):
        Class for handling CSSProperty*Color.
        (WebCore::ApplyPropertyColor::ApplyPropertyColor):
        Class for handling CSSPropertyColor.
        (WebCore::CSSStyleApplyProperty::sharedCSSStyleApplyProperty):
        Singleton initializer.
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Constructor that bulds up the map from property id to apply-er objects.
        * css/CSSStyleApplyProperty.h: Added.
        (WebCore::CSSStyleApplyProperty::inherit):
        Handle the inherit case for a given property.
        (WebCore::CSSStyleApplyProperty::initial):
        Handle the initial case for a given property.
        (WebCore::CSSStyleApplyProperty::value):
        Apply a value to a given property.
        (WebCore::CSSStyleApplyProperty::implements):
        Returns true if the provided property id is implemented.
        (WebCore::CSSStyleApplyProperty::index):
        Private function to determine the index of a property the property map.
        (WebCore::CSSStyleApplyProperty::valid):
        Function to determine that a given property id is valid.
        (WebCore::CSSStyleApplyProperty::setPropertyValue):
        (WebCore::CSSStyleApplyProperty::propertyValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        Get reference to the CSSStyleApplyProperty singleton.
        (WebCore::CSSStyleSelector::applyProperty):
        Now calls into CSSStyleApplyProperty for implemented property ids.
        Deleted color-related methods from the property id switch.
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::style):
        Made public to allow access from CSSStyleApplyProperty.
        (WebCore::CSSStyleSelector::parentStyle):
        Made public to allow access from CSSStyleApplyProperty.
        * rendering/style/RenderStyle.h:
        Made CSSStyleApplyProperty a friend class. Necessary because it needs
        to access the private getters and setters on this clsass.


git-svn-id: svn://svn.chromium.org/blink/trunk@80893 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      24f18706
    • beidson@apple.com's avatar
      Reviewed and landed by Brady Eidson. · d240e08a
      beidson@apple.com authored 
      Source/WebCore: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

Created StorageTracker as a central point for tracking and deleting LocalStorage per origin.
StorageTracker maintains its own database of origin identifiers and backing db paths,
and this allows it to contain more relational data in the future, like variable quotas per origin.

On initialization, StorageTracker syncs its database with LocalStorage files on disk. It adds
an origin entry when StorageAreaSync performs a first sync for an origin.

All StorageTracker file operations are performed on one background thread with a task queue.

Tests: storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html
       storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html
       storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html
       storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html
       storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html

* GNUmakefile.am:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/PageGroup.cpp:
(WebCore::PageGroup::clearLocalStorageForAllOrigins):
(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore::PageGroup::syncLocalStorage):
(WebCore::PageGroup::numberOfPageGroups):
* page/PageGroup.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::listDirectory):
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::listDirectory):
* storage/LocalStorageTask.cpp:
(WebCore::LocalStorageTask::LocalStorageTask):
(WebCore::LocalStorageTask::performTask):
* storage/LocalStorageTask.h:
(WebCore::LocalStorageTask::createOriginIdentifiersImport):
(WebCore::LocalStorageTask::createSetOriginDetails):
(WebCore::LocalStorageTask::createDeleteOrigin):
(WebCore::LocalStorageTask::createDeleteAllOrigins):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):
* storage/StorageAreaImpl.h:
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):
* storage/StorageAreaSync.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):
* storage/StorageNamespaceImpl.h:
* storage/StorageTracker.cpp: Added.
(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setStorageDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::scheduleTask):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::setClient):
(WebCore::StorageTracker::syncLocalStorage):
* storage/StorageTracker.h: Added.
* storage/StorageTrackerClient.h: Added.
(WebCore::StorageTrackerClient::~StorageTrackerClient):

Source/WebKit: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/chromium: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespaceProxy::clearOriginForDeletion):
(WebCore::StorageNamespaceProxy::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceProxy::sync):
* src/StorageNamespaceProxy.h:

Source/WebKit/mac: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

* Storage/WebStorageManager.mm: Added.
(+[WebStorageManager sharedWebStorageManager]):
(-[WebStorageManager origins]):
(-[WebStorageManager deleteAllOrigins]):
(-[WebStorageManager deleteOrigin:]):
(-[WebStorageManager syncLocalStorage]):
(-[WebStorageManager syncFileSystemAndTrackerDatabase]):
(storageDirectoryPath):
(WebKitInitializeStorageIfNecessary):
* Storage/WebStorageManagerInternal.h: Added.
* Storage/WebStorageManagerPrivate.h: Added.
* Storage/WebStorageTrackerClient.h: Added.
* Storage/WebStorageTrackerClient.mm: Added.
(WebStorageTrackerClient::sharedWebStorageTrackerClient):
(WebStorageTrackerClient::WebStorageTrackerClient):
(WebStorageTrackerClient::~WebStorageTrackerClient):
(WebStorageTrackerClient::dispatchDidModifyOriginOnMainThread):
(WebStorageTrackerClient::dispatchDidModifyOrigin):
* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin databaseIdentifier]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
* WebCoreSupport/WebSecurityOriginPrivate.h:
* WebKit.exp:
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

Tools: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
https://bugs.webkit.org/show_bug.cgi?id=51878
Add WebKit1 API to view and delete local storage

Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/LayoutTestController.cpp:
(syncLocalStorageCallback):
(observeStorageTrackerNotificationsCallback):
(deleteAllLocalStorageCallback):
(deleteLocalStorageForOriginCallback):
(originsWithLocalStorageCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/StorageTrackerDelegate.h: Added.
* DumpRenderTree/StorageTrackerDelegate.mm: Added.
(-[StorageTrackerDelegate init]):
(-[StorageTrackerDelegate logNotifications:controller:]):
(-[StorageTrackerDelegate originModified:]):
(-[StorageTrackerDelegate dealloc]):
(-[StorageTrackerDelegate setControllerToNotifyDone:]):
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(observeStorageTrackerNotifications):
(syncLocalStorage):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
(allocateGlobalControllers):
(releaseGlobalControllers):
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::syncLocalStorage):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::clearAllApplicationCaches):
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::syncLocalStorage):
(LayoutTestController::observeStorageTrackerNotifications):
(LayoutTestController::clearAllDatabases):
(LayoutTestController::deleteAllLocalStorage):
(LayoutTestController::originsWithLocalStorage):
(LayoutTestController::deleteLocalStorageForOrigin):

LayoutTests: 

Patch by Anton D'Auria <adauria@apple.com> on 2011-03-11
Add WebKit1 API to view and delete local storage
https://bugs.webkit.org/show_bug.cgi?id=51878

* platform/chromium/test_expectations.txt:
* storage/domstorage/localstorage/storagetracker: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Added.
* storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@80892 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d240e08a
    • jberlin@webkit.org's avatar
      http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath... · 3ef00306
      jberlin@webkit.org authored 
      http/tests/websocket/tests/url-with-credential.html sometimes crashes beneath SocketStreamHandle::readStreamCallback on Windows
https://bugs.webkit.org/show_bug.cgi?id=56185

url-parsing.html appears to be causing the crashes in later tests.
Skipping the url-parsing.html test and unskipping the url-with-credential.html test.

Unreviewed.

* platform/win/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@80891 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ef00306
    • commit-queue@webkit.org's avatar
      2011-03-11 Dominic Mazzoni <dmazzoni@google.com> · 06ae9610
      commit-queue@webkit.org authored 
              Reviewed by Dimitri Glazkov.

        Add an accessibilityIsIgnored method to WebAccessibilityObject.
        https://bugs.webkit.org/show_bug.cgi?id=50969

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::accessibilityIsIgnored):

git-svn-id: svn://svn.chromium.org/blink/trunk@80890 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      06ae9610
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · 7f42a9fb
      rniwa@webkit.org authored 
              Reviewed by Tony Chang.

        drag-text-delay.html should be a dump as text test
        https://bugs.webkit.org/show_bug.cgi?id=56223

        Converted the test to a dump as text. Also reorganized the test code and added more descriptions.

        * editing/selection/drag-text-delay-expected.txt:
        * editing/selection/drag-text-delay.html:
        * platform/chromium-linux/editing/selection/drag-text-delay-expected.checksum: Removed.
        * platform/chromium-linux/editing/selection/drag-text-delay-expected.png: Removed.
        * platform/chromium-win/editing/selection/drag-text-delay-expected.checksum: Removed.
        * platform/chromium-win/editing/selection/drag-text-delay-expected.png: Removed.
        * platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Removed.
        * platform/gtk/editing/selection/drag-text-delay-expected.checksum: Removed.
        * platform/gtk/editing/selection/drag-text-delay-expected.png: Removed.
        * platform/gtk/editing/selection/drag-text-delay-expected.txt: Removed.
        * platform/mac/editing/selection/drag-text-delay-expected.checksum: Removed.
        * platform/mac/editing/selection/drag-text-delay-expected.png: Removed.
        * platform/mac/editing/selection/drag-text-delay-expected.txt:
        * platform/win/editing/selection/drag-text-delay-expected.checksum: Removed.
        * platform/win/editing/selection/drag-text-delay-expected.png: Removed.
        * platform/win/editing/selection/drag-text-delay-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@80889 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7f42a9fb
    • steveblock@google.com's avatar
      2011-03-11 Steve Block <steveblock@google.com> · 9de1296e
      steveblock@google.com authored 
              Reviewed by Jeremy Orlow.

        JavaMethod does not correctly check for a null jstring for the method name
        https://bugs.webkit.org/show_bug.cgi?id=56187

        No new tests, simple typo fix.

        * bridge/jni/JavaMethod.cpp:
        (JavaMethod::JavaMethod):

git-svn-id: svn://svn.chromium.org/blink/trunk@80888 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9de1296e
    • enne@google.com's avatar
      2011-03-11 Adrienne Walker <enne@google.com> · a000c3dd
      enne@google.com authored 
              Reviewed by James Robinson.

        [chromium] Compositor uses too much texture memory for scrollbars
        https://bugs.webkit.org/show_bug.cgi?id=56212

        Compositor invalidations can be off the page (and very large), but
        scrollbars only need to care about the invalidation that's visible.
        The large invalidation was causing the tiler layer size to grow
        needlessly larger than the scrollbar.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::invalidateRootLayerRect):

git-svn-id: svn://svn.chromium.org/blink/trunk@80887 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a000c3dd
    • mihaip@chromium.org's avatar
      2011-03-11 Mihai Parparita <mihaip@chromium.org> · a00079a0
      mihaip@chromium.org authored 
              Chromium Mac expectations update. Rebaseline some more tests after
        r80582.

        * fast/repaint/text-emphasis-h-expected.checksum:
        * fast/repaint/text-emphasis-h-expected.png:
        * platform/chromium-mac/fast/repaint/text-emphasis-h-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.checksum:
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.png:
        * platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum:
        * platform/mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@80886 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a00079a0
    • mihaip@chromium.org's avatar
      2011-03-11 Mihai Parparita <mihaip@chromium.org> · 3d16077c
      mihaip@chromium.org authored 
              Chromium Mac expectations update. Rebaseline some tests after r80582
        (those that already had chromium-mac-leopard baselines).

        * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-lr-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-ruby-vertical-rl-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/vertical-align-table-baseline-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/vertical-font-fallback-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
        * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
        * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:
        * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.txt:
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Removed.
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum:
        * platform/mac-leopard/fast/blockflow/japanese-lr-selection-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@80885 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3d16077c
    • jberlin@webkit.org's avatar
      Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web · ad9b09c1
      jberlin@webkit.org authored 
      Process has finished launching.
https://bugs.webkit.org/show_bug.cgi?id=56208

Reviewed by Adam Roben.

Source/WebKit2: 

Only send the message if the Web Process is valid.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::clearResourceCaches):

Tools: 

* TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
(TestWebKitAPI::TEST):
Test that calling WKContextClearResourceCaches works with both options when called before
the Web Process is valid.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add the new test.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@80884 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ad9b09c1
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=52987 · 0d9d2dc5
      hyatt@apple.com authored 
              
Reviewed by Simon Fraser.

REGRESSION: Overflowing columns not repainted correctly
        
Make sure to add in column overflow as visual overflow as well.  It was only propagating layout overflow, which is obviously not
sufficient, since blocks paint their own columns.

Added fast/multicol/scrolling-overflow.html

Source/WebCore: 

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):

LayoutTests: 

* fast/multicol/scrolling-overflow.html: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/mac/fast/multicol/scrolling-overflow-expected.txt: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@80883 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0d9d2dc5
    • dglazkov@chromium.org's avatar
      2011-03-11 Dimitri Glazkov <dglazkov@chromium.org> · f34e21fe
      dglazkov@chromium.org authored 
              Reviewed by Adam Barth.

        Start using derived sources correctly and link minidom with JavaScriptCore gyp project.
        https://bugs.webkit.org/show_bug.cgi?id=56217

        * gyp/JavaScriptCore.gyp: Added derived source files and passing of shared directory
            to the scripts.
        * gyp/generate-derived-sources.sh: Changed to use passed directory.
        * gyp/generate-dtrace-header.sh: Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80882 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f34e21fe
    • mihaip@chromium.org's avatar
      2011-03-11 Mihai Parparita <mihaip@chromium.org> · ab05d7a5
      mihaip@chromium.org authored 
              Mac and Chromium expectations update. Remove failing expectations for
        tests that no longer fail. Rebaseline fast/overflow/
        overflow-rtl-vertical.html and fast/lists/008-vertical.html after
        r80755.

        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/lists/008-vertical-expected.checksum:
        * platform/mac/fast/lists/008-vertical-expected.png:
        * platform/mac/fast/overflow/overflow-rtl-vertical-expected.checksum:
        * platform/mac/fast/overflow/overflow-rtl-vertical-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@80881 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ab05d7a5
    • mdelaney@apple.com's avatar
      2011-03-11 Matthew Delaney <mdelaney@apple.com> · bbdb5c9f
      mdelaney@apple.com authored 
              Reviewed by Simon Fraser.

        Set canvasUsesAcceleratedDrawing setting to be off(false) by default
        https://bugs.webkit.org/show_bug.cgi?id=56215

        No new tests. Does not affect behavior. Just keeping the setting off by default.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):


git-svn-id: svn://svn.chromium.org/blink/trunk@80880 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bbdb5c9f
    • mihaip@chromium.org's avatar
      2011-03-11 Mihai Parparita <mihaip@chromium.org> · c73c656f
      mihaip@chromium.org authored 
              Update Chromium expectations. Remove some commented out lines and
        promote some expectatiosn from chromium-mac to mac-leopard, so that
        those tests pass on chromium Snow Leopard (and mac Leopard).

        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.checksum.
        * platform/mac-leopard/fast/block/basic/percent-height-inside-anonymous-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/basic/percent-height-inside-anonymous-block-expected.png.
        * platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.checksum.
        * platform/mac-leopard/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/positioning/static-distance-with-positioned-ancestor-expected.png.

git-svn-id: svn://svn.chromium.org/blink/trunk@80879 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c73c656f
    • aestes@apple.com's avatar
      2011-03-11 Andy Estes <aestes@apple.com> · 3b24ae99
      aestes@apple.com authored 
              Reviewed by David Hyatt.

        Table cells with dynamically added percentage height descendants do not
        grow in size if the table has already been laid out.
        https://bugs.webkit.org/show_bug.cgi?id=56174
        
        Table cells ignore their specified size and collapse to fit their
        children. When a descendent with percentage height is present before
        the table is first laid out, the descendent is sized based on the
        specified size of the table cell. However, when the child isn't present
        when the table is first laid out, the table cell ignores its specified
        size and collapses down to 0. Then, when the child div is added in a
        separate run loop iteration, it is sized to be 100% of the collapsed
        cell height instead of 100% of the cell's specified height. We should
        not get different layouts depending on the timing of tree construction.
        
        Fix this by clearing intrinsic padding before calculating the table
        cell's override height when we detect a child that should flex the
        table cell.

        Test: fast/table/dynamic-descendant-percentage-height.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::setOverrideSizeFromRowHeight): clear
        intrinsic padding before setting the override size.
        * rendering/RenderTableCell.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows): Call
        setOverrideSizeFromRowHeight() instead of setOverrideSize().
2011-03-11  Andy Estes  <aestes@apple.com>

        Reviewed by David Hyatt.

        Table cells with dynamically added percentage height descendants do not
        grow in size if the table has already been laid out.
        https://bugs.webkit.org/show_bug.cgi?id=56174

        * fast/table/dynamic-descendant-percentage-height.html: Added.
        * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
        * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
        * platform/mac/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@80878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3b24ae99
    • hyatt@apple.com's avatar
      Fix Windows build bustage. · d3903a46
      hyatt@apple.com authored 
      git-svn-id: svn://svn.chromium.org/blink/trunk@80877 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d3903a46
    • michaeln@google.com's avatar
      2011-03-11 Michael Nordman <michaeln@google.com> · 7dad9153
      michaeln@google.com authored 
              Reviewed by David Levin.

        Add SQLCallbackWrapper
        Instead of directly holding RefPtrs to the Callback objects in SQLStatement and SQLTransaction, hold a wrapper objects
        which holds those references whose dtors will schedule the release of those references on the ScriptExecution thread.
        https://bugs.webkit.org/show_bug.cgi?id=55919

        No new tests, existing tests apply.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/SQLCallbackWrapper.h: Added.
        (WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
        (WebCore::SQLCallbackWrapper::clear):
        (WebCore::SQLCallbackWrapper::unwrap):
        (WebCore::SQLCallbackWrapper::hasCallback):
        (WebCore::SQLCallbackWrapper::safeRelease):
        * storage/SQLStatement.cpp:
        (WebCore::SQLStatement::create):
        (WebCore::SQLStatement::SQLStatement):
        (WebCore::SQLStatement::performCallback):
        * storage/SQLStatement.h:
        (WebCore::SQLStatement::hasStatementCallback):
        (WebCore::SQLStatement::hasStatementErrorCallback):
        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::SQLTransaction):
        (WebCore::SQLTransaction::executeSQL):
        (WebCore::SQLTransaction::checkAndHandleClosedOrInterruptedDatabase):
        (WebCore::SQLTransaction::deliverTransactionCallback):
        (WebCore::SQLTransaction::deliverStatementCallback):
        (WebCore::SQLTransaction::postflightAndCommit):
        (WebCore::SQLTransaction::deliverSuccessCallback):
        (WebCore::SQLTransaction::handleTransactionError):
        (WebCore::SQLTransaction::deliverTransactionErrorCallback):
        * storage/SQLTransaction.h:


git-svn-id: svn://svn.chromium.org/blink/trunk@80876 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7dad9153