- 19 Aug, 2020 40 commits
-
-
Eugene But authored
Do not call reportBackUserAction on SettingsTableViewController as root settings view controller does not have "back" button and does not have to record "back" metric. DCHECK was hapenning after dragging SettingsTableViewController bottom and returning it back, which called presentation callback for root settings controller. Bug: 1117512 Change-Id: I45f3a2285007e8098b9155501a9c526fecf1df8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363003 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#799734}
-
Mohamed Amir Yosef authored
This is analogous to PasswordForm::in_store and reflects in which store those credentials are stored. Bug: 1108422 Change-Id: I1b60e2cc2725959342abf1a0d1dad9df09d10edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364508Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#799733}
-
Maks Orlovich authored
Bug: 982374 Change-Id: I9d83f7938967f44be95c410610d4a38f8c59b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364058Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#799732}
-
Kevin McNee authored
This reverts commit 5de0588a. Reason for revert: A few time related unit tests started flaking on win-asan, starting from the build containing this CL (13964). Suspecting this CL to be the culprit. https://ci.chromium.org/p/chromium/builders/ci/win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/13964 e.g. [ RUN ] ElapsedThreadTimerTest.Simple ../../base/timer/elapsed_timer_unittest.cc(72): error: Expected: (timer.Elapsed()) >= (kLoopingTime), actual: 0.000988 s vs 0.001 s Stack trace: Backtrace: base::ElapsedThreadTimerTest_Simple_Test::TestBody [0x00007FF7C6A735B1+1351] (C:\b\s\w\ir\cache\builder\src\base\timer\elapsed_timer_unittest.cc:72) [ FAILED ] ElapsedThreadTimerTest.Simple (289 ms) Original change's description: > //base/time cleanups: > > * Make more things constexpr and/or make it possible to do so later > * Inline SaturatedAdd/Sub(), FromDouble(), FromProduct() > * Order the FromUnits{,D}() pairs together > * Init members in declaration > * Briefer implementations of various functions > * IWYU > * Fix declared-but-not-defined issue for FromTimeSpec() w/OS_FUSCHIA > * Use more specific DCHECKs > * No else after return > * Omit needless qualifiers > * EXPECT -> static_assert where possible > * <atomic> is legal now > * Don't handle DCHECK failure > > The inlines don't hurt size: this saves 4 KB off chrome.dll in my local > release build. > > Bug: none > TBR: stevenjb@chromium.org > Change-Id: I269d6426ac1587569e7a4c785250a4dd5e95d5bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358997 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799459} TBR=stevenjb@chromium.org,pkasting@chromium.org,miu@chromium.org,tsepez@chromium.org,khegde@chromium.org Change-Id: Ic855d54ae010859b82c55848fb14d8af2cb778d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364062Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799731}
-
adamta authored
Improves header animation for when feed changes from visible to hidden. Sets border radius and colour in advance, and animates border width when the state changes. Bug: 1085419 Change-Id: I86778e7a50594dde1f8fb159f787a8c20ff8bc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342319 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
-
Sky Malice authored
Bug: 1111970 Change-Id: I473c0eed6a0975062055691f663ee9601cd70de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339760Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799729}
-
Xi Han authored
Record Startup.Android.FirstDrawCompletedTime.{Instant,NoInstant}. Bug: 1092931 Change-Id: I2d589ddc7f880cd7ccfc3c3fe45c46409896a035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355590Reviewed-by:Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799728}
-
Javier Ernesto Flores Robles authored
Context: https://docs.google.com/document/d/1vjo-PTxVBFpY0aZUozRuBOpL2bd9J4qahZTsGyQWvXE/edit#heading=h.uonvs79xfbra Bug: N/A Change-Id: I4153dd3a50ff9eb9652d585cd368d90931ff9681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352910 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799727}
-
David Roger authored
"Space" is replaced by "profile" and other minor changes. Bug: 1063856 Change-Id: I407f924286ff9791a1a660d72e2157eaf58566c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362658Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799726}
-
Jan Wilken Dörrie authored
This change makes use of absl::variant inside of base::Value and replaces the manually written tagged union. Since adding an Abseil #include requires propagation of the corresponding absl_include_config, several deps have been changed to public_deps in order to avoid build errors. TBR=battre Bug: 646113 Change-Id: I781fb43aa0eb4caacbda7f745babd042755f199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332182 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799725}
-
sauski authored
CL extends the PageSpecificContentSettingsDelegate to receive and forward access granted events for Indexed DB & Cache Storage to the AccessContextAuditService. Extends the existing AccessContextAuditBrowserTest to better support testing that origin keyed storage accesses are recorded and handled correctly. Bug: 1101675 Change-Id: I5782a331174c60a7235d29d55f66f70b4977dc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351916 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799724}
-
Olesia Marukhno authored
Added tests for keyword button, pedal button, remove suggestion button, multiple buttons for one suggestion (tab switch and keyword button). Cleaned up tests. Fixed a11y for remove suggestion button and buttons in dedicated row (set role to be list box option and set correct accessible name). Fixed selection event not being triggered for dedicated row buttons (GetSecondaryButton wasn't returning buttons from dedicated row). Fixed value changed event triggering extra time when switching selection from button to button. Bug: 1104264 Change-Id: I0c7a7a9cee0622cce2a24f6ea58c73a56ac996bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352826 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799723}
-
Evan Stade authored
PickerAdapter is split into a base PickerAdapter and a ChromePickerAdapter. Inheritance is used instead of a delegate object because ChromePickerAdapter overrides some Adapter methods. The code that uses the signin component is left in ChromePickerAdapter, even though it's componentized, as WebLayer doesn't currently use this component. This code may also be componentized later, but the plan is for WebLayer to initially skip the special handling for the owner contact. After this change, all of the contacts_picker package save ChromePickerAdapter can be moved to //components. Bug: 1016938 Change-Id: Iba554c2064e1e302a05455b8875b409a14c3b199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324762Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#799722}
-
Monica Basta authored
This CL adds backgrond illustration, back button, title. Screenshot: https://drive.google.com/file/d/1W9FMBB7ygkN3wtjxXon1SrEemfLWF2L_/view?usp=sharing Bug: 1115056 Change-Id: Ic3aec74621ce6ef8e4aba8ad054e9ed99b681160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362894 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799721}
-
dpapad authored
Bug: 1114268 Change-Id: I633cec77a423b2846f8f20d4ccf2347492f01710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360112Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#799720}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ad1011a1965..eeedb6ea3337 2020-08-19 orphis@webrtc.org Add error reporting on VP8 encoder configuration error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I359e1629eb13e9a464c13fc48698807ace357ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799719}
-
David Roger authored
* changes "space" to "profile" * uses simplified strings Consumer/Consumer: https://screenshot.googleplex.com/52275e2f-8e2d-4a62-a4d1-e410f2128f48.png Consumer/Enterprise: https://screenshot.googleplex.com/a461e697-d534-47ec-aeab-6cf3266ebb3a.png Enterprise/Consumer: https://screenshot.googleplex.com/0edb8efc-b7d2-47f2-841d-f9fef0929923.png Enterprise/Enterprise: https://screenshot.googleplex.com/d6404a97-b730-46d2-afee-a61411020758.png Bug: 1076880 Change-Id: I180abee9d6f7dfd3bf219c14cf37d37eebc803c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362854Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6a272ffee65..72e31331da03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia815122831736483ddd210d55b370017e745e570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364461Reviewed-by:
-
Michael Thiessen authored
Bug: 989569 Change-Id: I49c5124ccbbb4b921a65e7b42b7c46d05bfb87d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363867 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Sujie Zhu authored
We got full-launch approval, and already enabled by default: crrev.com/c/2334102 (We forgot to remove the field_trial config in that CL). Bug: 1059087 Change-Id: Iae4cad3adf059ffd881a854f70198ac78c83ca7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363923 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#799715}
-
Eugene But authored
- don't log "unknown" orientation on startup - don't log duplicate orientation changes Bug: 1046225 Change-Id: Idc9dbbb444737520d86edbc3306157992d599d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363353 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799714}
-
sauski authored
To support the observation of deletion events which flow through the StoragePartition exposed interface, the ability to register deletion observers is introduced. This functionality is then used by the Access Context Audit service to remove records for origin storages which are deleted in this manner. Bug: 1101675 Change-Id: I4123f42ba6607503a479f9b75b03fdfeaba023a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320569Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#799713}
-
Nicolas Ouellet-Payeur authored
This reverts commit fdb80c24. Reason for revert: CQ acting weird here: https://crrev.com/c/2352517/14 Original change's description: > [Traffic Annotations] Roll traffic_annotation_auditor > > Following the change that adds the grouping.xml check: > https://chromium-review.googlesource.com/c/chromium/src/+/2303313 > > Also updates grouping.xml to make sure the test passes on CQ. > > Bug: 1107860 > Change-Id: Icb4eea6540c6ddeb95dcd5efa9ea86ccec2afc13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362988 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799619} TBR=rhalavati@chromium.org,nicolaso@chromium.org Change-Id: I8b132868624506ddb79acffde57b3f89f3fb27cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1107860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364817Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#799712}
-
Titouan Rigoudy authored
This change introduces PrivateNetworkRequestPolicy, an enum describing how the network service should treat private network requests. A value for this enum is communicated by the browser to the network service through ClientSecurityState. This replaces the direct feature check by URLLoader, making it slightly easier to test URLLoader::OnConnected(). The feature check is moved one layer up, to content/. NavigationRequest is now in charge of setting the PrivateNetworkRequestPolicy according to the state of the feature flag and the stated intent of the content embedder, as communicated through ContentBrowserClient. By default, ContentBrowserClient allows no exceptions to the feature. ChromeContentBrowserClient uses content settings to manage exceptions. Bug: chromium:986744 Change-Id: Ic053b643426e70a4e88260e25709b95a3b843810 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339972Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799711}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: Iebbe654853bebeb4af49c9cb793dae5938416f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351374 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
-
Side Yilmaz authored
All usages of the functions are changes and this CL removes the deprecated createImageFecther functions. Bug: 1083923 Change-Id: Ifec79bc28ee8d80d509533b0dd624101ad1c561c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362890Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799709}
-
John Chen authored
This bot frequently fails due to insufficient capacity. Reducing number of shards from 35 to 28. Bug: 1114129 Change-Id: Id7a4fdb96725b815db009cd77bb01a4bf61c2c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364515 Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#799708}
-
Rakina Zata Amni authored
When doing a main-frame same-site navigation where we did a proactive Browsing Instance swap and we're reusing the old page's process, we will run the pagehide and visibilitychange handlers of the old page before we run the new page, without unloading the old page. This means script can still run after we've dispatched these events - this was not possible before. This CL adds a way to record occurences of certain actions happening on a page after the pagehide event gets dispatched. We will only track actions that might affect the user after we've navigated away from the old page such as modifications to storage, navigations, or postMessage. See: https://docs.google.com/document/d/1RXGDkrSWTfaeio76joXKWBLGDHAbiB48sHUdcTX6rdc/edit#heading=h.476deggm397n Bug: 977562 Change-Id: I5307309421b880ae556cc6dec30cffcec7ff6e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352304 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#799707}
-
Jeff Yoon authored
* upstream ios14-sdk compile and test with xc12b5 * upstrema ios14-beta compile n-1 and test w/ xc12b5 * upstream ios14-sdk trybot cache update to xc12b5 Bug: 1118191 Change-Id: I6d6e36c17a20e6a4bd684377aa6a396927ec8036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363706Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799706}
-
Alison Maher authored
If an element is hidden, we shouldn't paint a backplate behind it when in forced colors mode. Bug: 970285 Change-Id: I378776c71a6977722305e91df84418493be4f290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363443Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799705}
-
Tina Wang authored
Change the setting UI to uneditable when SearchSuggestEnabled is managed by enterprise policy. Bug: 1117253 Change-Id: I2c9619fd3e0d72de572d2dab4124695d8926503e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360574Reviewed-by:
-
Sharon Yang authored
To finish the default_context migration, remove the old default_context files. Test: CQ Bug: 1090364 Change-Id: I415b793572ed6d9042a7fded0ae258f83446ad04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303781Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#799703}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I1152739ef3e8fbea113a657453fd89108fac0d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352612 Commit-Queue: Sean McAllister <smcallis@google.com> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#799702}
-
Domenic Denicola authored
It appears these iframe tests weren't testing the getter value. Probably they were written before the getter existed. Bug: 1042415 Change-Id: I7b3fe224bb7bd998f4a8cb4a8a67b2c60738a5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364168Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799701}
-
Rayan Kanso authored
It seems that there have been crash reports related to this. The job details are not always present for some reason when the download client tries to get the uplaod data. Bug: 1115184 Change-Id: I8695e8538babe2ac36c2ea16e4cfbc8c7c2fdaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364497 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#799700}
-
Fredrik Söderqvist authored
Use a single insert() rather than find()+insert(). Change-Id: Ifb7008bc02928bea44a54183dd16f479063d87a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303435 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799699}
-
Xiaocheng Hu authored
Bug: 1098355 Change-Id: I30914ddd88b884a6b0241c1184904a67fa7370fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364001Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799698}
-
Tom Anderson authored
This fixes bug 1109422 which is caused by using the same x11::Connection from both the GPU main thread and the viz compositor thread. Summary of changes: * x11::Connection is now stored in TLS instead of as a singleton. This does not affect the browser process, but it means the GPU process will now have 2 connections: 1 for the main thread and 1 for the viz compositor thread. Additionally, chrome will have 3 connections when running in single-process-mode. * In X11 and Ozone/X11 contexts, the viz compositor thread must be a UI thread now so it can dispatch X events. This required making MessagePumpGlib compatible with multiple threads. * The GPU sandbox presents a challenge: we cannot open an X11 connection once it's up, since the socket() and connect() syscalls are blocked. To workaround this, we must open the viz compositor X11 connection the same time we open the main thread's X11 connection. For now, we stuff it in ui::X11UiThread as an obnoxious global variable. XShmImagePool and X11SoftwareBitmapPresenter are simplified as they are now only used on one thread. Also CreateVizCompositorThread() no longer requires a TaskRunner argument. With this change, once we remove the rest of Xlib, we can remove any locking when using X11. BUG=1066670,1078392,1109422 R=nickdiego,sky,msisov,rjkroege Change-Id: If122c071a2eef38ba0469fe592ab9cc71ccf6011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343314 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#799697}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e60f72f6801e..72e31331da03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iabe16801ab9aee90cc2ed386ded8a4c255cad85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363830Reviewed-by:
-
Domenic Denicola authored
This introduces a couple basic web platform tests for the popup cases. The main content of this CL is generalizing the test infrastructure, which previous was iframe-specific. Subsequent CLs will add a more comprehensive suite of popup tests. Bug: 1042415 Change-Id: I4f993783613f32cf9ebfb10e29973820e2fc9aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364057Reviewed-by:
-
