- 17 Mar, 2018 36 commits
-
-
Scott Chen authored
As of the time of this CL (M66), window's unload event doesn't not fire when the user navigates away with the back button. To make the behavior consistent between tab-closinng/reload/back, we instead listen to the beforeunload event. Bug: 806912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I319683f14284e4d6884aa22c84c78fea08ac78ef Reviewed-on: https://chromium-review.googlesource.com/965251 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543909}
-
Xiangjun Zhang authored
Add the video capture client implementation for the Mirroring service. It requests to start video capturing through the media::mojom::VideoCaptureHost interface, and receive the captured video frames through media::mojom::VideoCaptureObserver interface. Bug: 734672 Change-Id: I8007d9c8cbca1639eee8c5659f0b34a30c85e375 Reviewed-on: https://chromium-review.googlesource.com/954056Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543908}
-
Maks Orlovich authored
This may hopefully make the next person seeing reports of strange 1-byte range requests for previously truncated files less flabbergasted. (And also documented some fields at high-level). Bug: 820862 Change-Id: I3bbb8fc46c2c5a015bf8669165add631df289486 Reviewed-on: https://chromium-review.googlesource.com/964981Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#543907}
-
Qiang Xu authored
changes: Per UI review, change snap height from 16 to 32. Bug: 812313 Test: manual test Change-Id: Ib55687b9105bd705ed081ccea9cb52d97f5442ff Reviewed-on: https://chromium-review.googlesource.com/963593 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#543906}
-
Mitsuru Oshima authored
ash is cros only so we don't need suffix any more. done by mass-rename.sh script. Display_animator_chromeos will be handled in a separate CL as I have to merge two files. BUG=None TEST=All test should pass. Change-Id: I824b69de4db0c787de926963a562cfb0dde64d70 Reviewed-on: https://chromium-review.googlesource.com/967457Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#543905}
-
Karan Bhatia authored
This reverts commit 07737e12. Reason for revert: The CL did not resolve the issue. It seems the tests need to be suppressed in the LeakExpectations file instead. Original change's description: > Marking failures of layout tests on Webkit Linux Trusty > > Bug: 821547 > Change-Id: Idd4bd103a12935599a811a3d02b6f0071637543d > Reviewed-on: https://chromium-review.googlesource.com/961443 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Luna Lu <loonybear@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542892} TBR=loonybear@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821547 Change-Id: I9fa56a82a2ddd4e2f7c1b77aa8fce09a8b01b428 Reviewed-on: https://chromium-review.googlesource.com/967521Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543904}
-
Ahmed Fakhry authored
Moving from a tab of a display that has more modes to a tab of another display that has less modes, where the selected mode of the first display has index >= max index of the second display's modes, this would result in the first display's mode changing to the previous one in the slider. This CL fixes this issue by ignoring change callbacks when the various parameters of the currently selected display are still out of sync. BUG=822248 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I97d1a55b87ad99d9d6821270618609a7c4a880a7 Reviewed-on: https://chromium-review.googlesource.com/965630 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543903}
-
James West authored
Introduce a new CmaBackend interface that is used by the CMA pipeline instead of the public MediaPipelineBackend interface. The two implementations of CmaBackend are MediaPipelineBackendWrapper and MultizoneCmaBackend. Use AudioDecoderSoftwareWrapper to wrap MediaPipelineBackend::AudioDecoder in AudioDecoderWrapper instead of wrapping the audio decoder in the pipeline so that AudioDecoderSoftwareWrapper no longer wraps MultizoneAudioDecoder, which never requires upstream software decoding, and MultizoneAudioDecoder no longer has to handle creating an AudioDecoderSoftwareWrapper in passthrough mode. Bug: internal b/62147653 Test: cast_media_unittests and manual Change-Id: I63fedd14065cd665d89cef7917dcc44f21ce1fd0 Reviewed-on: https://chromium-review.googlesource.com/963493 Commit-Queue: James West <jameswest@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543902}
-
Charles Harrison authored
These experiments have all landed as enabled by default. Bug: None Change-Id: I47f27ae2074d66e1a6454884253baae4443ab64f Reviewed-on: https://chromium-review.googlesource.com/965933Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543901}
-
https://skia.googlesource.com/skia.git/+log/0a86820f2fe3..876dd31483bc $ git log 0a86820f2..876dd3148 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 1c08cbb39..dfebe9b2d (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Iba52824b31f8095f04a7912b5611425f323512d6 Reviewed-on: https://chromium-review.googlesource.com/967460Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543900}
-
Muyuan Li authored
Bug: 820255 Test: Manual Change-Id: Ib0a2227350acceb2214e0ed77195473a546f245a Reviewed-on: https://chromium-review.googlesource.com/923179 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543899}
-
Victor Vasiliev authored
Update the values of the feature flags Set FLAGS_quic_reloadable_flag_quic_streams_unblocked_by_session2 true Set FLAGS_quic_reloadable_flag_quic_disable_version_37 true Set FLAGS_quic_reloadable_flag_quic_disable_version_38 true FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay is deprecated. FLAGS_quic_reloadable_flag_quic_use_control_frame_manager is deprecated. Identify QUIC streams which should not be registered with the write blocked list using a constructor argument of the stream instead of checking the static_streams_ map in the QuicSession, which is not correctly populated when the check is performed. protected by FLAGS_quic_reloadable_flag_quic_register_streams_early2. Merge internal change: 188654154 https://chromium-review.googlesource.com/c/967182/ Remove unused typedef from BandwidthSampler code Merge internal change: 188514269 https://chromium-review.googlesource.com/c/967108/ Expore an accessor to initalized_ in QuicClient Merge internal change: 188509171 https://chromium-review.googlesource.com/c/967106/ In QUIC, stop sending a redundant PING every 20 acks, because a WINDOW_UPDATE is guaranteed to be sent. Protected by FLAGS_quic_reloadable_flag_quic_remove_redundant_ping. Although this WINDOW_UPDATE and PING will be bundled in the same packet, it is better to remove it. Merge internal change: 188486725 https://chromium-review.googlesource.com/c/967012/ Add bool return value to QuicSentPacketManager::OnIncomingAck() and ::OnAckFrameEnd() to indicate if a new packet has been ACKed. Merge internal change: 188389208 https://chromium-review.googlesource.com/c/967000/ Add IETF-format framer/deframer for the STOP SENDING Frame. Work done in preparation for developing the IETF version of QUIC Merge internal change: 188356015 https://chromium-review.googlesource.com/c/966998/ Let QUIC always discard outgoing packets after connection close. Protected by FLAGS_quic_reloadable_flag_quic_always_discard_packets_after_close. Merge internal change: 188341773 https://chromium-review.googlesource.com/c/966462/ Add Framer/Deframer for IETF QUIC Stream Reset frame Merge internal change: 188331903 https://chromium-review.googlesource.com/c/967002/ Replace a personalized TODO with a bug ID reference Merge internal change: 188320993 https://chromium-review.googlesource.com/c/963772/ Call OnSuccessfulVersionNegotiation earlier on server The server already has cases where version negotiation is completed without verifying authenticity of the packets from the client, but there was one case where it waited to do that before finishing. This changes the order of processing so that version negotiation (on a server) always completes before we have to decrypt a packet. This allows using OnSuccessfulVersionNegotiation as the signal to set the initial crypters for IETF QUIC. Changes when QUIC version negotiation completes on a server. Protected by FLAGS_quic_reloadable_flag_quic_server_early_version_negotiation Merge internal change: 188255217 https://chromium-review.googlesource.com/c/964806/ Deprecate FLAGS_quic_reloadable_flag_quic_use_control_frame_manager. Merge internal change: 188223533 https://chromium-review.googlesource.com/c/963855/ Fixed 3 DeadCode findings in 3 paths: //net/quic/quartc/quartc_stream.cc //net/quic/quartc/quartc_stream.h //net/quic/quartc/quartc_stream_interface.h * connection_error appears to be dead. (3 times) Merge internal change: 188124383 https://chromium-review.googlesource.com/c/964724/ Add QUIC_FLAG_COUNT macros for two flags The macros are added for FLAGS_quic_reloadable_flag_quic_store_version_before_signalling and gfe2_reloadable_flag_delay_quic_server_handshaker_construction. Merge internal change: 188083245 https://chromium-review.googlesource.com/c/964721/ Small refactor. Not flag protected. - Add WRITE_STATUS_MSGSIZE to gfe_quic::WriteStatus. But it is not set anywhere yet. - Add IsWriteError(WriteStatus status) to tell if |status| is an error. It is equivalent to the existing "status == WRITE_STATUS_ERROR" check since WRITE_STATUS_MSGSIZE is not set anywhere. - Add a QuicConnection::IsMsgTooBig(const WriteResult& result). It is equivalent to the existing check since WRITE_STATUS_MSGSIZE is not set anywhere. Merge internal change: 188062461 https://chromium-review.googlesource.com/c/964701/ Deprecate FLAGS_quic_reloadable_flag_quic_min_rtt_ack_delay. Merge internal change: 188050187 https://chromium-review.googlesource.com/c/963223/ R=rch@chromium.org Change-Id: Ib28a94eddbd95abff0b6b267c37d7f9f0a97bc95 Reviewed-on: https://chromium-review.googlesource.com/967100Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#543898}
-
Esmael El-Moslimany authored
Bug: 819996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab8fa2d66ab07cc0f8c0c9c4509f40563dfe0dd6 Reviewed-on: https://chromium-review.googlesource.com/956242 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543897}
-
Pavel Feldman authored
Change-Id: Ibf1a705b7106ea2a04d45f553819b20d1a37fc3e Reviewed-on: https://chromium-review.googlesource.com/965602Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543896}
-
Mitsuru Oshima authored
These will be used for ARC++ windows. This also moves the back button asset to ash/public/cpp/vector_icons where they should be. BUG=822960 Change-Id: Ie26b11c1eacbef8cce9e6f07a17ba8daf2c80754 Reviewed-on: https://chromium-review.googlesource.com/966942Reviewed-by:
-
Kyle Horimoto authored
See go/unified-better-together-cros for an outline of this service. This CL does the following: (1) Creates a Mojo interface for the service, adding only a single function for now. (2) Creates the MultiDeviceSetupService and MultiDeviceSetupImpl classes which implement this interface, as well as a test for the service. (3) Registers the service in the browser process via ProfileImpl. (4) Generates JavaScript files for the interface; because these files are the first resources generated in //chromeos, this CL also adds a new chromeos_resources.grd. (5) Adds the new "multidevice_setup" capability to the content_browser manifest file so that it can be used by content_renderer. (6) Adds a new button on the chrome://proximity-auth debug WebUI page which makes a Mojo call to the service. Change-Id: I0b74373b78a1c92fe01d789028342707321c2134 Reviewed-on: https://chromium-review.googlesource.com/954010Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#543894}
-
Esmael El-Moslimany authored
Bug: 819996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8a9fff7afcc4fa17f742bcad6bb102a8f6271881 Reviewed-on: https://chromium-review.googlesource.com/963694 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#543893}
-
rbpotter authored
Make custom margins draggable and allow for updates with text boxes. Does not yet update margins ticket item or limit margins values based on page size. Bug: 773928, 812095 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifa0e270bb32cc77c420788dae2daecf7817c063f Reviewed-on: https://chromium-review.googlesource.com/961483 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/bf3dbb4a692f..317a5228766f $ git log bf3dbb4a6..317a52287 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie886c3b21a2a5959e36cefb06dc8bb4a00670339 Reviewed-on: https://chromium-review.googlesource.com/967005Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543891}
-
https://chromium.googlesource.com/catapult.git/+log/16322a374abb..2fb447197524 $ git log 16322a374..2fb447197 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 dtu [pinpoint] Show "my jobs" only. 2018-03-07 konkers [fuchsia] Add thread state to fuchsia importer. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I6f741503c19384b9f52577ecd66b1ddb2708084c Reviewed-on: https://chromium-review.googlesource.com/967257Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543890}
-
Zhiling Huang authored
Bug: 790142 Change-Id: I77f5fa5dc4a45248af2dbe527d20f5ccdffa8eac Reviewed-on: https://chromium-review.googlesource.com/967004 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543889}
-
https://pdfium.googlesource.com/pdfium.git/+log/9d7c7ff0a5f0..502e85921306 $ git log 9d7c7ff0a..502e85921 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 thestig Rename some variables in FPDFTextEmbeddertest. 2018-03-16 thestig Fix methods that have definition with different parameter names. 2018-03-16 hnakashima Fix typo in doc of FPDFDest_GetDestPageIndex. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia8803889d774c214787128411580a40dc131580b Reviewed-on: https://chromium-review.googlesource.com/967368 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543888}
-
Jose Dapena Paz authored
CHECK() implementation for arm, arm64, x86 and x64 includes asm() statements. Recently added bounds checks using it on constexpr methods are breaking GCC build, as GCC follows more strictly C++14/11 standard, that explicitely forbids calling asm from constexpr. But GCC does not complain if the asm statement is not directly called from constexpr, but through a function call. So wrap the GCC asm calls for IMMEDIATE_CRASH in a lambda function. Bug: 821357 Change-Id: I9b806fa09eda872fb2b8e81cc79d8a4ea20e3e0b Reviewed-on: https://chromium-review.googlesource.com/960861 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
-
Scott Violet authored
This reverts commit d13c288b. Reason for revert: Two serious issues have come up: 822917 and 822577. Original change's description: > reland attempt 3: Adds WindowService-ChromeOS fieldtrial > > I'm not sure on the name here. I went with WindowService-ChromeOS as > at some point we will launch the WindowService on other platforms, but > that won't be anytime soon and is likely to be very different. So, I'm > thinking later on we have the field trial WindowService-Desktop. > > BUG=814898 > TEST=none > TBR=rkaplow@chromium.org > > Change-Id: I555c9cea0f59c28b2e6124196f362ac3231104fc > Reviewed-on: https://chromium-review.googlesource.com/962877 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543156} TBR=sky@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814898 Change-Id: I2290fd6ee56d985117b772f4554eac6e2e658b99 Reviewed-on: https://chromium-review.googlesource.com/966694Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543886}
-
Aleks Totic authored
Root cause of missing invalidations: LayoutObject::AdjustStyleDifference was not marking LayoutText with NG rendering as NeedPaintInvalidation. This caused invalidation not to propagate to document. It was not marked because LayoutObject:1789 ToLayoutText(this)->HasTextBoxes() always returned false for NG. The fix was to make HasTextBoxes() NG-aware. This caused 2 callers of HasTextBoxes() to behave incorrectly. Created HasLegacyTextBoxes(), and added a TODO to remove them. Bug: 819372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: If2c4ddc0c9c707d11bb9115ef26ac578387c8359 Reviewed-on: https://chromium-review.googlesource.com/961526 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543885}
-
Sandeep Vijayasekar authored
Besides setting this flag at creation time, it can be useful to enable later. Bug: internal b/69007670 Test: none Change-Id: I95d1eaa557e91c9c7e4ed29787928adbdb388ee2 Reviewed-on: https://chromium-review.googlesource.com/961543 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
-
Charlie Reis authored
This reverts commit 431c6dbf. Reason for revert: r543765 caused more test failures, tracked in https://crbug.com/822980. Original change's description: > Revert "Disable wheel scroll latching in failing content_browsertests." > > This reverts commit f2bf009a. > > Reason for revert: There has been a few bug fixes related to oopif and > latching, I will enable the latching flag to see if the failing tests > are fixed or not. If not I will disable the tests again addressing crbug.com/822764 bug as well. > > Original change's description: > > Disable wheel scroll latching in failing content_browsertests. > > > > I cannot reproduce the test failures on my local official windows build, > > in this cl I force wheel scroll latching to be disabled in the tests to > > see if it changes the test results on Win official or not. > > > > Bug: 800822 > > Change-Id: Ife07a29617ca5e0142e75f926967685cb61e2a08 > > Reviewed-on: https://chromium-review.googlesource.com/895842 > > Reviewed-by: James MacLean <wjmaclean@chromium.org> > > Reviewed-by: Nasko Oskov <nasko@chromium.org> > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#533347} > > TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 800822, 822764 > Change-Id: I563672dfbcb01298324a2b884cbed0e69c220339 > Reviewed-on: https://chromium-review.googlesource.com/966687 > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543765} TBR=nasko@chromium.org,wjmaclean@chromium.org,sahel@chromium.org Change-Id: Ie0212e01b308826c96eac54b86168ce9d1d04231 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800822, 822764 Reviewed-on: https://chromium-review.googlesource.com/967522Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#543883}
-
Weiliang Chen authored
Remove unused code. TBR=enne Bug: 822873 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Icfce16105876d05efaa83b858fd4d39be3add686 Reviewed-on: https://chromium-review.googlesource.com/967157 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#543882}
-
Raymond Toy authored
Enable tail processing by calling the necessary routines. A continuation of https://chromium-review.googlesource.com/c/chromium/src/+/949762 where tail processing is actually running. Keep nodes alive when there are no input connections so that the node has time to flush out any internal memory. When the output of the node is going to be disabled (because there are no inputs), place the node on a list, without disabling the output. The list is processed every rendering quantum to see if the tail time of node has passed. If the tail time has not passed, nothing is done; otherwise, the output is disabled, and the node is removed from the list. This allows the node to be collected, if possible. Bug:357843, 731518 Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html Change-Id: I5ba37015787fbbb2342eacb57b4851b99a36b3c5 Reviewed-on: https://chromium-review.googlesource.com/661165 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543881}
-
Alexei Filippov authored
When the last sample in a profile happen to be a (garbage collector), the forEachFrame function failed to close last opened stack frames. BUG=822909 Change-Id: I5165491e1aa1b92466aec339aa848186c89eb9f9 Reviewed-on: https://chromium-review.googlesource.com/967272 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543880}
-
Candice Sy authored
This is a fix for the bug where 5 user pauses of an offlining request fails the request because there is a max of 5 tries per request. Decreasing the started_attempt_count_ when pausing an offlining request undos the incrementation of the counter when the request began offlining. Bug: 701037 Change-Id: I721b41bd9e9a1c366c9fe7f5896f5627e8d8fb1a Reviewed-on: https://chromium-review.googlesource.com/957423 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#543879}
-
Yuichiro Hanada authored
virtualKeyboardPrivate.setMode() lacks 'bounds' parameter to set the virtual keyboard bounds after changing mode. The new method will replace setMode() with an ability to set bounds of the virtual keyboard container after changing mode. It's needed to prevent flashing when changing virtual keyboard mode. We want to change the window bounds before starting showing animation. Bug: 776260, 802991 Test: Manual. Change-Id: Iacf9977d06e05ac4dd3c66175cae7ba87d5fa0c6 Reviewed-on: https://chromium-review.googlesource.com/942281Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#543878}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5505a4a1..9f6698fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I122a76454515bfdd2649cf8115f6d794f13376cc Reviewed-on: https://chromium-review.googlesource.com/967245Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543877}
-
Karan Bhatia authored
BUG=822231 TBR=mfoltz@chromium.org Change-Id: I22d30d5c0c6ba309492697605077a94ba994148c Reviewed-on: https://chromium-review.googlesource.com/967411 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Emily Hanley authored
Bug: 757933 Change-Id: Id2f2e6603b92c5e96c685832ea7946fdef338f9f Reviewed-on: https://chromium-review.googlesource.com/966799Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#543875}
-
Matt Mueller authored
c/b/safe_browsing/certificate_reporting_service_test_utils.h: Remove unused members in CertReportJobInterceptor Change-Id: I037853fcb45f8babf359347241a43f3c22ba9f72 Reviewed-on: https://chromium-review.googlesource.com/967343Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#543874}
-
- 16 Mar, 2018 4 commits
-
-
https://skia.googlesource.com/skia.git/+log/16c1196ea6ba..0a86820f2fe3 $ git log 16c1196ea..0a86820f2 --date=short --no-merges --format='%ad %ae %s' 2018-03-16 stani Revert "fix nextContour bug" 2018-03-16 egdaniel Correctly discard or load RT when doing copies as draws in Vulkan 2018-03-16 benjaminwagner Add GT610 Debug ANGLE jobs. 2018-03-15 herb Apply filterTextFlags so the fonts are the same. 2018-03-16 egdaniel Add DoneProc to Promise Images 2018-03-16 reed handle bad xform in drawTextRSXform 2018-03-16 reed fix overflow in rgnbuilder 2018-03-16 rmistry Revert "Remove Android Framework bot from CQ while server is being upgraded" 2018-03-16 caryclark more imageinfo text and warnings and cleanup 2018-03-16 egdaniel Make sure we do a render pass load if we copied to a surface before hand Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie25a4a0b4b0a918ae290623ddade40066025ee4b Reviewed-on: https://chromium-review.googlesource.com/967247Reviewed-by:
-
Bin Zhao authored
dial_media_sink_service: - Added Register/UnregisterOnSinkQueryUpdatedCallback() - Start/StopObservingMediaSinks() takes std::string media_source as parameter dial_media_sink_service_impl: - Do not check app availability for discovery only devices media_router_desktop: - Initialize DialMediaRouteProvider if DialSinkQueryEnabled() media_router_mojo_impl: - Use extension MRP to create/terminate route for DIAL sink dial_media_route_provider: - Register OnSinkQueryUpdatedCallback with dial_media_sink_service Bug: 779892 Change-Id: Iddc760c4fa035c00210480f28de7db96e42fe61c Reviewed-on: https://chromium-review.googlesource.com/903419 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#543872}
-
Sammie Quon authored
This is a reland of e50412fb Original change's description: > cros: Convert switch to feature for new overview ui. > > Convert to feature which is enabled by default. > > Test: manual > Bug: 821608 > Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616 > Reviewed-on: https://chromium-review.googlesource.com/961721 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543139} Bug: 821608 Change-Id: Id240ddfa8b5551209c61612e406a4a88d5578d02 Reviewed-on: https://chromium-review.googlesource.com/963585Reviewed-by:
-
Nick Carter authored
Cause of flake was confirmed by adding a slow unload handler to |popup|. This fixes it. Bug: 821596, 822635 Change-Id: I602c98a0fb37f9951cc85fb9d886616bb22e8b42 Reviewed-on: https://chromium-review.googlesource.com/967352Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543870}
-
