GitLab

BUG=529938

Review URL: https://codereview.chromium.org/1410573008

Cr-Commit-Position: refs/heads/master@{#357052}

This should get reverted once the reference build is updated, which should be
sometime next week.

BUG=547833

Review URL: https://codereview.chromium.org/1404423010

Cr-Commit-Position: refs/heads/master@{#357051}

Revert of Web Animations: Use a single animation clock (patchset #7 id:120001 of https://codereview.chromium.org/1410313004/ )

Reason for revert:
Still breaks the Android bot (at least): https://build.chromium.org/p/chromium.webkit/waterfall?show=WebKit%20Android%20(Nexus4)

Please do not reland without first ensuring you have run the webkit_unit_tests step a few times on an equivalent Android bot.

Original issue's description:
> Web Animations: Use a single animation clock
>
> All animation clocks for a page should tick at the same time, but since we
> had an animation clock per document there were some cases where clocks
> could tick independently.
>
> This patch moves the clock from Document to PageAnimator.
> animation-timeline-detached-no-crash.html is removed as the test was not valid
> due to the animation's document not being active.
>
> Committed: https://crrev.com/b45c39903df3727d21cbc217a0b14c2c85b0715a
> Cr-Commit-Position: refs/heads/master@{#356776}
>
> Committed: https://crrev.com/ddd06a6080e1e7d7d02b15595289940980b04973
> Cr-Commit-Position: refs/heads/master@{#357044}

TBR=samli@chromium.org,dstockwell@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1425143006

Cr-Commit-Position: refs/heads/master@{#357050}

BUG=532905

Review URL: https://codereview.chromium.org/1425143004

Cr-Commit-Position: refs/heads/master@{#357049}

Missing these header files cause unclean builds.

TBR=haraken
BUG=548915

Review URL: https://codereview.chromium.org/1409033006

Cr-Commit-Position: refs/heads/master@{#357048}

This patch address the following corner cases:

1. If OnConnectionError() is invoked while there are queued requests, this
happens when extension is woken up but MRPM did not register with MR
successfully.
2. Wake up extension failed.
3. After connection is established (RegisterMediaRouteProvider), we try to run
all pending requests, but it's possible that the extension is already suspended
at that point. It looks like an uncommon timing issue and does not appear to
indicate a connection error.

For 1 and 3, we will retry the wakeup (up to a max number of attempts) since
there is no way to tell if the error was transient. For 2, it is usually due to
a nonretriable error, so we will just drain the queue.

The retry / drain logic also ensures pending requests do not sit in the queue
indefinitely.

Also, introduced a max limit queue size. When the queue size exceeds that limit,
the oldest pending request will be dropped.

A couple of things considered but not implemented:
- Try to fail the pending request in some way instead of dropping them. First,
not all types of requests can be failed, i.e. majority of them do not contain
callbacks. Also because it is a corner case, the added complexity probably does
not justify it.
- Adding a permanent_failure bit to MediaRouterMojoImpl and automatically drop
requests if set to true. Locking down the media router due to connection error
feels too restrictive and I am not sure if it will help.

BUG=490787

Review URL: https://codereview.chromium.org/1419853003

Cr-Commit-Position: refs/heads/master@{#357047}

Controlled by the AutofillFieldMetadata trial, we send the form name as described in the bug.

BUG=548366

Review URL: https://codereview.chromium.org/1422853003

Cr-Commit-Position: refs/heads/master@{#357046}

Previously we were filtering out PropertyHandle types while iterating over
an AnimationStack.
This change pushes the filter into the construction of the AnimationStack
to avoid having undesirable entries in the first place.

Review URL: https://codereview.chromium.org/1412423004

Cr-Commit-Position: refs/heads/master@{#357045}

All animation clocks for a page should tick at the same time, but since we
had an animation clock per document there were some cases where clocks
could tick independently.

This patch moves the clock from Document to PageAnimator.
animation-timeline-detached-no-crash.html is removed as the test was not valid
due to the animation's document not being active.

Committed: https://crrev.com/b45c39903df3727d21cbc217a0b14c2c85b0715a
Cr-Commit-Position: refs/heads/master@{#356776}

Review URL: https://codereview.chromium.org/1410313004

Cr-Commit-Position: refs/heads/master@{#357044}

The first reland had two mistakes.
  1) It tried to turn on Mach-based shared memory on 10.6, which isn't supported.
  2) It hit a race condition in AttachmentBrokering code in GPU conformance tests.

I submitted two speculative fixes for (2), but haven't been able to reproduce the problem
locally, so can't verify that the problem is definitively fixed. Please revert this CL if
problems are seen in GPU conformance tests.

> The CL changes the default behavior of resource buffer to use a Mach-backed
> SharedMemory region. This CL adds a field trial to measure the effect of Mach vs
> POSIX backed SharedMemory regions.
>
> BUG=547261, 466437
> Committed: https://crrev.com/e0e2fd398f3d07c8eebbe662d71a0f9286862476
> Cr-Commit-Position: refs/heads/master@{#356513}

BUG=547261, 466437
TBR=mark@chromium.org, isherman@chromium.org, asvitkine@chromium.org, avi@chromium.org

Review URL: https://codereview.chromium.org/1406123010

Cr-Commit-Position: refs/heads/master@{#357043}

Also updating interface due to thread safety concerns. Unit tests
have been modified to ensure that Observers and Validators can call
DeviceCapabilities methods safely without hitting deadlocks or
unexpected behavior.

TEST=cast_base_unittests
BUG=

Review URL: https://codereview.chromium.org/1409173006

Cr-Commit-Position: refs/heads/master@{#357042}

This change adds a method in StyleResolver which checks the animation-name
property of an element and returns all CSSOM keyframes rule representations
for that element. This method can then be used in InspectorCSSAgent to propogate
to the front-end and show the keyframes there.

BUG=266276

Review URL: https://codereview.chromium.org/1371723002

Cr-Commit-Position: refs/heads/master@{#357041}

Add to shelf on ChromeOS installs a bookmark app, which uses an
extension under the hood. Extension blacklist policies which prevent
extensions from being installed also disable the add to shelf feature
silently. This CL skips the policy checks for bookmark app installation,
allowing add to shelf to function when extensions are blacklisted.

BUG=545541
R=benwells

Review URL: https://codereview.chromium.org/1409393009

Cr-Commit-Position: refs/heads/master@{#357040}

These functions were introduced by [1] and all callsites were removed by [2].

[1] https://codereview.chromium.org/810583002
[2] https://codereview.chromium.org/1237353002

BUG=548977
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1429753002

Cr-Commit-Position: refs/heads/master@{#357039}

Revert of Change shortcut install location to non-subdir. (patchset #23 id:440001 of https://codereview.chromium.org/1289333005/ )

Reason for revert:
Cause of http://crbug.com/548965 and http://crbug.com/548964, need to figure out what's going on there before this goes to a larger population.

Only Canary was affected for now and users can recover through uninstall/reinstall (or even potentially just reboot if it's a Windows shell caching issue).

Original issue's description:
> Change shortcut install location to non-subdir.
>
> BUG=169669
>
> Committed: https://crrev.com/c5bab94fdde60b2bc9ed93822f35c5ce50202d26
> Cr-Commit-Position: refs/heads/master@{#356371}

TBR=grt@chromium.org,jhawkins@chromium.org,benwells@chromium.org,bcwhite@chromium.org
BUG=169669,548965,548964

Review URL: https://codereview.chromium.org/1405993006

Cr-Commit-Position: refs/heads/master@{#357038}

The registration was lost during refactoring how OOP apps are registered in
MojoShellContext.

BUG=403462
TEST=GN build with 'enable_mojo_media = "utility"' works with HTML5 audio.

Review URL: https://codereview.chromium.org/1425113003

Cr-Commit-Position: refs/heads/master@{#357037}

Cr-Commit-Position: refs/heads/master@{#357036}

In the GN build, chrome_android_core has a dependency on chrome/common
but it wasn't specified; this was causing a config to not get
correctly propagated up and a header file to get miscompiled as a
result.

R=pkotwicz@chromium.org, jam@chromium.org
BUG=547635

Review URL: https://codereview.chromium.org/1407353007

Cr-Commit-Position: refs/heads/master@{#357035}

- Introduces a new scheme "exe" which loads an executable alongside mojo_runner. TODO is some more security checking around this to prevent arbitrary apps from launching executables but since this is implemented in mojo_runner it's not in any production code right now.
- Includes an apptest of a .mojo app that connects to an executable and binds a service provided by it.
- Creates a new child library that makes it easy to bring up a runner controller thread in an arbitrary executable.

R=jam@chromium.org
http://crbug.com/548694

Review URL: https://codereview.chromium.org/1419293003

Cr-Commit-Position: refs/heads/master@{#357034}

SVG <use> can be used to gain access to a UA ShadowRoot, from there you could
then appendChild an input and querySelector across the boundary, or alter the
internals of the ShadowRoot during the SVG <use> cloning process.

This patch introduces a check in the callback queue that makes us drop all
callbacks for elements in UA shadows.

Review URL: https://codereview.chromium.org/1427783004

Cr-Commit-Position: refs/heads/master@{#357033}

This adds PageLoad.Timing2.NavigationToFirstContentfulPaint histogram,
which is the minimum of first text paint and first image paint.

BUG=542943

Review URL: https://codereview.chromium.org/1423263003

Cr-Commit-Position: refs/heads/master@{#357032}

BUG=n/a

Review URL: https://codereview.chromium.org/1420723009

Cr-Commit-Position: refs/heads/master@{#357031}

This change defers application of SVG Web Animations until after we
have sampled all current Web Animations. This allows us to group
InvalidatableInterpolations into PropertyHandle specific animation
stacks and composite them appropriately.

There are no SVGInterpolationTypes implemented yet that support
non-replace composite modes to test the additive pipeline.

BUG=530436

Review URL: https://codereview.chromium.org/1420553004

Cr-Commit-Position: refs/heads/master@{#357030}

A special resize callback is unnecessary because the decoder has access to the GLSurface and can call Resize on that.

Review URL: https://codereview.chromium.org/1420503011

Cr-Commit-Position: refs/heads/master@{#357029}

R=shatch
BUG=549306

Review URL: https://codereview.chromium.org/1427063002

Cr-Commit-Position: refs/heads/master@{#357028}

BUG=519022

Review URL: https://codereview.chromium.org/1417873007

Cr-Commit-Position: refs/heads/master@{#357027}

This patch adds an additional consumeIdent helper function to the new
CSSPropertyParser, which takes a list of CSSValueIDs as a template
argument to accept.

BUG=499780

Review URL: https://codereview.chromium.org/1430603003

Cr-Commit-Position: refs/heads/master@{#357026}

BUG=547958
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1402353013

Cr-Commit-Position: refs/heads/master@{#357025}

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org

Review URL: https://codereview.chromium.org/1424983004

Cr-Commit-Position: refs/heads/master@{#357024}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ad696d95..dce364cc

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1413773008

Cr-Commit-Position: refs/heads/master@{#357023}

  In order to roll GN adf2cc60..e35662dd (r354085:r356963) and pick up
  the following changes:

  784ffb68 Fix GN unittests on windows broken by abs-path change
  987f4a55 [GN] Allow spaces in output names and other substitutions.
  5b6813c0 Make sure abs-path gn labels have separate target_gen_dirs
  1c010e5f Make GN --as=output relative to the root build directory.
  a2d721a9 Handle Mozilla license blocks in the GN header checker.

TBR=brettw@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1406983009

Cr-Commit-Position: refs/heads/master@{#357022}

Move text-shadow/box-shadow properties from
LegacyCSSPropertyParser into CSSPropertyParser.

BUG=499780

Review URL: https://codereview.chromium.org/1419223002

Cr-Commit-Position: refs/heads/master@{#357021}

Fix regression: background artifact for origin glyphs of the '.security-property-unknown' persuasion.

BUG=548973

Review URL: https://codereview.chromium.org/1412093008

Cr-Commit-Position: refs/heads/master@{#357020}

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10427/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/10607/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/3569/steps/telemetry_unittests/logs/stdio

This patch include the original patch + logic to disable unittest on Mac 10.5, 10.6, 10.7.

BUG=369490

Review URL: https://codereview.chromium.org/1425163003

Cr-Commit-Position: refs/heads/master@{#357019}

Load decision is made inside didReceiveAuthenticationChallenge: and
for recoverable errors cached user decision is read from CertPolicyCache.
That method is called for good and bad certs as long as request is not
served from caches. This method allows accepting bad certs.

SSL Interstitial is presented inside didFailProvisionalNavigation: which
is called when top level frame has bad ssl cert and default behavior
was not overridden inside didReceiveAuthenticationChallenge.

CertStatus is evaluated inside didReceiveAuthenticationChallenge and
its status is cached so it can be reused inside
didFailProvisionalNavigation. It is not possible to re-evaluate cert
inside didFailProvisionalNavigation because that callback does not
provide complete cert chain.

BUG=462427

Review URL: https://codereview.chromium.org/1357773002

Cr-Commit-Position: refs/heads/master@{#357018}

This configuration got moved to the chromium_android.py config in the chromium_tests recipe module, since that's where this config seems to be for the chromium.linux Android Tests (dbg) builder.

base_unittests (along with several other unit tests) required --isolate-file-path <isolate-file> to know what to push to the device. We could either revise //testing/scripts/android_gtest_test.py (which is used for exactly one suite on the main Android bots), use gtest_tests and adapt the test generator on the recipe_module side to do what we need it to, or do what the main Android bots do.

We've opted for the latter with this CL & the matching one on the infra side, but I don't have a strong opinion one way or another.

BUG=

Review URL: https://codereview.chromium.org/1405253008

Cr-Commit-Position: refs/heads/master@{#357017}

Currently, a focused input text field in a cross-process subframe
doesn't have a blinking caret as expected.  The root cause of this is
that FrameSelection::scheduleVisualUpdate wasn't working correctly for
frames with WebFrameWidgets.  This CL fixes that by passing in the
local frame root to page->animator().scheduleVisualUpdate().

BUG=530663
TEST=Click on <input> text field in an OOP frame, observe blinking caret.

Review URL: https://codereview.chromium.org/1405373004

Cr-Commit-Position: refs/heads/master@{#357016}

The patch adds Stylus mode to the "lazy" cm-modes. This means the mode
will not be bundled with chrome; instead, it will be loaded from the
cloud if client needs it.

BUG=428657
R=dgozman@chromium.org, dgozman, pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1430753002 .

Cr-Commit-Position: refs/heads/master@{#357015}

iOS throws an exception (which leads to a crash) if didReceiveAuthenticationChallenge:
completion handler is deallocated but never called. Crash was happening
because CertVerifierBlockAdapter did not call its completion handler
if CertVerifierAdapter was destroyed during cert verification (may
happen when Tab is closed during the load).

Changed CertVerifierBlockAdapter to always call its Verify completion
handler by making net::CertVerifier::Request non-cancelable, so each
verification request will complete.

This change does not extend a lifetime of WKWebView (retaining its completion handler
does not retain WKWebView itself).

BUG=541484

Review URL: https://codereview.chromium.org/1392143003

Cr-Commit-Position: refs/heads/master@{#357014}

VC++ up to VS 2015 RTM does not require explicit storage allocation for
static const integers declared in classes. VS 2015 Update 1 requires
these storage definitions in some cases. It's unclear exactly what
cases - simple tests work with and without the explicit storage
allocation.

Many previous versions of VC++ have theoretically *allowed* a
definition to supply storage, but tests on VC++ 2013 show that this
doesn't actually work correctly - it leads to duplicate definition
errors. So, the change is scoped to VS 2015 only.

This changed was landed in the upstream protobuf repo:
https://github.com/google/protobuf/commit/a74e912a8be1274

With this change the chrome target builds with the latest VS 2015.

R=scottmg@chromium.org, pdr@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/1422453005

Cr-Commit-Position: refs/heads/master@{#357013}