GitLab

When the last display is removed, the |primary_display_id| is set to
invalid. In this case, we should return root window of the
|primary_tree_host_for_replace_|.

BUG=718232
Test=tested on local device

Review-Url: https://codereview.chromium.org/2870253006
Cr-Commit-Position: refs/heads/master@{#471172}

unnecessary after https://chromium-review.googlesource.com/c/497271/

BUG=716117

Review-Url: https://codereview.chromium.org/2869053003
Cr-Commit-Position: refs/heads/master@{#471171}

This CL flips `use_once_calback` flag on the Mojo code generator, and
fixes all compile errors after it. After this CL, Mojo interfaces in
//components/autofill starts using base::OnceCallback instead of
base::Callback on its return value handling.

The migration recipe was:
 - Convert pass-by-ref callback objects to pass-by-value.
 - Use std::move() to forward it to other consumer, or to invoke it
   with Callback::Run().
 - Handle wherever copies are required manually.
 - Check if the conversion doesn't change the semantics. As the transfer
   and invocation clobber the callback object, care about use-after-move.
   It's considered safe to consume almost scoped-out callback.

BUG=714018

Review-Url: https://codereview.chromium.org/2869673002
Cr-Commit-Position: refs/heads/master@{#471170}

This bot has been added in https://chromium-review.googlesource.com/c/502573/

Review-Url: https://codereview.chromium.org/2877853002
Cr-Commit-Position: refs/heads/master@{#471169}

It will be used in CWVScrollView.

Review-Url: https://codereview.chromium.org/2868333005
Cr-Commit-Position: refs/heads/master@{#471168}

When we find the id for the internal display it gets set and
Display::HasInternalDisplay() returns true. The internal display id
isn't reset, even when an internal display is removed. So even though we
might have an internal display id, there is no guarantee there is a
RootWindow for it.

BUG=721452
TEST=local device

Review-Url: https://codereview.chromium.org/2875123002
Cr-Commit-Position: refs/heads/master@{#471167}

BUG=349871
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2854263006
Cr-Commit-Position: refs/heads/master@{#471166}

 * Store the toolchain prefix in metadata
 * Resolve toolchain path when found from $PATH
 * Pass --prefix and --prefix-strip to objdump

Also:
WhereBiggerThan() -> WhereSizeBiggerThan() + WherePssBiggerThan()

BUG=695182

Review-Url: https://codereview.chromium.org/2881563003
Cr-Commit-Position: refs/heads/master@{#471165}

change ElementAnimtaions to take KeyframeAnimationOptions as arg.

See https://w3c.github.io/web-animations/#dictdef-keyframeanimationoptions

NOTE: this IDL change doesn't affect out shipping behaviour, and has low compatibility risk. Hence there is no need for an intent-to-ship notification.

Blink currently deviates from the spec in that the "id" field should be
in KeyframeAnimationOptions instead of KeyframeEffectOptions. Interface
Element should also take KeyframeAnimationOptions as arg. This cl
contains the following changes
- Add a new KeyframeAnimationOptions interface.
- Move "id" from KeyframeEffectOptions to KeyframeAnimationOptions.
- Change ElementAnimations to take KeyframeAnimationOptions as arg.
- Updates TimingInput to support KeyframeAnimationOptions.
- Add unit tests for TimingInput to cover KeyframeAnimationOptions.

BUG=700267

Review-Url: https://codereview.chromium.org/2875673005
Cr-Commit-Position: refs/heads/master@{#471164}

R=dgrogan@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2878723003
Cr-Commit-Position: refs/heads/master@{#471163}

This was released a long time ago. Removing flag to clear clutter.

BUG=338334

Review-Url: https://codereview.chromium.org/2875153002
Cr-Commit-Position: refs/heads/master@{#471162}

Inline the one internal reference in LayerImpl.

BUG=709137
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2882543002
Cr-Commit-Position: refs/heads/master@{#471161}

BUG=718386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2873823002
Cr-Commit-Position: refs/heads/master@{#471160}

Replacing eventSender by pointerActionSequence is not trivial. The deprecation
message should be a warning, so that CLs with eventSender can be at least
uploaded for reference or discussion purposes.

BUG=n/a

Review-Url: https://codereview.chromium.org/2872133011
Cr-Commit-Position: refs/heads/master@{#471159}

For an absolute positioned element, if its containing block is the body
it's not supposed to move as scroll. However, on low dpi devices, it
doesn't get composited if its ancestor is isolated composited therefore
it moves unexpectedly.

BUG=719533
TEST=third_party/WebKit/LayoutTests/compositing/overflow/absolute-element-in-isolated-composited-ancestor.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2869813002
Cr-Commit-Position: refs/heads/master@{#471158}

Move "Field is required" to content of editors
Change Cancel button in editors to "Cancel Payment"

BUG=718548

Review-Url: https://codereview.chromium.org/2882463002
Cr-Commit-Position: refs/heads/master@{#471157}

BUG=718925

Review-Url: https://codereview.chromium.org/2865963003
Cr-Commit-Position: refs/heads/master@{#471156}

Order of operations might matter, so tighten that up.

BUG=NONE

Review-Url: https://codereview.chromium.org/2879633003
Cr-Commit-Position: refs/heads/master@{#471155}

BUG=712895

Review-Url: https://codereview.chromium.org/2872813003
Cr-Commit-Position: refs/heads/master@{#471154}

https://skia.googlesource.com/skia.git/+log/ec8f8b064340..e6c210ae0113

$ git log ec8f8b064..e6c210ae0 --date=short --no-merges --format='%ad %ae %s'
2017-05-11 msarett Fix Ubuntu-Clang-x86_64-Release-Mini
2017-05-11 jvanverth Classify spot shadows for general shapes
2017-05-11 herb Evenly space gradient stage.
2017-05-11 mtklein proposed: inclusive gradients, exclusive images
2017-05-11 mtklein spin off: always clamp linear gradients
2017-05-11 robertphillips Setup for another attempt to split up opLists

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I304771b32863a9f92d229f45f06ddb0f432d79ea
Reviewed-on: https://chromium-review.googlesource.com/503494Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471153}

This CL adds a README.md to modules/imagecapture;
it gathers some links and also addresses some points
that were not evident, as gathered from the experiences
of fbeaufort@.

BUG=655107

Review-Url: https://codereview.chromium.org/2866593002
Cr-Commit-Position: refs/heads/master@{#471152}

Just a small cleanup.

BUG=635619

Review-Url: https://codereview.chromium.org/2870253002
Cr-Commit-Position: refs/heads/master@{#471151}

For testing protected content we need to bypass the prompt
for permission to play protected content. This change add the
switch --unsafely-allow-protected-media-identifier-for-domain
which will disable the info bar when protected content needs
permission when playing from localhost.

BUG=718608

Review-Url: https://codereview.chromium.org/2816773002
Cr-Commit-Position: refs/heads/master@{#471150}

Currently we use an InMemoryStore for the FeatureEngagementTracker,
which doesn't persist feature Events beyond the scope of the application
lifetime.  However once we move beyond demo mode, the feature engagement
conditions will span months, so we need to track the data for longer
than a single session.

This CL implements the Store interface and backs it with a
leveldb_proto::ProtoDatabase.

BUG=706309

Review-Url: https://codereview.chromium.org/2876633002
Cr-Commit-Position: refs/heads/master@{#471149}

GetNode, IsAXInlineTextBox, Detach.
These will most likely be needed for adding SetSelection support to this class.
R=dmazzoni@chromium.org, cbiesinger@chromium.org

Review-Url: https://codereview.chromium.org/2855043003
Cr-Commit-Position: refs/heads/master@{#471148}

BUG=576197
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2878513002
Cr-Commit-Position: refs/heads/master@{#471147}

This change improves the logic for deciding whether to track a subframe nav.

1. only track if the nav's main frame matches the main frame of the currently
   committed load in the web contents
2. otherwise, always return early, since we don't want to run any of the
   subsequent MWCO::DidFinishNavigation logic on subframes.

BUG=721526

Review-Url: https://codereview.chromium.org/2876793004
Cr-Commit-Position: refs/heads/master@{#471146}

This removes the ConnectionParams constructor which implies
TransportProtocol::kLegacy and updates all callers to specify the
protocl explicitly.

No functional change, so TBRing.

BUG=696031
TBR=jam@chromium.org
TBR=jcivelli@chromium.org

Change-Id: Ifb02e7b49eabefa94b1cf29388ea728dd5962177
Reviewed-on: https://chromium-review.googlesource.com/503610Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471145}

This will (1) make render tests perform pixel-wise
comparison and generate diff images, (2) allow you
to specify output directory for where to dump the
result images on the device, and (3) upload the results
to be visible from buildbot status page.

Review-Url: https://codereview.chromium.org/2866103002
Cr-Commit-Position: refs/heads/master@{#471144}

The DelayedPersistentAllocation added an atomic field to the
PersistentHistogramData structure that cannot be copied using
operator= (at least not without redefining it).  Copies of only
some of the fields are needed so explicitly copy only those; the
atomic field is not one of them.

BUG=721352

Review-Url: https://codereview.chromium.org/2875643004
Cr-Commit-Position: refs/heads/master@{#471143}

The C-style comments were confusing a regex.
No behavior change.

BUG=675877

Review-Url: https://codereview.chromium.org/2872133004
Cr-Commit-Position: refs/heads/master@{#471142}

Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB
devices may only support the GET_URL request used for reading the
landing page from the device. This patch fixes the descriptor reading
logic so that this is supported.

(Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed
entirely as part of issue 711443.)

BUG=721546

Review-Url: https://codereview.chromium.org/2876463008
Cr-Commit-Position: refs/heads/master@{#471141}

They all had the same underlying cause: we were firing accessibility events
based on changes to the accessibility tree, but before we had finished
making changes to BrowserAccessibilityWin. To fix this, queue up events
caused by tree changes and fire them after the tree is loaded.

We should probably use this technique more in the future. For now this
just re-enables some good tests.

BUG=719030

Review-Url: https://codereview.chromium.org/2857743006
Cr-Commit-Position: refs/heads/master@{#471140}

This allows flywheel to know when it's safe to switch resources.

BUG=504194

Review-Url: https://codereview.chromium.org/2842763003
Cr-Commit-Position: refs/heads/master@{#471139}

The memory-exhaustion loop could cause DbgHelp's SymFromAddr() to hang
in certain build configs (32-bit Windows Clang debug builds), causing
MetricsServiceBrowserTest.OOMRenderers to hang while generating the
backtrace after the OOM exception. Reducing the allocation size seems to
help.

BUG=692564
TBR=jochen

Review-Url: https://codereview.chromium.org/2882513003
Cr-Commit-Position: refs/heads/master@{#471138}

BUG=705331

Review-Url: https://codereview.chromium.org/2867683002
Cr-Commit-Position: refs/heads/master@{#471137}

The code guarded by it hasn't been compiling for a while, and this
code was added over 5 years ago. It probably isn't used any longer.

BUG=675877

Review-Url: https://codereview.chromium.org/2869953003
Cr-Commit-Position: refs/heads/master@{#471136}

This CL implements the viewport fling animation for iOS client. This
re-impements Android client's FlingAnimationJob and impements a simplified
version of Android's Scroller in C++.

BUG=714193

Review-Url: https://codereview.chromium.org/2869723007
Cr-Commit-Position: refs/heads/master@{#471135}

To correctly paint a float from LayoutNG we need to know the BFC offset
of the container to which we are attaching this float. It's used to
calculate {@code left_offset}, {@code top_offset}.
In most situations {@code (left|top)_offset} equals to float's logical
offset except the cases where a float needs to be re-attached to a non-zero
height parent.
Example:
  <body>
    <p style="height: 60px">Example</p>
    <div id="zero-height-div"><float></div>
Here the float's logical offset is 0 relative to its #zero-height-div
parent. Because of the "zero height" div this float is re-attached to the
1st non-empty parent => body. To paint this float correctly we provide the
modified {@code (top|left)_offset} which is relative to the float's new
parent.
I.e. for our example {@code top_offset} == #zero-height-div's BFC offset
                     - body's BFC offset + float's logical offset

BUG=635619
TESTS=Fixes 8 tests in CSS2/floats-clear, 1 in CSS2/floats,
1 in CSS2/positioning, 2 in fast/block/margin-collapse,
2 in fast/block/float. Total: 14

Review-Url: https://codereview.chromium.org/2850893003
Cr-Commit-Position: refs/heads/master@{#471134}

See https://html.spec.whatwg.org/multipage/infrastructure.html#safe-passing-of-structured-data

And the web platform test here:
https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history.html

BUG=chromium:718193

Review-Url: https://codereview.chromium.org/2857303003
Cr-Commit-Position: refs/heads/master@{#471133}