- 02 Dec, 2019 40 commits
-
-
Sorin Jianu authored
These virtual functions were used by the ActionRunner, which has been refactored in CL 1929863. Bug: 1027395 Change-Id: I43091b984fc28555234fdbe11366ea91c225a7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931383 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#720587}
-
Evan Stade authored
This is a reland of e38327e1 FindIt automatically reverted this CL but it looks like a false positive Original change's description: > Spellcheck cleanups > > Introduce a build flag for the remote spelling service, and stop > compiling/instantiating SpellingServiceClient on platforms that > don't use it (Android). Also try to reduce the number of platform > ifdefs in spellcheck code, in favor of buildflag usage. Reduce > the amount of code that's compiled but never used by removing > several SpellCheckHostImpl methods on mac/win. > > Also remove a couple of obsolete includes. > > Change-Id: I5697a5d3f891f69159d5bba855ee72e11a3ca8be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927412 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Bo <boliu@chromium.org> > Auto-Submit: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718338} TBR=boliu@chromium.org,rouslan@chromium.org Change-Id: Iffed71cfbe5d512db1a054364598445b00672a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946825Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#720586}
-
Richard Knoll authored
All sharing features for selected text should be in the same group. They should also be below the entry for "Copy" as that is a more frequently used option. Screenshots of the effects: https://imgur.com/a/TInzym5 Bug: 1028981,1009998,1028995 Change-Id: I9f06a4e90c1d4bc18d8e3820ecf8e47dde40777e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940267Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720585}
-
Lambros Lambrou authored
The native-messaging host does a permission-check by launching a child process. This CL ensures that the child is launched with stdin/stdout redirected to dev/null, since they are used by the native-messaging host to communicate with the website. The native-messaging host actually duplicates the file-descriptors for stdin/stdout, and uses these FDs instead of the original. It also unfortunately closes the original FDs. Whenever stdout is closed, LaunchProcess cannot launch any child process. This CL addresses this problem by manually redirecting stdout. A future CL will fix the native-messaging host so that it does not close FDs 0 and 1, which could potentially lead to unexpected behavior. Bug: 1029858 Change-Id: I7d626e9e4817159ec955b66d2338c07a73c9549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946827 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#720584}
-
Daniel Murphy authored
This reverts commit 3b866120. Reason for revert: Causing failures with webrtc.RTCPeerConnectionAccelUsed.dec_vp8 Bug: 1029856 Original change's description: > media/gpu/v4l2: abstract request logic in V4L2 framework > > Currently, the request creation and submission logic are handled > inside the decoder's backend. > This patch moves the request handling inside the V4L2 framework and > provides new classes to abstract the request creation and submission. > > BUG=chromium:1009921 > TEST=tast video.DecodeAccelVD.h264* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelVD.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.vp8* on veyron_minnie-kernelnext > TEST=tast video.DecodeAccelPerf.h264* on veyron_minnie-kernelnext > > Signed-off-by: Francois Buergisser <fbuergisser@chromium.org> > Change-Id: Idacff87aa4324c26b287ce2617398c51dee2721a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918794 > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720402} TBR=acourbot@chromium.org,fbuergisser@chromium.org Change-Id: I2b418ec4d718b81f7bc74f254c82e4772fc9f280 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1009921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946923Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720583}
-
James Cook authored
The SplitSettingsSync feature makes it possible to independently sync Chrome apps (via browser sync) and ARC apps (via OS sync). The app list data model and UI code can handle references to missing apps (for example, on Chromebooks that don't support ARC++ the app list data model may have references to ARC++ apps from sync, but the UI gracefully hides them). I initially tied the APP_LIST data type to OS apps. However, the user can end up in an odd state if we sync Chrome apps without syncing the app list metadata. For example, a user could disable OS sync, enable browser sync, install some Chrome apps, move them around in the app list, set up a new Chromebook, then discover that the apps are in the wrong order or are not pinned to the shelf. Ensure we sync the metadata if either browser apps or OS apps are being synced. Bug: 1013466 Test: added to sync_integration_tests Change-Id: Iddc13a978bb84259fadf91fe5fd9454606ba650d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931098 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720582}
-
Kalvin Lee authored
This change modifies the PpdProvider class to follow the conventions required by the presubmit checks. The changes are trivial and will cause no behavioral changes. They pave the way to moving the implementation of this class into a "deprecated" source file. Bug: 1025995 Change-Id: I6bb71439e519a7a71c7e8f87639b6f4719b3be96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935046Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#720581}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37c0baa6b7b4..33ae3e65534f Created with: gclient setdep -r src-internal@33ae3e65534f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1017165 Tbr: jbudorick@google.com Change-Id: I52f2c289b43652a825642252aa522357f82e4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946441Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720580}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8adeb1cc5a26..ebec004c878f git log 8adeb1cc5a26..ebec004c878f --date=short --first-parent --format='%ad %ae %s' 2019-12-02 eseckler@chromium.org telemetry: Increase timeout for trace collection further. Created with: gclient setdep -r src/third_party/catapult@ebec004c878f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029465 Tbr: nuskos@google.com Change-Id: Id7f91a9834300166f598193b0209535f6b623e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720579}
-
Kalvin Lee authored
This change modifies the CUPS IPP backend to suppress papers whose vendor IDs are not meant for users' eyes - i.e. the "custom_min" and "custom_max" sizes that CUPS incidentally exposes. Bug: 1026938 Change-Id: I047844030e7f7a161bda32755754494567e7734c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935173Reviewed-by:
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=garykac@chromium.org Bug: 891670 Change-Id: I4de41d7e941a5977044a774884acd3795959c50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945168 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#720577}
-
Julie Jeongeun Kim authored
This CL cleans up |socket| and |client_request| unused variables from P2PSocketTcpServerTest. Bug: 955171 Change-Id: Ic71452734f08090e2954cd1ad07354c422bcdf08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942686 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720576}
-
Elly Fong-Jones authored
This test does not work as written on Mac. This dialog's default button is Cancel, but on Mac the cancel button is never allowed to have initial focus, so this dialog does not start with any element keyboard-focused on Mac. To fix this, advance focus once before checking for focus. We did not notice that this test is broken because of issue 899286. Bug: 1028239 Change-Id: I174be7583760f2875bc9e586c8682167feae806d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944284 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#720575}
-
Chris Mumford authored
There are two CrossThreadFunction implementations, one that accepts a base::OnceCallback, and another that accepts a base::Callback (which is implicitly repeating). This change switches to explicitly using base::RepeatingCallback to eliminate the use of base::Callback. Also, renaming ConvertToBaseCallback to ConvertToBaseRepeatingCallback for symmetry with CrossThreadBindRepeating and base::RepeatingCallback. Bug: 1007835 Change-Id: I0b0a231bf74259194a78af9870960dbba0cc1f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919941 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#720574}
-
Mikhail Khokhlov authored
We have two different functions that call trace_processor in two different modules. This CL factors them out to a single module so that it was easier to reuse them in Results Processor. Bug: 990304 Change-Id: I1c94b0d48e520841b5c6e8bed08dec07138f02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939806 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#720573}
-
Nektarios Paisios authored
Imagine the following scenario: 1. An embedded object, e.g. a link, spans multiple lines. 2. There is some text before and after the embedded object. "Before <embedded_object> after". In IA2 and ATK, embedded objects are represented by an embedded object character in their parent's text. Calling IAccessibleText::get_textAtOffset, or an equivalent API, and trying to determine the bounds of the current line should return an offset range that includes the embedded object character, both when the call is made somewhere inside the text "Before" as well as when the call is made somewhere inside the text "after". This is necessary in order to signal to ATs that the embedded object starts somewhere inside the first line and also that it ends somewhere inside the last line. Otherwise, ATs Jaws and NVDA read only part of the last line when moving by line. R=aleventhal@chromium.org, dmazzoni@chromium.org Change-Id: I6f141e4fff5f60c05edbf80ff3f19ba920be7c31 Bug: 1028301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934312 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720572}
-
Garrett Beaty authored
Expected capacity requirements: * luci.chromium.ci * 0.66 x (builderless:1, cores:8, cpu:x86-64, os:Ubuntu-16.04, ssd:0) * chromium.tests * 1.44 x (device_os:KTU84P, os:Android, device_type:Nexus 5 (hammerhead)) * 20.32 x (device_os:MMB29Q, os:Android, device_type:Nexus 5x (bullhead)) Capacity requirements are supported by the current headroom. Bug: 1024641 Change-Id: I5ba96d029af33581cf38124feac22a88e5a1c09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929265Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#720571}
-
Daniel Murphy authored
This reverts commit f21f4c91. Reason for revert: Seems to be causing SingleClientStandaloneTransportSyncTest.HandlesResetFromDashboardWhenSyncActive to fail Bug: 1029869 Original change's description: > [signin] Don't clear unconsented primary account on cancelling Sync dialog > > The unconsented primary account doesn't necessarily change when the Sync > confirmation dialog is cancelled. > In particular this is the case when PrimaryAccountMutator::ClearPrimaryAccount > is called with RemoveAccountOptions::kKeepAll. > > This CL stops resetting the unconsented primary account as part of the signout > process. > The unconsented primary account is recomputed anyway when GoogleSignedOut is > called. > > > Fixed: 1029701 > Change-Id: Id46bb468952efe63170a13872519fcaded076cb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944862 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Monica Basta <msalama@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720502} TBR=droger@chromium.org,msalama@chromium.org Change-Id: I0632406070243902295db9f9e482f161df6e65ce No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946194Reviewed-by:
-
Jasper Chapman-Black authored
* Use WebAssembly backend for .sizediff * Fix bug where an empty .sizediff included all before/after symbols. * When displaying diff status, handle case where tree node has no children (I think this case only occurs when loading an empty diff). Change-Id: Ibb9aa309dacc87d92f2166922350a235297d85f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945361Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720569}
-
Kevin Ellis authored
Per spec, a microtask checkpoint should fire after the updates. Currently, the microtask checkpoint is firing later in the document lifecycle. For now, we need to force the update to finish synchronously in order to prevent potential rendering glitches due to a late finish. Bug: 1029695, 1029567 Change-Id: I1f6a67a81c2a068ba98e4464e2072963ec324b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946528 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720568}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8784a9284f65..19f9f4148196 git log 8784a9284f65..19f9f4148196 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 xinyi.he@arm.com Vulkan: Textures incorrect on Android maps with Vulkan Backend Created with: gclient setdep -r src/third_party/angle@19f9f4148196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I39706e18be0de0d34a424ffc1bba2cacd5d0196b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946433Reviewed-by:
-
Nate Chapin authored
There's no reason to keep separate DOMTimerCoordinator objects for different ExecutionContext subclasses. Just have one on ExecutionContext, and DCHECK that it's not used in contexts where timers should not exist. Also, remove DOMTimer::TimerTaskRunner(). It appears to be duplicated. Bug: 1029822 Change-Id: I87782d486997400b0bede0f8e52f343296c1a152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937130 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720566}
-
Daniel Murphy authored
See go/chrome-storage-dashboard R=mpearson@chromium.org Bug: 1021738 Change-Id: Id255b4124a426ac67a99e710bbb951d3e82dda68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927001Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#720565}
-
Daniel Murphy authored
R=rbpotter@chromium.org Bug: 1008122 Change-Id: I32be6eb85be6ae221f477cedf3a83dd9a4562d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945922Reviewed-by:
-
Istiaque Ahmed authored
We switched to using OnMessage::kEventName at some point but forgot to remove the unused definition. Bug: None Change-Id: I6c03968487bcf615564d9796736f5ce81f03ba9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930686 Auto-Submit: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720563}
-
Elly Fong-Jones authored
This test is already disabled as flaky on Windows & Linux; it appears to flakily time out on Mac (quite often actually) as well. Bug: 1014229, 1028239 Change-Id: I278543f670e5723ecb0428d09863367bbf8c772e Tbr: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946824Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720562}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGImageElement> and DynamicTo<SVGImageElement> as new downcast helper 2. Use IsA<SVGImageElement>(element) in place of IsSVGImageElement(element) Bug: 891908 Change-Id: I81b15e047f79e18df4bc2816caecaa92990f3b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936607 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720561}
-
Nicolás Peña Moreno authored
The ClusterFuzz testcase implies that the DCHECK is incorrect, so replace with an actual boundary check. Bug: 1027948 Change-Id: I4f9a26fbe37a76f1786554dfa942285723e6e3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945360 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#720560}
-
Yun Liu authored
Change-Id: I136d3d955059e9bd602bbedac7e5c6cd8b598424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918719Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#720559}
-
Alison Maher authored
Set the NewSystemColors flag to stable and update test expectations. Spec: https://drafts.csswg.org/css-color-4/#css-system-colors Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zv6k2X7Wr1M Bug: 1015968 Change-Id: I754cf7daefe4a61cc76c4b074aa0641c56c92904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931268Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#720558}
-
Peter Kasting authored
This should be non-null because this function is only called during painting, when there should always be a widget. The behavioral effect is that the location bar border color should better reflect the theme toolbar color for popup windows. I believe when this code was originally written, popup windows were not themed, so this wasn't necessary. Bug: none Change-Id: Ie4b33531cae28ce9a72c7571ebb579345fef83d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941189 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
David Benjamin authored
This dates to http://codereview.chromium.org/2870062 as a workaround for std::map::operator[] creating the key if missing. Use the helper function. Bug: none Change-Id: I92b21fd0f7834f8aee5560d080971fa576cc9d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941007Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#720556}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d523ce04e70a..b97a24a009a1 git log d523ce04e70a..b97a24a009a1 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 reed@google.com Revert "fix sense of ifdef for deprecated method" 2019-12-02 reed@google.com fix sense of ifdef for deprecated method Created with: gclient setdep -r src/third_party/skia@b97a24a009a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: Idb6c806872695535ed31e697afe9dee6fa938a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946434Reviewed-by:
-
Ioana Pandele authored
The bold spans are no longer used for any of the dialogs. Bug: 1029828 Change-Id: I4dbf79c2900a629e1e3424151e4e2a0bd5d7a583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882317Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#720554}
-
Varun Khaneja authored
Change-Id: I5901b42fce94a3ec71f67ed101dcc5053cdbc98f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944946Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#720553}
-
Nikita Podguzov authored
* Change structure of the policy information propagated there. This allows to add further printing policies easier. * Fix printing.print_header_footer pref description. * Restructure Print Preview policy tests. Bug: 994786 Change-Id: Ie70238205980bbf1eb81ae66c0be78812f798b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928787 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#720552}
-
James Cook authored
As part of the SplitSettingsSync project we want to use the browser's first-run sync opt-in flow on Chrome OS. We're trying to align browser sync with Windows/Mac/Linux. PRD in the bug. This CL adds SyncConfirmationUI, SyncConfirmationHandler, an existing unit test and associated dependencies to the build. It also fixes some minor style guide issues in the code. Chrome OS does not use the DICE identity model (it has its own account manager and behaves more like Android/iOS). Some of the dependencies therefore need BUILDFLAG(ENABLE_DICE_SUPPORT) checks. There are no user-visible changes yet. Bug: 1013466 Test: unit_tests Change-Id: I3b1a5c968279ffe48a32e9f6765bc6f6fe975e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917742Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#720551}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=dewittj@chromium.org Bug: 891670 Change-Id: I23c7baa0f9429ba704a6ebfb356542eeb0cc8ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943185 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#720550}
-
Elly Fong-Jones authored
The specific notion of overscroll this test is checking for is only implemented on Aura platforms. Bug: 1028239 Change-Id: Ic40d5d504e463517cd28fc28b3a6d36a7e5fb8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946683Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#720549}
-
Ben Kelly authored
Intent-to-experiment thread with LGTM: https://groups.google.com/a/chromium.org/d/msg/blink-dev/exoGLTG8m-c/5EUdD5zYBQAJ Bug: 1007272 Change-Id: If1ced44cff78c8d957fe5792e47fbe38264b5048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940137Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#720548}
-
