- 28 Mar, 2019 40 commits
-
-
Hans Wennborg authored
We used to have a version number for the plugin in this CMake file, so changing it should cause things to be rebuilt, but that hasn't been the case for some time. As Nico figured out, this way of versioning the plugin was removed in https://codereview.chromium.org/975503002 Bug: 416124 Change-Id: If4808ea8447e1b39435059021657536afb65db35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541238 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#645277}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7b7d2ef..4f260ee2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab17fdcdec28c5c396cd2bafc65af5b99f87c6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543023Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645276}
-
Elly Fong-Jones authored
TBR=avi@chromium.org Bug: None Change-Id: I870b79a125c874212027336343a86a1d5cc83043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541656Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#645275}
-
Gabriel Charette authored
This reverts commit 1e4fa9e1. Reason for revert: root caused fixed by crrev.com/644548 as mentioned @ https://bugs.chromium.org/p/chromium/issues/detail?id=938126#c42 Original change's description: > Disable MediaInternalsAudioLogTest.AudioLogCreateStartStopErrorClose > > Disable the test on Android, Linux and Fuchsia due to flaky. > > Tbr: petewil@chromium.org > Bug: 938812 > Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638226} TBR=zmin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 938812 Change-Id: I68c426318ecab6994fdd9588d32edcc620719dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542038 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#645274}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3993b18795b5..ce584cf1d926 git log 3993b18795b5..ce584cf1d926 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 eladalon@webrtc.org Remove Remb::kFeedbackMessageType 2019-03-28 danilchap@webrtc.org Remove CreateVideoStreamEncoder version that uses GlobalTaskQueueFactory Created with: gclient setdep -r src/third_party/webrtc@ce584cf1d926 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If5e8f46e135b68ba154786556fe9fdfed76c0d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645273}
-
Noel Gordon authored
external/wpt/content-security-policy/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow.html The test flakes timeout-pass on most bots. Update expectations. Tbr: foolip@ No-try: true No-presubmit: true Bug: 945774,626703 Change-Id: Ibc96e4939b264f9dd85def363c4148e3a5b592a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541554Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#645272}
-
Ramin Halavati authored
Seperator addition policy in profile menus was wrongly set in crrev.com/c/1499457 to add the separator only before the first group while the correct behavior is to add it before all groups except the first. Bug: 934689 Change-Id: I5c7a515199c526b259912a67c5ac84e097ac191d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543256 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#645271}
-
Corentin Wallez authored
This reverts commit 3192c3b0. Reason for revert: compile failure on Mac GPU FYI Original change's description: > Add SharedImageRepresentationDawn > > This will allow viewing shared images as Dawn textures, for example so > they can be rendered to via WebGPU. This representation is implemented > for IOSurface-backed shared images. > > Also adds a test to render an IOSurface backed shared image using Dawn, > and reading it back with Skia. > > BUG=chromium:938895 > > Change-Id: If64ea4a67368687ff54326bdb20094f17902ad2c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511419 > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644717} TBR=vmiura@chromium.org,cwallez@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:938895 Change-Id: I951280b86bbd706f6fc75c46ab180013b9f6ff81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543253Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#645270}
-
Gauthier Ambard authored
This CL moves the SideSwipeGestureRecognizer to the folder containing the rest of the SideSwipe code. Bug: 944008 Change-Id: I5d3019fa97afdfa85596992eadeed6702aea1613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543250 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#645269}
-
Xida Chen authored
This CL is part of a prototype: https://chromium-review.googlesource.com/c/chromium/src/+/1495445 This class dispatches the Paint request that comes from raster worker thread to the worklet thread. Bug: 884698 Change-Id: Ieefa238512110ba7406e6bcf220fc2af300695fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529113Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#645268}
-
Stephen McGruer authored
This hooks up Blink Paint to cc, by passing a PaintWorkletInput via a DeferredImage and then into a cc::PaintImage. See the design doc for details: https://docs.google.com/document/d/1xg0_A-R9Zfq90csleXUGsr7zi576cg-ELHKkvzOYeJ8/edit#heading=h.2zu1g67jbavu Bug: 884698, 890761, 933805 Change-Id: I2408a036dfa80a8127ab09dc5f2f5e64ecd9a9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525160Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#645267}
-
Olivier Robin authored
iOS does not support component build so we need to add an exception for this platform. Bots did not fail because they compile with symbol_level=1. Bug: 945515 Change-Id: Idae7de4933f4ad4647a0598074145173e8e001c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541784 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#645266}
-
Sylvain Defresne authored
Bug: none Change-Id: If6dede556bce74e9bf650d62dfa1c7d64a15102a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541790 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#645265}
-
Noel Gordon authored
Test crashes sometimes, update expectations. Tbr: findit@ No-try: true No-presubmit: true Bug: 946719 Change-Id: I83fe71181b9f4546f28332f1fd4e5fd3c491d7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543369Reviewed-by:
-
Askar Aitzhan authored
This is needed for ChromeOS to fetch this token and send Update request to Omaha Bug: 932465 Change-Id: I2bb65311e19c3c783f814526b3f0fff5dc841eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538496 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#645263}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8eba309d78ab..2c0fe38105ea git log 8eba309d78ab..2c0fe38105ea --date=short --no-merges --format='%ad %ae %s' 2019-03-28 fmayer@google.com Fix typo in docs. Created with: gclient setdep -r src/third_party/perfetto@2c0fe38105ea The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icc738e8fdbbf5c82fa1b7110ff2ef0db2477c8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542369Reviewed-by:
-
Marc Treib authored
Before this CL, SupervisedUserWhitelistService (accessible via SupervisedUserService::GetWhitelistService() was created in SupervisedUserService::Init(), which runs pretty late in the profile initialization sequence. This means that other KeyedServices which depend on SupervisedUserService might try to access the WhitelistService before it actually exists. This CL moves the creation of the WhitelistService into the constructor of SupervisedUserService. This way, KeyedService dependencies will work as expected. Bug: 946473 Change-Id: Ia674ecee15babfca470debf7429d0903692d0a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543254 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#645261}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ddc9c3a8038..e51181387f76 git log 4ddc9c3a8038..e51181387f76 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 208af3ebda25..e810ad90799c (10 commits) Created with: gclient setdep -r src/third_party/skia@e51181387f76 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Idff028bf363297a4e210e5b4b1e70a2ec2b22baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542370Reviewed-by:
-
Noel Gordon authored
This test is a timeout-pass flake on many bots. Update expections. Tbr: caseq@ No-try: true No-presubmit: true Bug: 946990 Change-Id: Ife803b28f1e6fd755b26eb9708e04682e167242c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542755Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/20574f48b540..3993b18795b5 git log 20574f48b540..3993b18795b5 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 danilchap@webrtc.org Use DefaultTaskQueueFactory in tool network_tester_server 2019-03-28 brandtr@webrtc.org Log when a TargetBitrate XR is sent with layers enabled/disabled. Created with: gclient setdep -r src/third_party/webrtc@3993b18795b5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia81c71c46c6b700cfe7ca4f1792c8dc3887da167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542371Reviewed-by:
-
François Doray authored
This is required to land https://webrtc-review.googlesource.com/c/src/+/128823. Bug: 889029 Change-Id: I0a4bbc71d7e9024ab9538a0c9d78e586dd37335a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538615 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#645257}
-
Karolina Soltys authored
I have added to PostTask a variant of runSynchronously returning a value, analogous to ThreadUtils.runOnUiThreadBlockingNoException -- this is needed to migrate several non-test usages of this function. Bug: 863341 Change-Id: Ie9ca5a44ffb9427df682881300e09d4e3f7b8272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541087Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#645256}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/exported, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Iefe9b0c8975a2719de0a08e4f00f15ef5a8a9b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542751Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b0ea7c9..a7b7d2ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib8997114d64fe19a159ca926bcf74df6de79e382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543020Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab23393d. With Chromium commits locally applied on WPT: 11eae161 "HTMLVideoElement: implement playsinline and auto-fullscreen." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I40dfbb5c88ee915c021bcfe465b089af78472739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543019Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2e35430ab78..a82d8927e675 Created with: gclient setdep -r src-internal@a82d8927e675 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I9844c424321ea6b949a85499ee9348ba1d3af3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543118Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Joanmarie Diggs authored
* kAlertDialog should be exposed as ATK_ROLE_DIALOG; not ATK_ROLE_ALERT * kDocument and kGraphicsDocument should each be exposed as ATK_ROLE_DOCUMENT_FRAME; not ATK_ROLE_DOCUMENT_WEB Bug: 946680 Change-Id: Ida4ce8a2aa3d0a7d7dd1fbf6efede5d6aa9368e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542091Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#645251}
-
Maksim Moskvitin authored
Bug: 944831 Change-Id: Ifdba1bfc5e1e3a4f8e4eceb67586c73e53081d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539701 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3ae979ecd92..20574f48b540 git log b3ae979ecd92..20574f48b540 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 mbonadei@webrtc.org Testing no /DUNICODE assumptions with Win more configs bots. 2019-03-28 mbonadei@webrtc.org Prefix AUDIO_DEVICE_INCLUDE_ANDROID_AAUDIO with WEBRTC_. Created with: gclient setdep -r src/third_party/webrtc@20574f48b540 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I926c05ceebe7e373f1dbea139d56d94fc5b0e7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543117Reviewed-by:
-
Stephane Zermatten authored
WebController ownership of its helpers. This change adds a helper to WebController for FindElement, similar to ElementPositionGetter. It also generalizes ownership of these two kinds of helpers, by keeping them in a map, so owned directly by the WebController instance. This change: - prepares the way for upcoming changes for WebController::FindElement. - simplifies ownership of ElementPositionGetter in WebController - possibly fix bugs in delete order, that we currently work around by waiting for actions to finish before deleting the controller - is a pure refactoring without behavior change Bug: b/129254215,b/129113367,b/128300038 Change-Id: Ib328cde766ffc669953b437e27898bb5cd543111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538091 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#645248}
-
Miyoung Shin authored
- long -> int32_t considering that WebIDL long type is signed 32 bits. - no logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I7621e803acc30058351b168a05f7db5dcf127a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539331Reviewed-by:
-
Miyoung Shin authored
- long -> int32_t - Change the internal function name. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I8c4a9f32744bfe45778122aa6175cefb2c1d96c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540900 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: Ia17a73c8cd5586330c0bf31c9cfe1d65dcde0678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537112Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#645245}
-
Friedrich Horschig authored
By moving components into designated folders, package private visibility becomes more meaningful. This is also an intermediate step to move all of these components into a separate feature. Ideally, all of the *_component packages will provide the coordinator as sole public class. This step shouldn't change any behavior, as well the next steps: - Splitting the metrics recorder - Making all views, binders, mediators and properties package-private Bug: 945314 Change-Id: I478f360c7203f098c504125e54630395ac1b9007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539041 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#645244}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3240800a9487..4ddc9c3a8038 git log 3240800a9487..4ddc9c3a8038 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 57e05b8be2d9..94f195b18776 (1 commits) Created with: gclient setdep -r src/third_party/skia@4ddc9c3a8038 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id0d94b31db9bc6c0a8b2742d99305a31388c62fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542968Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d6a48a188c6..aab7e3179a01 git log 6d6a48a188c6..aab7e3179a01 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 crouleau@chromium.org [Telemetry] Only print detailed browser into for first test run. Created with: gclient setdep -r src/third_party/catapult@aab7e3179a01 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:943650 TBR=simonhatch@chromium.org Change-Id: If0cc620e3545967e9bc9d4de85e9ed6ab5314ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542967Reviewed-by:
-
Jinho Bang authored
According to the spec[1], if request.[[state]] is not "interactive", updateWith() should throw an "InvalidStateError". But before this patch, it doesn't. This patch fixes the problem as follows: - Replace PaymentUpdater with PaymentRequestDelegate - Remove inheritance of PaymentUpdater in PaymentRequestUpdateEvent. - Added IsInteractive() to PaymentRequest to check whether request.[[state]] is interactive or not. Manual test: wpt/payment-request/PaymentRequestUpdateEvent/updateWith-state-checks-manual.https.html Bug: 942308 Change-Id: I1a9e69ad045c95256aae06f299712d1d9c0081d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532123 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#645241}
-
Thomas Tangl authored
...by increasing the horizontal margin. Screenshot before: https://drive.google.com/file/d/1vQ9YH-bHpjrgAmXKWUDrQlu2XSDeWkit/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1kwGgh1lEBx8jBgwjLx_2qQkDMnB0aE_v/view?usp=sharing Bug: 939737 Change-Id: I403429d0248f381a33dc9e0787c4cf4c3f284c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541782 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#645240}
-
Jonas Olsson authored
Bug: 941413 Change-Id: I9987a8ce31151310104bb7b37a884cdcfeb81671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520833Reviewed-by:
-
Ivan Sandrk authored
Bug: 578342 Change-Id: I54b346798ff8e295938430058fc92b694c3dedc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541159 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
