- 07 Jul, 2011 40 commits
-
-
sjl@chromium.org authored
This CL contains the new asserts for the media controls. I'll remove the old stuff after the webkit side of the change is in. BUG=88489 TEST=None needed. Purely asset additions. Review URL: http://codereview.chromium.org/7278037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91771 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
TEST=try bots. BUG=87210 Review URL: http://codereview.chromium.org/7289049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91770 0039d316-1c4b-4281-b951-d872f2087c98
-
ahendrickson@chromium.org authored
========================= Note: This revert is only temporary, to collect statistics for how frequently this case is encountered in the wild. This will be re-reverted shortly. ========================= Some servers will send a Content-Length which exceeds the number of bytes sent in the message body. Although this violates the RFC spec, other major browsers permit it and treat a download as complete in that case. Chrome did as well prior to M12, and now some users are unable to access the item that they downloaded. Attempt #2. BUG=85549 TEST=Go to server which advertises larger Content-Length than number of bytes sent, confirm that the download is no longer reported as interrupted. Review URL: http://codereview.chromium.org/7237031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91769 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Precede each CBC encrypted application data record with an empty application data record in order to randomize the IV in a backwards compatible manner. (This is a reland of r90632 which was reverted in r90643 because it tickled a bug in remoting unittests.) http://codereview.chromium.org/7239002 BUG=87159 TEST=HTTPS sites continue to work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91768 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=50675 TEST=none Review URL: http://codereview.chromium.org/7316019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91767 0039d316-1c4b-4281-b951-d872f2087c98
-
tburkard@chromium.org authored
R=cbentzel@chromium.org, dominich@chromium.org Review URL: http://codereview.chromium.org/7289020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91765 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
Hide details of window management and continue timers in the DesktopEnvironment class and expose OnConnect, OnLastDisconnect and OnPause methods. Move all host input monitor code into DesktopEnvironment as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/7312019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91764 0039d316-1c4b-4281-b951-d872f2087c98
-
bsalomon@google.com authored
When GL implementation is Mock or None return rather than setting the skia-gpu GL interface with an uninitialized binding. Fixes a -Werror issue. Review URL: http://codereview.chromium.org/7316023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91763 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
patch from issue 7171025 BUG=84721 TEST=Switch tabs...no flicker Review URL: http://codereview.chromium.org/7327002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91762 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
This does not take care of everything! There are many deprecated macros that we can't replace because their accessor replacements were in 2.20 or later. BUG=none TEST=none Review URL: http://codereview.chromium.org/7227027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91761 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
The tooltip is only displayed if the folder label is too wide for button which causes ellipsis to be displayed. Views specific. BUG=83838 TEST=Create a new folder with a long name in the bookmark bar and verifies the tooltip is displayed. Review URL: http://codereview.chromium.org/7277089 TBR=philippe.beaudoin@gmail.com Review URL: http://codereview.chromium.org/7277094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91760 0039d316-1c4b-4281-b951-d872f2087c98
-
philippe.beaudoin@gmail.com authored
The tooltip is only displayed if the folder label is too wide for button which causes ellipsis to be displayed. Views specific. BUG=83838 TEST=Create a new folder with a long name in the bookmark bar and verifies the tooltip is displayed. Review URL: http://codereview.chromium.org/7277089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91758 0039d316-1c4b-4281-b951-d872f2087c98
-
ihf@chromium.org authored
BUG=87831 TESTS=none Review URL: http://codereview.chromium.org/7237036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91757 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
While initializing the pepper plugin registry in the renderer we load each plugin and attempt to initialize it. If initialization fails for a plugin the code in PluginModule unloads the plugin but still attempts to invoke the shutdown function on an unloaded plugin module. Proposed fix is to initialize the entry points member with the plugin entry points only when initialization succeeds. BUG=none TEST=The renderer should not crash if initializing a pepper plugin fails. Review URL: http://codereview.chromium.org/7277077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91756 0039d316-1c4b-4281-b951-d872f2087c98
-
arthurhsu@chromium.org authored
http://codereview.appspot.com/4627077/ BUG=none TEST=none Review URL: http://codereview.chromium.org/7322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91755 0039d316-1c4b-4281-b951-d872f2087c98
-
jond@google.com authored
Review URL: http://codereview.chromium.org/7227011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91754 0039d316-1c4b-4281-b951-d872f2087c98
-
jond@google.com authored
Review URL: http://codereview.chromium.org/7314007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91753 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=72317 TEST=None R=thakis@chromium.org Review URL: http://codereview.chromium.org/7314017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91752 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=None TEST=None Review URL: http://codereview.chromium.org/7312013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91751 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
1. Elemnt IDs were updated in chroice.html, but not in remoting.js 2. Plugin container must not be hidden, otherwise the plugin doesn't load. BUG=None TEST=IT2Me host works. Review URL: http://codereview.chromium.org/7277088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91750 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
Clean up incorrect guard end comment, and remove unused pp_var.h Review URL: http://codereview.chromium.org/7310007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91749 0039d316-1c4b-4281-b951-d872f2087c98
-
michaelbai@google.com authored
BUG= TEST= Review URL: http://codereview.chromium.org/7238012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98
-
jbates@chromium.org authored
We were synchronously destroying the RendererGlContext transfer buffers while commands may still be pending in the command buffer that use them. This generated spurious kOutOfBounds errors. kOutOfBounds errors cause us to kill the associated GpuChannel. That leads to lots of bad behavior, such as failing to reload certain WebGL demos. This change simply lets the command buffer destroy the shared memory in its destructor instead of destroying them explicitly. The GPU-side resources are cleaned up when the command buffer is destroyed. BUG=88115 TEST=Open NVIDIA Command Buffer Object WebGL demo; Refresh; Verify successful refresh. Review URL: http://codereview.chromium.org/7301010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91747 0039d316-1c4b-4281-b951-d872f2087c98
-
imasaki@google.com authored
Add another test terminate condition in media perf test. This is to catch the video playing error as early as possible (rather than waiting for timeout). This will prevent my script from occupying buildbot. Review URL: http://codereview.chromium.org/7322015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91746 0039d316-1c4b-4281-b951-d872f2087c98
-
shubhojeets@chromium.org authored
BUG=88679 TEST=none Review URL: http://codereview.chromium.org/7314026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91745 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
Previously, we looked at the user gesture state when deciding whether to dismiss infobars. Now that WebKit's user gesture state doesn't lie, we can tell that this behavior is incorrect. Page-specific infobars, like translate, should close whenever the main frame navigates to a new page, regardless of whether that navigation was conducted from a user gesture. BUG=86417 Review URL: http://codereview.chromium.org/7205026 TBR=abarth@chromium.org Review URL: http://codereview.chromium.org/7324001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91744 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@google.com authored
CL that introduced the change: http://codereview.chromium.org/7292010/ Committed r91742 BUG=none TEST=none TBR=apatrick Review URL: http://codereview.chromium.org/7324004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91743 0039d316-1c4b-4281-b951-d872f2087c98
-
vrk@google.com authored
This CL divvies up the GpuVideoService functionality among the relevant classes. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7292010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91742 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
match sharing the same template url. For example, if the results were 'A B C D' with 'A' and 'B' sharing the same provider and 'C' and 'D' sharing the same provider, then 'A' and 'C' would get descriptions. As part of this I'm always setting AutocompleteMatch::template_url (previously we only set it for keywords). BUG=88322 TEST=see bug, also covered by unit tests. R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7321001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91741 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
1 - z-order: make it show on top of the footer 2 - disable uninstall when appropriate 3 - fix appearance of disabled items on linux/gtk (applies to all places menu.js is used) BUG=none TEST=see above Review URL: http://codereview.chromium.org/7227025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91740 0039d316-1c4b-4281-b951-d872f2087c98
-
cmp@chromium.org authored
- mac-release-10.5/morejs/times/t (regression at 89864, investigating) TBR=nsylvain@chromium.org BUG=88687 Review URL: http://codereview.chromium.org/7310034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91739 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Fix crashes in EnterpriseEnrollmentScreenTest.TestCancel. This is independent of any tfarina-induced bustage. BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/7313027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91738 0039d316-1c4b-4281-b951-d872f2087c98
-
lambroslambrou@chromium.org authored
Allow that method to be called without a corresponding call to OnSignalConnected() - the linked bug-report explains how this can happen. This is only a partial bug-fix; still need to address the problem of this method being called on the wrong thread from ChromotingHost::Shutdown(). BUG=83788 TEST=Manual Review URL: http://codereview.chromium.org/7307031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91737 0039d316-1c4b-4281-b951-d872f2087c98
-
miletus@chromium.org authored
Change the type of valuator_lookup_[kMaxDeviceNum][TP_LAST_ENTRY] from "char" to "signed char". -1 is set for valuator_lookup_[][] for invalid entry. Some ARM platform/cross-compiler defaults "char" as "unsigned char" which does not accommodate negative value -1. Fixing it by specifically setting the type to "signed char". BUG= TEST= Review URL: http://codereview.chromium.org/7312028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91736 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
move the rest of the tiles to where they belong when an app is uninstalled BUG=none TEST=uninstall an app that is in the middle of an apps page Review URL: http://codereview.chromium.org/7312016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91735 0039d316-1c4b-4281-b951-d872f2087c98
-
scr@chromium.org authored
R=sky@chromium.org BUG=88532 TEST=browser_tests --gtest_filter=TestWebUIFactory*.* Review URL: http://codereview.chromium.org/7307034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91734 0039d316-1c4b-4281-b951-d872f2087c98
-
sanga@chromium.org authored
Migrating PPB_FileIO_Dev, PPB_FileRef_Dev, and PPB_FileSystem_Dev dependencies to PPB_FileIO, PPB_FileRef, and PPB_FileSystem. Also fixed some lint errors. Review URL: http://codereview.chromium.org/7248047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91733 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91732 0039d316-1c4b-4281-b951-d872f2087c98
-
twiz@google.com authored
New test failure introduced and noted in test_expectations.txt: fast/canvas/canvas-empty-image-pattern.html Also, remove layout test failure markers that were resolved by skia r1810. BUG=88577, 88681 TEST=NONE Review URL: http://codereview.chromium.org/7317002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91731 0039d316-1c4b-4281-b951-d872f2087c98
-
jond@google.com authored
Review URL: http://codereview.chromium.org/7308009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91730 0039d316-1c4b-4281-b951-d872f2087c98
-