GitLab

Review URL: http://codereview.chromium.org/8772069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113358 0039d316-1c4b-4281-b951-d872f2087c98

The stack traces on these have been incorrect for quite some time. Doing logs analysis on mac/linux media_unittests and layout test results also show that these suppressions haven't been used in the last ~200 runs.

BUG=32360,93932,102016
TBR=glider

Review URL: http://codereview.chromium.org/8836004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113357 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104236
TEST=see bug, also chrome.toolkit is available in print preview's JS console.

Review URL: http://codereview.chromium.org/8619009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113356 0039d316-1c4b-4281-b951-d872f2087c98

See the TypedArray spec for reference:
http://www.khronos.org/registry/typedarray/specs/latest/

Things in the spec that I'm omiting:
- slice (Having a view of the ArrayBuffer that has a different offset/length)

TODO in future CLs:
-Implementation for in-process/trusted + tests (almost ready)
-NaCl proxy
-OOP proxy
Later still:
- Support for ArrayBufferView and TypedArray based on that.

BUG=103435
TEST=N/A

Review URL: http://codereview.chromium.org/8502030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113355 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to keep more of our tests running and identify the cases
where they fail, so we can fix them.
Add a comment to chrome_tests.gypi to keep mock header file together with
test_case.html.
BUG=Pepper Code Yellow
TEST=ui_tests, --gtest_filter=PPAPITest.*, OutOfProcessPPAPITest.*, PPAPINaClTest.*
Review URL: http://codereview.chromium.org/8770023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=browser_tests --gtest_filter="DesktopNotificationsTest.*" with use_aura=1 and use_webkit_compositor=1 (in debug), verify no assert.


Review URL: http://codereview.chromium.org/8771057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113353 0039d316-1c4b-4281-b951-d872f2087c98

InterstitialPage implements RenderViewHostDelegate but does
not override GetWebkitPrefs() which in the base class only
returns default settings. For example, this does not allow 
compositing for interstitial pages ever.

BUG=
TEST=


Review URL: http://codereview.chromium.org/8826013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113352 0039d316-1c4b-4281-b951-d872f2087c98

Second in a series of patches to replace ModelType{Bit,}Set with
ModelEnumSet (which will then be renamed to ModelTypeSet).

BUG=79970
TEST=


Review URL: http://codereview.chromium.org/8786014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113351 0039d316-1c4b-4281-b951-d872f2087c98

We never construct a ScrollView object with a null horiz_sb_ 
or vert_sb_ member, and we already dereference horiz_sb_ and 
vert_sb_ without null checking in many places (including the 
destructor), so all the null checks for horiz_sb_ and vert_sb_ 
are unnecessary. 

Original review URL: http://codereview.chromium.org/155980/

R=ben@chromium.org
BUG=17101 
TEST=none

Review URL: http://codereview.chromium.org/8827007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113350 0039d316-1c4b-4281-b951-d872f2087c98

The old name was not appropriate for the type of tests being performed, since they have nothing to
do with policies, and everything to do with enrollment.

Review URL: http://codereview.chromium.org/8823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=none


Review URL: http://codereview.chromium.org/8820012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113348 0039d316-1c4b-4281-b951-d872f2087c98

TEST=ProfileSyncServiceAutofillTest.ServerChangeRace should not crash
BUG=57884

Review URL: http://codereview.chromium.org/8771064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113347 0039d316-1c4b-4281-b951-d872f2087c98

GTK: Remove deprecated GtkThemeSurface::GetSurfaceNamed() calls in browser toolbar. Change to ResourceBundle when appropriate for sharing gfx::Images across profiles

BUG=106060
TEST=none

Review URL: http://codereview.chromium.org/8806026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113346 0039d316-1c4b-4281-b951-d872f2087c98

re-adjusted the padding above the tile grid to have a minimum of 60px rather than 100px, also it scales upwards faster as the page height increases because instead of aligning the middle of the tile grid at 1/3 from the top of the page, we align the 1/3 mark of the tile grid with the 1/3 mark of the page.

the end result is that a browser window <800px tall with 3 rows of apps and a floating bbar still will not have a scrollbar

BUG=101290
TEST=manual


Review URL: http://codereview.chromium.org/8771060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113345 0039d316-1c4b-4281-b951-d872f2087c98

- Provide windows notifictaion of thread termination

Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.

This fallback is ONLY used if there are no notifications
coming via the linker list.  This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.

It is a minimal change, suitable for pushing to other
channels (beta? stable?).

r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8839001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113342 0039d316-1c4b-4281-b951-d872f2087c98

- Save pipelining capabilities for the most used hosts between sessions.

BUG=None
TEST=unit_tests


Review URL: http://codereview.chromium.org/8770035

TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8832003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113341 0039d316-1c4b-4281-b951-d872f2087c98

- Save pipelining capabilities for the most used hosts between sessions.

BUG=None
TEST=unit_tests


Review URL: http://codereview.chromium.org/8770035

TBR=simonjam@chromium.org
Review URL: http://codereview.chromium.org/8833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113338 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=
TBR=tim

Review URL: http://codereview.chromium.org/8820019

TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/8835002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113336 0039d316-1c4b-4281-b951-d872f2087c98

Useful on machines that don't have 2.6 but do have 2.7.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8825016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113334 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92421
TEST=none

Review URL: http://codereview.chromium.org/8817010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113333 0039d316-1c4b-4281-b951-d872f2087c98

Needed to build on 10.5, which is in turn needed for coverity.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113332 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/8553001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103499
TEST=Ran RenderViewImplTest.{OnHandleKeyboardEvent,InsertCharacter}.


Review URL: http://codereview.chromium.org/8801008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106517
TEST=none

Review URL: http://codereview.chromium.org/8825010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113329 0039d316-1c4b-4281-b951-d872f2087c98

The old name was not appropriate for the type of tests being performed, since they have nothing to
do with policies, and everything to do with enrollment.

Review URL: http://codereview.chromium.org/8823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106529
TEST=removed suppressions from mem/heap check tools


Review URL: http://codereview.chromium.org/8819029

TBR=miket@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8801005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106617, 106060
TEST=none


Review URL: http://codereview.chromium.org/8771063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113325 0039d316-1c4b-4281-b951-d872f2087c98

The call that used to do this was made from the predictor, and
was accidentally removed during a predictor refactoring
(http://codereview.chromium.org/7467012/)

BUG=69732
TEST=open incognito window, go somewhere, close the window,
open net-internals, and check that no hints of what was
done during incognito mode remain.

Review URL: http://codereview.chromium.org/8775067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113324 0039d316-1c4b-4281-b951-d872f2087c98

renderer so it knows how to interpret manifests.

BUG=62897
TEST=This is covered by a zillion browser_tests once we make the
manifest_version check slightly tighter.
Review URL: http://codereview.chromium.org/8823017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113323 0039d316-1c4b-4281-b951-d872f2087c98

I should have disabled for chromeos, but not aura.
I probably was confused with other tests I was working on.

BUG=105627
TEST=none


Review URL: http://codereview.chromium.org/8828005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113322 0039d316-1c4b-4281-b951-d872f2087c98

Provide an automatic fallback scan of the linker
list of notifcation callbacks via DllMain.

This fallback is ONLY used if there are no notifications
coming via the linker list.  This allows all existing
code to continue working as it does today, and provides
thread teardown notifcatino on XP even though we use
the LoadLibrary call.

It is a minimal change, suitable for pushing to other
channels (beta? stable?).

r=cpu
BUG=103209
Review URL: http://codereview.chromium.org/8550009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8771065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113320 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to 113090 to see which ModelChangingSyncerCommand triggers
a perf regression.

BUG=97832
TEST=
TBR=tim

Review URL: http://codereview.chromium.org/8820019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=lint from review 8561031
TEST=none; this is a refactoring of existing unit tests.


Review URL: http://codereview.chromium.org/8824010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113318 0039d316-1c4b-4281-b951-d872f2087c98

Create a secondary file thread, FILE_USER_BLOCKING, for tasks requiring file IO which have user waiting for the results. Process appcache background tasks on that thread.

BUG=68894,78359
Review URL: http://codereview.chromium.org/8366020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests


Review URL: http://codereview.chromium.org/8770035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105755
TEST=Verify that visual glitch is gone, see bug for details.
Review URL: http://codereview.chromium.org/8828011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113314 0039d316-1c4b-4281-b951-d872f2087c98

Eighteen is a composite number, its proper divisors being 1, 2, 3, 6 and 9. Three of these divisors (3, 6 and 9) add up to 18, hence 18 is a semiperfect number. Eighteen is the first inverted square-prime of the form p.q2.
It is a heptagonal number, and as the sum of the first three pentagonal numbers, it is a pentagonal pyramidal number. It is also the sum of the totient function for the first seven integers.
Eighteen is the second abundant number with the aliquot sum of 21 (117% in abundance) in the aliquot sequence (18, 21, 11, 1, 0) thus being the first composite number in the 11-aliquot tree. Eighteen is the aliquot sum of only one number the square 289.
In base 10 it is a Harshad number.
18, aside from 0, is the only number that equals twice the sum of its decimal digits.

The atomic number of argon
The 18-electron rule is a rule of thumb in transition metal chemistry for characterising and predicting the stability of metal complexes
The number of years in the Saros cycle of eclipses of the sun and moon

18:00, a time on the 24-hour clock corresponding to 6:00 PM.
A 2005 movie directed by Richard Bell and starring Brendan Fletcher and Alan Cumming.
Bobby Labonte's car number in the NASCAR Winston Cup Series when he won the 2000 Championship. This is J. J. Yeley's car number until the end of the 2007 Nextel Cup Season. Kyle Busch took the car number in 2008.
A 2002 album by electronic artist Moby.
The number of holes in a stipulated round of golf
The number of chapters into which James Joyce's epic novel Ulysses is divided
Russ Wheeler's car number in the film Days of Thunder
A slang term used in association football for the Penalty Area
The number of wheels on the most common type of North American tractor-trailer truck, which are hence often called 18-wheelers
The number of the French department Cher and the Turkish province Bitlis
DVD-18 is double-sided, double-layered DVD format
Android 18, a fictional character in the metaseries Dragon Ball.
The Hindu epic Mahabharata has eighteen sections, involves eighteen armies and is about a war fought over eighteen days
In some countries the number 18 means blood (relative)
In Chinese folklore, the Shaolin temple had a group of 18 bronze Monks. Initiates could only be considered full graduates of Shaolin martial arts if they could defeat them in combat.
In 1990 Megadeth released Hanger 18 as a single for the Rust in Piece Album.
Eighteen Eighteen, a South African Rap artist.
"I'm Eighteen", Alice Cooper's first Top Ten hit single, from their 1971 album Love It to Death.
Eighteen is also a surname, recorded in East Anglia in the 18th century [3]

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113313 0039d316-1c4b-4281-b951-d872f2087c98

After this patch, all the unit_tests should pass.

BUG=62897
TBR=aa
Review URL: http://codereview.chromium.org/8826010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113312 0039d316-1c4b-4281-b951-d872f2087c98