GitLab

This patch updates W3CImportExpectations in order to import
the css-ui-3/ test suite.

40 new tests are imported on the following folder:
imported/csswg-test/css-ui-3/

27 pass and 13 are marked as failure on TestExpectations file.

BUG=669473

Review-Url: https://codereview.chromium.org/2539753002
Cr-Commit-Position: refs/heads/master@{#434986}

iOS doesn't yet have any delegate method that fires when we have
finished loading all the tiles on the NTP. Without that, it's not
possible to reliably output metrics for tile types. Adding this (after
NUM_RECORDED_TILE_TYPES) will let us proceed with the conversion to
metrics::RecordPageImpression() in the meantime.

BUG=669090

Review-Url: https://codereview.chromium.org/2539473002
Cr-Commit-Position: refs/heads/master@{#434985}

https://skia.googlesource.com/skia.git/+log/cb4feeb7dbbe..c51c18fd7837

$ git log cb4feeb7d..c51c18fd7 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 mtklein use fma() in accumulate
2016-11-28 reed don't support converting from alpha to non-alpha
2016-11-28 mtklein SkNx_abi is unused.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2535013003
Cr-Commit-Position: refs/heads/master@{#434984}

Revert of Stub out Skia AVX and HSW opts. (patchset #1 id:1 of https://codereview.chromium.org/2512093003/ )

Reason for revert:
Now that we're guarding against ucrt\math.h in Skia and that's rolled into Chromium, it's as good a time as ever to try turning back on Skia's AVX+ code at head.  (I intend to just leave it stubbed out like this in M56.)

Original issue's description:
> Stub out Skia AVX and HSW opts.
>
> This is hopefully temporary while we mull better options.
>
> BUG=666707
>
> Committed: https://crrev.com/2ea76e2274404af7e53cc4bb5d212b22856ee455
> Cr-Commit-Position: refs/heads/master@{#433407}

TBR=brucedawson@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=666707

Review-Url: https://codereview.chromium.org/2539453003
Cr-Commit-Position: refs/heads/master@{#434983}

including:
 - capturing partial stdout for failed shards
 - removing vestigial fifo support
 - removing on-device results parsing

BUG=646223

Review-Url: https://codereview.chromium.org/2514943002
Cr-Commit-Position: refs/heads/master@{#434982}

[ RUN      ] AutofillManagerTest.CreditCardSavedWhenAutocompleteOff
../../components/autofill/core/browser/autofill_manager_unittest.cc:3695: Failure
Actual function call count doesn't match EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _))...
         Expected: to be called once
	            Actual: never called - unsatisfied and active

BUG=666704
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2540673002
Cr-Commit-Position: refs/heads/master@{#434981}

Removed 8dp padding from the right side of the date label in the system
menu that was left over from non-md.

BUG=669221

Review-Url: https://codereview.chromium.org/2537033002
Cr-Commit-Position: refs/heads/master@{#434980}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2ef8719e..928e6b56

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2537793002
Cr-Commit-Position: refs/heads/master@{#434979}

The LinkLoader code assumes all link preloads will have lowercased
'as' values. This is not the case for preloads coming in via the preload
scanner.

This patch fixes that issue and adds a unit test that reproduces this
failure.

BUG=664744

Review-Url: https://codereview.chromium.org/2496343002
Cr-Commit-Position: refs/heads/master@{#434978}

SharedBuffer::getAsBytes returns false on failure, but XHR, the only caller,
calls it in a situation where it never fails.

BUG=None
R=tyoshino@chromium.org, hiroshige@chromium.org

Review-Url: https://codereview.chromium.org/2530323002
Cr-Commit-Position: refs/heads/master@{#434977}

The above mentioned function used a VisiblePosition to track
|startOfParagraphToMove|, which is wrong as VPs can't persist through
DOM mutations. This patch uses RelocatablePosition instead.

BUG=668765
TEST=webkit_unit_tests --gtest_filter=DeleteSelectionCommandTest.deleteListFromTable

Review-Url: https://codereview.chromium.org/2534783002
Cr-Commit-Position: refs/heads/master@{#434976}

PasswordReuseDetector is class for detecting password reuse. It consumes passwords from PassworStore, builds password index and then it can be used for detecting of password reuse by calling method CheckReuse().

This class is not created anywhere in production code yet. It will be done in next CLs.

BUG=657041

Review-Url: https://codereview.chromium.org/2525593002
Cr-Commit-Position: refs/heads/master@{#434975}

https://skia.googlesource.com/skia.git/+log/99ab92b5958a..cb4feeb7dbbe

$ git log 99ab92b59..cb4feeb7d --date=short --no-merges --format='%ad %ae %s'
2016-11-28 borenet [nobuildbot] Win GCE bots

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2536563004
Cr-Commit-Position: refs/heads/master@{#434974}

BUG=658242

Review-Url: https://codereview.chromium.org/2527383002
Cr-Commit-Position: refs/heads/master@{#434973}

Reland of After detach, there's no document to notify parsing is finished. (patchset #1 id:1 of https://codereview.chromium.org/2538473004/ )

Reason for revert:
Reland, probably innocuous for crbug.com/669435

Original issue's description:
> Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )
>
> Reason for revert:
> Speculative revert for crbug.com/669435
>
> Original issue's description:
> > After detach, there's no document to notify parsing is finished.
> >
> > HTMLViewSourceParser was tripping the DCHECK in
> > DocumentParser::document when it recieved the last bytes of the
> > document it was parsing after it was detached.
> >
> > BUG=664915
> >
> > Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> > Cr-Commit-Position: refs/heads/master@{#434937}
>
> TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664915
>
> Committed: https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129
> Cr-Commit-Position: refs/heads/master@{#434954}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2535233002
Cr-Commit-Position: refs/heads/master@{#434972}

This will lay out multicol containers in one single tall column, without any
support for fragmentation or column balancing.

Also had to disable creation of the anonymous LayoutMultiColumnFlowThread child
of multicol containers, since that's not going to be used in LayoutNG.

The algorithm for calculating the used values of column-width and column-count
can be found here: https://drafts.csswg.org/css-multicol-1/#pseudo-algorithm

Review-Url: https://codereview.chromium.org/2528203002
Cr-Commit-Position: refs/heads/master@{#434971}

[ RUN      ] AutofillManagerTest.UploadCreditCard
../../components/autofill/core/browser/autofill_manager_unittest.cc:4496: Failure
Value of: autofill_manager_->credit_card_was_uploaded()
  Actual: false
  Expected: true

BUG=666704
TBR=mathp@chromium.org

Review-Url: https://codereview.chromium.org/2533253002
Cr-Commit-Position: refs/heads/master@{#434970}

We'll no longer perform inaccurate layout from insertFloatingObject(), but
defer all layout to positionAndLayoutFloat(). We need to do this correctly
everywhere. One crucial thing is also to pay attention to the resulting
pagination strut before the float, if any. There's only one place where we do
this, and that's in positionAndLayoutFloat().

At most call sites, insertFloatingObject() is followed by a call to
placeNewFloats(), which will call positionAndLayoutFloat(). There are
exceptions to this in line layout, though. In some cases we just insert floats
without laying them out and placing them. This happens when we need to figure
out the height of the current line before we can place floats below it. In
order to figure out if a float fits on the current line, though, we first need
to lay it out without marking it as placed.

We lacked some test coverage, so I added
float-pushed-to-next-fragmentainer-by-floats.html . This also passed prior to
this CL, but I nearly broke it while working on this.

BUG=663942

Review-Url: https://codereview.chromium.org/2532573003
Cr-Commit-Position: refs/heads/master@{#434969}

Also type-check that we're dealing with a LayoutBlockFlow before casting.

Review-Url: https://codereview.chromium.org/2527393002
Cr-Commit-Position: refs/heads/master@{#434968}

Add "Add to" to the strings.
Also add olivierrobin as owners of the extensions.

BUG=661920

Review-Url: https://codereview.chromium.org/2540553003
Cr-Commit-Position: refs/heads/master@{#434967}

Currently WebGL2RenderingContext is not yet exposed in worker, which means
calling OffscreenCanvas.getContext('webgl2') fails in a worker.

This CL expose it with ExperimentalCanvasFeatures flag.
The test for this is upstreamed here:
https://github.com/KhronosGroup/WebGL/pull/2159

BUG=668727
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2531853003
Cr-Commit-Position: refs/heads/master@{#434966}

That height may not be uniform throughout the entire fragmentation context
anyway, so it's not reliable to do it like this. For multicol, the value was
only used as a flag (0=unknown height, 1=known height).

Move calculation of available column height to LayoutMultiColumnFlowThread. It
no longer needs to live in LayoutBlockFlow.

Review-Url: https://codereview.chromium.org/2529073002
Cr-Commit-Position: refs/heads/master@{#434965}

This is the same version of Clang, but contains a patched version of
LLVMgold.so to fix the problem of missing RUNPATH.

BUG=668587

Review-Url: https://codereview.chromium.org/2536973002
Cr-Commit-Position: refs/heads/master@{#434964}

The only stats dictionary that was missing was 'data-channel'. For it to
be included data channels had to be created. Added CreateDataChannel to
webrtc_browsertest_base.h/cc and peerconnection.js. Unittest updated to
EXPECT that no expected stats are missing.

Original CL: https://codereview.chromium.org/2527273003/
Reason for revert: A whitelist filter was landed roughly at the same
time as the the original CL, causing expected stats to be blacklisted.
In this re-land, the whitelist is updated.

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2533223003
Cr-Commit-Position: refs/heads/master@{#434963}

Attempt to compensate for some recent changes to DRT output. Also try
to get some more "correct" reference images.

TBR=schenney@chromium.org
NOTRY=true
BUG=639147

Review-Url: https://codereview.chromium.org/2537083003
Cr-Commit-Position: refs/heads/master@{#434962}

This patch changes |Editor::unappliedEditing()| to use |isNone()| predicate
rather than checking |Document| equality of |Position| to simplify source code
for improving code health.

Since |correctVisibleSelection()| always returns |VisibileSlection| which
is an empty or valid for specified |Document|, checking equality of |Document|
between selection start and |frame.document()| is equivalent to empty selection
check.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2540613002
Cr-Commit-Position: refs/heads/master@{#434961}

Revert of Script blocking resources tracking should be only done by Document::isScriptExecutionReady (patchset #3 id:40001 of https://codereview.chromium.org/2536753003/ )

Reason for revert:
Speculative revert for crbug.com/669435.

BUG=669435

Original issue's description:
> Script blocking resources tracking should be only done by Document::isScriptExecutionReady
>
> Before this CL, we had a duplicated tracking flag
> HTMLScriptRunner::m_hasScriptsWaitingForResources.
>
> This CL removes the flag in HTMLScriptRunner and changes code so it checks
> Document::isScriptExecutionReady() state instead.
>
> This CL also removes a comment referring to HTMLDocumentParser::executeScriptsWaitingForResources
> being called when it hasScriptsWaitingForResources as it should never happen
> and replaces it with a DCHECK
>
> BUG=None
>
> Committed: https://crrev.com/74341a4386cbe0c0b94eba0535fbbbf8d1aff8ea
> Cr-Commit-Position: refs/heads/master@{#434935}

TBR=dominicc@chromium.org,yhirano@chromium.org,kouhei@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None

Review-Url: https://codereview.chromium.org/2540653002
Cr-Commit-Position: refs/heads/master@{#434960}

Fails on Nexus 4 only with the following error:
../../base/test/histogram_tester.cc:40: Failure
Expected: (nullptr) != (histogram), actual: 4-byte object <00-00 00-00>
vs NULL
Histogram "WebCore.UseCounter_TEST.Features" does not exist.

BUG=667913
TBR=rbyers@chromium.org

Review-Url: https://codereview.chromium.org/2534833005
Cr-Commit-Position: refs/heads/master@{#434959}

BUG=667975

Review-Url: https://codereview.chromium.org/2535893002
Cr-Commit-Position: refs/heads/master@{#434958}

Currently there are three types of resource request.
- Normal resource request from renderer process.
- Resource request for browser side navigation. (PlzNavigate).
- Download request or Page Save request.

In ResourceRequestInfoImpl, these type are distinguished by process_type and
the existence of ResourceMessageFilter. But it is a bit confusing.
For example:
- AsyncRevalidationManager is checking only the existence of the filter to
  check that "the renderer is gone" or "the request is for PlzNavigate".
- service_worker_context field is added for PlzNavigate support. And the field
  is used only when the filter is not available in HandleServiceWorkerLink().

This CL introduces ResourceRequesterInfo to make it easy to distinguish those
requester types.

BUG=468227,649558
TBR=michaeln@chromium.org

Review-Url: https://codereview.chromium.org/2481093003
Cr-Commit-Position: refs/heads/master@{#434957}

 * propagate information about the success of an attach attempt
 * force-attach support
 * added the IsAttached() method

BUG=546953

Review-Url: https://codereview.chromium.org/2531313002
Cr-Commit-Position: refs/heads/master@{#434956}

In the ToValueImpl specialization for std::unique_ptr<T>, call ToValue
with the dereferenced type. All specializations take const&, which would
previously result in a call to ToValue(const*&), resulting in a wrong
specialization to be selected.

BUG=546953

Review-Url: https://codereview.chromium.org/2533083003
Cr-Commit-Position: refs/heads/master@{#434955}

Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ )

Reason for revert:
Speculative revert for crbug.com/669435

Original issue's description:
> After detach, there's no document to notify parsing is finished.
>
> HTMLViewSourceParser was tripping the DCHECK in
> DocumentParser::document when it recieved the last bytes of the
> document it was parsing after it was detached.
>
> BUG=664915
>
> Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745
> Cr-Commit-Position: refs/heads/master@{#434937}

TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=664915

Review-Url: https://codereview.chromium.org/2538473004
Cr-Commit-Position: refs/heads/master@{#434954}

Recording this metric gives insight into how many people update their
settings after seeing the disclosure.

BUG=661011

Review-Url: https://codereview.chromium.org/2518963002
Cr-Commit-Position: refs/heads/master@{#434953}

Previously, for a multipart image,
- ResourceClient::notifyFinished() and
- ImageResourceObserver::imageNotifyFinished()
might be called twice:
1. When the first part is loaded, and
2. When the whole loading is finished.

This CL removes the second case to make callback/observer control consistent
and simpler, as preparation for https://codereview.chromium.org/2469873002/.

Behavior change:
Previously, multipart images are replaced with broken images when cancelled
after the first part is loaded.
After this CL, multipart images remains as-is in such cases.
https://codereview.chromium.org/1840933002 fixes layout tests for this change.

BUG=668598

Review-Url: https://codereview.chromium.org/2513413008
Cr-Commit-Position: refs/heads/master@{#434952}

This eliminates one of the sources of flakiness in
ResourcePrefetchPredictorBrowserTest.
It seems impossible to avoid an emergence of several requests belonging to the
same subresource but we could just ignore them as real code does.
The real code also ignores repeating entries of the same subresource but doesn't
modify collection passing to test observer.

BUG=650253

Review-Url: https://codereview.chromium.org/2529263003
Cr-Commit-Position: refs/heads/master@{#434951}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a72be232..2ef8719e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2536123002
Cr-Commit-Position: refs/heads/master@{#434950}

Remove future and deprecated policies from app_restrictions.xml and
restriction_values.xml, hence making them invisible to Android policy
managers. Also include all lines of multiline descriptions of policies.

BUG=616800
BUG=616801

Review-Url: https://codereview.chromium.org/2529383003
Cr-Commit-Position: refs/heads/master@{#434949}

BUG=667751

Review-Url: https://codereview.chromium.org/2525303002
Cr-Commit-Position: refs/heads/master@{#434948}

Preparation for https://codereview.chromium.org/2513413008.

This CL introduces Internals::isLoading() and make the tests to use
isLoading() instead of size checks for detecting broken images.

BUG=668598

Review-Url: https://codereview.chromium.org/1840933002
Cr-Commit-Position: refs/heads/master@{#434947}