- 02 Jan, 2020 36 commits
-
-
Philipp Hancke authored
RTCPeerConnection.close() shall not fire events. It doesn't already for iceconnectionstate/connectionstate BUG=699036 Change-Id: I771cdd81c3bbdb4312a623e96f8150be8471d906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959042 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#727965}
-
Mikhail Khokhlov authored
Some stories that produced large traces were timing out or failing because trace conversion happened on the device. Now that trace conversion was moved to the host, we can re-enable them. TBR: crouleau@chromium.org Bug: 1029465 Change-Id: I27e1196a12b9a9b5341544d5467de0c10ffa9531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985017 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#727964}
-
Oriol Brufau authored
The marker-font-variant-numeric-default.html test is supposedly passing in Chromium according to Chromium, but not according to wpt.fyi. The reason is that in certain configurations, the test may look slightly different than the reference due to font anti-aliasing. The marker-font-variant-numeric-normal.html fails in all browsers due to lack of support for nested ::marker selectors, but there are also some differences in the parts that should actually match the reference. This patch fixes both issues. Bug: 457718 Change-Id: Id646b7810aed18441e1c7b37ad7bb1a37877be2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980174Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#727963}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/7e1b39f6cd1f..10d8de7541ab git log 7e1b39f6cd1f..10d8de7541ab --date=short --first-parent --format='%ad %ae %s' 2020-01-02 drott@chromium.org [truetype] Fix UBSan warning on offset to nullptr (#57501). 2019-12-31 ramakrishnan.nikhil@gmail.com [woff2] Allow bitmap-only fonts (#57394). 2019-12-21 hugh.mcmaster@outlook.com [docs] (2/2) Fix generation of API documentation (#56745). 2019-12-21 hugh.mcmaster@outlook.com [docs] (1/2) Move static web assets (#56745). 2019-12-21 drott@chromium.org Fix more UBSan warnings on adding offset to nullptr (#57432). Created with: gclient setdep -r src/third_party/freetype/src@10d8de7541ab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: 1036154, 1032387, 1034075 Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: If0edcc48ac1b8a9ca4d0848137d1d17d90cf91ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985685 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#727962}
-
Omer Katz authored
Adding tests for remaining heap collection types. Also refactor existing tests to use a template that gets the collection type. This reduces most of the boilerplate. Since interfaces of existing collection slightly differ, using *Adapter classes to wrap missing methods. Bug: 986235 Change-Id: I2717fbebe9396caf7e25309b8b285f698347c9c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962855 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#727961}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83461f034ab7..99be05ca5b0b Created with: gclient setdep -r src-internal@99be05ca5b0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I399d90c57f69e384f4ad6b9cebc76a9c637fadfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985687Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727960}
-
Alex Ilin authored
This reverts commit 6adf67f0. Reason for revert: causes crashes in the SharedImageBackingFactoryAHBTest test suite https://crbug.com/1038640 Original change's description: > Prevent access to uninitialized SharedImages > > This CL prevents read access to uninitialized SharedImages. For cases > where read/write access is reqeusted, the CL requires that the caller > specifically request uninitialized access if required. > > Bug: 1003686 > Change-Id: I52230217cd7f17e0cd9d4a82036ae6c72d3b1ea2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974630 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#727827} TBR=khushalsagar@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1003686, 1038640 Change-Id: I303089135726e3bb99918744c08019cfc43d68fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985015Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#727959}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2844b390..34b8e4d6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie01b75f457e1f68fcccc97b420f4fbbfeebaa769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727958}
-
Balazs Engedy authored
This reverts commit c07acb2e. Reason for revert: The test http/tests/devtools/a11y-axe-core/search/search-a11y-test.js deterministically times out on Linux MSAN builders. Original change's description: > DevTools [Search]: adding search accessibility tests > > Bug: 963183 > Change-Id: Iac3c3101babfb7285ff7b9905d94303120a2b982 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818470 > Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com> > Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#727893} TBR=lomitch@microsoft.com,Rob.Paveza@microsoft.com,ambake@microsoft.com,John.Emau@microsoft.com,michael.liao@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963183 Change-Id: I2394267653ca13107a2c28d3410a316ce606bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985016Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#727957}
-
Balazs Engedy authored
This reverts commit a351b484. Reason for revert: MemorySanitizer: use-of-uninitialized-value. New struct members added to PP_PrivateAccessibilityViewportInfo seem to remain uninitialized in PdfAccessibilityTreeTest.TestZoomAndScaleChanges. Original change's description: > Add viewport scroll information to PDFAccessibilityTree > > This CL adds following information to PDFAccessibilityTree > - ax::mojom::IntAttribute::kScrollXMin > - ax::mojom::IntAttribute::kScrollXMax > - ax::mojom::IntAttribute::kScrollX > - ax::mojom::IntAttribute::kScrollYMin > - ax::mojom::IntAttribute::kScrollYMax > - ax::mojom::IntAttribute::kScrollY > > It enables partial implementation of IScrollProvider, following methods > will work with this change > - IScrollProvider::get_HorizontallyScrollable > - IScrollProvider::get_VerticallyScrollable > - IScrollProvider::get_HorizontalScrollPercent > - IScrollProvider::get_VerticalScrollPercent > > This information is required by Screen readers to announce the current > scroll position and extent of scroll to the user. > > Tests: The best way to test this change will be through browser tests. > However, it requires the second part of the change, detailed in the > associated bug, to be completed. > > Bug: 1034521 > Change-Id: I11067b2af4d5bd73e62d89c8ce86fb00b5f3f7ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969412 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Commit-Queue: Virender Singh <virens@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#727858} TBR=dcheng@chromium.org,thestig@chromium.org,manojb@microsoft.com,mohitb@microsoft.com,virens@microsoft.com,ankk@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1034521 Change-Id: If82ca15040193884cd03891419d7065da425fcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985011Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie71c588e3d0163e419801f4ae117b764cf4b0ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985682Reviewed-by:
-
Kuo Jen Wei authored
Bug: 141518780 Test: Pass closure compiler check, tast run <DUT> 'camera.CCAUI*' on HALv1 and v3 devices. Change-Id: Idf1c6e740907215f0ce254277c39a09791952a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985633 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#727954}
-
Oleg Davydov authored
Extension content verification relies on hashes stored in file _metadata/computed_hashes.json. For extensions from Chrome Web Store there is also _metadata/verified_contents.json with almost the same hashes, but signed by Chrome Web Store. Therefore we can calculate hashes when they are requested, and afterwards check that they are correct. But for force-installed extensions outside of Chrome Web Store we don't have signed hashes, so this CL calculates hashes on installation. This is done so that external actors do not get a chance to tamper with the resources (e.g. corrupt them by hard-resetting device in the right moment) before we calculate hashes. Bug: 958794 Change-Id: I6332559dc92d2e88ce30bdc28d0191cc3f562e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914362 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#727953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff4a941ae23f..83461f034ab7 Created with: gclient setdep -r src-internal@83461f034ab7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia0c51481aebf1a967b35a42d1c70310daecff280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985681Reviewed-by:
-
Jasmine Chen authored
This CL disables Edge Enhancement (EE) and Noise Reduction (NR) in the reprocessing request for still captures. BUG=b:143260723 TEST=Tested on kukui and inspected with Camera Metadata Inspector Change-Id: I4ffaed4759a9aa24e2f33d1a9b178b1aae278559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983111Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1eccf285a299..d81bc733ae0c git log 1eccf285a299..d81bc733ae0c --date=short --first-parent --format='%ad %ae %s' 2020-01-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src e0db4afc..81693dc9 (33 commits) Created with: gclient setdep -r src/third_party/skia@d81bc733ae0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I6cd4725680ff54174d6c55202d3f772c7385fde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981702Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.0-1577099071-benchmark-81.0.4009.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4011.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I15ff186abc977fa9d5377d2e3e2b43ba69f97936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985596Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1c34ca7676e8..a43777dead46 git log 1c34ca7676e8..a43777dead46 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d488224..81693dc9 (727839:727940) Created with: gclient setdep -r src/third_party/webrtc@a43777dead46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b925df1ac8f3a3a278a93bda30763e865ba725f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985592Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e7dd8e8d..2844b390 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib9526f7c3145d0aa042c79caac0bdf6dc59743dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a1bd2ac157a5..c2ead15308b0 git log a1bd2ac157a5..c2ead15308b0 --date=short --first-parent --format='%ad %ae %s' 2020-01-02 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@c2ead15308b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I52cdc4022bef1c9ed51b6f51f2261b0e50c959a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981700Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e658c3481ce2..ff4a941ae23f Created with: gclient setdep -r src-internal@ff4a941ae23f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2403f072785e3caaeba9d27db23d1a7b8400ff1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981703Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 81693dc9. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If0cc37ea058a64976c59d37acbcd5f7fe6a99359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985599Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727944}
-
Wei Lee authored
Bug: b/146856318 Test: cts-tradefed run commandAndExit cts -m CtsCameraTestCases Change-Id: Ifb40154ecc1d15ac6e3d3dc6698224e86bc1c001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982347Reviewed-by:
-
nancy authored
Will fix the issue soon, and for short term, just disable it. TBR=xiyuan@chromium.com TBR=dominickn@chromium.com BUG=1038602 Change-Id: I79a9a4cdc151e3f3cdfdf5abce1721fc65874758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984797Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#727942}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9d4c33c63f11e66d3e66772554b2543f068a3998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985582Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727941}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a03b60eb797..e658c3481ce2 Created with: gclient setdep -r src-internal@e658c3481ce2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic8a0a34f5d87e689e80574a86df9297d6403e54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981699Reviewed-by:
-
Jinsuk Kim authored
Adds null checks against thinwebview object to attempt to fix the reported crash bug to do null pointer dereference. This is a speculative fix since the bug has not been reproducible locally. Bug: 1030616 Change-Id: I1541133691b33e2d685bd3fd6b0ab08feb3a1e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984795Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#727939}
-
nancy authored
BUG=1011235 Change-Id: I2bb653c806bb6d749158dfcec5bfee78ac613f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984793 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
nancy authored
Set the instance activated state when OnTaskSetActive is called. Check whether the window is still observed when set the window activated state, because when the window is destroyed, the window could be the old_active parameter for OnWindowActivated, and be added to instance. So check whether the window is still observed to not add to instance if the window has been destroyed. BUG=1011235 Change-Id: I0c276b71183ead5443eae1017fba669652b2153f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983103 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727937}
-
Robert Woods authored
https://chromium-review.googlesource.com/1961291 introduced a redundant call to WebLaunchFilesHelper::SetLaunchPaths in WebAppLaunchManager::OpenApplication. This CL removes it. Bug: 829689 Change-Id: If6c01e745d1e52dafb4e12fce2e38dff30b4f972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984792 Commit-Queue: Robert Woods <robertwoods@google.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#727936}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b3788f22c908..7c4300cb193f git log b3788f22c908..7c4300cb193f --date=short --first-parent --format='%ad %ae %s' 2020-01-02 dberris@chromium.org Dashboard: Tweak Clustering For Better Placement Created with: gclient setdep -r src/third_party/catapult@7c4300cb193f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:922256 Tbr: rmhasan@google.com Change-Id: I91a061b9b86865da8501d46221563bcbc9ecaacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981865Reviewed-by:
-
nancy authored
This CL is pure refactor. Replace the current ForOneInstance lambd with GetState or GetShelfId to simplify the code. BUG=1011235 Change-Id: Ia3afdae84e126feadc8e3455572ad07edabe14a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980332 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
nancy authored
Remove LoadIconFromResource, and don't load the default icon for ARC apps. BUG=1033215 Change-Id: I7e3d81b97aecf5a75b0fd227072f877c3e6167af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981526Reviewed-by:
-
Thanh Nguyen authored
Add an additional field to UserChargingEvent. Bug: 1028853 Change-Id: Icffeba88fa2ac949defd8b564f9420b2e0f40149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983118Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#727932}
-
nancy authored
This CL is used to fix the two unit tests in ASAN bots: The reason is when the window is closed, the item controller is not removed, because it can't find the app type from AppService. When the unit test exits, the window is deleted, then the item controller is removed, which accesses the removed window. Update extension_apps to SetWindowOwner when OnAppWindowAdded, otherwise MultiUserWindowManagerHelper::ShowWindowForUser could fail at ui side, because no owner for the window. Update the OnInstances to find the corrent proxy, which might has the instance info, because the window coud be teleported to from the inactive user to the active user, but the instance should still be saved in the inactive user's InstanceRegistry. Add kHidden state to avoid reusing kStarted state. BUG=1036648 Change-Id: I40b494dcf9fa5ea6febf29dad90150b51096e3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978342Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f323353c365..0a03b60eb797 Created with: gclient setdep -r src-internal@0a03b60eb797 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie7e8fc9c64392c51954a5f821b836c26d522dc22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981696Reviewed-by:
-
- 01 Jan, 2020 4 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e69f7ad80b7b..6f323353c365 Created with: gclient setdep -r src-internal@6f323353c365 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1725399157372a50d8744d9818aa83d84caa07a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981862Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6368ea1e803..e69f7ad80b7b Created with: gclient setdep -r src-internal@e69f7ad80b7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8f89206ea9000ffbc77a44dabd6674ea6ea536f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985401Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6c071d1f32670b1c088a6ef7c305a2389af06ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985400Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09efc69f5ae0..f6368ea1e803 Created with: gclient setdep -r src-internal@f6368ea1e803 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic14bfd7fd8efa683eaf0b6f55bd5df16e8a40185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985399Reviewed-by:
-
