GitLab

Adds BluetoothAdapter::Observer callbacks to Adapter implementation
for tracking changes in Adapter state including:
  AdapterDiscoverableChanged
  AdapterPoweredChanged
  AdapterPresentChanged

Adds adapter page to display details about the current state of the adapter.
Adds ObjectFieldSet interface component for displaying properties of a JavaScript object.

Screenshot: https://goo.gl/photos/dCbsULiydMbiAtiJ9

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2567983007
Cr-Commit-Position: refs/heads/master@{#443065}

This is a mechanical change to convert i18n-content to $i18n{} tags.

BUG=677338

Review-Url: https://codereview.chromium.org/2628093002
Cr-Commit-Position: refs/heads/master@{#443064}

https://chromium.googlesource.com/angle/angle.git/+log/98e3407..008450b

BUG=None

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2627713006
Cr-Commit-Position: refs/heads/master@{#443063}

Debian 8 restricts use of CLONE_NEWUSER to only processes with
CAP_SYS_ADMIN. (https://github.com/semplice/linux/blob/master/debian/patches/debian/add-sysctl-to-disallow-unprivileged-CLONE_NEWUSER-by-default.patch)
Chrome was previously checking if the kernel supported CLONE_NEWUSER
by running clone(CLONE_NEWUSER, ...) with the same capabilities chrome
was launched with.  This leads to 2 scenarios:

1. If Chrome was run as root:
   The check for CLONE_NEWUSER will succeed.  Chrome will then set up
   the namespace sandbox by clone()'ing and dropping CAP_SYS_ADMIN.
   Subsequent clone()'s with CLONE_NEWUSER will then fail.

2. If Chrome was run as a normal user:
   The check for CLONE_NEWUSER will fail.  Chrome will fallback to
   using the setuid sandbox.

The solution is to simply drop CAP_SYS_ADMIN before the check.

In addition, this CL disallows running Chromium as root unless launched
with --no-sandbox.

BUG=638180

Review-Url: https://codereview.chromium.org/2578483002
Cr-Commit-Position: refs/heads/master@{#443062}

We had previously added ForceReclaimResources to BeginCommit to throttle
frame output and prevent starving the display compositor's rasterization
tasks. Unfortunately, this introduces significant overhead as well.

With the addition of the Display Scheduler, this change no longer
appears to be needed. The scheduler has independent controls for
limiting the number of pending frames, and these should be used instead
(if further tweaking is necessary).

Removing this logic does not regress the benchmarks which it was
initially added for, and seems unneeded at this point. Removing.

R=reveman@chromium.org
BUG=676852,489515,617268
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2609253003
Cr-Commit-Position: refs/heads/master@{#443061}

BUG=388780

Review-Url: https://codereview.chromium.org/2608073002
Cr-Commit-Position: refs/heads/master@{#443060}

Previously scheduled cache mutation operations would begin the
size update calculation and then return to potentially begin
another mutation operation in parallel with the running size
update calculation. This could result in size held by CacheStorage
becoming mismatched with the actual cache size if Chrome were to
crash before the index could be written.

This change completes the size calculation before calling the
closure to begin the next scheduled operation.

BUG=678455

Review-Url: https://codereview.chromium.org/2613183003
Cr-Commit-Position: refs/heads/master@{#443059}

For device with high DPR, the image could be loaded from srcset. When
the img element is serialized, srcset attribute is skipped. We need to
set width and height attributes to retain the original size of the
image.

BUG=674999
TEST=new tests added

Review-Url: https://codereview.chromium.org/2624953002
Cr-Commit-Position: refs/heads/master@{#443058}

https://pdfium.googlesource.com/pdfium.git/+log/8fa82794ffc2..96f482c9cd3c

$ git log 8fa82794f..96f482c9c --date=short --no-merges --format='%ad %ae %s'
2017-01-11 dsinclair Convert FDE CSS enums to enum classes.
2017-01-11 npm Really fix m_nb_mct_records calculation in opj_j2k_read_mct

BUG=678461,680102

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2623103004
Cr-Commit-Position: refs/heads/master@{#443057}

(And also use it for positioned boxes)

We want to use this for layoutng/legacy interop. For legacy layout,
there should be no change in behavior because flexbox is currently
the only caller of this function:
https://cs.chromium.org/search/?q=setOverrideLogicalContentWidth&sq=package:chromium&type=cs

Interestingly, the height version did not have this limitation already.

This patch also deleted an outdated FIXME comment.

R=atotic@chromium.org,eae@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2624143005
Cr-Commit-Position: refs/heads/master@{#443056}

This patch removes two functions in InvalidatableInterpolation that are
unreached: apply and getCachedValueForTesting.

Since InvalidatableInterpolation has cached values, I had originally intended to
supply a meaningful implementation for getCachedValueForTesting. However, after
further consultation, I'm instead removing the virtual function from the
Interpolation superclass and modifying the tests that use it to make it explicit
that they will be executing LegacyStyleInterpolation::getCachedValueForTesting.

BUG=678875

Review-Url: https://codereview.chromium.org/2627793002
Cr-Commit-Position: refs/heads/master@{#443055}

Also removes an oddity with CertVerifyResult::operator== by handling the null case instead of documenting it as invalid.

operator== was only used by a unit-test (components/cronet/android/cert/cert_verifier_cache_serializer_unittest.cc), so this generalization does not weaken nullability guarantees.

Review-Url: https://codereview.chromium.org/2624283002
Cr-Commit-Position: refs/heads/master@{#443054}

Using update-w3c-deps in Chromium 2e36b96a.

Build: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7867

TBR=qyearsley@chromium.org
NOEXPORT=true

Review-Url: https://codereview.chromium.org/2623223003
Cr-Commit-Position: refs/heads/master@{#443053}

 - Adds the touch calibration setting to settings > display
 - Adds a command line switch to enable the settings.
 - Updates system_display.idl to add a new parameter.

BUG=634166
COMPONENT=System Display API, ChromeOS Switch, md settings
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620073002
Cr-Commit-Position: refs/heads/master@{#443052}

The initial value for scale is none not 1
https://drafts.csswg.org/css-transforms-2/#individual-transforms

BUG=679873

Review-Url: https://codereview.chromium.org/2620263002
Cr-Commit-Position: refs/heads/master@{#443051}

This removes the access to x509_chain in Chromium which crept in.

BUG=671420

Review-Url: https://codereview.chromium.org/2626113002
Cr-Commit-Position: refs/heads/master@{#443050}

This method has callsites inside of compositing, in which it's illegal
to try to update layout and style because compositing comes after.
However, it's also pointless to do so from such callsites.

The other call sites are: FrameView::scrollBehaviorStyle
Various scrolling methods in Element. All of the Element callsites already
update style and layout; this CL adds it to the former (which has a very
complicated set of ways it can be called, making it very hard to determine
if style or layout could be dirty before calling it).

BUG=679099
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2618323004
Cr-Commit-Position: refs/heads/master@{#443049}

Review-Url: https://codereview.chromium.org/2621403002
Cr-Commit-Position: refs/heads/master@{#443048}

This causes validation failures breaking the test expectations
when the new asm.js -> wasm pipeline is turned on.

BUG=v8:4203
R=danno@chromium.org,machenbach@chromium.org,binji@chromium.org

Review-Url: https://codereview.chromium.org/2624863003
Cr-Commit-Position: refs/heads/master@{#443047}

BUG=680276,680278,680282
TEST=FYI waterfall bots
TBR=kbr@chromium.org,yunchao.he@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2626903006
Cr-Commit-Position: refs/heads/master@{#443046}

This is my review comment from https://codereview.chromium.org/2616093004/

R=atotic@chromium.org
BUG=635619

Review-Url: https://codereview.chromium.org/2628983002
Cr-Commit-Position: refs/heads/master@{#443045}

Set up a mojom connection for content-browser to talk to content-gpu
through the mojom.GpuMain interface. Subsequent CLs will add code to
allow chrome-browser to set up a mojom.GpuService connection through
GpuMain to the gpu process. This GpuService will replace the existing
chrome-ipc messages between chrome-browser and chrome-gpu.

BUG=643746, 630895

Review-Url: https://codereview.chromium.org/2625933002
Cr-Commit-Position: refs/heads/master@{#443044}

Also introduce a new wrapper class for testing ResourceHandlers,
which will be useful to help make an upcoming API chance a bit simpler.

Also add support for on ResourceThrottle calling Resume() after another
does an out-of-band-cancel.  We have nothing to prevent that case,
but a DCHECK could be triggered in the (unlikely) case it happened.

BUG=672581

Review-Url: https://codereview.chromium.org/2563163002
Cr-Commit-Position: refs/heads/master@{#443043}

Makes case sensitivity and option on highlightRanges, which becomes
a static method on FilteredListWidget.

BUG=none

Review-Url: https://codereview.chromium.org/2627783002
Cr-Commit-Position: refs/heads/master@{#443042}

Renamed EUnicodeBidi to just UnicodeBidi to match the name of the file,
UnicodeBidi.h. This is pre-work to allow UnicodeBidi to be used by
generated fields in ComputedStyleBase, and also better matches the
style guidelines (class names should have the same name as the file).

BUG=628043

Review-Url: https://codereview.chromium.org/2620873002
Cr-Commit-Position: refs/heads/master@{#443041}

Previously, an oscillator would start at the nearest sample frame
boundary.  This can produce noticeable effects.

Instead, make the oscillator start at the requested sample time and
sample the curve appropriately.

BUG=631576
TEST=Oscillator/start-sampling.html

Review-Url: https://codereview.chromium.org/2186813003
Cr-Original-Commit-Position: refs/heads/master@{#442669}
Committed: https://chromium.googlesource.com/chromium/src/+/7909df464ca46a1ea121b0c54e5d04cfa521e38c
Review-Url: https://codereview.chromium.org/2186813003
Cr-Commit-Position: refs/heads/master@{#443040}

Revert of Enable creation of offscreen contexts which own their backing surface. (patchset #12 id:220001 of https://codereview.chromium.org/2586803003/ )

Reason for revert:
Causes out-of-order frames and tearing in WebVR.

Original issue's description:
> Enable creation of offscreen contexts which own their backing surface.
>
> This is adapted from bajones's patch from issue 2461803002 at patchset 1
> (http://crrev.com/2461803002#ps1)
>
> Uses the own_offscreen_surface flag with WebGL contexts when WebVR is enabled,
> to allow the surface to be swapped out with a compatible one if used for VR
> presentation.
>
> Includes support for canvas attributes such as "antialias", and adds a "low
> priority" GL context option so that postprocessing such as in WebVR frame
> submit at normal priority won't get blocked on the next frame being drawn.
>
> BUG=655722
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2586803003
> Cr-Commit-Position: refs/heads/master@{#442448}
> Committed: https://chromium.googlesource.com/chromium/src/+/46b9f6aaaf5851014c2474365734e71ffe9367a0

TBR=aelias@chromium.org,bajones@chromium.org,dcheng@chromium.org,jbauman@chromium.org,klausw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=655722

Review-Url: https://codereview.chromium.org/2628963002
Cr-Commit-Position: refs/heads/master@{#443039}

The testBrowsingPostEntryWithKeyboard test is flaky on device, with the
failure that the Go button on the keyboard is not interactable when tap
is performed. This implies that the tap is reached before the keyboard
is fully interactable, so this CL adds a requirement that the button is
interactable to the wait criteria.

BUG=670380

Review-Url: https://codereview.chromium.org/2626143002
Cr-Commit-Position: refs/heads/master@{#443038}

We need to add touchscreen support to mustash where display and
input-device management happens in a different process from ash.
Decouple ash::TouchTransformerController from the rest of ash and move
to src/ui/display/ so it can be used with mus. This also decouples and
moves the accompanying tests.

The dependency on WindowTreeHostManager can't be broken so add
AshTouchTransformController which extends TouchTransformController and
listens for ash display configuration changes.

BUG=679747

Review-Url: https://codereview.chromium.org/2617043003
Cr-Commit-Position: refs/heads/master@{#443037}

The separator is actually a dot.

BUG=661741

Review-Url: https://codereview.chromium.org/2620353002
Cr-Commit-Position: refs/heads/master@{#443036}

The last of these files was removed from cc/base/ over a year ago:
  https://chromium.googlesource.com/chromium/src/+/a370ef52788ea0f6c410b05ec40a74ee9bf3a647

Review-Url: https://codereview.chromium.org/2625913004
Cr-Commit-Position: refs/heads/master@{#443035}

- Add support to ContentRectangle.
- Inherit opacity from parent elements.
- Update tests.
- Drive omnibox opacity animations natively rather than via CSS.

BUG=679761
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2624243002
Cr-Commit-Position: refs/heads/master@{#443034}

This flag is used in the renderer to override the memory limit for
tiles. The code to actually override the memory is already there, but
the flag isn't currently being propagated to the renderer. This patch
fixes this.

R=enne@chromium.org

Review-Url: https://codereview.chromium.org/2616773002
Cr-Commit-Position: refs/heads/master@{#443033}

Also update callers to use better way to construct the path using
StringPiece-s, avoiding string copy (GURL::path()) and substring
copy (std::string::substr(1)).

Move ExtensionIconSet's unittest to extensions/

BUG=None

Review-Url: https://codereview.chromium.org/2626923002
Cr-Commit-Position: refs/heads/master@{#443032}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7863f77ca84e..64cff499aefc

$ git log 7863f77ca..64cff499a --date=short --no-merges --format='%ad %ae %s'
2017-01-11 simonhatch Dashboard - Fix incorrect default metric on group_report.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628073002
Cr-Commit-Position: refs/heads/master@{#443031}

A dummy CTVerifier and CTPolicyEnforcer is used to turn off parsing,
validation, and evaluation of results.

BUG= internal b/34104027

Review-Url: https://codereview.chromium.org/2621083004
Cr-Commit-Position: refs/heads/master@{#443030}

Replace the SetSubclassProperties method with CheckSubclassProperties,
which checks the properties that were set, and checks that all others
are the default values.

The next step is to delete all of the sub-classes (including the
just-added CheckSubclassProperties functions).

BUG=667966
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2628713002
Cr-Commit-Position: refs/heads/master@{#443029}

Copying the summary from dcheng@ on the referenced bug:

The current implementation looks like this:
void WebTaskRunner::postTask(const WebTraceLocation& location,
                             std::unique_ptr<CrossThreadClosure> task) {
  toSingleThreadTaskRunner()->PostTask(location,

     convertToBaseCallback(std::move(task)));
}

However, base::TaskRunner::PostTask() takes a const base::Closure&.
When we convert the CrossThreadClosure to a base::Callback, we just
extract the internal callback object. However, this callback object is
never supposed to be copied, only moved.

Since the base APIs haven't been updated to use base::OnceCallback, now
 we have two copies of the callback referencing the same
base::BindState (which is holding the bound variables): one on the
posting thread (call it thread 1), and one on the posted thread (call
it thread 2).

If the copy on thread 2 is destroyed before the copy on thread 1,
base::BindState will be destroyed on thread 1. If base::BindState
contained WTF::String or other thread-unsafe objects, and thread 2
copied it, this means that the thread-unsafe objects will be ref'ed
and deref'ed on multiple threads, which is not good.

BUG=679915, 680042

Review-Url: https://codereview.chromium.org/2626883003
Cr-Commit-Position: refs/heads/master@{#443028}

Follow-up from discussion on http://crrev.com/2612093002.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2616353003
Cr-Commit-Position: refs/heads/master@{#443027}

This caused a crash bug in FRE code on some versions of
Android where setUserVisibleHint() gets called before
onViewCreated().

This was broken by my CL from this morning:
https://codereview.chromium.org/2561433002

BUG=632199
NOTRY=true

Review-Url: https://codereview.chromium.org/2628943002
Cr-Commit-Position: refs/heads/master@{#443026}