- 15 Dec, 2014 40 commits
-
-
tfarina authored
As noted in https://codereview.chromium.org/780873002/ BUG=None R=sdefresne@chromium.org Review URL: https://codereview.chromium.org/797363003 Cr-Commit-Position: refs/heads/master@{#308348}
-
sdefresne authored
Follow-up CL to address comments on https://codereview.chromium.org/787903003 after the CL landed: - cleanup #includes in image_fetcher.{h,mm} - use const ref to scoped_refptr to avoid inc/dec ref churn - prefer base::ThreadTaskRunnerHandle::Get() to MessageLoopProxy::current() - remove std::string concatenation BUG=None Review URL: https://codereview.chromium.org/805713004 Cr-Commit-Position: refs/heads/master@{#308347}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/f5f568d..a784d7b TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org Review URL: https://codereview.chromium.org/795013004 Cr-Commit-Position: refs/heads/master@{#308346}
-
ginkage authored
BUG=none Review URL: https://codereview.chromium.org/791393002 Cr-Commit-Position: refs/heads/master@{#308345}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#308344}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7ca8eaa..f5f568d TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org Review URL: https://codereview.chromium.org/806793002 Cr-Commit-Position: refs/heads/master@{#308343}
-
Tommi authored
WebRTC 7892:7897 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/d81f3bd..e7280c6 Libjingle 7892:7896 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/3b74632..8cc6cb0 TBR=kjellander@chromium.org Review URL: https://codereview.chromium.org/799383002 Cr-Commit-Position: refs/heads/master@{#308342}
-
tnagel authored
BUG=none Review URL: https://codereview.chromium.org/689673002 Cr-Commit-Position: refs/heads/master@{#308341}
-
elisabets authored
Topbar was not hiding while scrolling down at some pages starting with a table. It did show up however if previously hidden when scrolling up. With this change, topbar animation is triggered for both up & down scrolling. See for example http://sv.wikipedia.org/wiki/M%C3%B6lnlycke and try scrolling down, topbar is not hidden. BUG=438548 Review URL: https://codereview.chromium.org/769273002 Cr-Commit-Position: refs/heads/master@{#308340}
-
fukino authored
Trivial fix to make the closure's Buildbot green. http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux BUG=none TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default TBR=yawano@chromium.org Review URL: https://codereview.chromium.org/800393003 Cr-Commit-Position: refs/heads/master@{#308339}
-
phoglund authored
We'll now measure vital statistics for all audio codecs we support, notably the CPU usage of the various codecs. The results on by Linux box suggests Opus is the most expensive codec (but it presumably sounds better). It will be interesting to see what results we will see on Android and ChromeOS devices. BUG=413577 Review URL: https://codereview.chromium.org/798903003 Cr-Commit-Position: refs/heads/master@{#308338}
-
e.hakkinen authored
Do not process the tiling with required for activation tiles if it is certain that that tiling cannot have required for activation tiles having the current priority bin. Review URL: https://codereview.chromium.org/800883002 Cr-Commit-Position: refs/heads/master@{#308337}
-
perezju authored
The implementation is based on the new AdbWrapper class methods: KillServer and StartServer. BUG=267773 Review URL: https://codereview.chromium.org/724413003 Cr-Commit-Position: refs/heads/master@{#308336}
-
Gordana.Cmiljanovic authored
BUG= TEST=Compile 'chrome' for MIPSEL Linux Review URL: https://codereview.chromium.org/795053004 Cr-Commit-Position: refs/heads/master@{#308335}
-
Gordana.Cmiljanovic authored
This CL modifies gcc_version.gni to set the gcc_version to the target GCC toolchain version when building for MIPSEL Linux. BUG= TEST=Compile 'chrome' target with 'os="linux" cpu_arch="mipsel"'. Manually verify that the correct GCC options are used. Review URL: https://codereview.chromium.org/797593002 Cr-Commit-Position: refs/heads/master@{#308334}
-
Tommi authored
WebRTC 7864:7892 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/764bd22..d81f3bd Libjingle 7860:7892 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/e2d3246..3b74632 TBR=kjellander@chromium.org Review URL: https://codereview.chromium.org/798343003 Cr-Commit-Position: refs/heads/master@{#308333}
-
kinuko authored
- Plumbed from EmbeddedWorkerDevToolsAgentHost to ServiceWorkerVersion to flip 'DevToolsAttached' flag - Added EmbeddedWorkerInstance::StopIfIdle() which doesn't stop the worker if devtools is attached - Changed stop-worker-timer code to call StopIfIdle() instead of Stop() - Added a hook in EmbeddedDevToolsManager that is called when we didn't stop the worker (to show an educational console message) BUG=429582 TEST=EmbeddedWorkerInstanceTest.StopWhenDevToolsAttached Review URL: https://codereview.chromium.org/761923004 Cr-Commit-Position: refs/heads/master@{#308332}
-
etiennej authored
python modules composed of C++ and/or Cython files. This change is necessary for https://codereview.chromium.org/792843002/. It is also backward-incompatible with the current mojo/public/python build rules; I change them in the same changelist to avoid the dependency issue. Once this CL lands, I will roll the changes into the mojo repository from chromium. R=qsr@chromium.org,jamesr@chromium.org Review URL: https://codereview.chromium.org/799923003 Cr-Commit-Position: refs/heads/master@{#308331}
-
e.hakkinen authored
Tiling data iterators need tiling data pointer only in constructors thus there is no need to store that pointer into a member variable. Review URL: https://codereview.chromium.org/798973003 Cr-Commit-Position: refs/heads/master@{#308330}
-
serya authored
Revert of Stub for web-base client for DevTools bridge and tests (patchset #5 id:100001 of https://codereview.chromium.org/736363002/) Reason for revert: Reverting since now DevToolsBridgeClient (https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/devtools/device/webrtc/devtools_bridge_client.h) is that WebClient supposed to be. All further code will be placed there. Original issue's description: > Stub for web-base client for DevTools bridge and tests > > This patch mostly consists of testing environment for web WebClient. While > WebClient intended to be base for a new DeviceProvider in DevTools frontend > (https://codereview.chromium.org/720133002/) it is convinient to run > tests on android. It lets to test the client directly against server > counterpart avoiding flakiness of network and cloud services. > > TBR=jochen@chromium.org > BUG=383418 > > Committed: https://crrev.com/ff7a801dfddaa22643accaf3e0df192470fb7a7b > Cr-Commit-Position: refs/heads/master@{#305131} TBR=mnaganov@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=383418 Review URL: https://codereview.chromium.org/802293002 Cr-Commit-Position: refs/heads/master@{#308329}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6556aea..7ca8eaa TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org Review URL: https://codereview.chromium.org/802273002 Cr-Commit-Position: refs/heads/master@{#308328}
-
xiang.long authored
A document will associate a new matched registration if it is not controlled, but it doesn't equal to "using" the registration. We should omit documents that are not using the registration when skipWaiting happens. BUG=370742 TEST=http/tests/serviceworker/skip-waiting.html Review URL: https://codereview.chromium.org/798833002 Cr-Commit-Position: refs/heads/master@{#308327}
-
tmoniuszko authored
BUG=437829 Committed: https://crrev.com/0593c1690aeb6ac4869504b91d8172546aea1da6 Cr-Commit-Position: refs/heads/master@{#306389} Review URL: https://codereview.chromium.org/772533002 Cr-Commit-Position: refs/heads/master@{#308326}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/799073007 Cr-Commit-Position: refs/heads/master@{#308325}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/9561fd6..6556aea TBR= Review URL: https://codereview.chromium.org/801293002 Cr-Commit-Position: refs/heads/master@{#308324}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#308323}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/3d81dfe..9561fd6 TBR= Review URL: https://codereview.chromium.org/806703002 Cr-Commit-Position: refs/heads/master@{#308322}
-
tbarzic authored
As part of easy sign-in protocol, a nonce has to be signed by TPM private key. To be able to do this, we need to allow system token to be loaded before a user is logged in. This cl starts system token initialization (which is done by TPMTokenLoader) before LoginState is LOGGED_IN if there is a user with easy sign-in enabled. BUG=409027 Review URL: https://codereview.chromium.org/741593002 Cr-Commit-Position: refs/heads/master@{#308321}
-
yawano authored
BUG=433728 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default | grep "gallery/js/mosaic_mode.js" Review URL: https://codereview.chromium.org/805723003 Cr-Commit-Position: refs/heads/master@{#308320}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/54355486..3d81dfe TBR= Review URL: https://codereview.chromium.org/802083003 Cr-Commit-Position: refs/heads/master@{#308319}
-
amistry authored
BUG=397019 Review URL: https://codereview.chromium.org/804853002 Cr-Commit-Position: refs/heads/master@{#308318}
-
mgiuca authored
Provides better contrast with the downloads bar while remaining contrasted with the background. BUG=424067 Review URL: https://codereview.chromium.org/791273002 Cr-Commit-Position: refs/heads/master@{#308317}
-
calamity authored
This CL makes the app list recommendations their own SearchResult::DisplayType. This prevents recommendations from flashing up for an instant when the search query is deleted. BUG=440051 Review URL: https://codereview.chromium.org/796793002 Cr-Commit-Position: refs/heads/master@{#308316}
-
andresantoso authored
This reverts commit 4eb0fd47. HistogramManagerBucketFields times out on Win7 Tests. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/33548 TBR=rtenneti@chromium.org,asvitkine@chromium.org,mef@chromium.org NOTREECHECKS=true NOTRY=true BUG=441466 Review URL: https://codereview.chromium.org/800363002 Cr-Commit-Position: refs/heads/master@{#308315}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/0c64792..54355486 TBR= Review URL: https://codereview.chromium.org/801243002 Cr-Commit-Position: refs/heads/master@{#308314}
-
andresantoso authored
Revert of Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally usi… (patchset #2 id:20001 of https://codereview.chromium.org/805593002/) Reason for revert: Some of the newly enabled tests fail on the bots. For example, https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/51555 Original issue's description: > Fix file naming issue causing page_run_end_to_end tests to never run (at least when run locally using run_tests script). > Fix a failing test from this file. > > Found this while fixing unit test for max_failures patch > (https://codereview.chromium.org/790673005/). > > BUG=440101 > > Committed: https://crrev.com/c484a63e356fb1011b553b94612586d2084325d3 > Cr-Commit-Position: refs/heads/master@{#308264} TBR=nednguyen@google.com,chrishenry@google.com NOTREECHECKS=true NOTRY=true BUG=440101 Review URL: https://codereview.chromium.org/802243002 Cr-Commit-Position: refs/heads/master@{#308313}
-
deepak.m1 authored
Presently when we selects bookmark icon then it checks weather Ctrl+D has been set as overridden command for any extension if yes, then it executes extension popup for that extension. Changes done so that when bookmarking a page is done via bookmark icon by mouse click then bookmark overridden commands should not be considered as overriding happened for keyboard shortcuts. As user have overridden shortcut key for bookmark to launch extension pop up, not the bookmarking via selection of bookmark icon by mouse event. TBR=sky@chromium.org BUG=426791 Review URL: https://codereview.chromium.org/765043002 Cr-Commit-Position: refs/heads/master@{#308312}
-
kalman authored
_behavior_features.json. Arbitrarily use it to implement the allow-in-incognito whitelist. BUG=440194 R=rockot@chromium.org Review URL: https://codereview.chromium.org/789383002 Cr-Commit-Position: refs/heads/master@{#308311}
-
calamity authored
This CL implements an experimental scheme for navigating the tile results in the experimental app list. The left and right arrow keys now navigate the tile list if the search box cursor is at the end of the text. BUG=436327 Review URL: https://codereview.chromium.org/793633002 Cr-Commit-Position: refs/heads/master@{#308310}
-
calamity authored
This CL fixes issues with the app list where the search box widget would render above the app list overlay while accepting input. This has been fixed by appropriately animating the search box widget when the app list overlay is shown and disabling the search box. BUG=439350 Review URL: https://codereview.chromium.org/781423002 Cr-Commit-Position: refs/heads/master@{#308309}
-