GitLab

Adding tests for error reporting and wrapper, the rest will follow.

BUG=164227
TEST=No

Review URL: https://chromiumcodereview.appspot.com/23477006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221239 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

I don't understand this piece of code.
There is not side-effects. Old code? Or for debugging?

R=mrossetti@chromium.org, sky@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/22475002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23707010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=252011
TEST=manual tests on Lumpy

Review URL: https://chromiumcodereview.appspot.com/23514028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221236 0039d316-1c4b-4281-b951-d872f2087c98

When overflow bubble is shown, active state item in overflow bubble is changed
to running state item because overflow bubble get focus.

R=jamescook@chromium.org
BUG=283206
TEST=Compiles, Manual tests

Review URL: https://chromiumcodereview.appspot.com/23540013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221235 0039d316-1c4b-4281-b951-d872f2087c98

* Adds more functionality to the Chromium testshell SyncController.
* Enables GCM for sync.
* Upstream sync test framework and chrome://sync tests.
* Adds auto-login to Chromium testshell.

BUG=272584

Review URL: https://chromiumcodereview.appspot.com/22914014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://chromiumcodereview.appspot.com/23701011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221232 0039d316-1c4b-4281-b951-d872f2087c98

The request target type used to be object for all requests coming from a Pepper plug-in (since http://crrev.com/142370), but we only want it for the initial plug-in file, not for navigations.

BUG=283374

Review URL: https://chromiumcodereview.appspot.com/23548008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221231 0039d316-1c4b-4281-b951-d872f2087c98

Previously, fileBrowserPrivate.getFileTasks() returned Drive app tasks
regardless of whether files were on Drive or not, and the results were
filtered in JS side with ".driveApp" field.

It's much simpler for getFileTasks() to return Drive app tasks only if
all files are on Drive. This way, we can get rid of the filtering logic
in JS, as well as the ".driveApp" field.

BUG=284242
TEST=Install Pixlr Editor from webstore; Launch Files.app; Confirm that Pixlr Editor is an option for a JPG file on Drive, but not an option for a JPG file on the local disk.
TBR=benwells@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23477036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221230 0039d316-1c4b-4281-b951-d872f2087c98

This is a necessary step in moving PasswordForm from //content to //autofill.

BUG=263121

Review URL: https://chromiumcodereview.appspot.com/23622013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221229 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285051
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/23506031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221228 0039d316-1c4b-4281-b951-d872f2087c98

This eases debugging failures of the WebGL conformance tests run under
Telemetry.

BUG=280750
R=bajones@chromium.org, dtu@chromium.org, skyostil@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/23604039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221226 0039d316-1c4b-4281-b951-d872f2087c98

Currently this only works if the window is activated with the mouse. If we Alt Tab to the window then
the focus window is not restored in AURA. The view is correctly focused though.

Fixes as below:-
1. Added a new function HandleActivationChanged to the DesktopNativeWidgetAura class. This is invoked from
   the DesktopRootWindowHostWin::HandleActivationChanged and DesktopRootWindowHostX11::HandleNativeWidgetActivationChanged
   functions.

2. Most of the common code in those functions now lives in the DesktopNativeWidgetAura::HandleActivationChanged function.
   This includes deactivating the window in the aura activation client and now additionally activating the window when
   we are being activated.

Added an interactive ui test DesktopNativeWidgetAuraActivationAndFocusTest for Windows AURA.

BUG=278000
TEST=Interactive ui test DesktopNativeWidgetAuraActivationAndFocusTest
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23702017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221225 0039d316-1c4b-4281-b951-d872f2087c98

Binary data separation from https://codereview.chromium.org/22938005/ in order
to allow trybot and CQ run on that patch.

BUG=21734
TBR=yoz@chromium.org, kalman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/23532041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221224 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240152
TEST=manual
R=hirono@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23691034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221223 0039d316-1c4b-4281-b951-d872f2087c98

Fill json data in index.html template by python script and
try to open page in chrome using xdg-open command. If page
open failed, it will output the path of generated html file.

index.html containing the content of index.js would be
generated by python script, so index.html and index.js are
deleted.

BUG=259206
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221222 0039d316-1c4b-4281-b951-d872f2087c98

Fixes r216992's regression (input not sent to Combobox/TreeView).
Call views::InputMethod::On[Focus|Blur] for Combobox and TreeView.
This correctly forwards input method input to the focused views.
(this minimal CL should be mergeable to fix this issue in M-30)

I had landed a fix that was more complex: http://crrev.com/219673
That caused regressions and was reverted: http://crrev.com/220121
Both CLs should be superceded by: http://crrev.com/23583013
(but that CL is a complex WIP proof of concept, not mergeable)

BUG=276720
TEST=Test Win (desktop, Win8 Metro, and Aura builds), CrOS, and Linux Aura's Omnibox, Find Bar, Bookmark Bubble, and Edit Bookmark Dialog's textfield text entry (and text input handling to select combobox and tree view elements) with EN, JA, and other IMEs, and related IME usage (Win+Space to change IME on Win8, Alt+` to change modes, etc.). Also test with --enable-text-services-framework.
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23882003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221221 0039d316-1c4b-4281-b951-d872f2087c98

Made the ChromeViewHostMsg_CloseCurrentConnections message synchronous so
that Telemetry can't issue further network requests until it's processed.

Removed call to util.CloseConnections from _RunCompoundAction in
page_test.py. This was aborting resource requests issued by the current
test, and was the root cause of the flakiness of the WebGL conformance
tests that loaded external resources.

BUG=280750
R=dtu@chromium.org, palmer@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/23533029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221220 0039d316-1c4b-4281-b951-d872f2087c98

WebContentsModalDialogManager closes web contents modal dialogs
when the WebContents is destroyed, so there is no need for
TabModalConfirmDialogDelegate to also close dialogs on tab closing.

BUG=157161
R=sky@chromium.org

Review URL: https://codereview.chromium.org/23820004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221219 0039d316-1c4b-4281-b951-d872f2087c98

* Rewrote in ppapi_cpp
* Remove URL loading (data is static in the .nexe)
* Cube data is no longer generated
* Added sliders for cube rotation (useful for testing)

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/23838002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221218 0039d316-1c4b-4281-b951-d872f2087c98

These were added to ppapi_cpp_private/library.dsc in r221149, but the files
were not landed in that CL.

BUG=none
TBR=kcwu@chromium.org

Review URL: https://codereview.chromium.org/23898005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221217 0039d316-1c4b-4281-b951-d872f2087c98

This lets browsertests and apitests use more obvious code in some
cases, especially when they need to alternate between the background
page and the test running code.

Review URL: https://chromiumcodereview.appspot.com/23874006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268640

Review URL: https://chromiumcodereview.appspot.com/23842002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221215 0039d316-1c4b-4281-b951-d872f2087c98

This way the Installer.DownloadSourcesUsed metric conveys how often
p2p is used and new metrics Installer.SuccessfulMBsDownloadedFromHttpPeer
and Installer.TotalMBsDownloadedFromHttpPeer gives additional detail.

BUG=chromium:284714
TEST=Validated the xml, pretty print succeeded.

Review URL: https://chromiumcodereview.appspot.com/23838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=281698
TEST=Link should be disabled while the user's signed-in state is unknown.
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23806002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221213 0039d316-1c4b-4281-b951-d872f2087c98

When sign in is initiated from the bookmark bubble in an incognito
browser, the sign in page is not displayed in the browser provided to
chrome::ShowBrowserSignin() but in a new/existing non-incognito browser.
BookmarkBubbleSignInDelegate was not aware of that and called Show()
on the wrong browser.

This call was unnecessary because chrome::ShowBrowserSignin() already
make it on the right browser. I removed the unnecessary call.

BUG=282305
TEST=
Pre-condition: Make sure you are not signed in to Chrome.
1.Launch Chrome, open 'Incognito window' from hot-dog menu and navigate to www.google.com.
2.Click on bookmark icon(star) in omnibox and click on 'Sign in' link of bookmark dialog box.
Expected result: Sign in page is displayed in a non-incognito browser.
This browser is displayed in front of the incognito browser.
R=rogerta

Review URL: https://chromiumcodereview.appspot.com/23726016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221212 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221211 0039d316-1c4b-4281-b951-d872f2087c98

The struct was used for keeping the app list internally in DriveAppRegistry,
but the information it holds is identical to its public cousin: DriveAppInfo.

BUG=284951

Review URL: https://chromiumcodereview.appspot.com/23608007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221210 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vadimsh@chromium.org
NOTRY=true
BUG=

Review URL: https://chromiumcodereview.appspot.com/23593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221209 0039d316-1c4b-4281-b951-d872f2087c98

Hiding tooltip when mouse button is pressed was done in launcher view.
It looks more better when tooltip manager handles.

R=skuhne@chromium.org
BUG=NONE
TEST=ash_unittests

Review URL: https://chromiumcodereview.appspot.com/23536012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221208 0039d316-1c4b-4281-b951-d872f2087c98

Breaks win aura builder.


> Adds an integration test for uninstalling app list search results.
> 
> This involves exposing the app list model to a BrowserTest, and ensuring
> that changes in the model are properly observed by the UI.
> 
> BUG=277897,169114
> TEST=AppListControllerSearchResultsBrowserTest.UninstallSearchResult
> 
> Review URL: https://chromiumcodereview.appspot.com/23072036

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/23808004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221207 0039d316-1c4b-4281-b951-d872f2087c98

> Remove simple_util::GetMTime from simple cache.
> 
> With base::PlatformFile::GetPlatformFileInfo now being high resolution, there's
> no need for this system specific cruft in the simple disk cache.
> 
> R=clamy,pasko
> BUG=None
> 
> Review URL: https://chromiumcodereview.appspot.com/22571011

Reason: GetFileInfo is being used, and it is not high resolution right now.

TBR=gavinp@chromium.org

Review URL: https://codereview.chromium.org/23597016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221206 0039d316-1c4b-4281-b951-d872f2087c98

The app launcher will now display an app's short name (the new
short_name property in the manifest file). If an app's short name
and full name differ, the tooltip will show the full name. If an
app's short name and full name are identical, a tooltip will only
be shown if the title is truncated.

BUG=226848
TEST=If an app has a short name and it differs from its full name,
a tooltip should always be shown, displaying the full name. If an
app does not have a short name override, there should be no change
in behavior, i.e. a tooltip will only be shown if the title is
truncated.

Review URL: https://chromiumcodereview.appspot.com/23709003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221205 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221204 0039d316-1c4b-4281-b951-d872f2087c98

R=siggi@chromium.org

NOTRY=True

BUG=

Review URL: https://chromiumcodereview.appspot.com/23620011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221203 0039d316-1c4b-4281-b951-d872f2087c98

The page background color is only restricted to the inside of the content tab while it should be the entire page minus the title bar. Also we should be able to drag by clicking anywhere on the title bar except the buttons. This CL fixes both the issues.

R=xiyuan@chromium.org
BUG=279635

Review URL: https://chromiumcodereview.appspot.com/23503032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221202 0039d316-1c4b-4281-b951-d872f2087c98

The page cyclers run with Telemetry now. They should not be baked into the chrome
binary itself. This causes unwanted dependencies on test code and bloats the
binary.

BUG=280157

Review URL: https://chromiumcodereview.appspot.com/23498004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221201 0039d316-1c4b-4281-b951-d872f2087c98

Chrome on Android's overscroll effect is created on-demand, the first time a
user overscrolls.  Rather than wait for an update from the compositor to give
the effect a valid size, provide the created effect the last valid content size.
This prevents the initial overscroll hitch that may occur if the compositor is
otherwise inactive when the first overscroll update is received.

BUG=284523
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23494021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221200 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up after http://crrev.com/217968 per comments on
https://chromiumcodereview.appspot.com/23235002/

R=jam@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/23452016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221199 0039d316-1c4b-4281-b951-d872f2087c98

The reload button is a circular arrow the same size as the spinner graphic.
While the list is being reloaded, the latter is displayed instead.

BUG=273137

Review URL: https://chromiumcodereview.appspot.com/23441022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221198 0039d316-1c4b-4281-b951-d872f2087c98