- 19 Sep, 2018 40 commits
-
-
Michael Spang authored
Add const to members that are set in the ctor and never change. Also remove the unused status field from PageFlipRequest. Bug: none Test: compile Change-Id: I8bc54acd67812d860a87fab64381c7ae0f6b7b24 Reviewed-on: https://chromium-review.googlesource.com/1234223Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5b1844cce9d..2a0473aeb232 Created with: gclient setdep -r src-internal@2a0473aeb232 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I27e19a46686af6b275609f1f9040ebe962134a69 Reviewed-on: https://chromium-review.googlesource.com/1234815Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592542}
-
Reilly Grant authored
DeviceImpl::OnOpen handles a null UsbDeviceHandle on the normal path but unconditionally closed the handle if the weak pointer to the DeviceImpl was invalidated. This change adds a null check there as well. Bug: 884145 Change-Id: Ib9e68904468320a25c4c7bc866d61728d101d4ca Reviewed-on: https://chromium-review.googlesource.com/1234365Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592541}
-
Siddhartha authored
Make the copy buffer to malloced, since 1MB could be over stack limit for sampling thread. BUG=859260 R=wittman@chromium.org Change-Id: Idc7719c79be378fec69f6a1d90b8f9300d67e132 Reviewed-on: https://chromium-review.googlesource.com/1231382 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592540}
-
Weidong Guo authored
Changes: 1. Calculate the first available position in AppListModelUpdater for newly added item. 2. Add test coverage. Bug: 883939 Test: AppListSyncableServiceTest.FirstAvailablePosition Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319 Reviewed-on: https://chromium-review.googlesource.com/1231193 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592539}
-
David Bokan authored
Adding viewport nodes causes a performance regression so this CL turns off the paint tree update in VisualViewport if BGPT (and SPv2) are off since the nodes aren't needed. Bug: 879205 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I19060e1d487d50ac9b65ae7bdaa32dba2e5caaa7 Reviewed-on: https://chromium-review.googlesource.com/1228489Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592538}
-
Ehsan Karamad authored
The CL 1187231 implemented MimeHandlerViewFrameContainer. This is a follow-up to that CL to fix some major issues in attaching a MHVG on the browser side. The main problems and updates: 1- The test added in 1187231 was inadvertently removed in Patch 4. This caused the incorrect code to land without flagging. This CL adds the test again (test runs with MimeHandlerViewInCrossProcessFrame). 2- MimeHandlerViewGuest::WillBeginAttach was using |embedder_web_contents()| which is null at this point. 3- The newly introduced code path for attaching Guests on the browser side would end up in code paths which expected RWHVGuest. This was happening in BPG::OnWillAttachComplete leading to an invalid cast from RWHVCF to RWHVG. This turned out to cause crashes on some bots. 4- It is possible with small changes to unify the attaching code path for other GuestViews and MHVG. This CL does just that. This CL also adds a sanity DCHECK in WCViewGuest to make sure we do not instantiate an incorrect type of GuestView. Bug: 659750 Change-Id: Id9c668aa5a98a8f669f56596828cef40198ec57f Reviewed-on: https://chromium-review.googlesource.com/1225307 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592537}
-
Marijn Kruisselbrink authored
The existance of this DefaultHash implementation is potentially problematic for several reasons: - DefaultHash<scoped_refptr<T>> exists as well, making it very easy to end up with ODR violations where different translation units end up with different types for a HashSet<scoped_refptr<const SecurityOrigin>>. - It is not obvious what "equality" the hash implements, since there are at least two equally valid definitions of equality for origins ("same origin" vs "same origin-domain"). Currently no code is actually using this hash, but our upcoming DOMStorage onion souping will want a hash that implements same origin equality, so for that this also changes the implementation to implement that version of equality. Bug: 781870 Change-Id: I79d8820194b51cb81ba4bf0684e65cba575dba82 Reviewed-on: https://chromium-review.googlesource.com/1229357Reviewed-by:Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#592536}
-
Brandon Wylie authored
Bug: 882966 Change-Id: I3624b8cef4cc0cf28c300beb426ae169c3be0730 Reviewed-on: https://chromium-review.googlesource.com/1219939 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592535}
-
Martin Robinson authored
Bug: 885093 Change-Id: I9b6c6f7635a893b10e333bd6e72765fa630f9efb Reviewed-on: https://chromium-review.googlesource.com/1233353Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#592534}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/92ef0386b8b6..582a06eb7835 git log 92ef0386b8b6..582a06eb7835 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 chiniforooshan@chromium.org Telemetry: don't fail when SF cannot find win name Created with: gclient setdep -r src/third_party/catapult@582a06eb7835 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884999 TBR=sullivan@chromium.org Change-Id: I7ce1f90275c2422e5cb7a0325379004f8e30cc3d Reviewed-on: https://chromium-review.googlesource.com/1234957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592533}
-
Clifford Cheng authored
Sometimes the function failed to find the "close-button" because it's closed. This can be due to a recent change in telemetry. See bug for more details. Bug: 884929 Change-Id: I47af2f8e87431120d5dfebba3d25ead91d98f565 Reviewed-on: https://chromium-review.googlesource.com/1229359 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592532}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 342523`. Bug: 880827 Change-Id: I8f747ab4a2de74a0f0b4b5a201d37e111f323077 Reviewed-on: https://chromium-review.googlesource.com/1232590Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592531}
-
Sky Malice authored
Change-Id: Ib5698fdef987ca82a67c9e2b974a20012e95f508 Reviewed-on: https://chromium-review.googlesource.com/1228298Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#592530}
-
Peter Kasting authored
Fixes tests broken in Touchable Refresh and changes them from being tested in Touchable to Touchable Refresh. Also does some other cleanups. This does not remove flags added during refresh (e.g. NTB position); those will be added separately. Bug: 814847 Change-Id: I8c31a0421c65c4cd46f287d9e67aa17645089703 Reviewed-on: https://chromium-review.googlesource.com/1232882Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592529}
-
Gabriel Charette authored
That variant was useful in the early days of TaskScheduler to ensure compatibility. It is now in the way as other variants of MessageLoop are being considered. MessageLoop is independent from TaskScheduler and the integration is now well-covered implicitly by the vast majority of tests in the codebase. R=fdoray@chromium.org Bug: 708584 Change-Id: Id93d8eb4f970e0aa0e1915ffcbc7471190e3d312 Reviewed-on: https://chromium-review.googlesource.com/1232573Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592528}
-
Peter Kasting authored
This removes support for pre-refresh modes. It does not change the design of path computations/drawing or other deeper refactors. Also does some other minor cleanup, and fixes one clear bug with high DPI in PaintChildren(). Bug: 873855 Change-Id: I3496ea60ed670d5f1c30abf33b989162c558fa16 Reviewed-on: https://chromium-review.googlesource.com/1231898Reviewed-by:
-
Steven Bennetts authored
This removes direct access to KeyboardUI outside of tests while the code is re-factored for Mash. Bug: 843332 Change-Id: Ic6b60032512b36b7ff1ae05bb8d12060db8f8d29 Reviewed-on: https://chromium-review.googlesource.com/1227171Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592526}
-
Krishna Govind authored
R=benmason@chromium.org Change-Id: I0b9f1c1b77edbbd8135d20d3088b2663d4e149b5 Reviewed-on: https://chromium-review.googlesource.com/1235053Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#592525}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/69f640ec0900..647e1e79eb71 git log 69f640ec0900..647e1e79eb71 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 ehmaldonado@chromium.org Reland "gclient: delete unversioned directory before adding cipd dep for the same path" Created with: gclient setdep -r src/third_party/depot_tools@647e1e79eb71 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882611 TBR=agable@chromium.org Change-Id: I7902b0657f1aa899a92b0a55fb9a2d6317343fd6 Reviewed-on: https://chromium-review.googlesource.com/1234368Reviewed-by:
-
Zach Helfinstein authored
Bug: 884297 Change-Id: I4d733650e54b01459154c1c59da5c95246ec3d05 Reviewed-on: https://chromium-review.googlesource.com/1232682 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592523}
-
Yuri Wiitala authored
Overrides the default behavior of dropping fullscreen when a tab modal dialog is opened in the FullscreenWithinTab case. This is because, in FWT mode, the browser window is in its normal layout (not fullscreened). Bug: 883535,812769 Change-Id: I1c262954b962d508eb86ef9a8a312bec03ab2332 Reviewed-on: https://chromium-review.googlesource.com/1228976 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592522}
-
Dmitry Gozman authored
This removes reliance on the callbacks from blink in RenderFrameImpl (e.g. WillSubmitForm) to track transition type. Instead, we can calculate it when needed based on the WebDocumentLoader instance. Also removes NavigationStateImpl::GetTransitionType() to avoid misusing it. Bug: 855189 Change-Id: I5c53f0f576cec0630c8de07b2ac902a1dffc30f9 Reviewed-on: https://chromium-review.googlesource.com/1228953Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592521}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c8f0845431d..2ec817bb6bd9 git log 2c8f0845431d..2ec817bb6bd9 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 tobine@google.com Remove writeResource down readPixels path Created with: gclient setdep -r src/third_party/angle@2ec817bb6bd9 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I895bd1cc63055d543dcd99c8dcb1a3598ccc1f22 Reviewed-on: https://chromium-review.googlesource.com/1234364Reviewed-by:
-
Christian Biesinger authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1232584, layout_block.h no longer needs to include ng_constraint_space.h Change-Id: I9788d6ba0488431facfd3af1eaf6e8f32927ca91 Reviewed-on: https://chromium-review.googlesource.com/1234218 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592519}
-
Bence Béky authored
Original CL landed at https://crrev.com/c/1073192. Revert (with edits) landed at https://crrev.com/c/1230442. This CL relands the original with the modification that |callback_| is reset in DhcpPacFileFetcherChromeos::Cancel() and OnShutdown(). It is believed that the crashes the original CL caused happened when Fetch() was called after Cancel(), and this modification will prevent that from happening. Kudos to eroman@ for pointing this out at https://crrev.com/c/1230442/3/chromeos/network/dhcp_pac_file_fetcher_chromeos.cc#63 Bug: 882996 Change-Id: I4747004c00fa3ac7a698d7a35c0b52999411adb5 Reviewed-on: https://chromium-review.googlesource.com/1232576Reviewed-by:
-
Eugene But authored
TaskShutdownBehavior::BLOCK_SHUTDOWN is used to make sure that completion handler is always called on shutdown. Bug: 853774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ief6560419f79055ce9a8d0de47806db5f3f9c9d4 Reviewed-on: https://chromium-review.googlesource.com/1226195Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592517}
-
Nektarios Paisios authored
Windows screen readers call IAccessible::get_appName and IAccessible::get_appVersion to determine that Chrome is running and retrieve its version for loading the correct scripts. However, when the content_shell is running instead of Chrome, |GetProduct| returns an empty string. Since screen reader access is not essential while content_shell is running, we simply return E_FAIL for both these API calls rather than DCHECK. R=dmazzoni@chromium.org Change-Id: Iec62c134cd55b204fe460ff0d632b280996297a3 Reviewed-on: https://chromium-review.googlesource.com/1232583Reviewed-by:
-
Matt Menke authored
Also add a TCPConnectedSocketOptions structure to sent options on socket construction, as it makes state management and error handling in consumers simpler if they want to set multiple options when creating a socket. BUG=848078 TBR=mfoltz@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2177b907b2a1d75212e27505f8366c608457e2b8 Reviewed-on: https://chromium-review.googlesource.com/1204852 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#592515}
-
chrome://discardsSigurdur Asgeirsson authored
Also drop some unused styles while I was in there. Bug: 874968 Change-Id: I44881e7b5eefd63db4d9999c37958ba825fe1cbf Reviewed-on: https://chromium-review.googlesource.com/1228775Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592514}
-
Kevin Marshall authored
* Install the Context's persistent data directory in /data. * Use the existence of /data as the canonical signal for enabling incognito mode. (Tests will still use the --incognito switch override.) ** Add a smoke test suite for running in incognito mode. * Configure disk_cache to use SimpleCacheBackend. The default persistent cache backend will break because it relies on mmap(), which isn't supported by minfs. * Add semantic validation for the |data_directory| handle. ** Add tests to exercise validation. * Remove GetPackageRoot(), since there's no reason to not use PathService(DIR_SOURCE_ROOT, ...) anymore. * Remove unused Fuchsia-specific path DIR_FUCHSIA_RESOURCES. Bug: 840598 Change-Id: I3efdb072cc4ee8f7df21992d6a84a1b548bb7fed Reviewed-on: https://chromium-review.googlesource.com/1232524Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Asanka Herath authored
This reverts commit c9b5d530. Reason for revert: Compile failure: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/56793 Original change's description: > Refresh access token only for auth error. > > Bug: b:114756954 > Test: Manual > Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 > Reviewed-on: https://chromium-review.googlesource.com/1226527 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592467} TBR=xiaohuic@chromium.org,dmblack@google.com,yileili@google.com Change-Id: I47b836b3b8d1d49e3dde93a8133d80c27a411a5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:114756954 Reviewed-on: https://chromium-review.googlesource.com/1234895Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592512}
-
David Tseng authored
Follow up to incomplete change https://chromium-review.googlesource.com/c/chromium/src/+/1228790 Change-Id: I552c0896ae903223f659eb647bf3b3bf5f75e3dc Reviewed-on: https://chromium-review.googlesource.com/1232954Reviewed-by:
-
dpapad authored
In Polymer 2 the following syntax for registering event listeners is no longer supported. listeners: { 'id.eventName': 'onEventName_', }, Bug: 885294 Change-Id: I143aea45aab7ccb237f9034b04be5882ef7b8de0 Reviewed-on: https://chromium-review.googlesource.com/1231926Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592510}
-
liberato@chromium.org authored
This CL addresses a few issues with MCVD unittests: - Some tests were marked 'VP8' when they were supposed to be 'not VP8'. This changes them to H264. Not exactly the same thing, but better than it was. - Some tests were marked 'H264' since they didn't work for VPx for no clear reason. These have been fixed. - VP8 codec could leak, since the drain during destruction wasn't complete. It now completes the drain when needed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id9dab9b93425581fa3f7892ef734fbd3e5c54eaf Reviewed-on: https://chromium-review.googlesource.com/1234360 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592509}
-
Mike Reed authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id97f574f12deffbfe28e943a7735823be1533db9 Reviewed-on: https://chromium-review.googlesource.com/1233941Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#592508}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2d0fb17deef..8a0014403563 git log c2d0fb17deef..8a0014403563 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 halcanary@google.com test,tools: whitespace changes for clang-format 2018-09-19 mtklein@google.com update clang_linux to Clang 7 Created with: gclient setdep -r src/third_party/skia@8a0014403563 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I2cbc67728a544de1248e2434d1334fb5e09f7e03 Reviewed-on: https://chromium-review.googlesource.com/1234366Reviewed-by:
-
David Tseng authored
TBR=dmazzoni@chromium.org Bug: 795840 Change-Id: I66868a0b735f660e5f0190e7bcc6e4c158393138 Reviewed-on: https://chromium-review.googlesource.com/1234317Reviewed-by:
-
Sergey Poromov authored
Finalizing LoginDisplayHost before AttemptUserExit caused double deletion of LoginDisplayHost and a crash that leaded to not remembering error KioskAppLaunchError in a pref. Bug: 879652 Test: Manual Change-Id: I291872af300d99940cb9199cbdf62b01918ffbdc Reviewed-on: https://chromium-review.googlesource.com/1234476Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592505}
-
Mathieu Perreault authored
The feature was overriding values in |upload_request_.profiles|, which turns out was being reused for a subsequent request. We now use a temporary structure to send country-only addresses to Payments for GetUploadDetails call. This change also disables by default the SendOnlyCountryInGetUploadDetails and PaymentsCustomerData features. Bug: 878416 Test: components_unittests Change-Id: If78098e8b494cf4bba2e5049c368d87b2913a84d Reviewed-on: https://chromium-review.googlesource.com/1233815 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#592504}
-
