- 22 Feb, 2019 40 commits
-
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/xml and //blink/renderer/core/xmlhttprequest have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of XMLParserContent class, it makes sense to use USING_FAST_MALLOC because it has been used with scoped_refptr<> In DeferredEvent class case, it makes sense to use DISALLOW_NEW because it has been used by a member variable with a reference. Bug: 919389 Change-Id: I18da5a1078b91caec8ad69c338ef874c9395f7e5 Reviewed-on: https://chromium-review.googlesource.com/c/1482280Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634651}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/workers has not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of InstalledScriptsManager, WorkerBackingThread, and WorkerSettings classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. Bug: 919389 Change-Id: I9d57544ae8a64ccf5c7a79fe9db95693902aefa8 Reviewed-on: https://chromium-review.googlesource.com/c/1482279Reviewed-by:
-
Alex Clarke authored
Some PostTask closures do exciting things on destruction like posting other tasks. Some of them call ThreadTaskRunnerHandle::Get and these where crashing because it had gone away. This patch fixes that. Bug: 933295 Change-Id: I7f48e2743dcebe38f9f6e9f08030d762760fc733 Reviewed-on: https://chromium-review.googlesource.com/c/1482954Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634649}
-
Stephane Zermatten authored
With this change, with verbose level 3 enabled, we can see the rectangles that form the touchable element area, as defined by the script, if any. Bug: 806868 Change-Id: I2fb28988bb1a7db62d3fab907868d0d81df9be86 Reviewed-on: https://chromium-review.googlesource.com/c/1479961 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634648}
-
Clemens Arbesser authored
The text was changed to match the description in the doc: https://docs.google.com/document/d/1rtaxREBeL9gp4vRcwGgoxkGlQ8ns08aZqBxRUNrTUqc/edit#bookmark=id.kzi3ubtldlm3. Also fixed an issue where a line break was inserted in between the 'learn more' link. Bug: 806868 Change-Id: I34f3bdda778b854da46751d80ddd9ee27df21717 Reviewed-on: https://chromium-review.googlesource.com/c/1480002Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#634647}
-
Maks Orlovich authored
This permits to check it against list of cookieable schemes (fixing #850044), and is a prerequisite for getting rid of SetCookieWithOptionsAsync in favor of everything using SetCanonicalCookieAsync. Bug: 850044 Change-Id: I890cf266767a124b116fc553932a74b5a97ed943 Reviewed-on: https://chromium-review.googlesource.com/c/1450420 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634646}
-
Roman Sorokin authored
Bug: none Change-Id: I03bb3dbe57b254e35b8946bf42c78a613a59d661 Reviewed-on: https://chromium-review.googlesource.com/c/1482458 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#634645}
-
David Roger authored
InlineLoginHandlerImpl can only be used when force signin is enabled, or with the Google Credential Provider on windows. This CL removes support for other flows. Bug: 915678 Change-Id: I0ceff59eef46d8be957a5d55e597c3a1925ed92b Reviewed-on: https://chromium-review.googlesource.com/c/1466984 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#634644}
-
Hans Wennborg authored
Otherwise the 'size' command doesn't work unless there's a system xcode around, which there isn't on newer buildbots. Bug: 934698 Change-Id: I930ee63b695ab000efa301abc2c169111eb66da3 Reviewed-on: https://chromium-review.googlesource.com/c/1482950 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634643}
-
Konstantin Ganenko authored
Previously simple cache 2 stream's EOF signature was checked at end of the read, not when the entry was opened. R=morlovich@chromium.org Change-Id: Ic7672fbaa7bcec19337a9004da8c966b8a0029c7 Reviewed-on: https://chromium-review.googlesource.com/c/1477830Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Konstantin Ganenko <ganenkokb@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#634642}
-
Polina Bondarenko authored
Create new boolean policy to control wilco diagnostics and telemetry controller if it is present on the device. BUG=b:123926018 TEST=unit_tests Change-Id: I8161a36424310fbabfc580d3931121dc7a5c5492 Reviewed-on: https://chromium-review.googlesource.com/c/1456075 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#634641}
-
Stephane Zermatten authored
Before this change, the UI was destroyed when switching tab - even if it mean that it would be re-created if switching back to the current tab, or when switching to another tab with Autofill Assistant running. With this change, the UIController is kept around, just hidden, during tab switch, when no tabs are selected. Once a new tab is selected, the UIController is then either: - re-shown, if the same tab was selected - destroyed if a tab without AA was selected - attached to another controller if a tab with AA was selected In the last part, ownership of the UIController is transferred to the new tab's client. With this change, AssistantCoordinator is not tied to a specific WebContents anymore. The components that need access to WebContents are updated when attaching the UI to a new Controller. For background, see go/aa-any-tab Bug: 806868 Change-Id: Iac50dcf0acc53eb02bd684dba3c2824f284d75d5 Reviewed-on: https://chromium-review.googlesource.com/c/1475409 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#634640}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45af00f33bfc..65438812ba0d git log 45af00f33bfc..65438812ba0d --date=short --no-merges --format='%ad %ae %s' 2019-02-22 aleloi@webrtc.org 2nd reland of https://webrtc-review.googlesource.com/c/src/+/114883 2019-02-22 alessiob@webrtc.org PFFFT C++ wrapper for APM Created with: gclient setdep -r src/third_party/webrtc@65438812ba0d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic709108d742f77bb55027e045e605ef5e6c80f6c Reviewed-on: https://chromium-review.googlesource.com/c/1482627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634639}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e1bc9a8d48c..6abcf043ece1 Created with: gclient setdep -r src-internal@6abcf043ece1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4d13d51d979a05dbf7e956cd3b7bc80ab4d438a Reviewed-on: https://chromium-review.googlesource.com/c/1483110Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634638}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c4b8be31..ac7e7332 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If358a956662d3bc583c6d5951fa2498abd22d8f7 Reviewed-on: https://chromium-review.googlesource.com/c/1482601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634637}
-
Sergiy Belozorov authored
R=perezju@chromium.org Bug: 895891 Change-Id: I0bfd1342187e809cbe4e51daaa5eebfa145d3389 Reviewed-on: https://chromium-review.googlesource.com/c/1477709 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#634636}
-
Marc Treib authored
Previously, the code to detect unrecoverable errors and emit a corresponding message was duplicated in GetStatusLabelsImpl(). This CL pulls it out of the if/else and thus combines the two. One behavior difference is when an unrecoverable error happens while the initial Sync setup is in progress: Previously that was treated as "setup in progress", now it's treated as an unrecoverable error, which seems preferable. Bug: 911153 Change-Id: I16275d65a9c6c2be97754d948c5ebddfd9b492ad Reviewed-on: https://chromium-review.googlesource.com/c/1478810 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#634635}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7cddd1ec983..fdd15284affe git log b7cddd1ec983..fdd15284affe --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@fdd15284affe The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2de166a665f194ab32736af872d736c57cb73728 Reviewed-on: https://chromium-review.googlesource.com/c/1482628Reviewed-by:
-
Alexandre Courbot authored
The name of this class is very misleading. What it actually does is serve as a base class for common functionality of V4L2ReadableBufferRef and V4L2WritableBufferRef. Change the name to V4L2BufferRefBase to better reflect that fact. Bug: 792790 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: Icf91c801487201d165c568c668ed5f4496587c0a Reviewed-on: https://chromium-review.googlesource.com/c/1481188 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634633}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 81d80354. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" f82f5505 "[LayoutNG] Fix inline-level OOFs inside a block-level context." 1a46f4bb "v8binding: Make PaintWorkletGlobalScope use IDL callback function" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I3ab17c47978479fb5321b0dad4c78ec64bd1ca74 Reviewed-on: https://chromium-review.googlesource.com/c/1482600Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634632}
-
Christos Froussios authored
This reverts commit 735b1fdc. Reason for revert: Speculative revert did not fix the failure Original change's description: > Revert "Fix search restart after zero entries (again)." > > This reverts commit d41579e2. > > Reason for revert: Speculative revert. > This is the only CL in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel/325 when it started to break. > > Original change's description: > > Fix search restart after zero entries (again). > > > > The fix was lost in refactoring that ended up duplicating > > the last_find_request_completed_with_no_matches_ member. > > > > BUG=669983 > > > > Change-Id: I09229496d183ef3f9b69c6089a6ac3ecd8b5ef82 > > Reviewed-on: https://chromium-review.googlesource.com/c/1477835 > > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#634599} > > TBR=haraken@chromium.org,rakina@chromium.org,allan.jensen@qt.io > > Change-Id: I5b59c759eb23e526892b8fdab7ed580306cfd6d6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 669983 > Reviewed-on: https://chromium-review.googlesource.com/c/1482455 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634625} TBR=haraken@chromium.org,cfroussios@chromium.org,rakina@chromium.org,allan.jensen@qt.io Change-Id: Ia19ee92cf309fa3b2554c226170412c4722bcbce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669983 Reviewed-on: https://chromium-review.googlesource.com/c/1483079Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634631}
-
Samuel Huang authored
LLD creates '.Lswitch.table._Z...' symbols, which llvm-cxxfilt does not properly demangle. This CL solves this problem. Details: * Updates demangle.py to detect and demangle these symbols: * E.g., '.Lswitch.table._Z3foov' is demangled to 'Switch table for foo()', which then becomes 'foo() [Switch table]' downstream. * Applies agrieve@'s idea to use the demangled names of switch tables to deduce object_path if missing (happens most of the time), by looking up the object_path of the symbol for the containing function. * Caveat: Some switch table symbols have suffices like ' (.123)', which need to be stripped. * For ~5% of cases for Chrome (with thin-LTO) there are multiple matching functions with different object files. For this, we simply arbitrate and take the first one found. Bug: 923936 Change-Id: I30a6cdaabee2191b197ef05a643d704574e50344 Reviewed-on: https://chromium-review.googlesource.com/c/1481744 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#634630}
-
Tanmoy Mollik authored
This is a reland of http://crrev.com/633591 . There were a small error in that patch. That patch also only added statistics in the background. This patch modifies the histogram.xml and memory_emitter.cc file to reflect it on UMA. Bug: 931669 Change-Id: Ic03717102ab2a2126e716c024464222372e15990 Reviewed-on: https://chromium-review.googlesource.com/c/1475404 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3acdefa9aad9..b1b14cdf2bee git log 3acdefa9aad9..b1b14cdf2bee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 hferreiro@igalia.com Limit the rebase-update call after reparent-branch Created with: gclient setdep -r src/third_party/depot_tools@b1b14cdf2bee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I116f778184a71389bf27afb1dd66faa236dccb3d Reviewed-on: https://chromium-review.googlesource.com/c/1482623Reviewed-by:
-
Kush Sinha authored
Summary of changes: - Remove subscription from Chrome OS Account Manager. - Use IdentityManager as the source of truth for account updates. IdentityManager transitively uses Chrome OS Account Manager as the source of truth for Chrome OS accounts. - Remove usages of AccountTrackerService and AccountMapperUtil since they are no longer needed. Bug: 925827 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: If1caea0580eda094466c5fe17565013a038383c5 Reviewed-on: https://chromium-review.googlesource.com/c/1480518 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:Yury Khmel <khmel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634627}
-
Christos Froussios authored
because it is flaky TBR=mmenke@chromium.org Bug: 934778 Change-Id: I06f222489a3bcc61d6b5b6f2ce2b7f3559ad65aa Reviewed-on: https://chromium-review.googlesource.com/c/1483051 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Christos Froussios authored
This reverts commit d41579e2. Reason for revert: Speculative revert. This is the only CL in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel/325 when it started to break. Original change's description: > Fix search restart after zero entries (again). > > The fix was lost in refactoring that ended up duplicating > the last_find_request_completed_with_no_matches_ member. > > BUG=669983 > > Change-Id: I09229496d183ef3f9b69c6089a6ac3ecd8b5ef82 > Reviewed-on: https://chromium-review.googlesource.com/c/1477835 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634599} TBR=haraken@chromium.org,rakina@chromium.org,allan.jensen@qt.io Change-Id: I5b59c759eb23e526892b8fdab7ed580306cfd6d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669983 Reviewed-on: https://chromium-review.googlesource.com/c/1482455Reviewed-by:
-
Rakina Zata Amni authored
When a shadow root with non-empty |adoptedStyleSheets| is inserted, we should make sure that the |active_tree_scopes_| list is updated and the tree scope is marked dirty so that style invalidation & recalc will work. Bug: 934340 Change-Id: I365936e4bcc0132c938fe4e200e208abac91d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1482437 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#634624}
-
Colin Blundell authored
identity_services_provider_android.cc serves as the glue between the Java Profile object and the Java signin-related objects associated with that Profile. In particular, it allows for getting the Java AccountTrackerService and OAuth2TokenService objects associated with the Java Profile. This mapping isn't done in Java itself as the Java Profile object does not have a concept of KeyedServices. When we have internalized usage of these classes behind IdentityManager in Java, this glue will naturally be only on IdentityManager rather than on the underlying internal classes. In order to enable the completion of internalization of the C++ classes (of which this is one of the very few remaining blockers), we are introducing legacy C++ APIs on IdentityManager to get the Java objects for AccountTrackerService and ProfileOAuth2TokenService. Bug: 934701 Change-Id: Iab70b66a14892dcb37a6924e1e76742b5ac570a4 Reviewed-on: https://chromium-review.googlesource.com/c/1482793Reviewed-by:
-
Christos Froussios authored
The test is timing out on WebKit Linux Trusty MSAN. Example https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20MSAN/12923 The failure was probably introduced with https://chromium.googlesource.com/chromium/src/+/69d311c45f95b958dfdf07fd2a48469ca94015d7 Bug: 929122 No-try: True No-presubmit: True Change-Id: I494a4c6d9619d368577dd4a4924398d708b27d96 Reviewed-on: https://chromium-review.googlesource.com/c/1482898Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dceb02b288e4..6e1bc9a8d48c Created with: gclient setdep -r src-internal@6e1bc9a8d48c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I04efa75eee5e2b70a8c8aaa5db9b53395fe0a1fb Reviewed-on: https://chromium-review.googlesource.com/c/1482624Reviewed-by:
-
Balazs Engedy authored
Registering event handlers to `devicemotion`, `deviceorientation`, and `deviceorientationabsolute` events is still possible, but the handlers will never be invoked in non-secure browsing contexts. The following, related, interfaces are marked as [SecureContext]: -- DeviceOrientationEvent, -- DeviceMotionEvent, -- DeviceMotionEventAcceleration, -- DeviceMotionEventRotationRate. The change is gated on RestrictDeviceSensorEventsToSecureContexts, which is disabled by default, so this CL is a no-op unless the base::Feature with the same name is manually enabled. Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5yqfAXibz1I Bug: 932078 Change-Id: I9baaafd1f4483f121feadc054650c4d510a2c88d TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1473992 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#634620}
-
Colin Blundell authored
Missed when this unittest was converted. Bug: 883330 Change-Id: I2c6bfcb3de58aa741c4e33fc63ea457dc139714c Reviewed-on: https://chromium-review.googlesource.com/c/1482972Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634619}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/969659dbb313..b7cddd1ec983 git log 969659dbb313..b7cddd1ec983 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b7cddd1ec983 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: If9ab17c15dc442ff86d429b4a125e493a0b51068 Reviewed-on: https://chromium-review.googlesource.com/c/1482621Reviewed-by:
-
Friedrich Horschig authored
This CL adds a space below the last UserInfo element and the first non-UserInfo element. Effectively, this means the FooterCommands have the same padding to the UserInfo as UserInfo elements have to each other. Screenshot before: https://photos.app.goo.gl/h3By5RN2zUiDGVLw8 Screenshot after: https://photos.app.goo.gl/MVzu6uirjkkVhnBF9 Alternatives considered: 1. A static top margin for a footer command would not work here since footer commands are not supposed to have paddings between each other. 2. Adding the space relative to the first Footer Command adds a padding between the "No saved passwords" text and the footer commands if no UserInfo is available. Such padding isn't supposed to exist either. 3. Wrapping FooterCommands or UserInfos into a Layout and add the margin to the layout would work but degrades the effectiveness of the RecyclerView which wants to reuse containers. Change-Id: I63e08ab42215f81befb05bd5a26b96d27dc4b908 Reviewed-on: https://chromium-review.googlesource.com/c/1481295Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#634617}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e11b7d2e8087..45af00f33bfc git log e11b7d2e8087..45af00f33bfc --date=short --no-merges --format='%ad %ae %s' 2019-02-22 ssilkin@webrtc.org Revert "Adds resource path support for video files in scenario tests." 2019-02-22 kwiberg@webrtc.org Use `final` so that the compiler will be able to inline calls 2019-02-21 kwiberg@webrtc.org Add thread safety annotations for PeerConnection::configuration_ 2019-02-21 srte@webrtc.org Adds resource path support for video files in scenario tests. 2019-02-21 andersc@webrtc.org Make sure RTC_SUPPORTS_METAL is set in AppRTCMobile. 2019-02-21 devicentepena@webrtc.org CreateAudioProcessor: do not propagate an unset echo control factory to the AudioProcessing instance 2019-02-21 peterhanspers@webrtc.org Adding entry point for the v2 stats API. 2019-02-21 hta@webrtc.org DtlsTransport::ice_transport is const and can be called off thread 2019-02-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 94ca2b10..f39a1b89 (634089:634190) 2019-02-21 kron@webrtc.org Reland "Extend TransportSequenceNumber RTP header extension" 2019-02-21 jakobi@webrtc.org Refactor DelayManager into separate Histogram class and make it injectable for testing purposes. 2019-02-21 danilchap@webrtc.org Migrate stdlib task queue to TaskQueueBase interface Created with: gclient setdep -r src/third_party/webrtc@45af00f33bfc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:907849,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4fdff3902d583c16e383b3db12a450f4407fad39 Reviewed-on: https://chromium-review.googlesource.com/c/1482618Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a74495a2956d..0a94c0324d42 git log a74495a2956d..0a94c0324d42 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 khokhlov@google.com Clean up benchmark_runner.py Created with: gclient setdep -r src/third_party/catapult@0a94c0324d42 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iaad29a8641f444a2f4a200592f7f076d18e35e20 Reviewed-on: https://chromium-review.googlesource.com/c/1482622Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43b5c7b0..c4b8be31 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icf1715b7e157250f3fdd4c0b04bc8635b412e0dd Reviewed-on: https://chromium-review.googlesource.com/c/1482599Reviewed-by:
-
Colin Blundell authored
Helps clarify what the actual users are here. Change-Id: I8554fb008046df105e619a56a8fdd73d8269d9d3 Reviewed-on: https://chromium-review.googlesource.com/c/1477013Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634613}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4309189029fc..dceb02b288e4 Created with: gclient setdep -r src-internal@dceb02b288e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I950ec43dee6479d6bd511f5f18d2754298e08c7a Reviewed-on: https://chromium-review.googlesource.com/c/1482619Reviewed-by:
-
