- 09 Sep, 2019 40 commits
-
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in DataReductionProxy interface. - Apply pending_remote to DataReductionProxyThrottleConfigObserver argument in AddThrottleConfigObserver. Bug: 955171 Change-Id: I97e09e918f3ef206196d5f856b00a60b9e382650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787762Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#694718}
-
Rohit Agarwal authored
If the user started the browser in incognito mode and triggered a restart in regular mode, the browser was started in the incognito mode. Similarly, if the user started in the regular mode and triggered a restart in the incognito mode, the browser was started in the regular mode. The fix is to find the profile type that invoked the restart. Then use this type to modify old switch arguments which are used to create the new cmd line arguments for restart. Bug: 999085 Change-Id: Ide6e86aabb90b5a333ec10ea23e3add62a3d0e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789582Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#694717}
-
Justin Cohen authored
This reverts commit 063da117. Reason for revert: Test disabled, relanding. Original change's description: > Revert "[ios] Enable SlimNav and dependent features by default." > > This reverts commit 7c516511. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > [ios] Enable SlimNav and dependent features by default. > > > > Tentatively enabling this by default for M79. > > > > Bug: 789582 > > Change-Id: I030902ddbb1a19f5b49a847b727c439cfd10fcf9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787885 > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#694620} > > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > Change-Id: Idb139bf5eed97036ccd2d0f26d331db77786b6e8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 789582 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789152 > Reviewed-by: Yi Su <mrsuyi@chromium.org> > Commit-Queue: Yi Su <mrsuyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694670} TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org,mrsuyi@chromium.org Change-Id: Ia3470ee5f77a5171af99940b0efa32104cfdb873 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789582, 1001965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791266Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#694716}
-
Simon Que authored
CI/try builders migrated: - android-cronet-arm-dbg / android-cronet-arm-dbg - android-cronet-arm-rel / android_cronet - android-cronet-arm64-dbg - android-cronet-arm64-rel - android-cronet-asan-arm-rel - android-cronet-kitkat-arm-rel - android-cronet-lollipop-arm-rel - android-cronet-marshmallow-arm64-perf-rel - android-cronet-marshmallow-arm64-rel - android-cronet-x86-dbg - android-cronet-x86-rel - android-incremental-dbg - android-kitkat-arm-rel / android-kitkat-arm-rel - android-mojo-webview-rel - android-pie-arm64-dbg Migration schedule: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I42b3f0a21846ea4b6d20b46ed9a8850b61f3d24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780083 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#694715}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8629d82b7f98..f5102cee4165 Created with: gclient setdep -r src-internal@f5102cee4165 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I32300e5c13fa051d5cceadeb0ae01dc1a8dc8eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694714}
-
Martin Šrámek authored
TBR: mlamouri@chromium.org Bug: 1001421 Change-Id: I2916cd9443d2b169176036919491bc1c1306f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790104Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#694713}
-
Justin Cohen authored
TBR: eugenebut Bug: 789582 Change-Id: I12a1fa41211036bb94b663fae1264e7eacfdbb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790416 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694712}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce when applicable, removes calls to base::AdaptCallbackForRepeating when the returned base:: RepeatingCallback is immediately converted to a base::OnceCallback, and replaces calls to base::Passed with std::move where appropriate. This CL was uploaded by git cl split. R=morlovich@chromium.org Bug: 714018 Change-Id: Iaf6fd2df7ca796caac734053194b6ee479550b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778777 Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:Maks Orlovich <morlovich@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#694711}
-
Adam Rice authored
This reverts commit 60617f58. Reason for revert: Reverted because the interfaces have been fixed. Original change's description: > Mark QueueingStrategy methods as not webview exposed. > > These currently aren't being properly exposed in WebView and it's > causing ongoing test failures. Mark them as intentionally not exposed > for now - this can be reverted when the interfaces are fixed. > > Bug: 994324 > Change-Id: If5cf5fcf61ac6d046e913362c684430216528f40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787890 > Auto-Submit: Richard Coles <torne@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693952} TBR=torne@chromium.org,changwan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994324 Change-Id: I9028d57463d12e45f271a6b7bdf844268cc2d000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792411Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#694710}
-
Maksim Ivanov authored
Cancel the whole SAML sign-in flow when the user clicks "Back" in the security token PIN dialog. This allows to avoid the unexpected popup of Network Selection screen to the user after they click the "Back" button. It was happening because, under the hood, terminating the PIN request alone aborts the pending HTTPS connection to the SAML IdP server, which is seen as a generic network error by the Chrome Login code and leads to popping up the Network Selection screen. Also this CL makes the behavior of the Back button more consistent, since it had always been aborting the SAML sign-in before the special case of the security token PIN UI was introduced. Bug: 1001718 Test: start SAML sign-in using a smart card, click "Back" in the PIN dialog, check that no Network Selection screen pops up Change-Id: I6bb9b2e506f7330181ad7a3c560582e3cefd7d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789804Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#694709}
-
Mohamed Amir Yosef authored
This CL introduces PasswordFeatureManager class which will act as a central point for checking which feature is enable. In this CL PasswordGeneration is already migrated to be using the newly introduced class. Follow-up CLs will also include other features here. Change-Id: Iaf52f20b9846ee25ae084079f5a7a6b5dc339633 Bug: 1001122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#694708}
-
Ilya Bizyaev authored
This adds a feature flag that will be used in the near future to test experimental functionality for Ansible software management playbook generation from JSON schema. This is intentionally separated in meaning from the CrostiniAnsibleInfrastructure flag, which controls Ansible infrastructure as a whole. Test: compile Bug: 998124 Change-Id: I38fc61a4bf2c717386019ddabe8e9691c3c78be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787552Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Cr-Commit-Position: refs/heads/master@{#694707}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fcd6915ca283..3c6c057c3feb git log fcd6915ca283..3c6c057c3feb --date=short --no-merges --format='%ad %ae %s' 2019-09-09 ulan@chromium.org Handle DevTools target navigation error in WaitForJavaScriptCondition Created with: gclient setdep -r src/third_party/catapult@3c6c057c3feb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:999004 Change-Id: I347fdccebf136663a7b354931bb7bf47f7445475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694706}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/879cafdd9c15..7010f3a19670 git log 879cafdd9c15..7010f3a19670 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 fmayer@google.com Do not pass -Werror on fuzzers. Created with: gclient setdep -r src/third_party/perfetto@7010f3a19670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie56806af8799cbb76ec771e227c52a17ada09728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792562Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4b8f8f4..97a7d404 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0007425e00737757dea4ed585ccabbe0b6c25cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792313Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694704}
-
Julie Jeongeun Kim authored
This CL converts DataPipeGetterRequest to new Mojo types. It also updates Clone from data_pipe_getter.mojom and AsDataPipeGetter from blob.mojom and methods and members which implements them. Bug: 955171, 978694 Change-Id: I7e55369a870ec047c10c52ccca449c94c47744c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787760Reviewed-by:
-
Miyoung Shin authored
This CL converts MediaDevicesDispatcherHost{Ptr, Request} in blink and content to the new Mojo types. Bug: 955171, 978694 Change-Id: Icbc1606029a4c6ad3c429e165e505bec97b7b53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782192 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#694702}
-
Miyoung Shin authored
This CL converts DeviceNotifierPtr and mojo::Binding<DeviceListener> in content to the new Mojo types. Bug: 955171 Change-Id: I5636f652ea7ed3211dd725b5c3d4c8fa20b107f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786888Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#694701}
-
Takashi Toyoshima authored
Bug: 1000554 Change-Id: Id31934d890f1b833deca04122ae2b80b0fa5923b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792217Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be2e5f78b349..4d6b2691bd5d git log be2e5f78b349..4d6b2691bd5d --date=short --no-merges --format='%ad %ae %s' 2019-09-09 henrika@webrtc.org Adds setAudio[Track/Record]StateCallback interfaces to the Java ADM 2019-09-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b67ee864..82910f73 (694439:694601) Created with: gclient setdep -r src/third_party/webrtc@4d6b2691bd5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie18f58c86d3027943385f2d3b825c7d07a4ca1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792442Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b218ad19949f..76261e2a7df1 git log b218ad19949f..76261e2a7df1 --date=short --no-merges --format='%ad %ae %s' 2019-09-06 stevenperron@google.com Replace CubeFaceCoord and CubeFaceIndexAMD (#2840) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@76261e2a7df1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,syoussefi@chromium.org Bug: None Change-Id: I77ed90e821d0eb45c729f7acc4f052d3c25c217e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791789Reviewed-by:
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/renderer/loader. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=yhirano@chromium.org Bug: 891670 Change-Id: I7487025c0118106d88933abdaf931b3ce09b8aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787074 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#694697}
-
Martin Šrámek authored
TBR: mlamouri@chromium.org Bug: 1001446 Change-Id: I7bb3e123442f2ba21d188a5602e01635c9fb86ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789807Reviewed-by:
-
Tanisha Mandre authored
- Enable Flag kSettingsAddPaymentMethod for tests. - Implement set up for tests using helper methods, which navigate to the 'add credit card screen'. - Implement new matchers for the 'Add Payment method' and 'Payment Methods' buttons. Bug: 1000669 Change-Id: Ib1c7777b9e440da640ec91c188194c9d4d141291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782905 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#694695}
-
Miyoung Shin authored
This CL converts AudioProcessorControls{Ptr, Request} in content to the new Mojo types. Bug: 955171 Change-Id: I4c5f0a4f08e6d0f92750811dbd40a90cf6f0f622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786362Reviewed-by: -
Pavol Marko authored
Loading the owner key is a prerequisite to making stored device (policy) settings available over DeviceSettingsService, which can be user visible for many uses. Thus increase the priority of loading the public key (in the async path) to base::TaskPriority::USER_VISIBLE. This also fixes current issues with enrollment in autotest by avoiding a race condition where a DeviceSettingsService::Load operation started at chrome process start finishes during the active enterprise enrollment process. The fix for the root cause of that is tracked in https://crbug.com/1001822 . Bug: 979195 Test: in cros_sdk: test_that --board=${BOARD} ip_addr policy_DeviceServer.AllowBluetooth_notset passes Change-Id: I5e430d704137b0e8f6e23e4eea26346ec86834a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791143Reviewed-by:
A Olsen <olsen@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#694693}
-
Takuto Ikuta authored
This reverts commit 5abd4a9f. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/linux-gcc-rel/108347 Original change's description: > infra: Re-migrate linux-ozone-rel to Goma RBE > > This was previously reverted due to reaching the Goma RBE server > capacity limit. > https://chromium-review.googlesource.com/c/chromium/src/+/1786872 > > The limit has since been increased. > > R=bpastene@chromium.org, jbudorick@chromium.org, tikuta@chromium.org > > Bug: 1001231,950413 > Change-Id: I820be1e6128db0d6ff16c9e8d3b12207db71cf92 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789220 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Simon Que <sque@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694653} TBR=sque@chromium.org,tikuta@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Ib0e1e6fe8fb7768247dcd7ce1383c583c75e70dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1001231, 950413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792505Reviewed-by:
-
Marc Treib authored
Full Sync uses the profile storage, so if we don't clear the account storage we'll get duplicates. Bug: 998455 Change-Id: Ia60fc39cc9de36ab21d2105641062f6f6373f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789526 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#694691}
-
Kent Tamura authored
This CL removes node.h dependency from many of binding-generated .cc files. This CL doesn't change compiled code at all on macOS with the current toolchain. Bug: 242216 Change-Id: I0d00edad349b08960d7d0c0c16f42cc3cd4c5273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789208 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#694690}
-
Adam Rice authored
For workers and webview, the v8 extras versions of CountQueuingStrategy and ByteLengthQueuingStrategy were being used even when StreamsNative was enabled. Stop adding the queuing strategies unconditionally to the global in the v8 extras JavaScript. Instead put them on the binding object, and only copy them to the global in InitializeV8ExtrasBinding() if the StreamsNative feature is not enabled. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1757411 modified to let values be copied to the bindings object even when they are not needed because we are using the C++ implementation. This modification is sufficient to avoid triggering a leak in http/tests/clipboard/async-write-image-read-image.html, which was the cause of the original CL being reverted. BUG=994324 Change-Id: I29ccdc69a09027d1f89af859d002e8ac7fd4583e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787623Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27325b90a86c..8629d82b7f98 Created with: gclient setdep -r src-internal@8629d82b7f98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iee275c71806866077aa660f34b46690d20549e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791790Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4c33cade. With Chromium commits locally applied on WPT: 1f146124 "[WPT/common/security-features] Remove {mixed-content,referrer-policy}-test-case.sub.js" bfd6ddf8 "[WPT/common/security-features] Update subresource and redirection type names" 9d7721df "Strip the fragment directive and update scroll-to-text WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib83aa8d1d19c973b3f88d3a4f6dac4862c14a97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792305Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#694687}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7ff7df26f28..4f431ad17465 git log a7ff7df26f28..4f431ad17465 --date=short --no-merges --format='%ad %ae %s' 2019-09-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src b218ad19949f..76261e2a7df1 (1 commits) Created with: gclient setdep -r src/third_party/angle@4f431ad17465 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: chromium:None Change-Id: I56cf54188f8021865b3a9aa96ccd84c2eb438407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791788Reviewed-by:
-
Nikita Podguzov authored
Each proto corresponds to one print job. Bug: 992889 Change-Id: Ib63b3b6c9c90ef990ecfe008b954ce5bc13dd648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771605Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#694685}
-
Colin Blundell authored
Legacy supervised users were eliminated in M75; this CL rips out the corresponding IdentityManager support. Note: This CL makes the minimal changes to SupervisedUserService to eliminate the usage of these APIs; followup elimination of now-dead flows in that class should be possible. Bug: 860492 Change-Id: Id503f5473304a146e71e3c513d3b5018f4cb31cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729631 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#694684}
-
Jakub Vrana authored
Translations are not always under the application control and they can contain special characters. If they are used in HTML context then this can result in XSS. This change addresses it by escaping < in chrome.i18n.getMessage before substituting the placeholders (which often contain trusted HTML) if the new {escape_lt: true} option is set. This will be used by Closure Templates which generate goog.getMsg('', {}, {html: true}) which will be translated by Closure Compiler to chrome.i18n.getMessage('', {}, {escape_lt: true}) for Chrome extensions. Bug: 989413 Change-Id: I5c56af375dc443a0f6fc7ebddc038fb4a074db3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728572 Commit-Queue: Jakub Vrana <jakubvrana@google.com> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Jakub Vrana <jakubvrana@google.com> Cr-Commit-Position: refs/heads/master@{#694683}
-
Richard Knoll authored
This fixes a UAF when closing a tab while there is a SharingDialog open. Bug: 1000934 Change-Id: Ie8f6e52626ee834bc72acfe318c5a28aafe27635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789150 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#694682}
-
Rika Fujimaki authored
We made ScriptValue Traceable to replace SharedPersistent with TraceWrapperV8Reference in a follow-up CL. In this CL, most of the changes are just: - Replace Vector<ScriptValue> with HeapVector<ScriptValue> because ScriptValue has a Trace method. - Add a trace method for ScriptValue because ScriptValue is traceable. - Add a trace method for ScriptPromise because it has a ScriptValue. We recommend you to mainly check - script_value.h where I add VectorTraits. - script_promise.h where I add VectorTraits. - v8_callback_function.py where I add a code to generate HeapVector. - v8_types.py * Add ScriptValue and ScriptPromise to "is_traceable==True" which is used to generate Trace method for ScriptValue and ScriptPromise. * Add ScriptValue and ScriptPromise to "is_gc_type==True" which is used to generate HeapVector instead of Vector. Bug: 998994 Change-Id: I595a87636464e9fbf30533373995b61c89e464b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787483 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#694681}
-
Arthur Sonzogni authored
This reverts commit 48946365. Reason for revert: https://crbug.com/1001905 Original change's description: > Rolldep for QUICHE and update QUIC flags. > > > Roll src/net/third_party/quiche/src/ 43652ca17..b2486b8ca (10 commits) > > https://quiche.googlesource.com/quiche.git/+log/43652ca1735a..b2486b8ca513 > > $ git log 43652ca17..b2486b8ca --date=short --no-merges --format='%ad %ae %s' > 2019-09-06 wub gfe-relnote: (n/a) Update QuicIetfFramerTest.(Application|Connection)Close to use the new QuicConnectionCloseFrame constructor. Test only, not protected. > 2019-09-06 dschinazi Deprecate quic_drop_invalid_small_initial_connection_id > 2019-09-06 vasilvv Support the use of MESSAGE/DATAGRAM frames in QBONE. > 2019-09-06 vasilvv Switch QuicMakeUnique to std::make_unique, part 1: //third_party/quic > 2019-09-06 renjietang Remove QuicSession::RegisterStaticStream() and merge it into QuicSession::ActivateStream(). > 2019-09-06 fkastenholz Add version-aware QuicConnectionCloseFrame constructor > 2019-09-06 renjietang Use QuicSession::transport_version() instead of QuicConnection::transport_version() to make code cleaner. > 2019-09-06 fayang gfe-relnote: n/a (TODO added) > 2019-09-06 fkastenholz Change Application and Transport ConnectionClose codes to uint64_t > 2019-09-06 wub gfe-relnote: (n/a) Only increment flag count for quic_simple_inflight_time when the flag is true. Flag count only. > > Created with: > roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src > > R=rch@chromium.org > > Change-Id: I6a831fe8ab9072a639d8f6f9e16c617b325d2b0b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790486 > Commit-Queue: Bin Wu <wub@chromium.org> > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#694539} TBR=rch@chromium.org,wub@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4147cfcd0f7cb488884a730e32e0a1f2a71b0b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791145Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#694680}
-
Yoichi Osato authored
This patch changes the default values as below: --websocket-renderer-receive-quota-max: 32768-> 65500 --websocket-read-buffer-size 32768-> 131000 Performance improvement: Win10(ToT->Patch@MB/s): 270->362 Linux(ToT->Patch@MB/s): 543->683 Because this change makes Chrome consume much memory and the request is from desktop user, we've decided to leave values for Android as-is. Bug: 865001 Change-Id: I5803f60f55f7aef375c896e5a0090db1c1481dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792208 Auto-Submit: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
