1. 03 Dec, 2019 40 commits
    • Noel Gordon's avatar
      [directorytree] Style files-ng .align-right-icon to always display · e93fdb22
      Noel Gordon authored
      Files-ng allows a very narrow tree, and if too narrow, the .tree-row's
      .align-right-icon can be elided (disappear). In files-ng, add style so
      that .align-right-icon are never elided.
      
      Bug: 992819
      Change-Id: I8c2930a5093eeb77fe534a76dc6188eff5fb2f2c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947503Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
      Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
      Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
      Commit-Queue: Noel Gordon <noel@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720853}
      e93fdb22
    • chromium-autoroll's avatar
      Roll src/third_party/skia 49e564e5e02c..f888b87a74bc (1 commits) · f20ec3ed
      chromium-autoroll authored
      https://skia.googlesource.com/skia.git/+log/49e564e5e02c..f888b87a74bc
      
      git log 49e564e5e02c..f888b87a74bc --date=short --first-parent --format='%ad %ae %s'
      2019-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ea0dcd4bda18..fb40d231c3e2 (10 commits)
      
      Created with:
        gclient setdep -r src/third_party/skia@f888b87a74bc
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/skia-autoroll
      Please CC bsalomon@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Bug: None
      Tbr: bsalomon@google.com
      Change-Id: I52b7f69f432fafdeb4d0cdbb4696c5988203601e
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948212Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720852}
      f20ec3ed
    • chromium-internal-autoroll's avatar
      Roll src-internal 4e899ffa92b9..db299863e0c5 (1 commits) · 313e3ac3
      chromium-internal-autoroll authored
      https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e899ffa92b9..db299863e0c5
      
      
      Created with:
        gclient setdep -r src-internal@db299863e0c5
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
      Please CC jbudorick@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
      Bug: None
      Tbr: jbudorick@google.com
      Change-Id: I431751d3ade7ba5aca4830c35ab6a0a8740e78ef
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948349Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720851}
      313e3ac3
    • Hayato Ito's avatar
      Rename variable names (timer -> event queue) in service_worker_event_queue_test.cc · 604dd23a
      Hayato Ito authored
      Follow-up of http://crrev/c/1945951.
      
      Fix variable names in the test here so that gerrit can recognize the file renaming
      correctly in http://crrev/c/1945951.
      
      Bug: 965802
      Change-Id: Ic30e3f2991999b7575e1fd095174ad649d516cd0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946167
      Commit-Queue: Hayato Ito <hayato@chromium.org>
      Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720850}
      604dd23a
    • Koji Ishii's avatar
      [auto] Update FlagExpectations for LayoutNGFragmentItem · 3d36f250
      Koji Ishii authored
      Following bot results are included.
      499 500 501 502 503 504 505 506
      
      23 lines were removed and 7 lines were deflaked by consecutive
      results since 494.
      
      TBR=yosin@chromium.org
      NOTRY=true
      
      Bug: 982194
      Change-Id: Ia5eca640b034de3518ae1734419ff52fbdb383be
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942681Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
      Commit-Queue: Koji Ishii <kojii@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720849}
      3d36f250
    • Rachel Carpenter's avatar
      Add Help App CIPD resources to the resource bundle. · e10b3bfb
      Rachel Carpenter authored
      This means that we render the real app when ChromeOS,
      and the mock html and JS when not (for testing).
      
      Bug: 1012578, b/144121590
      Change-Id: I282b39343c110da0482481f1569ad05a57e2f736
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930360
      Commit-Queue: Rachel Carpenter <carpenterr@google.com>
      Reviewed-by: default avatarSamuel Huang <huangs@chromium.org>
      Reviewed-by: default avatarRyo Hashimoto <hashimoto@chromium.org>
      Reviewed-by: default avatarTrent Apted <tapted@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720848}
      e10b3bfb
    • Hayato Ito's avatar
      Rename ServiceWorkerTimeoutTimer to ServiceWorkerEventQueue · 20f60637
      Hayato Ito authored
      Follow-up of http://crrev/c/1906452.
      This CL intentionally did only the file renaming and necessary minimum
      changes so that Gerrit can recognize the file renaming correctly.
      
      Note if we did all follow-up tasks in one CL, Gerrit
      couldn't recognize the file renaming, as seen in http://crrev/c/1942903.
      
      Other trivial and non-trivial changes, such as PushTask -> EnqueueNormal,
      renaming functions and variables, will be included in other follow-up
      CLs.
      
      TBR=kinuko@chromium.org
      
      Bug: 965802
      Change-Id: I68ee6edfdad4083a7056928b246c6ff916619067
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945951
      Commit-Queue: Hayato Ito <hayato@chromium.org>
      Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720847}
      20f60637
    • sreejakshetty@chromium.org's avatar
      [bfcache] Don't cache pages with SelfRequestingDeleteDelegate · 4bb949f4
      sreejakshetty@chromium.org authored
      Do not put a page in the back-forward cache when the
      SelfRequestingDeleteDelegate is used.
      
      It is because ViewRequestDelegate which holds a ViewerHandle deletes
      itself after the WebContents navigates or goes away.
      
      Some background on why we sometimes need to disable bfcache:
      https://docs.google.com/document/d/1NjZeusdS1kyEkZyfLggndU1A6qVt0Y1sa-LRUxnMoK8
      
      BUG=1001087
      
      Change-Id: I535c1620f453651417a68eb8f1ab13a92e893c2a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832279Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
      Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
      Reviewed-by: default avatarCarlos Caballero <carlscab@google.com>
      Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720846}
      4bb949f4
    • Carlos Caballero's avatar
      Fix braces · bf5cc480
      Carlos Caballero authored
      Change-Id: I7d8acd5b10e2b19d8233f0ca9ece7cc4f26df827
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947723
      Commit-Queue: Mike West <mkwst@chromium.org>
      Reviewed-by: default avatarMike West <mkwst@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720845}
      bf5cc480
    • Mike West's avatar
      Verify that nested frames can navigate same-origin ancestors. · 189e65b3
      Mike West authored
      Bug: 1027148
      Change-Id: I6630788dad82d6b98f2630d7deb3cf64dccfd652
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944859Reviewed-by: default avatarChristian Biesinger <cbiesinger@chromium.org>
      Commit-Queue: Mike West <mkwst@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720844}
      189e65b3
    • Makoto Shimazu's avatar
      Reland "Revert PowerSaveBlockerLinux [2/4]" · cd9dd718
      Makoto Shimazu authored
      This reverts commit abf93b0b.
      
      Reason for revert: a few WakeLockTest are failing probably due to this. Let me try to revert this to see how it'll go.
      Sample failing build:
      https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/85013
      
      Original change's description:
      > Revert "Revert  PowerSaveBlockerLinux [2/4]"
      > 
      > This reverts commit bbfce899.
      > 
      > Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands
      > 
      > Original change's description:
      > > Revert  PowerSaveBlockerLinux [2/4]
      > > 
      > > and the subsequent  PowerSaveBlockerLinux [3/4] and  PowerSaveBlockerLinux [4/4] patches
      > > 
      > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]")
      > > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]")
      > > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]")
      > > 
      > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on
      > > Linux Tests (dbg). More details in crbug/1027852.
      > > 
      > > TBR=thomasanderson@chromium.org
      > > 
      > > Bug: 1013812,1027852
      > > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb
      > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357
      > > Commit-Queue: Tim Schumann <tschumann@chromium.org>
      > > Reviewed-by: Tim Schumann <tschumann@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#718447}
      > 
      > TBR=thomasanderson@chromium.org,tschumann@chromium.org
      > 
      > # Not skipping CQ checks because original CL landed > 1 day ago.
      > 
      > Bug: 1013812, 1027852
      > Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509
      > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
      > Reviewed-by: Tim Schumann <tschumann@chromium.org>
      > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#720760}
      
      TBR=thomasanderson@chromium.org,tschumann@chromium.org
      
      Change-Id: I317fd312d0c44b3e59bbada94df3200fa44ae3ac
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 1013812, 1027852
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947513Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
      Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720843}
      cd9dd718
    • chromium-autoroll's avatar
      Roll src/third_party/perfetto a5287b0409dc..b1bad5558240 (275 commits) · f3df187f
      chromium-autoroll authored
      https://android.googlesource.com/platform/external/perfetto.git/+log/a5287b0409dc..b1bad5558240
      
      git log a5287b0409dc..b1bad5558240 --date=short --first-parent --format='%ad %ae %s'
      2019-12-02 lalitm@google.com trace_processor: add helper methods for adding constraints on typed cols
      2019-12-02 zakerinasab@google.com Merge "Add Vulkan memory tracker config to trace config"
      2019-12-02 hjd@google.com Merge "perfetto-cmd: Reset guardrail state on boot"
      2019-12-02 taylori@google.com Merge "Create a reusable thread_state table"
      2019-12-02 lalitm@google.com Merge "trace_processor: Replace FATAL with error stat"
      2019-12-02 rslawik@google.com Merge "Add all matched packages to process metadata"
      2019-12-02 hjd@google.com Merge "fuzzer: Remove bad CHECK on Send"
      2019-12-02 tneda@google.com perfetto-ui: Prevent lots of flamegraph queries being queued
      2019-11-29 ilkos@google.com Merge "trace_processor: fix span outer join when one of the tables is empty"
      2019-11-29 rslawik@google.com Merge "Find system ion size during LMK"
      2019-11-29 hjd@google.com Merge "perfetto-cmd: Add --upload flag"
      2019-11-28 tneda@google.com Merge "Refactoring - changing TODO labels"
      2019-11-28 hjd@google.com Merge "trace_processor: Clear sort queues on ForceExtract"
      2019-11-28 tneda@google.com Merge "Expanding details panel to full height when selection is heap profile"
      2019-11-28 ilkos@google.com Merge "trace_processor: fix incorrect DCHECK and loop condition"
      2019-11-28 primiano@google.com Merge "Protozero decoder: skip large fields, don't abort parsing"
      2019-11-28 ilkos@google.com Fix non-reentrant metadata
      2019-11-28 lalitm@google.com trace_processor: fix filtering on long and string and add tests
      2019-11-28 skyostil@google.com Merge "TrackEvent: Start using boot time where available"
      2019-11-28 skyostil@google.com Merge "TrackEvent: Add support for raw debug annotations"
      2019-11-28 ilkos@google.com Merge "Add statsd subscription id to trace metadata"
      2019-11-28 ilkos@google.com Fix cost estimation for single row
      2019-11-28 rslawik@google.com Merge "Create views and table only if they do not exist"
      2019-11-27 ilkos@google.com Plumb build fingerprint to trace processor
      2019-11-27 nuskos@google.com Merge "Add a new typed argument proto to encapsulate chromium's scheduler state."
      2019-11-27 lalitm@google.com Merge "trace_processor: improve testing of cost estimation"
      2019-11-27 lalitm@google.com Merge "trace_processor: prepare for distribution"
      2019-11-27 rslawik@google.com Merge "Define LMK reason metric"
      2019-11-27 buss@google.com Fix android x64 compilation using Ninja.
      2019-11-27 nuskos@google.com Merge "Switch TRACE_EVENT to something that is only one line of code."
      2019-11-26 primiano@google.com Merge "Reduce entropy in tools/trace_to_text"
      2019-11-26 hjd@google.com Merge "trace_processor: improve costing algorithm to better account for sort"
      2019-11-26 skyostil@google.com Merge "TrackEvent: Add support for debug annotations"
      2019-11-26 primiano@google.com Fix chromium build, remove some assert_no_deps
      2019-11-26 rslawik@google.com Merge "Refactor: define oom_score_adj span once"
      2019-11-26 fmayer@google.com Merge "Handle DeobfuscationMapping."
      2019-11-26 tneda@google.com Merge "perfetto-ui: Changing picture in the record page for heap profiling"
      2019-11-26 primiano@google.com Merge "Remove libprotobuf from IPC layer"
      2019-11-26 primiano@google.com Merge "tools(tmux): correctly find ninja"
      2019-11-26 tneda@google.com perfetto-ui: Moving heap profile flamegraph to details panel
      2019-11-25 primiano@google.com Fix build and address nits from aosp/1172102
      2019-11-25 primiano@google.com Merge "Non functional refactorings to gen classes"
      2019-11-25 lalitm@google.com Merge "trace_processor: take into account asc/desc for eliminating constraints"
      2019-11-25 lalitm@google.com trace_processor: update metrics to stop using ref/ref_type
      2019-11-25 lalitm@google.com Merge "trace_processor: eliminate useless order by constraints from query set"
      2019-11-25 rsavitski@google.com Merge "traced_perf: build in-tree (i.e. add to Android.bp)"
      2019-11-25 fmayer@google.com Merge "Add data source names to data_source_config proto."
      2019-11-25 lalitm@google.com Merge "trace_processor: migrate all slice/counter tests to use track instead of ref"
      2019-11-22 primiano@google.com Fix Chromium roll on windows
      2019-11-22 primiano@google.com Merge "Minor fixes to IPC proto and build files"
      2019-11-22 rtenneti@google.com Merge "Revert "Add proto for recording VkDebugMarkerSetObjectNameEXT""
      2019-11-22 chiur@google.com Merge "Add proto for recording VkDebugMarkerSetObjectNameEXT"
      2019-11-22 lalitm@google.com Merge "trace_processor: expose set_name function"
      2019-11-22 ilkos@google.com Merge "Add build fingerprint to system info"
      2019-11-22 fmayer@google.com Merge "Allow to produce DeobfuscationMapping from proguard map."
      2019-11-22 lalitm@google.com trace_processor: remove ref and ref_type from test outputs
      2019-11-22 lalitm@google.com Merge "trace_processor: refactor process tracking to be more clear"
      2019-11-21 oysteine@google.com Merge "perfetto: expose non minimal protos as public in bazel"
      2019-11-21 hjd@google.com Merge "traced_probes: Bump atrace timeout"
      2019-11-21 lalitm@google.com Merge "perfetto: roll trace processor and traceconv"
      2019-11-21 eseckler@google.com Merge "processor: Make it possible to configure the string pool block size."
      2019-11-21 primiano@google.com Merge "Protozero-gen: don't depend on .pbzero.* from .gen.*"
      2019-11-21 lalitm@google.com Merge "trace_processor: fix string is not null typo"
      2019-11-21 lalitm@google.com Merge "gn: ensure that highest proto visibility is preserved when merging"
      2019-11-21 hjd@google.com Merge "perfetto-cmd: Remove 10mb upload limit on user"
      2019-11-21 eseckler@google.com Merge "ui: Link to public version of extension page"
      2019-11-21 lalitm@google.com trace_processor: fix userspace Android slice tracking
      2019-11-21 fmayer@google.com Fix dep path.
      2019-11-21 ilkos@google.com Add missing group by for clarity
      2019-11-20 ilkos@google.com Merge "Improve process to package matching"
      2019-11-20 rsavitski@google.com Merge "traced_perf: basic producer scaffolding with logging of samples on Flush."
      2019-11-20 rsavitski@google.com Merge "traced_perf: trivial config proto (PerfEventConfig) for further development."
      2019-11-20 taylori@google.com Merge "Fix bazel build"
      2019-11-20 fmayer@google.com Merge "Add parser for proguard maps."
      2019-11-20 fmayer@google.com Merge "Add calloc fix to CHANGELOG."
      2019-11-20 fmayer@google.com Merge "Properly sample calloc calls."
      2019-11-20 lalitm@google.com Merge "trace_processor: pass through 0 and -1 dur slices in span join"
      2019-11-20 lalitm@google.com Merge "trace_processor: make Next in span join more explicit"
      2019-11-20 taylori@google.com Merge "Parse the gfp_flags field based on kernel version"
      2019-11-20 taylori@google.com Merge "perfetto-ui: Scrollable details panel"
      2019-11-20 tneda@google.com Merge "perfetto-ui: Trace with large start ts has out-of-memory crash"
      2019-11-19 primiano@google.com Merge "Bazel: allow embedder to depend on intermediate proto targets"
      2019-11-19 skyostil@google.com Merge "TrackEvent: Rename track event context for readability"
      2019-11-19 rsavitski@google.com Merge "traced_probes: "sched" atrace group: remove sched_wakeup"
      2019-11-19 ilkos@google.com Merge "trace_processor: fix subtle bug in test"
      2019-11-19 rsavitski@google.com tmux script fixup: eat double quotes again
      2019-11-19 primiano@google.com Merge "Fix bazel build: Remove dep on wire_protocol"
      2019-11-19 tneda@google.com Merge "perfetto-ui: Improvements in hovering text in flamegraph"
      2019-11-19 hjd@google.com Merge "Revert "Add statsd logging to perfetto_cmd""
      2019-11-19 ilkos@google.com Merge "Join with packages and align protos"
      2019-11-19 primiano@google.com Merge "Fix incremental builds: rm before creating .a archives"
      2019-11-19 fmayer@google.com Merge "Add protos and cols for deobfuscation."
      2019-11-19 hjd@google.com Merge "Add statsd logging to perfetto_cmd"
      2019-11-19 primiano@google.com Merge "Fix tmux on mac"
      2019-11-19 hjd@google.com Merge "perfetto-ui: npm audit fix"
      2019-11-19 ilkos@google.com Merge "Remove unused process growth"
      2019-11-19 primiano@google.com Use protozero in IPC framing protocol
      2019-11-19 primiano@google.com Switch TracingService to use protozero
      2019-11-19 primiano@google.com Use protozero in .gen.cc proto->C++ classes
      2019-11-18 eseckler@google.com Merge "processor: Support delta timestamps and other units in ClockTracker"
      2019-11-18 zakerinasab@google.com Merge "Update Vulkan memory tracker counters"
      2019-11-18 tneda@google.com Merge "perfetto-ui: Showing demangled name in flamegraph if any"
      2019-11-18 hjd@google.com Merge "base: Change UUID to class"
      2019-11-18 lalitm@google.com Merge "trace_processor: order ID constraints to the start of the constraint set"
      2019-11-18 lalitm@google.com Merge "trace_processor: add ahead-of-time index computation on repeated queries"
      2019-11-18 fmayer@google.com Merge "Document positional arguments to Insert for heap graphs."
      2019-11-18 hjd@google.com Merge "Update to use new UUID format"
      2019-11-18 lalitm@google.com Merge "trace_processor: add copy/move constructors to potentially fix compile"
      2019-11-18 ilkos@google.com Merge "Add process uid to the trace processor"
      2019-11-18 lalitm@google.com Merge "trace_processor: remove ts/dur DCHECK on span join"
      2019-11-15 lalitm@google.com Merge "perfetto: remove IS_TRIVIALLY wrapper macros"
      2019-11-15 fmayer@google.com Merge "Reland "Support packed fields for HeapGraph.""
      2019-11-15 lalitm@google.com Merge "trace_processor: revamp sorting algorithm"
      2019-11-15 lalitm@google.com Merge "trace_processor: fix sqlvalue comparision"
      2019-11-15 lalitm@google.com trace_processor: remove ids from test files
      2019-11-15 fmayer@google.com Merge "Revert "Support packed fields for HeapGraph.""
      2019-11-15 fmayer@google.com Merge "Support packed fields for HeapGraph."
      2019-11-15 lalitm@google.com Merge "trace_processor: stop asan android benchmarks from timing out on CI"
      2019-11-15 fmayer@google.com Merge "Manually maintain stack for heap graph walk."
      2019-11-15 lalitm@google.com Merge "ui: switch UI to use track id instead of ref/ref_type"
      2019-11-14 ilkos@google.com Merge "Write process tree when polling /proc irrespective of on-demand quirk"
      2019-11-14 hjd@google.com Merge "Add lsb/msb UUID in trace proto"
      2019-11-14 hjd@google.com Merge "traced_probes: Ignore ip field on print events"
      2019-11-14 lalitm@google.com Merge "Update Vulkan memory tracker counters"
      2019-11-14 lalitm@google.com trace_processor: add benchmarks for measuring sort performance
      2019-11-14 tneda@google.com perfetto-ui: Adding different viewing options for heap profile flamegraph
      2019-11-14 tneda@google.com perfetto-ui: Integrate merging callsites with expanding
      2019-11-14 lalitm@google.com trace_processor: add special handling of constraints on sorted cols
      2019-11-14 lalitm@google.com trace_processor: fix sort setting flags on correct columns
      2019-11-13 eseckler@google.com Merge "processor: Ignore track events with absolute 0 timestamp"
      2019-11-13 lalitm@google.com trace_processor: add benchmarks for sorted columns
      2019-11-13 eseckler@google.com Merge "build: Fix chrome build after aosp/1163504"
      2019-11-13 tneda@google.com Merge "perfetto-ui: Merging small callsites in flamegraph"
      2019-11-13 eseckler@google.com Merge "build: Fix chrome ODR violations"
      2019-11-13 fmayer@google.com Merge "Allow to specify maximum block time."
      2019-11-13 skyostil@google.com Merge "protozero: Add arrow operator to repeated field iterator"
      2019-11-13 primiano@google.com Minor cleanups in preparation of protobuf -> zero migration
      2019-11-12 skyostil@google.com Merge "TrackEvent: Add support for instant events"
      2019-11-12 skyostil@google.com Merge "TrackEvent: Add support for scoped events"
      2019-11-12 eseckler@google.com Merge "ui: Fix persisting of target selection on record page"
      2019-11-12 primiano@google.com trace_processor: don't use cxxabi for demangling on windows
      2019-11-12 eseckler@google.com Merge "trace_processor: make stringpool not commit by default"
      2019-11-12 skyostil@google.com TrackEvent: Check that category names are well formed
      2019-11-12 tneda@google.com Merge "trace_processor: Implementing "demangle" SQL function"
      2019-11-12 oysteine@google.com Update EXPORT_JSON to output stack samples in a matching format to the legacy viewer
      2019-11-12 lalitm@google.com Merge "trace_processor: rework best index logic again"
      2019-11-12 fmayer@google.com Merge "Disable AllGraphs test."
      2019-11-12 lalitm@google.com Merge "trace_processor: remove kId flag"
      2019-11-12 fmayer@google.com Merge "Only run HeapGraphWalker::AllGraphs on standalone builds."
      2019-11-12 fmayer@google.com Merge "Mention UI for recording profiles."
      2019-11-12 fmayer@google.com Merge "Add new assertion to HeapGraphWalkerTest::AllGraphs"
      2019-11-12 rsavitski@google.com Merge "ftrace probe: fix padding size calculation being off by 4 bytes"
      2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained."
      2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices"
      2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor"
      2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)"
      2019-11-11 fmayer@google.com Merge "Wait for app to stop in java hprof CTS."
      2019-11-08 cferris@google.com Merge "Rename heapprofd_iterate to heapprofd_malloc_iterate."
      2019-11-08 oysteine@google.com Merge "Re-land "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence""
      2019-11-08 eseckler@google.com processor: Build all of TP on chrome desktop platforms
      2019-11-08 fmayer@google.com Merge "Do not block on control socket."
      2019-11-08 rsavitski@google.com Merge "compact sched_waking: cfg/trace protos"
      2019-11-08 rsavitski@google.com Merge "ui: remove "idle process" process/thread tracks (utid 0)"
      2019-11-08 lalitm@google.com trace_processor: fix counter values best index logic
      2019-11-08 ilkos@google.com Encapsulate the totals on the heap profiles metrics
      2019-11-08 ilkos@google.com Java heap stats metrics
      2019-11-07 lalitm@google.com Merge "trace_processor: fix test failure and swap around counter <-> counter_values"
      2019-11-07 skyostil@google.com Merge "Lift function debug signature into a compiler specific macro"
      2019-11-07 lalitm@google.com trace_processor: rework xBestIndex handling by making it more flexible
      2019-11-07 lalitm@google.com trace_processor: fix broken iteration logic in thread and proces tables
      2019-11-07 lalitm@google.com trace_processor: add missing new/legacy views
      2019-11-07 fmayer@google.com Merge "Add disabled test-case for incorrect unique_retained."
      2019-11-07 primiano@google.com Merge "Move CopyablePtr from base to protozero"
      2019-11-07 skyostil@google.com Merge "TrackEvent: Add support for interned state"
      2019-11-07 lalitm@google.com Merge "trace_processor: move counter_definitions to new macro tables"
      2019-11-07 ilkos@google.com Merge "UUID in TraceMetadata"
      2019-11-07 fmayer@google.com Merge "Do not use garbage object for unique_retained / retained calculation."
      2019-11-07 eseckler@google.com Merge "core: Expose kMaxPreambleBytes from TracePacket"
      2019-11-07 primiano@google.com Merge "UI: feature-detect window.chrome, make firefox friendly"
      2019-11-07 primiano@google.com Merge "infra: quality of life"
      2019-11-06 fmayer@google.com Merge "Disable fdsan after clone(2)."
      2019-11-06 eseckler@google.com Merge "processor: Some more fixes for chromium json export"
      2019-11-06 lalitm@google.com Merge "trace_processor: optimize filtering a range into a BitVector"
      2019-11-06 lalitm@google.com Merge "trace_processor: improve SelectRangeWithBv for start == 0 case"
      2019-11-06 lalitm@google.com Merge "trace_processor: make filtering of non-null columns faster"
      2019-11-06 primiano@google.com Merge "protozero: simplify packed field and allow heap growth"
      2019-11-06 ilkos@google.com Add heap profiler test for jit frames
      2019-11-06 fmayer@google.com Merge "Revert "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence""
      2019-11-06 hjd@google.com Merge "trace_processor: Don't leak memory on invalid zip"
      2019-11-05 oysteine@google.com Merge "Un-inline the Rpc default constructor."
      2019-11-05 fmayer@google.com Merge "More efficiently track unique_retained."
      2019-11-05 taylori@google.com Merge "perfetto-ui: Only do logs queries when there are logs"
      2019-11-05 rsavitski@google.com Merge "Bump googletest version to match external/googletest in aosp"
      2019-11-05 taylori@google.com Merge "Fix parsing of systrace events"
      2019-11-05 hjd@google.com Merge "Increase max buffer to 128mb size when uploading"
      2019-11-04 oysteine@google.com Merge "Stack profiles: Reuse existing frame/module rows rather than adding one per sequence"
      2019-11-04 eseckler@google.com Merge "processor: Add back ifdefs around json-related cc files"
      2019-11-04 zakerinasab@google.com Merge "Docs: Add running UI and docs server to running.md"
      2019-11-04 lalitm@google.com trace_processor: add RowMap iterator and use in Table iterator
      2019-11-04 lalitm@google.com Merge "trace_processor: add benchmark for table iterator"
      2019-11-04 eseckler@google.com Merge "processor: Extract HeapGraph parsing into module"
      2019-11-04 taylori@google.com Merge "perfetto-ui: Condense track size"
      2019-11-04 lalitm@google.com Merge "trace_processor: add support for like constraint"
      2019-11-04 lalitm@google.com Merge "trace_processor: add benchmarks for filtering parent col in child"
      2019-11-04 fmayer@google.com Merge "Count retained and uniquely retained bytes."
      2019-11-04 nuskos@google.com Merge "Add 'mojom' to ipc tracing and 'navigation' and 'browser' to navigation & loading."
      2019-11-04 skyostil@google.com Merge "TrackEvent: Migrate from legacy_event.name_iid to track_event.name_iid"
      2019-11-04 eseckler@google.com Merge "processor: Retain original event ids during export + always export args"
      2019-11-04 hjd@google.com Merge "Support UUID"
      2019-11-04 eseckler@google.com Merge "processor: Don't build VulkanMemoryTracker if graphics module disabled"
      2019-11-04 eseckler@google.com Merge "processor: Exclude syscalls from build if not needed"
      2019-11-03 primiano@google.com Merge changes I8956e3c0,I28fd0043,I29e5b6f5,I7f6222ce
      2019-11-01 skyostil@google.com Merge "TrackEvent: Add support for arguments"
      2019-11-01 tneda@google.com Merge "perfetto-ui: Button to minimize/maximize track with heap profile flamegraph"
      2019-11-01 eseckler@google.com Merge "processor: Remove stale memory_tracker.h/cc files"
      2019-11-01 primiano@google.com Merge "Fix CI script to actually delete directory"
      2019-11-01 primiano@google.com Merge "UI: Fix undefined in scroll handler"
      2019-11-01 eseckler@google.com Merge "processor: Support disabling json importer separately from export_json"
      2019-11-01 primiano@google.com CI: Don't run benchmarks under sanitizers and debug
      2019-11-01 eseckler@google.com processor: Make sql/sqlite layer optional at compile time
      2019-11-01 eseckler@google.com processor: Replace pbzero includes in importer headers with fwd decls
      2019-10-31 oysteine@google.com Merge "Do not add samples/callstack which reference invalid data"
      2019-10-31 fmayer@google.com Merge "Proto format fixes."
      2019-10-31 primiano@google.com Merge "UI: Simplify WASM interop"
      2019-10-31 fmayer@google.com Merge "Fix next ID."
      2019-10-31 lalitm@google.com Merge "trace_processor: make table rowmaps ranges by default"
      2019-10-31 lalitm@google.com Merge "trace_processor: make filtering more efficient by filtering on type"
      2019-10-31 zakerinasab@google.com Merge "Fix multiple issues in vulkan memory tracker"
      2019-10-31 lalitm@google.com Merge "trace_processor: add three more benchmarks for filtering code"
      2019-10-31 hjd@google.com Merge "Enforce constructor constraints for uniform_int_distribution"
      2019-10-31 primiano@google.com Merge "UI; unify File/ArrayBuffer/fetch() into TraceStream"
      2019-10-31 tneda@google.com Merge "perfetto-ui: Correctly opening trace via link with only heap profile"
      2019-10-31 eseckler@google.com Merge "processor: Don't override system process/thread names with Chrome's"
      2019-10-31 lalitm@google.com trace_processor: switch SparseVector to use RowMap instead of BitVector
      2019-10-31 lalitm@google.com Merge "trace_processor: improve filter performance by iterating over col rowmaps"
      2019-10-31 fmayer@google.com Merge "Increase trace duration of runtime HeapprofdCtsTest."
      2019-10-30 delphij@google.com DO NOT MERGE - qt-qpr1-dev-plus-aosp-without-vendor@5915889 into stage-aosp-master
      2019-10-30 fmayer@google.com Merge "Block client for heapprofd CTS."
      2019-10-30 taylori@google.com Merge "perfetto-ui: Add tabs to the details panel"
      2019-10-30 hjd@google.com Merge "Fix use of NullTermStringView and enable test cases"
      2019-10-30 hjd@google.com Merge "trace_processor: Add boiler plate for binder events"
      2019-10-30 hjd@google.com Merge "Improve error for bad enums in txt format configs"
      2019-10-30 eseckler@google.com protozero: Improve runtime of cppgen enum/type gen
      2019-10-30 eseckler@google.com protozero: Make generated cpp enum/class order stable
      2019-10-29 primiano@google.com Trace Processor: Add RestoreInitialTables() method
      2019-10-29 primiano@google.com Merge "tools(tmux): fix script argument"
      2019-10-29 primiano@google.com Merge changes I0d2677c1,If1a8bfcd
      2019-10-29 taylori@google.com Merge "Revert "perfetto-ui: Add beta search tooltip""
      2019-10-29 matthew.clarkson@arm.com Merge "tools(install-build-deps): support Python 3"
      2019-10-29 fmayer@google.com Merge "Re-enable HeapprofdJavaCtsTest."
      2019-10-29 primiano@google.com Merge "UI: fix include path in heap_profile_flamegraph/common.ts"
      2019-10-28 tneda@google.com Merge "perfetto-ui: Adding symbol names to callsites in flamegraph"
      2019-10-28 fmayer@google.com Merge "Disable HeapprofdJavaCtsTest."
      2019-10-28 eseckler@google.com processor: Remove unnecessary includes & fix incomplete rename
      2019-10-28 eseckler@google.com Merge "processor: Fix chrome build & legacy arg export"
      2019-10-28 taylori@google.com Merge changes I747c37c5,If56568d7
      2019-10-28 khokhlov@google.com Fix Windows build
      2019-10-28 lalitm@google.com traceconv: bump shas to a58d04db
      2019-10-28 primiano@google.com Fix strnicmp for MSVC
      2019-10-28 bhamrick@google.com Merge "Fuchsia importer: Don't rely on non-guaranteed alignment"
      2019-10-28 primiano@google.com Merge "tools(ci): support running with podman"
      2019-10-27 primiano@google.com Trace Processor: add --httpd
      2019-10-27 primiano@google.com String utils: add StringView.find(StringView) and ToLower
      2019-10-25 adsrini@google.com Merge "Add DETACH, ATTACH and CANCEL buffer events to the Frame event proto"
      2019-10-25 lalitm@google.com Merge "trace_processor: migrate callsite table to new macro tables"
      2019-10-25 lalitm@google.com Merge "trace_processor: enforce ordering by ts on counters table"
      2019-10-25 fmayer@google.com Merge "Mention Perfetto UI in heapprofd docs."
      2019-10-25 taylori@google.com Merge "Fix parsing of HTML files"
      2019-10-25 skyostil@google.com Merge "TrackEvent: Add support for dynamically enabled tracing categories"
      2019-10-25 lalitm@google.com Merge "traceconv: add --full-sort option"
      2019-10-25 eseckler@google.com Merge "processor: Add ProtoImporterModules for android + system probes"
      2019-10-25 tneda@google.com Merge "Adding heap profiling to the record page"
      2019-10-25 lalitm@google.com Merge "trace_processor: switch to creating ranged RowMap when filtering"
      2019-10-25 lalitm@google.com Merge changes I7b4e3667,Ie36db4d9
      2019-10-25 eseckler@google.com Merge "processor: Handle chrome traces with clock_id but no ClockSnapshot"
      
      Created with:
        gclient setdep -r src/third_party/perfetto@b1bad5558240
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/perfetto-chromium-autoroll
      Please CC perfetto-bugs@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Bug: chromium:142003500
      Tbr: perfetto-bugs@google.com
      Change-Id: I162201da04734107ddf95a0dad5d5e1086d78fff
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948217Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720842}
      f3df187f
    • Makoto Shimazu's avatar
      Disabled flaky tests in unit_tests: ExtensionsMenuViewUnitTest · d7e4cf65
      Makoto Shimazu authored
      TBR=rdevlin.cronin@chromium.org
      
      No-Try: true
      Bug: 1030172
      Change-Id: Ib4ee8bdd72a12236bbc6fa6e2cb5cdec0355e370
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947512
      Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
      Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720841}
      d7e4cf65
    • Maggie Cai's avatar
      [IntentHandling] Automatically launch preferred app. · 64634408
      Maggie Cai authored
      This CL adds the logic to automatically launch the preferred app in the
      new intent picker implementation.
      
      BUG=853604
      
      Change-Id: Ie7a698a9cca259b5469535d6add0f6d1e99f7493
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947863
      Commit-Queue: Maggie Cai <mxcai@chromium.org>
      Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720840}
      64634408
    • rbpotter's avatar
      History WebUI: Replace some CallJavascriptFunctionUnsafe() calls · b3e11512
      rbpotter authored
      Replace CallJavascriptFunctionUnsafe('showNotification') and
      CallJavascriptFunctionUnsafe('updateSignInState') with
      FireWebUIListener() calls.
      
      Bug: 1022212
      Change-Id: Ife9107755b0877f2237e5d3d9b6d344e0e261dec
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935888
      Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
      Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720839}
      b3e11512
    • Ken Buchanan's avatar
      Extend validity for relying party security check failure message · e8f35c82
      Ken Buchanan authored
      This metric is still being monitored as Web Authentication gradually
      ramps up adoption on the web.
      
      Fixed: 1025855
      Change-Id: Icb878f6904b207e764c4c33f1fcc756af5e767cf
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946941
      Auto-Submit: Ken Buchanan <kenrb@chromium.org>
      Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
      Commit-Queue: Ken Buchanan <kenrb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720838}
      e8f35c82
    • Kuo Jen Wei's avatar
      [CCA] Handle animation cancelled. · c40618b0
      Kuo Jen Wei authored
      The animation may not be properly ended if it's cancelled by hide of
      target element during playing. This CL caught the cancelled events and
      clean up the animate class.
      
      Bug: 1028678
      Test: Bug is resolved.
      Change-Id: Id11e04da174783c5be5e977247c593815c29f284
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939140
      Commit-Queue: Kuo Jen Wei <inker@chromium.org>
      Commit-Queue: Shik Chen <shik@chromium.org>
      Auto-Submit: Kuo Jen Wei <inker@chromium.org>
      Reviewed-by: default avatarShik Chen <shik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720837}
      c40618b0
    • chromium-autoroll's avatar
      Roll Fuchsia SDK from 889520313737 to 889515271482 · e0cc9452
      chromium-autoroll authored
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
      Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
      Tbr: cr-fuchsia+bot@chromium.org
      Change-Id: I229f9d7feb0c8e88482f29a92ceb328a17cdfc3a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948207Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720836}
      e0cc9452
    • chromium-autoroll's avatar
      Roll src/third_party/catapult dca8df948ef5..69272c40ae6e (1 commits) · 6af164cd
      chromium-autoroll authored
      https://chromium.googlesource.com/catapult.git/+log/dca8df948ef5..69272c40ae6e
      
      git log dca8df948ef5..69272c40ae6e --date=short --first-parent --format='%ad %ae %s'
      2019-12-03 fancl@chromium.org Reland "Remove api_key requirement for /subscriptions/match"
      
      Created with:
        gclient setdep -r src/third_party/catapult@69272c40ae6e
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/catapult-autoroll
      Please CC nuskos@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Bug: chromium:953181
      Tbr: nuskos@google.com
      Change-Id: I17cde80da09ca915d2a1a9b3a4514ce70570217a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948213Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720835}
      6af164cd
    • Virender Singh's avatar
      Honoring DPI changes in PdfAccessibilityTree · dfc6c794
      Virender Singh authored
      This change fixes the incorrect scale that we apply to root transform
      in PdfAccessibilityTree. At present, we remove the dpi factor from root
      transform. This results in only zoom factor being applied when
      calculating bounds. For Windows, device scaling is also handled by
      application. This is not the case with Mac. As a result, conditional
      scale calculation, based on OS, should be done.
      
      Fix uses content::IsUseZoomForDSFEnabled() to find out the correct
      scale that needs to be applied.
      
      Bug: 1007169
      Change-Id: I4cda488b8acf3823178b4ff68503b081e12aeaa2
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820697
      Commit-Queue: Virender Singh <virens@microsoft.com>
      Reviewed-by: default avatarIan Prest <iapres@microsoft.com>
      Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720834}
      dfc6c794
    • Carlos Caballero's avatar
      Remove MessageLoop references in /cc · 1f500332
      Carlos Caballero authored
      MessageLoop is going away soon.
      
      This CL was uploaded by git cl split.
      
      R=samans@chromium.org
      
      Bug: 891670
      Change-Id: I15740af265a11a121228c63c6cca39541fcc6ed5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946228
      Auto-Submit: Carlos Caballero <carlscab@google.com>
      Reviewed-by: default avatarSaman Sami <samans@chromium.org>
      Commit-Queue: Carlos Caballero <carlscab@google.com>
      Cr-Commit-Position: refs/heads/master@{#720833}
      1f500332
    • siyua's avatar
      [Autofill Auth UI] Disable the cancel button when OS dialog is visible. · c4c3bb07
      siyua authored
      Disable the cancel button in the Webauthn verify pending dialog when
      the system OS authentication dialog is shown. At this moment, if user
      cancel the OS dialog, the verify pending dialog will also go away.
      
      After user interacts with the system OS dialog, the OS dialog will
      go away and the cancel button will be enabled again for users to
      cancel the flow if they want.
      
      Bug: 991037
      Change-Id: I8760690e377e3d294832dc5278d177eb3017dc65
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935493
      Commit-Queue: Siyu An <siyua@chromium.org>
      Reviewed-by: default avatarFabio Tirelo <ftirelo@chromium.org>
      Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
      Reviewed-by: default avatarManas Verma <manasverma@google.com>
      Cr-Commit-Position: refs/heads/master@{#720832}
      c4c3bb07
    • Yuki Shiino's avatar
      bind-gen: Implement/improve blink_api_call to support optional args · 65fc95ff
      Yuki Shiino authored
      Implements support of optional arguments.
      
      Bug: 839389
      Change-Id: I1e35774a52fc18786eb712b2dcc6d9456faea5d8
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942895Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
      Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720831}
      65fc95ff
    • Alan Cutter's avatar
      WebApps: Remove unused BitmapAndSource struct · e59d30f9
      Alan Cutter authored
      With the change to split WebApplicationInfo::icons into icon_infos and
      icon_bitmaps [1] we don't need to preserve URLs when downloading icons.
      This means we can simplfy the BitmapAndSource struct into just SkBitmap.
      
      [1] https://chromium-review.googlesource.com/c/chromium/src/+/1928600/10
      
      Bug: 926083
      Change-Id: I9c36d1bf1e726aeb6d1f79f1bdab005b8032265a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936441
      Commit-Queue: Alan Cutter <alancutter@chromium.org>
      Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720830}
      e59d30f9
    • Archie Pusaka's avatar
      [CrOS Bluetooth] Wiring BT verbose logging toggle to D-Bus · 59630335
      Archie Pusaka authored
      When a user which primary account is Google corp account opts in for
      BT verbose logging, a D-Bus command will be sent upon sign in to enable
      verbose logging level 1.
      
      Logging will be stopped upon sign out or device shutdown.
      
      Bug: 1004572, 734152
      Change-Id: I00b5d56d41d7df3669e1a7c73c86d4fb67226959
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824721Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
      Reviewed-by: default avatarMiao-chen Chou <mcchou@chromium.org>
      Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
      Commit-Queue: Archie Pusaka <apusaka@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720829}
      59630335
    • Tom Sepez's avatar
      Add some privacy-related comments to pdfium_form_filler.cc · 46531d75
      Tom Sepez authored
      Although these are in XFA-callbacks, which we do not ship, call out
      other places where we'd not want to provide full support.
      
      - Remove some partial code from these functions.
      
      Change-Id: I0de38c161982e1830a9c9b51f1a0c06fb6f7e3c0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947805Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
      Commit-Queue: Tom Sepez <tsepez@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720828}
      46531d75
    • Kunihiko Sakamoto's avatar
      WebBundle: Verify ParseResponse() arguments in unit tests · 8a081301
      Kunihiko Sakamoto authored
      This is a preparation change for crbug.com/1029406.
      
      Bug: 1029406
      Change-Id: I361ae579f1daddc3bc82ca97ada35c87286e96ef
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946055Reviewed-by: default avatarTsuyoshi Horo <horo@chromium.org>
      Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720827}
      8a081301
    • Simon Que's avatar
      infra: CrOS builder def funcs default to Goma RBE · 185254b2
      Simon Que authored
      chromiumos_builder() in both ci.star and try.star use Goma RBE backend
      by default.
      
      Bug: 1025325
      Change-Id: I5997959592a1c9d4fb629541cc603ba22e8c1a60
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948008Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
      Commit-Queue: Simon Que <sque@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720826}
      185254b2
    • Scott Violet's avatar
      weblayer: adds versioning · 9d4aa096
      Scott Violet authored
      This patch separates out creation of WebLayer to a WebLayerFactory and
      has the client supply the version of chrome the client was compiled with.
      WebLayerFactory also offers functions to return the version of the
      implementation. This does not change the existing versioning checks, rather
      adds the real chrome version. The goal is we will eventually use the real
      chrome version and not the one of version we added.
      
      BUG=1025615
      TEST=all tests implicitly trigger the new code paths
      
      Change-Id: Ie6330a57fd9f205504758c9cde9707537cb643f3
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935037
      Commit-Queue: Scott Violet <sky@chromium.org>
      Reviewed-by: default avatarClark DuVall <cduvall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720825}
      9d4aa096
    • Hiroshi Ichikawa's avatar
      Delete CRWWebViewScrollViewProxyTest.MultipleWebViewScrollViewProxies. · ff9eac7c
      Hiroshi Ichikawa authored
      This test tests a use case which is not really supported by
      CRWWebViewScrollViewProxy. So I believe this should rather be deleted.
      
      CRWWebViewScrollViewProxy doesn't really support setting up multiple
      proxies for a single UIScrollView. If you try it with a real
      UIScrollView, it hits an assertion here:
      https://cs.chromium.org/chromium/src/ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm?l=73&rcl=c8f602e2f2dae5bdbde111f556474f3373c23a3d
      
      This test currently passes just because it uses a mock UIScrollView.
      
      Change-Id: Ib85ec49db033cd894f84d53a5053d1a006b1ff59
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939139
      Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org>
      Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
      Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
      Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720824}
      ff9eac7c
    • chromium-internal-autoroll's avatar
      Roll src-internal bfd5c311ca87..4e899ffa92b9 (1 commits) · fb4676e5
      chromium-internal-autoroll authored
      https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfd5c311ca87..4e899ffa92b9
      
      
      Created with:
        gclient setdep -r src-internal@4e899ffa92b9
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
      Please CC jbudorick@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
      Bug: None
      Tbr: jbudorick@google.com
      Change-Id: I09d63f13b9f423e453fbdd530b0baaaab73e41d6
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948039Reviewed-by: default avatarchromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720823}
      fb4676e5
    • Alan Cutter's avatar
      Remove PWA omnibox install icon flag · 07ee7c85
      Alan Cutter authored
      This feature has been enabled since M76, the flag can now be removed.
      
      Bug: 907351
      Change-Id: Ia8cfc6bfd5f49ff934aa04b81dd8de6a6124f628
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918911
      Commit-Queue: Alan Cutter <alancutter@chromium.org>
      Auto-Submit: Alan Cutter <alancutter@chromium.org>
      Reviewed-by: default avatarEvan Stade <estade@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720822}
      07ee7c85
    • Julie Jeongeun Kim's avatar
      Clean up old Mojo types for mojom::DebugLogsChangeHandler · 74bb01de
      Julie Jeongeun Kim authored
      This CL cleans up old Mojo types for mojom::DebugLogsChangeHandler
      using PendingRemote and ReceiverSet instead of InterfacePtr
      and BindingSet.
      
      Bug: 955171
      Change-Id: Iffb8cb730857f8b5ea417300f0e8b9235c88ed97
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939070Reviewed-by: default avatarSam McNally <sammc@chromium.org>
      Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
      Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
      Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
      Commit-Queue: Julie Kim <jkim@igalia.com>
      Cr-Commit-Position: refs/heads/master@{#720821}
      74bb01de
    • chromium-autoroll's avatar
      Roll src/third_party/catapult 42f2c4bd8176..dca8df948ef5 (1 commits) · 5ccfd617
      chromium-autoroll authored
      https://chromium.googlesource.com/catapult.git/+log/42f2c4bd8176..dca8df948ef5
      
      git log 42f2c4bd8176..dca8df948ef5 --date=short --first-parent --format='%ad %ae %s'
      2019-12-03 dberris@chromium.org Pinpoint: Blame only top 2 culprits
      
      Created with:
        gclient setdep -r src/third_party/catapult@dca8df948ef5
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/catapult-autoroll
      Please CC nuskos@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Bug: chromium:1021523
      Tbr: nuskos@google.com
      Change-Id: Ie19e8ed34ccdba044a006abdcaee03704a9e90f7
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948033Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720820}
      5ccfd617
    • Erik Jensen's avatar
      remoting: Implement initial keyboard layout monitor for Windows. · b8876671
      Erik Jensen authored
      This uses various Windows APIs to try to glean information about the
      current layout. Unfortunately, there appears to be no way to get some of
      the needed information in a clean fashion through these APIs, so the
      implementation uses various guesses and hacks to try to infer it. In the
      future, I'd like to look into reading the layout directly from the
      layout files, which contain mapping tables that provide all of the
      needed information in a known format.
      
      This currently runs in the network process. That means it can't monitor
      active window changes and thus never sends an updated layout after the
      initial connection. A follow up CL will run the monitor in the desktop
      process and communicate the result back via IPC.
      
      Bug: 1026029
      Change-Id: Iaba9c0bb0ef2c60fac249a9af392f9434b9c5f93
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918356
      Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
      Reviewed-by: default avatarYuwei Huang <yuweih@chromium.org>
      Reviewed-by: default avatarGary Kacmarcik <garykac@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720819}
      b8876671
    • chromium-autoroll's avatar
      Roll src/third_party/skia bf6b0b251ec0..49e564e5e02c (2 commits) · a603a371
      chromium-autoroll authored
      https://skia.googlesource.com/skia.git/+log/bf6b0b251ec0..49e564e5e02c
      
      git log bf6b0b251ec0..49e564e5e02c --date=short --first-parent --format='%ad %ae %s'
      2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
      2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
      
      Created with:
        gclient setdep -r src/third_party/skia@49e564e5e02c
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/skia-autoroll
      Please CC bsalomon@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Bug: None
      Tbr: bsalomon@google.com
      Change-Id: I2ea936a04289414c768cb1f3449caff2538627b1
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948032Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720818}
      a603a371
    • siyua's avatar
      [Autofill Auth UI] Merge MVCs of VerifyPendingDialog and WebauthnOfferDialog · 0a75b84f
      siyua authored
      The verify pending dialog will need to (UX decision) reuse the current
      webauthn dialog UX format. Since they are both using this format, and
      are for the same flow. It makes sense to merge the two sets of MVCs and
      show different content based on different dialog state
      
      This is a follow up of CL crrev.com/c/1925761
      
      Bug: 991037
      Change-Id: I4837e02adeef471d6a775587af0ab921646cdaf5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931857
      Commit-Queue: Siyu An <siyua@chromium.org>
      Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
      Reviewed-by: default avatarJared Saul <jsaul@google.com>
      Reviewed-by: default avatarFabio Tirelo <ftirelo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720817}
      0a75b84f
    • chromium-autoroll's avatar
      Roll src/third_party/depot_tools ba8d15b7d9af..6aa0bcb82820 (1 commits) · d15f825c
      chromium-autoroll authored
      https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba8d15b7d9af..6aa0bcb82820
      
      git log ba8d15b7d9af..6aa0bcb82820 --date=short --first-parent --format='%ad %ae %s'
      2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
      
      Created with:
        gclient setdep -r src/third_party/depot_tools@6aa0bcb82820
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/depot-tools-chromium-autoroll
      Please CC agable@chromium.org on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      
      Bug: None
      Tbr: agable@chromium.org
      Change-Id: Ia3dfe254f8e246a9a5ffafcf3d903d08ad055f7a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948031Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#720816}
      d15f825c
    • Makoto Shimazu's avatar
      Disable GpuInitializationAndRunningTasks on TSan · 007cb99b
      Makoto Shimazu authored
      It was flaky on TSan bot.
      
      TBR=zmo@chromium.org
      
      No-Try: true
      Bug: 1030130
      Change-Id: I3dbbe2f8e3559609bc1bac8e6504417c2a2c1b11
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947866Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
      Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720815}
      007cb99b
    • Austin Tankiang's avatar
      Remove storage::kFileSystemTypeDrive · 0bf02521
      Austin Tankiang authored
      This filesystem type was used by the legacy drive sync client that has
      now been replaced by DriveFS. Also replace all usages in tests of this
      filesystem type with an equivalent type.
      
      Bug: 1003238
      Change-Id: I5f99a3eaca6887423cb1ec073f5f9b22e83b694b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946050Reviewed-by: default avatarSam McNally <sammc@chromium.org>
      Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
      Commit-Queue: Austin Tankiang <austinct@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#720814}
      0bf02521