- 14 Aug, 2020 40 commits
-
-
Hirokazu Honda authored
media/gpu/video_encode_accelerator_tests: Fix the timing of FlushDoneTask() when VEA doesn't support Flush() When VideoEncodeAccelerator (VEA) doesn't support Flush(), VideoEncoderClient simulates the Flush() flow. VideoEncoderClient starts the Flush event when the last frame is fed to VEA. VideoEncoderClient, however, invokes FlushDoneEvent() when the VEA read the last frame. This may be before the encoded bitstream of the last frame is returned by BitstreamBufferReady(). This not only breaks VEA API rule; FlushDoneTask() is called after the encoded bitstream of the last frame is returned, but also BitstreamBufferProcessors may process less number of frames than expected. This CL fixes the timing of FlushDoneTask(). Bug: b:159384004, 1045825 Test: video_encode_accelerator_tests on hana Change-Id: I47e3bc39699a727f5bdb9ccc0043dc2bd096fa6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#798001}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I07fcafbe11cf4a00af1549f4a4ae3ef17db1ce0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354467 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#798000}
-
Hirokazu Honda authored
V4L2VideoEncodeAccelerator (V4L2VEA) may not proceed encoding unless an output bitstream buffer is provided. BitstreamBufferValidator decodes bitstreams and releases bitstreams when decoding the bitstreams completes. This causes a dead-lock issue. To progress the decoding in BitstreamBufferValidator, successive decoder buffers are required, but they don't come because V4L2VEA doesn't have bitstream buffers to be filled. This fixes the issue that by releasing the bitstreams in BitstreamBufferValidator when it finish reading the bitstream, i.e., VideoDecoder::DecodeCB is invoked. Bug: 1045825 Test: video_encode_accelerator_tests on hana Change-Id: Ic02d36511437ee87cba0a68c2e10fde36260a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340653Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/af63c44964ad..4daf2c7a45b2 2020-08-14 wenbinzhang@google.com [benchmarking] Add win-laptop tag for filtering win-10_laptop_low_end-perf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114681,chromium:1115156 Tbr: eseckler@google.com Change-Id: I62659876382ab763f1852cda1d71b9c5cd68737b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355121Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797998}
-
Peter Kasting authored
* Use Tween::SizeValueBetween() * Use range-for loops * Use View::SetBoundsRect() * Some variable name improvements Bug: none Change-Id: I55f1d50723053e36eaddb29715bed86f2a438d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350303Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797997}
-
Kent Tamura authored
The feature enables LayoutNG for <fieldset>, and fix some interoperability issues such as flex/grid support. This CL adds base::Feature for LayoutNGFieldset runtime flag. We can disable the feature by Finch if we find critical issues of the feature. Bug: 375693, 875235 Change-Id: Ib0a212b7ccfe13d561aef4051950beb6db4722e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354120 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#797996}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I336fafabbbb901fed5017874466c4eee220394e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354964Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#797995}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Idabb9f7c3351307abb8b06ec74947cbe3fae9fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355438Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797994}
-
Peter Kasting authored
No intended behavior change. This doesn't exhaustively convert things, just some in code I was already touching elsewhere. Bug: none Change-Id: I1b1fdc7a097126075e8392a76cf42fef4c563156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345477 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Roman Aleksandrov authored
If TPM is locked show banner with steps on how to fix this issue. Bug: 1114656 Change-Id: I85dab0f4ce003ac3dad61c318efb3333457993ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346266Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#797992}
-
Kent Tamura authored
Bug: 1040826 Change-Id: I0a2f9db962e74a44758293e0711009617e6a42d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354119 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Lan Wei authored
org.chromium.weblayer.test.DownloadCallbackTest.testBasic fails on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUB3ZWJs YXllcl9pbnN0cnVtZW50YXRpb25fdGVzdF9hcGtAb3JnLmNocm9taXVtLndlYmxheWVyLnRl c3QuRG93bmxvYWRDYWxsYmFja1Rlc3QjdGVzdEJhc2ljDA, disable it for now until it is fixed. TBR=jam@chromium.org Bug: 1116248 Change-Id: I24f0ab8414f4b17ff3689f3686e3f58682c48b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354162Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797990}
-
Lan Wei authored
AddressViewControllerTestCase/ testAddressesViewControllerIsPresented is flaky on ios-simulator-full-configs, https://ci.chromium.org/p/chromium/builders/ci/ ios-simulator-full-configs/25750, disable it for now until it is fixed. TBR=javierrobles@chromium.org Bug: 1116274 Change-Id: Ia300c71fb7acb074095842436a20fd3b9380cd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355291Reviewed-by:
-
Avi Drissman authored
Bug: 1104256 Change-Id: I8d308d6dc6973e1c537e3896f5bd81d8ae2b127d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354965 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797988}
-
Bo Liu authored
Remove the separate base::Feature, and tie enabling this to when site isolation is enabled. Bug: 946216 Change-Id: Ic14262b2fde78858b8f67f4e84ed35e199c2d3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354271 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797987}
-
Hazim Mohamed authored
Introduces a browser test that implements end-to-end testing of the DataTransferItem.getAsFileSystemHandle() method. It contains two tests: one for dropped files and one for dropped directories. Bug: 1080811 Change-Id: Ie64096539a732c0a2d101ca98bf9e86fcc9190ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339945 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797986}
-
Ben Goldberger authored
This implementation will be used to support teamfood experimentation and will be replaced with a non-blocking async implementation before exposing to live traffic. Change-Id: I5936d6506013d3d0beb251500974ec5b92214da8 Bug: 1099982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289207 Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#797985}
-
Stephen Sigwart authored
Bug: 365196 Change-Id: I71f74169589ac768f8c8299c9683ec82be2eb9b5 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331518 Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#797984}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7497bb4edd42..ec709593d585 2020-08-13 Han) Zhang Revert "Modified git cl format for distributed histograms" 2020-08-13 ddoman@chromium.org [lucicfg] move the cipd pin of lucicfg in depot_tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1115773 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4e86cc6aec10273fad1d5f289f6f0e02f73a9125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354662Reviewed-by:
-
Peter Kasting authored
Bug: 1104532 Change-Id: I310d988be0cefd15dbe21a8d58fa9e110602849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354992 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#797982}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597341503-4f5bca114f9d97d0c5a366353ca44da70cbc454a.profdata to chrome-mac-master-1597363129-a36e46938cb7f6611b8efddbaf720b98c4f2f1a3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: Ibecca84d6d16107fca8154e9ca375c0ecf119492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355124Reviewed-by:
-
Avi Drissman authored
Bug: 1107690 Change-Id: Ib94f111c3f4080c658f37dd8f25a4d8da751d5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354905 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#797980}
-
Kunihiko Sakamoto authored
Revert "Replacing "blacklist" with "blocklist" in IDS_EXTENSION_ALERT_ITEM_BLACKLISTED_MALWARE.png.sha1" This reverts commit 8aaf5430. Reason for revert: Caused Deterministic Linux build failure: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux/28789 Original change's description: > Replacing "blacklist" with "blocklist" in IDS_EXTENSION_ALERT_ITEM_BLACKLISTED_MALWARE.png.sha1 > > Bug: 1097279 > Change-Id: Ie4ee96134433cd45432df96b047ff331eaeac573 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353400 > Commit-Queue: Elaine Chien <elainec@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797879} TBR=karandeepb@chromium.org,elainec@chromium.org Change-Id: I3eec50e43777b1b77825185ab10242eb8fbc2e23 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355350Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797979}
-
yjliu authored
Render pass with pixel-moving filters will now report its |output_rect| as its damage if any of its quads has damage. Surfaces' damage reporting is no longer directly affected by pixel-moving filters. gfx::Rect PrewalkRenderPass(RenderPass* render_pass) { gfx::Rect damage_rect; // Go through quads back to front to accumulate damage and update |damage_rect|. for (DrawQuad* quad : quad_list) { // in reverse order ..... } // Expand the damage to cover entire |output_rect| if the render pass has pixel-moving foreground filters. if (!damage_rect.IsEmpty() && render_pass.filters.HasFilterThatMovesPixels()) damage_rect.Union(render_pass.output_rect); return damage_rect; } For more details and pseudo-code, please see: https://docs.google.com/document/d/1D1MTNTaJnZjbmMZGMz0u150N3u5evEFSmJU-ou2vcFw/edit#heading=h.qxb209uq3j9k Bug: 1110016 Change-Id: I3c495d8ea1ed25585c636a0989a3c7f51fdce7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321114Reviewed-by:kylechar <kylechar@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Auto-Submit: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797978}
-
Haiyang Pan authored
This reverts commit 9ae09da8. Reason for revert: The following tests start to fail since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1824 org.chromium.chrome.browser.ntp.cards.promo.HomepagePromoTest#testDismiss_Large org.chromium.chrome.browser.ntp.cards.promo.HomepagePromoTest#testToggleFeed_WithHomepage Original change's description: > Introduce CriteriaHelper#pollUiThreadNested > > This change adds an assertion that pollUiThread is not called from the > UI thread, which is equivalent to calling sleep(), and won't actually > run any UI thread tasks. > > In the few cases where polling the UI Thread from the UI thread is > necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests > the looper in order to continue running UI tasks. > > Bug: 1115220 > Change-Id: I834251df334c80d657e45dddeab5ae744de0fe17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340004 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797436} TBR=yfriedman@chromium.org,mthiesse@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115220 Change-Id: Icf5edbfe7f22f48a78ce25e5e49480419edfc897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355096Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#797977}
-
Piotr Pawliczek authored
This patch extends the validity of the histogram Printing.PrintServers.ServersToQuery to M90. BUG=chromium:1104975 TEST=none Change-Id: I87b78e01dadfb9e43d16c65093a008c5db394d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333195 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#797976}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b27846491d0..283c230fa18a 2020-08-13 bungeman@google.com Improve ASSERT_RETURN in SkScan_Path 2020-08-13 johnstiles@google.com State lambda return types explicitly when multiple returns exist. 2020-08-13 johnstiles@google.com Return the `T*` pointer back to the caller in SymbolTable::add. 2020-08-13 bsalomon@google.com Make asserts in EllipticalRRectOp::Make agree with calling code. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1114968 Tbr: fmalita@google.com Change-Id: I926e9ef71c718a60bd9881119d5d4ef7de79b066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354586Reviewed-by:
-
Lan Wei authored
org.chromium.weblayer.test.InfoBarTest.testTabDestruction is flaky on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydwsSBUZsYWtlImxjaHJvbWl1bUB3ZWJs YXllcl9wcml2YXRlX2luc3RydW1lbnRhdGlvbl90ZXN0X2Fwa0BvcmcuY2hyb21pdW0ud2Vi bGF5ZXIudGVzdC5JbmZvQmFyVGVzdCN0ZXN0VGFiRGVzdHJ1Y3Rpb24M, disable it for now until it is fixed. TBR=blundell@chromium.org Bug: 1116247 Change-Id: I98a6348a7120de2adb121b221084965ab6cac1e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355389Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fa7957ea438..4faa62a0e9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I454ca5fa1081a93a1dd405225512d9e6f0f10ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355210Reviewed-by:
-
Alan Cutter authored
This CL removes the restriction that a web app's manifest display mode must be one of "standalone", "fullscreen" or "minimal-ui" in order to participate in manifest updating. Bug: 1095860 Change-Id: I48241e339c442f8fba341adb85012231b53391f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352457Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#797972}
-
Tina Wang authored
Having initWithMessage call initWithPrimaryAttributedString:secondaryAttributedString:, so we would have only a single designated initializer and we wouldn't have code duplicated between the two initializers. Bug: 1094420 Change-Id: Ic1aaf0d7f37e75af5ebe17d6578f44e7acb50f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355129Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797971}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78d7b4b8250e..4faa62a0e9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3d14beb01bce4ded4a62483f78b397b6c78672ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355006Reviewed-by:
-
James Cook authored
Add mojo interface for communication between ash and lacros. For now, just add the fields needed for simple text notifications. Notifications are handled in a new class MessageCenterAsh. It lives in //chrome/browser/chromeos/crosapi instead of //c/b/notifications for consistency with other crosapi implementations. On mojo disconnect (e.g. lacros-chrome crash) all notifications created by lacros are removed. I'm working on tests now. They are not in this CL because this CL is getting too large. Test: Spawn basic notifications from test app Notifications Galore in chrome/test/data/extensions/api_test/notifications/galore/ Bug: 1113889 Change-Id: I6363b0e7568756b9087f089651a7fdc6d0901902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343849Reviewed-by:Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797969}
-
Donn Denman authored
This reverts commit bc08f94f. Reason for revert: Not needed. There was an issue with the CLA not being accepted. Original change's description: > Add a chromium author that could not add himself > > BUG=1116202 > > Change-Id: I10738961da81ad153b770210e3d969210b0bcd0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354557 > Commit-Queue: Donn Denman <donnd@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Auto-Submit: Donn Denman <donnd@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797916} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: Iaffe8f52f36455ba0c7746b0ed47fa2d9f5db209 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354562Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797968}
-
Alexander Cooper authored
https://crrev.com/c/2352519 stopped attempting to load the GvrKeyboard, and the original bug that it fixed had the same error stack as seen in this bug. Re-enable the Permissions Tests that were failing with the same error. Fixed: 1091800 Change-Id: Icc2bf2d29ddd8ffbf0016df2be6e9e6d310a1ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354721 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797967}
-
Lan Wei authored
This reverts commit 261661bb. Reason for revert: BluetoothSocketTest.TestInputStream/TestOutputStream fails on Linux TSan Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982 Original change's description: > [Nearby] Create concrete BluetoothSocket and implement ConnectToService. > > Implement a concrete location::nearby::api::BluetoothSocket, created via > a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly > implemented BluetoothClassicMedium::ConnectToService(). > > Nearby Connections uses this BluetoothSocket to communicate with a > remote device. At a high-level, it first exchanges frames to encrypt > the connection, then delegates to its caller (e.g., Nearby Share) > to authenticate the connection, and finally expects its caller to > send and receive application-level messages. The following precautions > are taken to handle untrusted bytes received from remote devices: > * Nearby Connections (including the code being added in this CL) is > hosted in a Nearby utility process. > * Whenever Nearby Connections provides bytes received from a remote > device to its caller, even after it has been authenticated, the > caller must not trust those bytes, and is responsible for first > passing those bytes through the trusted NearbyDecoder interface > (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same > Nearby utility process. > > api::BluetoothSocket is a synchronous interface, so this > implementation consumes the synchronous signatures of > bluetooth::mojom::Socket methods. > > api::BluetoothSocket's subclasses are also synchronous interfaces, > but the Mojo DataPipes they consume only provide asynchronous > interfaces. This is reconciled by blocking on the caller thread when > waiting (via a mojo::SimpleWatcher) for the DataPipes to become > readable or writable (this is expected by the callers of > api::BluetoothSocket's subclasses). Mojo DataPipe operations are > handled on a separate task runner so that blocking on the calling > thread will not deadlock. > > Please see design doc go/nearby-chrome-bt for more details. > > Bug: b:154849033, b:158848873 > Change-Id: I2e945277aa1f75b4ca378d0b961f7682ff25d812 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322166 > Commit-Queue: Ryan Hansberry <hansberry@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797758} TBR=reillyg@chromium.org,hansberry@chromium.org,alexchau@chromium.org,vecore@google.com Change-Id: Ia33d32ae93a8900032e81f77d298553c5de82874 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:154849033 Bug: b:158848873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355253Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fa7957ea438..4faa62a0e9f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I29bbbb11504a671706c05fa15577c8c24c3fb4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355131Reviewed-by:
-
Avi Drissman authored
For CrOS, since the Task Manager is showing tasks for all of CrOS and not just “Chromium”, it's not appropriate to label it as such. Bug: 1109438 Change-Id: Iba02159483b124601a90123b0eed4a215f7851a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354415Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797964}
-
Kunihiko Sakamoto authored
This reverts commit 34bca2e3. Reason for revert: Suspected for TSan error (data race) in BluetoothSocketTest.TestOutputStream and BluetoothSocketTest.TestInputStream. https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57982 Original change's description: > Implement key verification for incoming connection. > > Implements the key verification module that to verify remote device > before requesting introduction and beginning the transfer flow. > > Bug: 1085068 > Change-Id: I4bb75dce474042ef43ca86199db3456d63406874 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346325 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797868} TBR=alexchau@chromium.org,nohle@chromium.org,himanshujaju@chromium.org Change-Id: I04ef174610f0e3751299ea7aeccdd16c4bf8683f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352300Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5c8c6b4296e5..5559351c907d 2020-08-13 timvp@google.com Vulkan: Correctly determine mip level in resolveColorWithCommand() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: FramebufferTest_ES31::MultisampleResolveIntoMipMapWithBlit() Change-Id: I949ddd444d7586521289ffbd5cb458419d3eb9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355130Reviewed-by:
-
