- 28 Feb, 2020 40 commits
-
-
Mike Frysinger authored
Bug: 1050345 Test: loaded Secure Shell & checked chrome.xxx APIs were defined Change-Id: Iff76898eed3ebf86c212560aa9182314c016b87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047769 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745568}
-
Nina Satragno authored
Mirror the behaviour of GetAssertion and obtain a UV token for devices that support it and have UV configured. Handle retries and fallback to PIN. Bug: 1055497 Change-Id: I8c3c524db0da848374f2a68a0166a4420bdd248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073139 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#745567}
-
sandromaggi authored
Before this change, element coordinates were relative to their window, i.e. frame. For elements in iFrame this meant that the "cutout" was misplaced. This change now keeps a frame-stack while retrieving elements and then sums up the position to get a "global" position of the element for using in a showcast. Bug: b/143942385 Change-Id: I8f3827002df58874d7921e969954f911630cc4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074499 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#745566}
-
Xiaohui Chen authored
Bug: None Change-Id: Iaf4ad87d59a6f957c5aef6623e7c64f72d92c364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080195Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#745565}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from setttings_strings.grdp to os_settings_strings.grdp, specifically languages sub page strings. Bug: 967883 Change-Id: I6309deb37268c2210ffb28b2e02b299a274521c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055968Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#745564}
-
Andrew Grieve authored
with the goal of making it impossible to have values from invoker accidentally clobber values from the template (or vice versa). Bug: 1050094 Change-Id: I7248c76cc7f0b628f756d23d9618271befffb820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079838 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#745563}
-
Rohit Rao authored
This reverts commit d3273ac4. Reason for revert: Causing crashes on (internal) iphone-device and ipad-device. Might be a Debug vs Release issue, rather than a device vs simulator issue. https://ci.chromium.org/p/chrome/builders/ci/iphone-device/7243 https://ci.chromium.org/p/chrome/builders/ci/ipad-device/7808 Original change's description: > [iOS] Plumb Browser into RecentTabsViewController > > Changes RecentTabsViewController to accept a Browser instead of separate > WebStateList and BrowserState inputs. This will make future refactoring > more straightforward. > > (There remains a great deal of work to do to fully refactor Recent Tabs > to properly factor responsibilities into a mediator and coordinator). > > Bug: 845192 > Change-Id: I068b0a343752dba602d2a2226cd0bcf327873446 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078452 > Commit-Queue: Mark Cogan <marq@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745456} TBR=marq@chromium.org,gambard@chromium.org Change-Id: I7119af082ce06b110638bda6ba6782f4382c1f16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079468Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#745562}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some chromeOS settings did not include all applicable test cases. This CL copies missing test cases applicable to chromeOS from cr_settings_browsertest.js to os_settings_browsertest.js. Bug: 990137 Change-Id: Id4f786c83b70e31e2da555ecbbbd6cdc96f0f867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071910 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Wan-Teh Chang authored
The prototype of the pure virtual method VideoDecoder::Reset() changed from virtual void Reset(const base::Closure& closure) = 0; to virtual void Reset(base::OnceClosure closure) = 0; in commit 7ee39c86. Update AomVideoDecoder::Reset() to the new prototype. Tested: $ gn args out/Default In the editor, add the following line: enable_libaom_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests Change-Id: I1ccfe15588e6c94817f2d671bc55e9fea7305ae2 Bug: chromium:1055917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079851Reviewed-by:Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#745560}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1e1d74467e0d..fb551728d77b git log 1e1d74467e0d..fb551728d77b --date=short --first-parent --format='%ad %ae %s' 2020-02-28 ynovikov@chromium.org Suppress SwANGLE dEQP-GLES3.functional.texture.compressed.astc.* failures Created with: gclient setdep -r src/third_party/angle@fb551728d77b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ia5d5ad566fef77e62d8823455ce31544cff966f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745559}
-
rbpotter authored
Bug: 1026426 Change-Id: Ib6be48069cd3fe5f2547587fb6f3cf40678dc336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079898Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745558}
-
Regan Hsu authored
Bug: 1056909 Change-Id: I48f2a52c69cfcd4184b01eb4b4db7d96ac4ece1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078801 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Eric Seckler authored
Switch from StartupTraceWriter(Registry) and their thread-local buffers to startup tracing using producer-supplied shared memory buffers. Each ProducerClient allocates their own SMB now, which is provided to the service when the ProducerClient connects. With this new mechanism, we're aiming for simpler code with fewer race conditions and hopefully fewer chances for data loss, see design doc for details. Note that this breaks startup tracing with the Perfetto system daemon. At the moment, no tooling uses this, so we can probably remove support for the time being. To add it back, we would have to: - start tracing with an SMB allocated by PosixSystemProducer. In sandboxed processes, we can allocate the SMB before the sandbox comes up, or later via mojo's broker (and then somehow plumb it through perfetto's IPC mechanism), or allocate it in the browser + pass an FD to it via the cmdline when spawning. - attempt to connect to the system service using this SMB. - bail out, stop and restart the session with a service-provided SMB if the system service doesn't support producer-provided SMBs (and thus fails to adopt the producer-provided SMB). Design doc (incl. security review): https://docs.google.com/document/d/1FygJQbD29vMkfVfT7m0Lb1u1zZZU1VgXAPi_R0uBoTw/edit Related Perfetto-side patches: https://android-review.googlesource.com/c/platform/external/perfetto/+/1218420 https://android-review.googlesource.com/c/platform/external/perfetto/+/1196779 Bug: 1006753, 941318 Change-Id: I3fa7657d57bbf7261d7d504df8895edfc02d9f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978682Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#745556}
-
Philip Rogers authored
Change-Id: Iee7a9e63a43bbf9ef1eeffdea03f8f2de79d83e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080465Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745555}
-
Chris Mumford authored
This reverts commit f02f7639. Reason for revert: Failed to build on Cast Audio Linux https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/67917 Original change's description: > Improve DoH server availability tracking > > Now that server availability and stats are tracked per-context, DoH > servers only need to be disabled for consecutive failures. And now that > availability behaves much more similarly to normal server failure > tracking, the availability has been mostly merged into the normal > tracking instead of using a separate flag. A DoH server is now > considered "available" (eligible for use in automatic mode) if > |ServerStats::last_failure_count| is less than > |kAutomaticModeFailureLimit| and there has been at least one success > recorded on the current connection. > > Net effect is that DoH servers can be enabled or failure-tracking reset > for any successful request or probe to that server on the same context, > even if a failure disable has taken effect (eg a transaction started > before the server was disabled, or a new probe when we restart probes in > a future CL). > > Also, previously the DoH probe logic reset availability when restarted. > Because the probes were generally only restarted for connection change, > this had the effect of resetting availability for connection change. > Now, the ResolveContext handles that itself on connection change by > resetting the flag that it has seen at least one success on the current > connection. > > Bug: 1022059 > Change-Id: I872057cbb9f7a0a41f580dff57d906b1e4e5d33c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062676 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Eric Orth <ericorth@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745551} TBR=mmenke@chromium.org,ericorth@chromium.org Change-Id: I0005490d361cb8c86583ab1b0f3819eeee13c4cd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1022059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080446Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745554}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //components/chromeos_camera to Once or Repeating. Bug: 1007676 Change-Id: I50160fe35211329df7a29b4b2ec64c768695dbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062947Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#745553}
-
Vitaly Buka authored
This variable affects blink_perf.canvas with benchmark on linux with -ftrivial-auto-var-init=pattern. crrev.com/c/2067928 This patch reduces the regression form 14% to 4.5% Somehow pinpoint does not work for this test. So I've attached local results of HEAD vs HEAD+patch are here https://bugs.chromium.org/p/chromium/issues/detail?id=1055652#c13 Bug: 1055652, 977230 Change-Id: Ied2e89ae414728a72659d196d73aa97d1e8532a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072671Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#745552}
-
Eric Orth authored
Now that server availability and stats are tracked per-context, DoH servers only need to be disabled for consecutive failures. And now that availability behaves much more similarly to normal server failure tracking, the availability has been mostly merged into the normal tracking instead of using a separate flag. A DoH server is now considered "available" (eligible for use in automatic mode) if |ServerStats::last_failure_count| is less than |kAutomaticModeFailureLimit| and there has been at least one success recorded on the current connection. Net effect is that DoH servers can be enabled or failure-tracking reset for any successful request or probe to that server on the same context, even if a failure disable has taken effect (eg a transaction started before the server was disabled, or a new probe when we restart probes in a future CL). Also, previously the DoH probe logic reset availability when restarted. Because the probes were generally only restarted for connection change, this had the effect of resetting availability for connection change. Now, the ResolveContext handles that itself on connection change by resetting the flag that it has seen at least one success on the current connection. Bug: 1022059 Change-Id: I872057cbb9f7a0a41f580dff57d906b1e4e5d33c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062676Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#745551}
-
Khushal authored
R=sunnyps@chromium.org Change-Id: I67a0bb9643ecbf70c5aa2b9f5f6a070883cf7a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078799 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#745550}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. R=juncai@chromium.org Bug: 1026641 Change-Id: I14264a1265eb4675548aa40f0003c6fd5a8961f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079076Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745549}
-
Clark DuVall authored
This will be needed by code in //components/permissions, and seems to make more sense in PermissionUtil than WebsitePreferenceBridge. Bug: 1025609 Change-Id: I86d229dc1fcf15d2dab9e0fe0bebc7bfb7ced5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079546 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745548}
-
yilkal authored
This CL makes minor changes to check if the absence of SupervisedUserNavigationObserver is the cause of crash in android chrome in TabContentsSyncedTabDelegate::ShouldSync. Bug: 1048643 Change-Id: I8cdb18b30ba42ba781b09d0ba455fc8c26d101f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079004 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745547}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6045fb83..817bf7ab Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic4e7c216e25298f3d4f32414bc8eb245f74fe503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079636Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745546}
-
Michael Chang authored
Bug: 1055942 Change-Id: I9f79ba6c696f4fee51cf1ac67e17a4a6ab7cef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076399Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Michael Chang <donchan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#745545}
-
Philip Rogers authored
Painted scrollbars are used for overlay scrollbars on MacOS. Thumb movement would cause a commit on every scroll change because the update rect (set via Layer::SetNeedsDisplay) would change. This patch ignores the update rect in PaintedScrollbarLayer::Update and uses part invalidation for causing commits. With this change, scroll offset changes do not cause commits. Bug: 1048384f Change-Id: I79bac7fbd9756cb71af7c3b83be3df824dd7a5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078847Reviewed-by:
-
John Budorick authored
Bug: 1056325 Change-Id: Ic12a263fd56df460434c9ae078e45172ed58e3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075973Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745543}
-
Connie Wan authored
WebUI doesn't use TabGroupHeaders for tab groups, so Mohnstrudel needs another way to position the Editor Bubble. BubbleDialogDelegateView allows for an alternative way to set an anchor, which is to give it the anchor bounds as a Rect. This CL exposes that method of anchoring the bubble while still defaulting to using the TabGroupHeader in the desktop UI. Bug: 1055537 Change-Id: I9d38971f867a362007abd626aa425515bef16af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071911 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745542}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0fb07f8c90ae..cabed431f8c8 git log 0fb07f8c90ae..cabed431f8c8 --date=short --first-parent --format='%ad %ae %s' 2020-02-28 srte@webrtc.org Adds stable target rate to GoogCC debug output. Created with: gclient setdep -r src/third_party/webrtc@cabed431f8c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I37135f8bd7d8d7f3591887d6c1413dbe38e4ad37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080462Reviewed-by:
-
Bo Liu authored
There is a situation where chromium java code is loaded into different class loaders in the same process. The expectation is to avoid sharing renderer processes between the two class loaders. So pass a string representation of the class loader into BindToCaller and check it along with the pid. Bug: 1051358 Change-Id: I8147582026549e7a4749f63d1941bd47e7d67ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051531 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#745540}
-
Chunbo Hua authored
Currently Microsoft H.264 encoder MFT is always used as WebRTC external encoder without hardware acceleration. This change enables H.264 hardware MFT encoder on Windows. Bug: 982799 Change-Id: Ia33812508034daa99dd3dc1fb64b83cb1d7c8465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777521 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Reduce the interval between dots in the input field shown on the SAML smart card dialog (the <security-token-pin> Polymer element). The interval is decreased in order to fit 8 dots, in order to have a nice UX for one of the most common cases - the 8-digit PIN. (It's pretty rare to have a longer PIN.) Bug: 1051859 Test: start SAML login using a smart card, type 8 digits in the PIN dialog, verify that all 8 dots fit into the input field Change-Id: I96b43e320f5107c2c0b6a46cd1f2f49199222c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069324 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
rajendrant authored
This CL changes media bytes to be recorded on every delta update, instead of at response completion (which may miss some responses that have not completed by pageload end). Also changes logic to treat all video/*, audio/* mimetypes as video responses. Change-Id: Ib78861227147978c34ed1d28dd7b24fc63600253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079513Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#745537}
-
sandromaggi authored
The existing UI tests do not test the interaction (and actual retrieval of element positions) from the webpage. This tests the full interaction of a FocusElement action. The test is somewhat flawed as it would also pass if there is no showcast at all. Bug: b/143942385 Change-Id: Id843f55a965dc996a00001fd02c190e8247eae4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078212Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#745536}
-
Nico Weber authored
The code might now compile with it on. TBR=martinkr@google.com Bug: 1039697 Change-Id: I1eaaa9ad5bcf0365d61ac7959e24c77e84df0b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067150 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#745535}
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //remoting/base to Once or Repeating Bug: 1007820 Change-Id: I92c6f555b8b9464beec2f53af00ee45846a52ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067394Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#745534}
-
Leon Scroggins III authored
Bug: skia:9756 https://skia-review.googlesource.com/c/skia/+/273768 splits SK_HAS_***_LIBRARY into separate defines for encoding and decoding. Split them up here, too. The old defines can be removed once the Skia CL lands. No behavior change. Change-Id: Iabf5a1e7692fa5077ddd06a28bdc442f463e021e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078745Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com> Cr-Commit-Position: refs/heads/master@{#745533}
-
John Budorick authored
Follow-up to crrev.com/c/2055408 Bug: 1057130 Change-Id: I032dc071209ddaf46bf4e8f3ae2d3d3f20ee739e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079685Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745532}
-
Philip Rogers authored
I was in this code for https://crbug.com/1048384 and noticed these redundant calls. The FakePaintedScrollbarLayer constructor already calls SetScrollElementId. Change-Id: Ieec2762cacc7097603d491e5c644358f2bd0a217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080482 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Tommy Steimel authored
In a refactor, we had accidentally changed the "CanControl" MPRIS property to be false instead of true. This CL changes it back. Bug: 1056629 Change-Id: Ie072f735bf10510f2c231d7d1f33d13f95101c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078974Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#745530}
-
John Chen authored
Fix a couple of issues related to handling of some types of invisible elements: * When element.getClientRects() returns an empty list, the code tries to use getBoundingClientRect, but the Object.assign call doesn't work correctly. * Zero-size elements can't be clicked on. Return appropriate error. These changes fix problems reported in an internal Google discussion (https://groups.google.com/a/google.com/g/webdriver-users/c/CKv3HQCBA4o). Change-Id: I4f9a2c42e6268441b6b3105de23bbef7b370a0c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079998 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#745529}
-
