GitLab

Methods OnPrimaryAccountSet/Cleared are deprecated. So this cl changes
these calls to OnPrimaryAccountChanged().

Bug: 1158855
Change-Id: Ie5a7880c7805f7a047345ee06111e78999db58ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612891Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841044}

Replace IdentityManager.Observer.(onPrimaryAccountSet/Cleared) call with
onPrimaryAccountChanged call.
Thse cl also replaces these calls in SigninManagerTest

Bug: 1158855
Change-Id: I7ffac4a907c34fb22b0ff07ffc27e09a4465a563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606347Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841043}

This disables tests that check the linkify output of the DevTools'
Linkifier. Temporarily disabling it to make changes in the Linkifier.

Bug: chromium:1132260
Change-Id: Ic0668709b2e8ee9e02c2f2624e073131556e918d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611029Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841042}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8978b61a6b13..61a89564cea2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC clamy@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: clamy@google.com
Change-Id: I2ecdf2562fded8c151d49db3dd199525cf83d2a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614698Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841041}

Change-Id: I9252a3dbf1d3d5906cfe5379090d2a06750eddfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612722
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841040}

Currently, TimerBase cannot correctly track the lifetime of objects
embedded in GC-ed objects, like FontPreloadManager which is embedded in
Document. This causes some memory safety issues.

This patch moves FontPreloadManager to Oilpan to avoid the issue.

Bug: 1154965
Change-Id: I490b416abc6a997034baaa7994cd3a50bca7e055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611755Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841039}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/468417610753..7c54d0e3efb6

2021-01-07 wolfi@chromium.org Add ignoreListJSFramesOnTimeline experiment
2021-01-07 tvanderlippe@chromium.org Update CodeMirror to 5.59.1
2021-01-07 jacktfranklin@chromium.org Migrate component docs data grid example to TS file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1144106,chromium:1161439
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8c8da1e21b8765b1b7125fc4fc0a6da901420e77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841038}

https://android.googlesource.com/platform/external/perfetto.git/+log/ccaf6dbd5c6e..5ff758df67da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I10b444bd144bf889148d16a882d2dc57d110910a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614469Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841037}

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..4191ca1784d8

$ git log 995c0b844..4191ca178 --date=short --no-merges --format='%ad %ae %s'
2021-01-04 vitaly Fixed installation on other than Ubuntu GNU/Linux distributions. (#541)
2021-01-01 tuexen Improve handling of aborted associations
2020-12-31 yuquanw2 Add SACK into fuzzer_fragment (#516)
2020-12-31 61293369+ihsinme Update client_upcall.c (#559)
2020-12-30 deadbeef Add optional SCTP_USE_OPENSSL_RAND define to use openssll's RNG. (#558)
2020-12-30 deadbeef Lowercase reference to iphlpapi.lib (#560)
2020-12-23 tuexen Improve input validation for parameters in ASCONF and ASCONF-ACK chunks
2020-12-20 deadbeef Fall back to using urandom on Linux if getrandom isn't available. (#557)
2020-12-14 tuexen Harden the handling of outgoing streams in case of an restart or INIT collision. This avouds an out-of-bounce access in case the peer can break the cookie signature. Thanks to Felix Wilhelm from Google for reporting the issue.
2020-12-12 tuexen Clean up more resouces of an existing SCTP association in case of a restart.
2020-11-19 weinrank Sync master with fuzzing branch (#551)
2020-11-18 CoolmanCZ MinGW release build - initialize variables (#548)
2020-11-18 deadbeef Call __msan_unpoison after syscall(__NR_getrandom, ...). (#550)
2020-11-18 deadbeef Support building with emscripten. (#549)
2020-11-18 sironhide0null Fix a typo in user_mbuf.c (#552)
2020-11-09 tuexen Fix a potential use-after-free bug introduced in https://github.com/sctplab/usrsctp/commit/b10a5d3b26e94320232dbdf269873497f8f7cff1.
2020-11-04 weinrank Fix #545 - remove .lib extension (#546)
2020-11-02 weinrank Use CMAKE's BUILD_SHARED_LIBS flag to build shared library (#543)
2020-10-22 tuexen Use the SCTP_REUSE_PORT socket option.
2020-10-17 tuexen Improve the handling of cookie life times. The staleness reported in an error cause is in us, not ms. Enforce limits on the life time via sysct; and socket options consistently. Update the description of the sysctl variable to use the right unit. Also do some minor cleanups. This also fixes an interger overflow issue if the peer can modify the cookie. This was reported by Felix Weinrank by fuzz testing the userland stack and in https://oss-fuzz.com/testcase-detail/4800394024452096
2020-10-13 tuexen Improve compilation on Windows.
2020-10-07 tuexen Whitespace changes
2020-10-06 tuexen Reset delayed SACK state when restarting an SCTP association
2020-10-06 tuexen Cleanup.
2020-10-06 tuexen Accept any cookie if FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION is defined.
2020-10-06 tuexen Provide RNG for __native_client__ as suggested by Taylor Brandstetter. Fail compilation on all platforms we don't have a specific RNG for.
2020-10-06 tuexen terminate_non_graceful() never returns...
2020-10-06 tuexen Initialize variables before using
2020-10-06 tuexen Remove dead stores reported by clang
2020-10-06 tuexen Cleanup
2020-10-06 tuexen Whitespace changes
2020-10-04 tuexen Use __func__ instead of __FUNCTION__
2020-10-04 tuexen Cleanup. No functional change intended
2020-10-02 tuexen Minor cleanup.
2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533)
2020-10-01 tuexen I guess Bitrig support arc4random().
2020-10-01 tuexen Whitespace change.
2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0.
2020-09-30 deadbeef Add missing return type to init_random. (#531)
2020-09-30 tuexen Try to fix the Windows build.
2020-09-30 tuexen Add Android specific code for the random number generator.
2020-09-30 tuexen Add platform specifc includes to the corresponding code.
2020-09-30 tuexen Add a cleanup routine for the random number generator.
2020-09-29 tuexen Improve the input validation and processing of cookies.
2020-09-28 tuexen Whitespace cleanup
2020-09-28 tuexen Improve random number generation on __Fuchsia__.
2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path.
2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984
2020-09-24 tuexen Whitespace changes
2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529)
2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527)
2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528)
2020-09-19 tuexen Improve consistency.
2020-09-19 tuexen Cleanup.
2020-09-19 tuexen Improve Windows build.
2020-09-19 tuexen Fix syntax error on windows.
2020-09-19 tuexen Add include for getrandom() on Linux.
2020-09-19 tuexen Fix type of init_random() on Linux and Windows.
2020-09-19 tuexen Improve Windows build.
2020-09-19 tuexen Improve consistency.
2020-09-19 tuexen Improve random number generation on Linux and Windows.
2020-09-19 tuexen Cleanup read_random(). No functional change.
2020-09-19 tuexen Fix NetBSD related #ifdef.
2020-09-19 tuexen Whitespace changes
2020-09-18 tuexen Add license.
2020-09-18 tuexen Add license statement.
2020-09-18 tuexen Fox more typos.
2020-09-18 tuexen Fix typo.
2020-09-18 tuexen Remove trailing whitspaces.
2020-09-18 tuexen Improve consistency, no functional change intended.
2020-09-18 tuexen Check for too short packets when using the receive threads.
2020-09-18 tuexen Fix mask for ECN bits.

Created with:
  roll-dep src/third_party/usrsctp/usrsctplib

Bug: chromium:1163228
Change-Id: I9b0b5f8c98bf3f7c9f51ae6fae24dd0e9b6e3117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612384Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841036}

Bug: 1112301
Change-Id: I24e68ca470e639c6ad704d0fd268c6a8c98b8731
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613052Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Yunke Zhou <yunkez@google.com>
Cr-Commit-Position: refs/heads/master@{#841035}

Before this CL, DatabasePageReader::ReadPage() computed `read_offset`,
which is a byte offset in a SQLite database file, by multiplying two
ints, a page ID and a page size. The multiplication result is an int,
which may overflow. Even on 64-bit Unix platforms, int is 32-bit wide.

The overflow may produce a negative offset, which breaks the API
preconditions of SQLite's low-level reading functions. On Unix
platforms, the xRead() function called by ReadPage() is implemented by
unixRead(). When SQLite's mmap support is enabled (it is in Chrome),
passing a negative offset to xRead() causes it to memcpy() from an
invalid memory address.

This CL fixes the overflow by casting one of the multiplication inputs
to int64_t, which causes the multiplication result to be an int64_t.
This CL is likely to fix the attached bug, because a few sample crash
dumps are consistent with the hypothesis of a memcpy() from an invalid
offset.

Bug: 1015800
Change-Id: Ibc8e8dab52eef447acdb65d0ee9ddaeab1e160df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605970
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841034}

This CL fixes problems that -1 of Int8Array is converted to 255 since it
is the casting as the char type and that a maximum value of
Uint{16, 32}Arrays are converted to -1 since they are the casting as the
signed types in TypedArraySerializerImpl.
For Uint32Array, this CL serializes/deserializes the value as the binary
type since base::Value supports the only int for the integer type.

Bug: 1148997
Change-Id: I52af228070606e4cd3f293dd80e4f0ca53b6b082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589535Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#841033}

Drop the std::move() call that has no effect and only triggers the
"bugprone-use-after-move" clang-tidy warning.

Bug: 1122844
Change-Id: I04d29171f6ced2fc129bff5bafb19a35acf2815f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611028
Commit-Queue: Matthias Körber <koerber@google.com>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matthias Körber <koerber@google.com>
Cr-Commit-Position: refs/heads/master@{#841032}

Bug: 1160744
Change-Id: I380a647751c692ef8880d92b63ad4e8080f36fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601741Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#841031}

Ephemeral Guest profiles are registered in profile attributes storage
because if Chrome crashes we need the registry to find and delete them.
But they should not be counted as a regular profile, so they are removed
from the count when the number of profiles is asked.

This was previously done in ProfileManager, but now moved to
ProfileInfoCache to avoid inconsistency when asked from different
classes.

Bug: 1161494, 1125474
Change-Id: I5fd9f9a262a940dd2e9358daa09f6e714d574669
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606282Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841030}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/e7ca23acac..a6c17c7e84
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/e7ca23acac..a6c17c7e84

No .def changes

Bug: None
Change-Id: I3e9329be1fad85a28ab05e35b8e26ee8701b85be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612847
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Auto-Submit: Danil Chapovalov <danilchap@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841029}

- Unittests for DlpClipboardNotificationHelper

Bug: 1161183
Change-Id: I0259954c314148a0df46c9bdefd7f87efcee1950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600899Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841028}

This CL removes the unused method in ChildAccountService. The method
was added before 2015.

Bug: 1161702
Change-Id: I7b6596b987a8b8b1203041a6fde138d8f92b1351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612997Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841027}

https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..5ff758df67da

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ib1b09e77b50272aa211311024cc4766af8097f61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841026}

https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..ccaf6dbd5c6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I589fa01c9bbd4eed97bc26e60a35b335e8a00f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614468Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841025}

This reverts commit d24a515a.

Reason for revert: Several  http/tests/security/isolatedWorld are failing following this CL landing. See https://bugs.chromium.org/p/chromium/issues/detail?id=1163893.

Original change's description:
> Reinitialize isolated world window proxies on navigation if needed.
>
> When a window proxy is initialized for a child frame, it must be
> reinitialized on every subsequent navigation to correctly hook up the
> window proxy (which may have cached JS references).
>
> Previously, this was only happening for the main world window proxy. One
> visible side effect is that if an extension cached a window proxy
> reference to a frame that was then navigated, the cached reference would
> not work until something else forced the window proxy to be
> reinitialized.
>
> Fixing this has an unintended side effect in an inspector protocol test
> which logs context creation: since isolated world window proxies are
> reinitialized in an arbitrary order (specifically, HashMap iteration
> order), the expected results become arbitrary as well. Instead of hoping
> that iteration order remains consistent, update the test to only log the
> context creation events it actually cares about.
>
> Change-Id: I11d7e13f7c2810d1c662ccf40f37c880e5026db5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607680
> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840983}

TBR=dcheng@chromium.org,yukishiino@chromium.org,haraken@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Bug: 1163893
Change-Id: I67acd05b659eb0134582301931f1ed2f3d7844bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612850
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841024}

Originally, this field was a ScopedPersistent, making it a strong GC
root from Blink to v8::Context. When the context was disposed (e.g. when
detaching the frame or purging v8), it was important to convert it to a
weak GC root with SetPhantom(). Otherwise, even if WindowProxy itself
was no longer reachable via Blink C++ objects, the strong V8 reference
could create a reference cycle preventing GC of both Blink and v8
objects.

   WindowProxy -> global_proxy_ -> v8::Context -> JS object
       -> chain of Blink C++ objects -> WindowProxy

With unified tracing, global_proxy_ can simply be a traced v8 reference.
Once WindowProxy is no longer reachable from a GC root (typically via
WebFrame (retained via a SelfKeepAlive) -> Frame -> WindowProxy),
WindowProxy and the associated v8::Context become collectible with no
need to explitily break a cycle.

Change-Id: If009b16260100a840c96ba4550a3da51554015fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598664
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841023}

1. Refactoring `NGGridPlacement` to contain all of the required data for
   item placement; on future steps of the sizing algorithm, this will be
   useful to avoid passing down most of its members as parameters.

2. Fixing a bug where auto-placed grid items would not consider lines
   created by negative indices as the start-most lines of the grid,
   which was the expected behavior from legacy's implementation.

3. Fixing an issue when using `GridPositionsResolver` where we didn't
   provide the total count of tracks spanned by an 'auto-fill' or
   'auto-fit' repeater in the respective direction.

Bug: 1045599
Change-Id: I77d9de38ac93d0b223f86939a629cfd0c90f7d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598396
Commit-Queue: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841022}

This change enables use of Affiliation Service to obtain Change
Password URLs on iOS.

Bug: 1108279
Change-Id: I48ce4fd4bd6e9da74166309e2ee737b50fb8aa86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566753
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841021}

This flag will guard a new implementation of OmniboxTextFieldIOS

Bug: None
Change-Id: I305e0d980287950595fd591e8dc71be34f141b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611244
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841020}

This addresses a subtle race condition in
CameraModuleCallbacks::SetCallbacks().

The key sequence of events,
1. CameraHalClient receives a pending remote of CameraModule
2. CameraHalClient calls CameraModule::GetNumberOfCameras()
3. CameraHalClient calls CameraModule::SetCallbacks() to pass a pending
   remote of CameraModuleCallbacks.
4. CameraModule receiver would fire
   CameraModuleCallbacks::CameraDeviceStatusChange()
5. CameraModule receiver then fires CameraModule::SetCallbacksCallback

The expectation was that 4 would be received before 5. However, since
CameraModule and CameraModuleCallbacks run on different message pipes, 4
can actually be received after 5, not meeting the expectation.

So here we make CameraModuleCallbacks an associated interface of
CameraModule.
Please see crrev.com/c/2434712 for the implementation on CameraModule.

Bug: b/169324225
Test: With the following,
    1. Open Chrome Camera App (CCA)
    2. restart cros-camera
    3. Verify CameraDeviceStatusChange is received before
       SetCallbacksCallback
    4. Repeat and passes 20/20 times.
    Additionally,
    1. Build capture_unittests and scp to DUT
    2. tast run dut 'camera.CaptureUnittests'

Change-Id: I79f6006b7827d2e556b01e7d57df43916ca7913e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470898Reviewed-by: Wei Lee <wtlee@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841019}

1. Readback for textured frames in blink::VideoEncoder
2. Media foundation encoder can now handle NV12 frames

Test: https://kstreeter.github.io/wctranscode/
Bug: 1158665
Change-Id: Ie5865736eeee22f91bcf161f82a687c03679f912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598058
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841018}

This reverts commit 387260f4.

Reason for revert: StartSurfaceTest#testShow_SingleAsHomepage_BackButton__Instant_Return is failing on builder "test-o-phone", see https://crbug.com/1163874

Original change's description:
> [Start] Don't auto delete a tab selected from the tab switcher.
>
> In this CL, we introduce a new flag "keepTab" for a Tab with launch type
> FROM_START_SURFACE. When this kind of Tab is selected from the carousel
> Tab switcher on the Start surface, or from grid tab switcher, the
> "keepTab" is set to be true. This guarantees the tab won't be auto
> deleted from the TabModel when the back button is tapped.
>
> More details see doc:
> https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit#
>
> Bug: 1155139
> Change-Id: Ib1e2ce917b0396bbd147ada2ebfc470cffd4718a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585822
> Commit-Queue: Xi Han <hanxi@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840737}

TBR=dtrainor@chromium.org,hanxi@chromium.org,wychen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Id3a59cff24aa7568b8d6866877731e8979ffeaae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1155139, 1163874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612897Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841017}

Chrome OS stores feature flags (in the chrome://flags sense) in signed
device settings so they can be applied to the login screen
environment. With this change, the code that writes to device settings
no longer stores raw switch values but feature flag names.

BUG=chromium:1073940
TEST=New unit tests

Change-Id: I97033aa72941ba31ee950948ff1e235ccc9692e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287290
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841016}

Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4379.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4380.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Icb366ab4a1c674dfa25ba555085bb20e8aaf7f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614565Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841015}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/24a9cfc3d443..468417610753

2021-01-07 changhaohan@chromium.org Fix angle popover early hiding and shift-click behavior

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I2613e51d5ff66359c2635b291104b480280d4368
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614465Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841014}

This is a reland of e8136dba
with updating the initial value for |cancel| in
PrintRenderFrameHelper::CheckForCancel() to false as it
could be called after |preview_ui_| is closed.

This change also includes cleaning up
printing_message_filter.{cc,h} since all messages in
PrintingMessageFilter has been converted to mojo interfaces.

Original change's description:
> [printing] Mojofy PrintHostMsg_CheckForCancel
>
> This CL replaces the PrintHostMsg_CheckForCancel IPC message
> with a new CheckForCancel Mojo method in the PrintPreviewUI
> interface.
>
> Bug: 1008939
> Change-Id: Ic694b892744387bfc0c4c1232ed4b6a9cb1b6388
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212181
> Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#771581}>

Change-Id: Ie8a9e8c7ae6e5c74616964a485fc2ec0496160a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596667
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841013}

Bug: 1150458
Change-Id: Id2720551fcfab68ea9ef9be8f97210fef89ed7ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612869Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841012}

If the result is a valid URL with a not HTTP(s) scheme, add
quotes so it triggers a search instead of a load.

Bug: 1153445
Change-Id: I5d9d79feafc6d2df756da5a9d35c434ce22393f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611735
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841011}

Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4379.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4380.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-bigcore-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ieb721438cf50fc972d0f48b5b9de996477ee149f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614567Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841010}

https://android.googlesource.com/platform/external/perfetto.git/+log/ccaf6dbd5c6e..5ff758df67da

2021-01-07 primiano@google.com Win port: Build {Thread,Test}TaskRunner on Windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: chromium:174454879
Tbr: perfetto-bugs@google.com
Change-Id: I55439b842c72eaf615702c0105004571d8e5364a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614185Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841009}

This change adds a clang tool to rewrite deprecated base::StringPiece
APIs. To do so, it makes use Clang Transformer [1], significantly
reducing the required boilerplate. For now, it only removes usages of
the `as_string()` API, replacing it with explicit std::string
constructions or omitting it entirely, if possible.

The edits generated by the tool compile cleanly, except when used
in complicated macro expressions. In these cases commas might not be
enclosed in parentheses correctly. While it'd be possible to modify
the tool to handle these cases properly, the required effort likely
outweighs a small manual pass over the result to fix these issues.

[1] http://lists.llvm.org/pipermail/cfe-dev/2018-November/060184.html

Bug: 1049498
Change-Id: I77a0945d6cb59bde6f2ad65f079a399f67bbd054
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601742
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841008}

https://android.googlesource.com/platform/external/perfetto.git/+log/7f2db542af0f..ccaf6dbd5c6e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Idd3f9add0888eb646b61ef4419fea11a8e46572f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#841007}

This reverts commit 7c0169de.

Reason for revert: Temporary revert to let https://chromium-review.googlesource.com/c/chromium/src/+/2612384 land before the -Wsometimes-uninitialized is addressed upstream.

Original change's description:
> Enable usrsctp runtime checks.
>
> The usrsctp library has a mechanism to enforce invariants (similar to
> CHECK or RTC_CHECK). In order to enable these checks, the macro
> INVARIANTS needs to be defined on all the usrsctp translation units.
>
> Maybe, this macro should be renamed into USRSCTP_ENABLE_CHECKS or at
> least into something with USRSCTP_ as prefix.
>
> This CL enables these runtime checks in debug builds and when the
> build is explicitly asking for them (dcheck_always_on=true).
>
> Bug: None
> Change-Id: Id63d78200ae2a762b86a4dc0c70d1a04e7d94350
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600903
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840138}

TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: Ifd63fad568cfdad45fe5330948e1fb616ba1c5cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614406Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841006}

Fixed by waiting for |requestVideoFrameCallback()| returned before draw
video onto canvas.

Bug: b/172214187
Test: tast run "camera.CCAUI*"
Change-Id: I7352a58f08d36cc2c2459af06883ae124ad7ad77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611148
Commit-Queue: Shik Chen <shik@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Auto-Submit: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841005}