GitLab

The PeerConnectionTracker logs events relating to an RTCPeerConnection
(APIs called, events firing, tracks added or removed) and lists them in
chrome://webrtc-internals.

Ever since the days of addStream()/removeStream(), the tracker has
listed a local or remote stream being added or removed as an event.
These APIs are no longer in the spec and are in fact implemented on top
of the spec-compliant addTrack()/removeTrack().

Prior to this CL, the tracker reported a stream being added by any means
as "addStream" and removed as "removeStream", which is misleading
because they may have been added through other APIs.

In preparation for Unified Plan, which expresses media sections in terms
of transceivers (sender-receiver pairs), the PeerConnectionTracker is
updated to more accurately express what is going on. In Unified Plan you
may for example add a transceiver that does not have a track yet or
receive a track by reusing an already existing transceiver. You may also
send the same track multiple times, or send/receive tracks that don't
belong to any stream or that belongs to multiple streams. This is all
described by the sender/receiver, not by any set of "local" or "remote
streams". In Unified Plan, because receiving tracks are created
alongside transceivers, often before being used if ever used, speaking
of tracks being "added" or "removed" is confusing.

Instead of "addStream"/"removeStream" we get
"[sender/receiver/transceiver][Added/Modified/Removed]".
The chrome://webrtc-internals log shows state of the sender or receiver
(TODO: or in Unified Plan, the transceiver) that was added, updated or
removed.

This will continue to make sense moving forward, and removes the
dependency on streams, which is a RTCRtpTransceiver blocker because
Unified Plan uses stream IDs, not streams.

Bug: 810708, 777617
Change-Id: I47dad2cb0b754c4ab8fb47ca5c7da3e0f33c6072
Reviewed-on: https://chromium-review.googlesource.com/1117063Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571129}

Using wpt-import in Chromium f67bbacc.
With Chromium commits locally applied on WPT:
ab4fb5ca "Update links to feature policy documentation."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20297

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=markdittmer

No-Export: true
Change-Id: I79984ede877feafd838921daa2af13167f4acde5
Reviewed-on: https://chromium-review.googlesource.com/1118015
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571128}

When this flag is specified (e.g. in tryjob retry without patch &
FindIt), the test runner doesn't fail if no tests are run (e.g. because
of an empty test list). Previously, the runner would still exit early
and produce no artifacts in such case. This CL changes the behaviour to
keep executing and produce valid empty (*) test result JSONs.

* Caveat: the JSONs aren't really empty; they still contain a list of
WONTFIX (and hence skipped) tests because of implementation details.

Bug: 851639
Change-Id: Idfc990263e130bc02dc441bc0d375a149e8b44d3
Reviewed-on: https://chromium-review.googlesource.com/1117623Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571127}

This CL increases CheckableImageView size specified in
checkable_image_view_widget.xml to match the size of standard checkbox
widget and fix alignment.

Bug: 857267
Change-Id: I6beb61a6d7d27092b3a491b3e8e2c9ee962f69ae
Reviewed-on: https://chromium-review.googlesource.com/1118272Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571126}

This reverts commit ccd4ec08.

Reason for revert: multiple tests failing on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)(32)/50984

UpdateServiceTest.UninstallExtensionWhileUpdating
PolicyUpdateServiceTest.PolicyCorruptedOnStartup
PolicyUpdateServiceTest.FailedUpdateRetries
UpdateServiceTest.TwoUpdateCheckErrors
UpdateServiceTest.UpdateCheckError
UpdateServiceTest.SuccessfulUpdate
ComponentUpdaterPolicyTest.EnabledComponentUpdates
PolicyUpdateServiceTest.Backoff
UpdateServiceTest.PolicyCorrupted
UpdateServiceTest.NoUpdate

[5637:5892:0628/072239.370548:FATAL:http_request_headers.cc(129)] "POST /pinghost/service/ping HTTP/1.1" is missing colon delimiter.
 


Original change's description:
> Migrate client_update::SendProtocolRequest to SimpleURLLoader
> 
> URLFetcher et al will stop working in the browser process with advent
> of Network Service, and SimpleURLLoader is the replacement API
> for most clients. CL migrates SendProtocolRequest to the new API.
> 
> Major remarks:
> 
> * URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
> of the former is kept (are almost the same) in the later. This allows the extensive set of unit
> tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
> to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.
> 
> * URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
> and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
> This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
> directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
> eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
> Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
> have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
> using EmbeddedTestServer in order to intercept URL loads.
> 
> Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
> some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
> so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
> It will be done in a follow up CL.
> 
> BUG=773295,844973
> 
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
> Reviewed-on: https://chromium-review.googlesource.com/1097337
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571097}

TBR=droger@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,sorin@chromium.org,emaxx@chromium.org,tonikitoo@igalia.com,mxnguyen@chromium.org

Change-Id: I0974aeef814ac153bf7da86ebf3e2f09b410bdd6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 773295, 844973
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118585Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571125}

Extensions may be whitelisted to suppress the zoom bubble when
performing an extension initiated zoom (e.g. the PDF viewer). However,
this also suppressed updates to the zoom bubble if it was already
being shown.

We now update the zoom bubble (if it exists) in this case.

Bug: 817278
Change-Id: Ia746f25de2760e8349a1ec3d3f4c899392d0fc81
Reviewed-on: https://chromium-review.googlesource.com/1086153Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571124}

So far, all instances of this missing selector crash linked in the bug have
come from 10.10.0, but my copy of 10.10 has it. This change checks
`respondsToSelector:`, instead of OS version, before calling SPI.

Bug: 856211
Change-Id: Ib2aa07e0e24b83f1766a2f6e16e19b2b123970a6
Reviewed-on: https://chromium-review.googlesource.com/1115781Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571123}

Bug: 753924
Change-Id: I4656a4f3d409bb6aada86654f675dc0e51cb93d2
Reviewed-on: https://chromium-review.googlesource.com/1117601Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571122}

A new Clang version caught this.

TBR=wangxianzhu

Bug: 857393
Change-Id: Ib3d9d7c0bd67d9b2deed699662de91e75ee47694
Reviewed-on: https://chromium-review.googlesource.com/1118380Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571121}

IdentityProvider currently has baked-in knowledge of OAuth2TokenService
for functionality that is shared between ProfileIdentityProvider and
DeviceIdentityProvider. However, as we will be converting
ProfileIdentityProvider to talk to IdentityManager rather than
OAuth2TokenService, this baked-in knowledge needs to be moved out of
IdentityProvider; ultimately, it will end up only in
DeviceIdentityProvider.

This CL takes a step along that path by moving the IdentityProvider
method implementations that interact with access tokens into the two
derived classes, making fetching and invalidating access tokens virtual
methods of IdentityProvider.

TBR=pastaramovj@chromium.org

Bug: 809452
Change-Id: I7b80f54d783dfa4de3236aec46c663bbfcb92422
Reviewed-on: https://chromium-review.googlesource.com/1114611
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571120}

The experiment expired a year ago, so we presumably don't need to keep
it around.

Bug: None
Change-Id: Ie8ad4237aea5e4dadbaf9b9a1b7a8439829645d9
Reviewed-on: https://chromium-review.googlesource.com/1117024Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571119}

Noticed while preparing
https://chromium-review.googlesource.com/c/chromium/src/+/1113548: this
test currently does not test what it is intended to. It is intended to
test that when an ongoing access token request is fulfilled with an
expired token, GCMAccountTracker notices that the token is no longer
valid and marks the account as needing a token request. However, the
current structure of the test prevents any access token request ever
being made for the newly-added account: the account is added when the
driver isn't connected, in which case GCMAccountTracker doesn't make
access token requests. Hence, the test passes even if the call to
IssueExpiredAccessToken() is replaced by a call to IssueAccessToken().

This CL changes the test to match its intention: we add the account
with the driver connected and check that the request was started, then
disconnect the driver before fulfilling the request (so that another
token request isn't made immediately), and *then* check that a new
token request is now marked as being needed. In particular, the test
now fails if the replacement mentioned in the previous paragraph is
made.

Bug: 809923
Change-Id: Idc2458d4a0d8e9e702ac8a61cdff9ad138e16fa3
Reviewed-on: https://chromium-review.googlesource.com/1113677
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571118}

This is a reland of 30184c71

Original change's description:
> Add a test helper method in services/network to get the body from a ResourceRequest.
> 
> Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3
> Reviewed-on: https://chromium-review.googlesource.com/1115346
> Reviewed-by: Doug Turner <dougt@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570813}

Change-Id: If27653a4cc7e94d7f44b02f9eb790e2a46949cc4
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1118438Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571117}

The test has been previously disabled (skipped) on Windows due to
recurrent timeouts. Running the test locally leads to an average of ~
3.7 sec runtime on a high-performance Windows 10 rig (Z840). The test is
not skipped on Linux right now, but since its runtime exceeds the 2 sec
rule of thumb (from the comments in SlowTests), this CL will make it
slow on Linux as well.

Bug: 850964
Change-Id: Ib478c0f59313da4302325578d9b768e1070bdcb6
Reviewed-on: https://chromium-review.googlesource.com/1115214Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571116}

https://skia.googlesource.com/skia.git/+log/0ce5ab9d3122..385804514edf


git log 0ce5ab9d3122..385804514edf --date=short --no-merges --format='%ad %ae %s'
2018-06-28 robertphillips@google.com Revert "Remove drawTextBlob from device use drawGlyphRunList"
2018-06-28 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-06-28 herb@google.com Remove drawTextBlob from device use drawGlyphRunList


Created with:
  gclient setdep -r src/third_party/skia@385804514edf

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I3fdc9150792c2f951218ab3332f70c627254e283
Reviewed-on: https://chromium-review.googlesource.com/1117945Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571115}

Many of the uses are of page allocator, which can just be used directly. partition_alloc.h
previously included wtf.h but did not use it; removing this required adding it to various
source files which were using IsMainThread but not including the appropriate header.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9ee136ed2396b83639b99224e6aaf0622ef12e3a
Reviewed-on: https://chromium-review.googlesource.com/1115500Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571114}

https://chromium.googlesource.com/angle/angle.git/+log/26581113047a..a26de2500503


git log 26581113047a..a26de2500503 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 lucferron@chromium.org Vulkan: Enable dEQP a passing test in buffer.write
2018-06-28 lucferron@chromium.org Vulkan: Enable the remaining dEQP fbo.render tests


Created with:
  gclient setdep -r src/third_party/angle@a26de2500503

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I8ee418f33f09f274cb4267c8e533ae51f09ea00e
Reviewed-on: https://chromium-review.googlesource.com/1117947Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571113}

Bug: 807724
Change-Id: I51a758649dc72cc4835311264d883e0acac98a42
Reviewed-on: https://chromium-review.googlesource.com/1117035Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571112}

This CL adds accessibility traits to the toolbars such as they are
acting as VoiceOver "container". If the user sets the accessibility
rotor to "containers", the user is able to go navigate quickly between
the toolbars and the webpage.

Bug: 856212
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I309a1308bb200bf9f90aaa4b164a3798c93c0f31
Reviewed-on: https://chromium-review.googlesource.com/1118275Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571111}

The new State encompasses (and should eventually largely replace) the
following state getters:
- CanSyncStart
- IsEngineInitialized
- GetAuthError
- IsFirstSetupComplete
- HasUnrecoverableError
- IsSyncActive
- ConfigurationDone

Other SyncService state that it *not* packed into the enum:
- Setup in progress
- Encryption
- Anything that's per-ModelType
- Local Sync

Bug: 839834
Change-Id: Iec1c3d744ffcb33fceccfe0bb0d028cc17203655
Reviewed-on: https://chromium-review.googlesource.com/1102331
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571110}

The URL and security state are read first. The next accessible
element is the share button.

Bug: 821808
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0416aae221309f3202b2e1644b55b6755e88fbfd
Reviewed-on: https://chromium-review.googlesource.com/1112010
Commit-Queue: Elodie Banel <lod@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571109}

Prior to a refactoring in crbug.com/827334,
NewTabPageView#onAttachedToWindow used to update the search box scroll
position which is used by ToolbarPhone to determine location bar properties.
In the refactoring, this logic moved to NewTabPageLayout#onAttachedToWindow.
This method, however, is not always guaranteed to be called when the NTP is
refocused because the NTPLayout may be scrolled off screen and not
immediately bound to a RecyclerView ViewHolder.

This CL re-introduces NewTabPageView#onAttachedToWindow, ensuring
ToolbarPhone is properly notified of the current NTP scroll position
when the NTP is refocused.

BUG=856936

Change-Id: Iefa82aff60cd1e60a2787734c93793e5e50a65f4
Reviewed-on: https://chromium-review.googlesource.com/1117860Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571108}

Each v8::Context is wired with a ScriptState, and it clears the
self-reference of ScriptState at its termination.
In worker threads, it means that ScriptState is kept alive until
terminating v8::Isolate, although ScriptState is not used after
disposing global scope.

This CL explicitly does tasks in weak callback registered in v8::Context
at disposing global scope. Actual tasks are (1)to clear self-persistent
of ScriptState and (2)to drop a weak reference from ScriptState to
v8::Context.
This change makes it possible to release ScriptState at anytime before
v8::Isolate termination.


Bug: 773605
Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7
Reviewed-on: https://chromium-review.googlesource.com/1117976
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571107}

Following bot results are included.
7278 7285

0 lines were removed and 0 lines were deflaked by consecutive
results since 7194.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: If4116f789a84eab78272c231cad0c3aff7166569
Reviewed-on: https://chromium-review.googlesource.com/1118095
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571106}

This reverts commit 0c2015e1.

Reason for revert: This CL isn't actually disabling the test.

Original change's description:
> Disable WebStateTest.MessageFromIFrame test.
> 
> TBR=eugenebut@chromium.org
> 
> Bug: 857129
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I407a6464e71296cc15eef43bf7ed2a8ca8181909
> Reviewed-on: https://chromium-review.googlesource.com/1117300
> Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570882}

TBR=eugenebut@chromium.org,michaeldo@chromium.org

Change-Id: I444e4e1b224685b63cee4f2a672066bfeca8983f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118319Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571105}

Decreased top inset from 5 to 4 px. With 5 px, the top of the omnibox was 1 pixel higher than the top of the location bar.

Bug: 857068
Change-Id: Id1ea4601aed65f62fffccd05deac5dcbeab8d0d5
Reviewed-on: https://chromium-review.googlesource.com/1117642
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571104}

Set priority of ad frames to low or best effort depending on the
feature list enabled.

Bug: 856150
Change-Id: Ia76d55e1fc4b8617d5db9bca26b79ac25b5856c9
Reviewed-on: https://chromium-review.googlesource.com/1112251Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571103}

Depot tools download the GN here now.

Bug: 855791
Change-Id: Id2d60230331b90ff97018493892189deed5bbb77
Reviewed-on: https://chromium-review.googlesource.com/1118269Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571102}

Some functions ended up having more overloaded versions than
is reasonable; templates to the rescue.

1. Move MaybeReply from .h to .cc, made it into a template, and
   used it in a few additional cases.
2. Made MaybeReply take a base::Location&, rather than hard-code
   the location of the helper function itself.
3. Created a template for Reply and ReplyClosure in the unit test
   suite.

Bug: 775415
Change-Id: Ie2c9e31defd045535845d198c658f0859ef99228
Reviewed-on: https://chromium-review.googlesource.com/1114615
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571101}

This reverts commit 30184c71.

Reason for revert: <suspecting that this patch caused unit test SSLErrorHandlerDateInvalidTest.TimeQueryHangs flaky, crbug.com/857446>

Original change's description:
> Add a test helper method in services/network to get the body from a ResourceRequest.
> 
> Also remove the custom URLLoaderFactory in content_hash_fetcher_unittest. This isn't needed anymore as TestURLLoaderFactory now supports Clone.
> 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: Id70ec605886a6b0f2cb9bf7392fac4eff85fc1b3
> Reviewed-on: https://chromium-review.googlesource.com/1115346
> Reviewed-by: Doug Turner <dougt@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570813}

TBR=jam@chromium.org,dougt@chromium.org

Change-Id: I2bd852fbf746203e325e6a859ad2b5cc2919b7e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1117521Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571100}

While the underlying SVGResource should be unique (or nullptr - for
invalid cases), the StyleSVGResource wrapper usually isn't. Hence we
need to use DataEquivalent(...) to properly determine equality.

Bug: 769774, 855914
Change-Id: I333bc7a737d0635aabe35e39bb066edbc4282790
Reviewed-on: https://chromium-review.googlesource.com/1118219Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#571099}

Whitelist the one place which wants to query malloc usage, which is a
memory reduction histogram on Android.

Change-Id: I03a821aeec7b3b0524b02b432d2cea196b7a1f83
Reviewed-on: https://chromium-review.googlesource.com/1117634Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571098}

URLFetcher et al will stop working in the browser process with advent
of Network Service, and SimpleURLLoader is the replacement API
for most clients. CL migrates SendProtocolRequest to the new API.

Major remarks:

* URLRequestPostInterceptor is replaced by URLLoaderPostInterceptor although the public APIs
of the former is kept (are almost the same) in the later. This allows the extensive set of unit
tests to remain untouched. The replacement is needed because URLRequestPostInterceptor used
to intercept requests instantiated by URLFetcher, precisely the class we are moving away to use.

* URLLoaderPostInterceptor operates in two modes: it supports working both with TestURLLoaderFactory
and EmbeddedTestServer. Two constructors are offered that control the 'mode' it operates on.
This is needed because of the nature of the tests: some tests manipulate the TestConfigurator
directly, hence the needed SharedURLLoaderFactory instance can be acquired directly from it,
eg PingManagerTest, UpdateCheckerTest and RequestSenderTest.
Some other tests, trigger the respective SimpleURLLoader machinery from upper layers, and then
have no access to TestConfigurator instances. In such cases, URLLoaderPostInterceptor operates
using EmbeddedTestServer in order to intercept URL loads.

Note that this CL migrates components/update_client/utils.cc|h to SimpleURLLoader, but there
some other classes on the same directory that still use URLFetcher (eg UrlFetcherDownloader),
so we simply can not *yet* remove all the references to URLFetcher and URLRequestContextGetter.
It will be done in a follow up CL.

BUG=773295,844973

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3d8be368818ba77b559907c0217995f8c6a95b04
Reviewed-on: https://chromium-review.googlesource.com/1097337
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571097}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/56b60a2e..d3714bb8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I93ec403a2c990e082e806b037f1293553b35ef13
Reviewed-on: https://chromium-review.googlesource.com/1118007Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571096}

https://webrtc.googlesource.com/src.git/+log/64b17c2aca96..77cc8182aef6


git log 64b17c2aca96..77cc8182aef6 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 mbonadei@webrtc.org Pull GN via CIPD package.
2018-06-28 alexnarest@webrtc.org Adding ABWENoTWCC field trial
2018-06-28 terelius@webrtc.org Add return after NOT_REACHED() in eventlog unittest.


Created with:
  gclient setdep -r src/third_party/webrtc@77cc8182aef6

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib9844e6d7c25671ddbdb96fe1ba12a8846a3bf81
Reviewed-on: https://chromium-review.googlesource.com/1117944Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571095}

The DelayUnsafeAds field trial parameters should only be queried if the client has
AdTagging enabled.

Bug: 856271
Change-Id: Ie4c19bb735c8b20c2454da21f12c3c7ce7cd4e02
Reviewed-on: https://chromium-review.googlesource.com/1117326Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571094}

There is no usage of the constructor.

Change-Id: I23cfe086745d2d6b395ee4a6e29c64304504a1d4
Reviewed-on: https://chromium-review.googlesource.com/1118075Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571093}

When a tab is closed, if other tabs do not have active peer
connections, remote event logs collected on the first tab become
eligible for upload.

Bug: 775415
Change-Id: Id14b880753d90e0a4693bd5f966e1d674d4d850a
Reviewed-on: https://chromium-review.googlesource.com/1116548
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571092}

A new Clang version caught these two cases.

(While fixing localized_error.cc, switch the bitfields to unsigned and
tweak a comment.)

TBR=edwardjung,khushalsagar

Bug: 857393
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I88bf4bfb2f3cf7874c308c9b3453e9d01c7c16ee
Reviewed-on: https://chromium-review.googlesource.com/1118165Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571091}

Prepares moving DocumentState creation outside of
DidCreateDocumentLoader. It does a few things:

- Separates the paths between using pending_navigation_params_
and not using them to build DocumentState.
- Removes the dependencies on navigation_state in
DidCreateDocumentLoader. Instead we use the pending_navigation_params_
directly. Also removes reliance on default constructed values of
CommonNavigationParams and RequestNavigationParams members.
- Moved as much things as possible out of the main class into
utilities in the anonymous namespace.
- Stripped UpdateNavigationState that is now only used to update same
document navigation states.


Bug: 789577
Change-Id: I18d12d24827c3289ef909d9253fe8bbf6ca5080f
Reviewed-on: https://chromium-review.googlesource.com/1109831Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571090}