GitLab

Write() operations to a Channel can fail due to the peer having closed
it, while there are still messages waiting to be read from it. We must
therefore defer notifying the caller of the Channel::Error until we
observe end-of-stream via a readable notification, otherwise those
messages may be dropped (depending on whether the posted OnError task
is processed before or after a pending Channel-readable event).

Bug: 816620
Change-Id: I75bd34a48edf4022809d27ce49f9cfba7a5d4daf
Reviewed-on: https://chromium-review.googlesource.com/956932
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542634}

R=nodir@chromium.org

Change-Id: If7d4793523d7ada7e08722b5442988568554d5c1
Reviewed-on: https://chromium-review.googlesource.com/959603Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542633}

This is a reland of https://crrev.com/c/953591 with a fix.

BUG=813163
TBR=jochen@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/953591Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541636}
Change-Id: I2683369ef68c198a954488b2aaa7d66eb63c9b2f
Reviewed-on: https://chromium-review.googlesource.com/958036
Cr-Commit-Position: refs/heads/master@{#542632}

https://skia.googlesource.com/skia.git/+log/24f25dc8bca7..67f62b1a6101

$ git log 24f25dc8b..67f62b1a6 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 brianosman Add SkColorSpaceXform_skcms
2018-03-12 bungeman Revert "IWYU for some test files starting with 'C'."
2018-03-12 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 3ca91a31d..6cecdee60 (2 commits)
2018-03-12 bungeman IWYU for some test files starting with 'C'.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: I2c9341bc6f134e265a20f670bc78d5fc066c33c8
Reviewed-on: https://chromium-review.googlesource.com/959458
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542631}

There are two cases that PDF files are being printed: from print
preview or directly from PDF plugin extension. Our previous way of
identifying a PDF file being printed replies on the printed
document's setting 'is_modifiable' is correctly set up. However,
it was only set up when print preview is enabled, not when using
system dialog. This CL fixed that by directly checking the web URL.

Also since the web url can be checked for print preview, we no
longer need to keep the flag 'for_preview' inside print composite
client. So removed that.

BUG=820143

Change-Id: I8c9051d5e2945b1d5a4b9f74494fbe3f6ad795f2
Reviewed-on: https://chromium-review.googlesource.com/958298
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542630}

nicholss@chromium.org shows "No longer on Chrome" in Gerrit.

zijiehe@ has left per jamiewalch@

Change-Id: I3d4b5dae03a0e16f6d3322c0994a901039bd7546
Reviewed-on: https://chromium-review.googlesource.com/959563Reviewed-by: Zijie He <zijiehe@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#542629}

Adds constants and helpers for upcomming frame metrics.

The Accumulator96b class accumulates values with 96 bits
of precision, which will be important when accumulating
32-bit values that are squared and weighted.

Bug: 790761
Change-Id: Ie88800bef37c6103dd2becd9f85402b3e5fd34d4
Reviewed-on: https://chromium-review.googlesource.com/949823Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542628}

Fixed AXObject IndexInParent by retrieving the unignored parent since all children are unignored by default

R=dmazzoni@chromium.org, aboxhall@chromium.org

Change-Id: Ib8b391fd938eee6dc0b48fc08791dd01f68e7faf
Reviewed-on: https://chromium-review.googlesource.com/956298
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542627}

This reverts commit f70764f0.

Reason for revert: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133606 Android build failed.

Original change's description:
> Adds a class that encapsulates a range in Blink's accessibility tree.
> 
> This is just a basic class that can convert from a DOM selection to an AX range and vice versa. It can also perform a selection on the AX range.
> This class doesn't still handle any of the many corner cases that I will be looking at next, cases that will be covered by tests.
> R=​dmazzoni@chromium.org
> 
> Bug: 
> Change-Id: I7c98617e8ef3b8bcca8cfc0d2e5518f2da771063
> Reviewed-on: https://chromium-review.googlesource.com/678016
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542619}

TBR=dmazzoni@chromium.org,yosin@chromium.org,haraken@chromium.org,mlamouri@chromium.org,yoichio@chromium.org,nektar@chromium.org,xiaochengh@chromium.org,xiaochengh@google.com

Change-Id: I9aa2b6ecde4df092f73255e22155087a1f87486b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/959429Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542626}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/fc5740ae..10c5b8fc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I2410d09aeb483619fc8e21b55846de85f7f24532
Reviewed-on: https://chromium-review.googlesource.com/959428Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542625}

Network traffic annotation is passed from HttpRequestInfo to
SpdyHttpStream.

Bug: 656607
Change-Id: I8cfc0cade93e016c3e7f497e3a06a1dbf9894494
Reviewed-on: https://chromium-review.googlesource.com/958921
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542624}

Previous version of fuzzer used std::string, which in
C++11 nul-terminates, but actual caller expects
base::StringPiece which does not. This failed to catch
an overflow bug, so switch to using base::StringPiece.
Also revert "base_json_reader_fuzzer: Sanitizer-poison memory around the input buffer."
since the change is unneeded.

This reverts commit 845bbd0e.

R=rsesek@chromium.org

Change-Id: I8abffc3f2931818711119406effa685b1d368659
Reviewed-on: https://chromium-review.googlesource.com/959564
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542623}

ScrollLatencyBrowserTest.SmoothWheelScroll waits for an UMA metric to
be collected. With OOP-D, the metric is collected in the gpu process,
instead of in the browser process. So, make sure the test collects
all the UMA from the child processes so that it can see the UMA it is
waiting for.

BUG=786151

Change-Id: I58d93c32c4ee57b1f8ba24de1a370bac97f0e17f
Reviewed-on: https://chromium-review.googlesource.com/959454
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542622}

After looking through the code, it seems the only thing that could
be going wrong here is |app_state| not thinking we have running
activities during the unit test.

This CL will let us figure out if app_state is the member at fault here,
and hopefully what to do about it.

Bug: 819592
Change-Id: I3f43b3b7ec5dab8c7c5e6ca0b4fa9f2967e4ea9f
Reviewed-on: https://chromium-review.googlesource.com/958190Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542621}

The Android "core trampler" bug has been fixed so all the code added
to validate histogram objects (and thus locate when the corruption was
occurring) is no longer necessary.

Bug: 744734
Change-Id: I96fbf10d87aa38e062cc32acdade1448e47067a5
Reviewed-on: https://chromium-review.googlesource.com/693454Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542620}

This is just a basic class that can convert from a DOM selection to an AX range and vice versa. It can also perform a selection on the AX range.
This class doesn't still handle any of the many corner cases that I will be looking at next, cases that will be covered by tests.
R=dmazzoni@chromium.org

Bug: 
Change-Id: I7c98617e8ef3b8bcca8cfc0d2e5518f2da771063
Reviewed-on: https://chromium-review.googlesource.com/678016
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542619}

Upload crashes to the crash server (official build only) using the
product name "AppShell_Linux".

Bug: 818065
Change-Id: I6ad23001323bbc7858ab5b45763868bccfa90a7e
Reviewed-on: https://chromium-review.googlesource.com/957968
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542618}

iPhone 6s 10.3.3 device.
This has been failing since Friday, March 9th.

============
VariationsCrashKeysTest.BasicFunctionality:
../../components/variations/variations_crash_keys_unittest.cc:60: Failure
Expected equality of these values:
  "1"
  GetNumExperimentsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:61: Failure
Expected equality of these values:
  "8e7abfb0-c16397b7,"
  GetVariationsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:67: Failure
Expected equality of these values:
  "2"
  GetNumExperimentsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:68: Failure
Expected equality of these values:
  "8e7abfb0-c16397b7,277f2a3d-d77354d0,"
  GetVariationsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:74: Failure
Expected equality of these values:
  "3"
  GetNumExperimentsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:76: Failure
Expected equality of these values:
  "8e7abfb0-c16397b7,277f2a3d-d77354d0,9f339c9d-746c2ad4,"
  GetVariationsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:81: Failure
Expected equality of these values:
  "4"
  GetNumExperimentsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:85: Failure
Expected equality of these values:
  "8e7abfb0-c16397b7,277f2a3d-d77354d0,21710f4c-99b90b01," "9f339c9d-746c2ad4,"
    Which is: "8e7abfb0-c16397b7,277f2a3d-d77354d0,21710f4c-99b90b01,9f339c9d-746c2ad4,"
  GetVariationsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:93: Failure
Expected equality of these values:
  "5"
  GetNumExperimentsCrashKey()
    Which is: ""
../../components/variations/variations_crash_keys_unittest.cc:97: Failure
Expected equality of these values:
  "8e7abfb0-c16397b7,277f2a3d-d77354d0,21710f4c-99b90b01," "9f339c9d-3250dddc,21710f4c-99b90b01,"
    Which is: "8e7abfb0-c16397b7,277f2a3d-d77354d0,21710f4c-99b90b01,9f339c9d-3250dddc,21710f4c-99b90b01,"
  GetVariationsCrashKey()
    Which is: ""

TBR=asvitkine

Bug: 821162
Change-Id: I7bbe3f33165fb260dbb2d10751ab16b109c0325e
Reviewed-on: https://chromium-review.googlesource.com/959562Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542617}

Change-Id: I39631a593843bc5036503b3d4a27ba7eac00c16e
Reviewed-on: https://chromium-review.googlesource.com/956754
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542616}

https://chromium.googlesource.com/angle/angle.git/+log/529434a5a565..203d6365c567

$ git log 529434a5a..203d6365c --date=short --no-merges --format='%ad %ae %s'
2018-03-09 lucferron Vulkan: enable multiple draw* dEQP tests
2018-03-12 lfy Run clang-format on State.cpp
2018-03-09 lucferron Vulkan: Enable 16 additional tests for the scissor test
2018-03-09 lucferron Vulkan: Enable 1046 additional tests for blending rasterization states
2018-03-08 jmadill Framebuffer: Handle errors in checkStatus.
2018-03-12 lucferron gpu_test_expectations: Fix test for API overlap

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I36aab3baf0e519ecc28bb1e2ecd447e9ce91598a
Reviewed-on: https://chromium-review.googlesource.com/958029
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542615}

This adds a final timeout to PageAlmostIdle transitions so that they always fire at some point.
This notification is intended to mean "initial load has finished", and it makes sense for this
to fire at some point. This simplifies logic in an upcoming CL which factors
observation logic out of the TabManager into a helper component.

BUG=749789

Change-Id: I1db03f991220eebd33251dc5258a2760042eedef
Reviewed-on: https://chromium-review.googlesource.com/929985
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542614}

This clears animation state maps maintained in IAC, on navigaion.
The navigaiton signal is recieved from LTH and the entries without
driver/recordings are cleared on activation. A new LTHI func is
introduced ::DidNavigate, which takes care of clearing both animation
and decode cache.

BUG=789715

Change-Id: I8c6b37a6c2783ff727931e9812ff41c4321ab855
Reviewed-on: https://chromium-review.googlesource.com/919265
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542613}

TBR=fgorski@ for namespace change affecting offline_page_download_bridge.cc

Change-Id: I2570e3c45827bb223cd3a729ee60e2e7c63b632c
Reviewed-on: https://chromium-review.googlesource.com/955844Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542612}

When the user wants to export or view passwords in Chrome's settings
on Android, the user needs to reauthenticate by unlocking the device.
So far, if such reauthentication proceded successfully, Chrome
remembered its timestamp and scope (bulk action -- exporting, or
single-item -- viewing).

However, if the user failed the reauthentication by cancelling or
simply not being able to reauthenticate, Chrome did nothing so far.

For implementation reasons, Chrome needs to consider the
reauthentication as valid for a short time, in particular to pick the
result up after being resumed once the OS-provided lock screen gets
dismissed.

To avoid reusing a recent reauth success once the user has failed the
challenge even more recently, this CL makes Chrome to also explicitly
declare the last authentication as invalid every time the user fails
to reauthenticate.

Bug: 820603
Change-Id: Ia37b9e8cfab43bfe4dec08bc7f2e67722c1b1534
Reviewed-on: https://chromium-review.googlesource.com/958462
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542611}

This API returns a URL containing the locale as a query parameter. The
Google help center uses this to decide in which language to display the
page. The old method for obtaining the locale would sometimes return a
locale in a format the help center didn't recognize (e.g., "cs-CZ").
Instead, use the UIManager to fetch the locale, to stay consistent with
how we generate the URL for actual interstitial pages.

This new approach seems more consistent with the help center's
expectations (e.g., "cs" instead of "cs-CZ").

the API, observe the page displays in the proper language

Bug: 820694
Test: manual - Put device in Czech (cs/cs-CZ) and visit the url returned
Change-Id: I72606a2eee00f5b1890f703593267e93fdd645ff
Reviewed-on: https://chromium-review.googlesource.com/958229Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542610}

- Reduce multipliers from 0.9/1.1 to 0.95/1.05. The current multipliers
seem too drastic.
- Remove logging that doesn't seem too useful for now.
- Add difference_slope logging. It may be useful to log in which
direction the difference is going and how fast.
- Only set the playback rate in the sync'd case if there is
a difference. Otherwise we're making uncessary calls and causing logspam

BUG=internal 73746352
TEST=On device

Change-Id: If073b98892e84ca8f13435f7322012daeb6ffe1a
Reviewed-on: https://chromium-review.googlesource.com/956877
Commit-Queue: Mina Almasry <almasrymina@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542609}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5edef2fbc54..a5910bdfbceb

$ git log c5edef2fb..a5910bdfb --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=821144


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id46d9ca7881806e7878311bd4fd4f06d88850347
Reviewed-on: https://chromium-review.googlesource.com/959448
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542608}

With this change, I have corrected the aspect ratio of our radial
gradients. That is, they are no longer elliptical when the quad is
rectangular. I have also made it possible to set a different center
point for the gradient.

Bug: 817620
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2d3a754fb1b8235ff454ea5148dfd9bbfde69068
Reviewed-on: https://chromium-review.googlesource.com/958037Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542607}

This CL adds TCP socket API to network service.
This is partly based on mandoline implementation
(https://codereview.chromium.org/1873463003/)

Two TCP socket interfaces are added.
- TCPConnectedSocket
- TCPServerSocket

TBR=miu@chromium.org

Bug: 721401
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I56e2702c02b9c86a72eba68c85391c3b017a4d64
Reviewed-on: https://chromium-review.googlesource.com/868711Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542606}

Similar to the previous alike-titled CL "[Blink] Avoid O(n) lookup during
scroll parent computation", this CL changes CompositingInputsUpdater to
keep track of clip chain information in recursion context for different
type of positioned descendants to achieve O(1) lookup.

And conveniently workaround crbug.com/817175

BUG=818768,817175

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib8bb76eb219a7056d6488484cc8439d44e7d7aac
Reviewed-on: https://chromium-review.googlesource.com/956503
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542605}

Also:
- Update the code to use PathService to get various locations.
- Check both per-user and per-machine locations for Desktop shortcuts.
- Remove stale comments and replace a stale constant with its documented
  name.
- Perform expensive checks outside of the critical path to startup.

BUG=none
R=tmartino@chromium.org

Change-Id: Ib8e4cdb91def96660095fbfbb18ae59e77d8e8da
Reviewed-on: https://chromium-review.googlesource.com/955655Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542604}

Bug: 791130
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7d9ab135ce43d7670b04083437889caacad93874
Reviewed-on: https://chromium-review.googlesource.com/949052Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542603}

Bug: 782356
Change-Id: I426c455e028fb70fa86eb39ba0d651bddf3cad2f
Reviewed-on: https://chromium-review.googlesource.com/930241Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542602}

http/tests/devtools/appcache/appcache-iframe-manifests.js:
- This test was associated with crbug.com/678481 and that
  bug is now fixed, and the test-related expectation has
  already been removed from LayoutTests/TestExpectations
  in r527386

http/tests/media/autoplay/document-user-activation-*
- These tests are flaky regardless of site-per-process
  and are already covered by LayoutTests/TestExpectations.
  This CL just extends TestExpectations entry to also cover Win.

external/wpt/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html
- New bug has been opened prior to this CL: https://crbug.com/819800

external/wpt/fullscreen/api/element-ready-check*
- New bug has been opened prior to this CL: https://crbug.com/820617

external/wpt/css/css-fonts/font-display/font-display.html
- This test is simply slow and often takes more than 5 seconds to
  finish - see https://crbug.com/816026#c7
- The timeout of this test is (since 2018-03-12) covered by the main
  LayoutTests/TestExpectations (see r542490).

Other entries removed by this CL simply seem to have "healed" themselves
and are currently passing on the waterfall and on the tryjobs.

Bug: 477150, 794631, 678481, 788390
Bug: 819800, 820617, 788390, 801992
Change-Id: If24ec321df9593ab217f50b7f1b39b3496faceef
Reviewed-on: https://chromium-review.googlesource.com/957683
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542601}

This is a reland of the commit listed below, with a fix for a
missing dependency that was causing an intermittent compile error.

TBR=yfriedman@chromium.org, kinuko@chromium.org

BUG=820262, 754862

Original change's description:
> [TTS] mojo-ify ShowUnhandleTapUIIfNeeded.
>
> Replaces the whole call chain for ShowUnhandledTapUIIfNeeded
> between Blink and Chrome/WebView with Mojo messaging.
>
> Removes the Blink WebTappedInfo class in favor of a new UnhandledTapInfo
> that sends a Mojo construct of the same name to the Browser which
> has a service installed via a RenderHostFrame observer.
>
> All functionality should remain unchanged.
>
> NEW CODE:
> The CSTabHelper now creates an UnhandledTapWebContentsObserver that
> connects the Mojo service via UnhandledTapNotifierImpl.  That Impl
> calls back through Java to the CSTabHelper to the CSManager to notify
> that a Tap has occurred.  The CSTabHelper ignores these notifications
> when CS is disabled.
>
> The mojo message is only sent to the browser if the tap is unhandled
> and the other required conditions are met.
>
> UPDATED TESTS:
> Test notification is now done through mojo messaging, so we now only
> know if the tap was unhandled, not whether the page changed or other
> details about why the tap was unhandled.
>
> Updated the test page by adding nodes that do not trigger, and removed
> the mousemove handler since it's unrelated to tap handling.
>
> BUG=754862
>
> Change-Id: I18111f2537cfb16a4523d7f0cc766037fbf6050a
> Reviewed-on: https://chromium-review.googlesource.com/841544
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#540629}

Change-Id: I91f1a3a6b6cfd410b49187beed94fc2191cae928
Reviewed-on: https://chromium-review.googlesource.com/957443
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542600}

Dumps symbols for app_shell to a file called "app_shell.breakpad.x64",
which official builders will soon start uploading to the crash server.

Also moves the logic for extracting Chrome Linux symbols into a new
"extract_symbols" GN template at //build/linux/extract_symbols.gni.

Bug: 818078
Change-Id: I68bafd10860040e105fde7abeddd52f35f12d07e
Reviewed-on: https://chromium-review.googlesource.com/957981Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542599}

When we set a whole truck of model data to Ash, every item will have
its folder id set properly. This may fail in the folder id checks in
AddItemToFolder and AddItemToFolderItemAndNotify.

Bug: 733662
Change-Id: I6d33353c6dd068be016da7d3af679c2f31a86b03
Reviewed-on: https://chromium-review.googlesource.com/958023Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#542598}

Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite convoluted
today. This a 1/n of a series of patches that clean it up.

CL adds a GetUserDataAs templatized function, where the actual type
is passed in.

BUG=None

Change-Id: Ie4d5ceb006c8c4d5fb7efb9a2fc3873b1f29ddf0
Reviewed-on: https://chromium-review.googlesource.com/959481
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542597}

This is a reland of 0588d062, as it was concluded
not to have been the culprit for the compile breakage.

Original change's description:
> Introduce a generic ScopedU2fDiscoveryFactory override.
>
>  -- In preparation for introducing ScopedU2fVirtualDiscoveryFactory, create a
>     base class ScopedU2fDiscoveryFactory and let ScopedU2fFakeDiscoveryFactory
>     derive from that.
>  -- In preparation for a wider adoption of FakeU2fDiscovery in tests that could
>     not care less about when a discovery starts, add a version of the fake
>     discovery where SimulateStarted()/SimulateStopped() is called automatically.
>
> Bug: 785955
> Change-Id: I4b1c9bd962c6e225be45971bbb0d5aad3b05a68a
> Reviewed-on: https://chromium-review.googlesource.com/959001
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542507}

TBR=jdoerrie@chromium.org

Bug: 785955
Change-Id: I4c9f42d81793567b6536d303f8a4d020fbe147d9
Reviewed-on: https://chromium-review.googlesource.com/959322
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542596}

This tests fails commonly due to additional range requests happening that
turn out to be expected.  After discussion we decided the 2 response
verification doesn't make sense and should be removed.  See comment 8
in the bug.

Bug: 809161
Change-Id: I57c60520c7a74a03cec3fff9e22dd1311ef78b47
Reviewed-on: https://chromium-review.googlesource.com/959452Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Richard Bustamante <bustamante@google.com>
Cr-Commit-Position: refs/heads/master@{#542595}