- 26 Mar, 2020 20 commits
-
-
Jesse Mohrland authored
If a user clicks into the omnibox and types before mouse-up, the characters typed before mouse-up can get deleted by subsequent chars due to the select-all behavior upon mouse-up. This detects the mouse-down state while typing and immediately executes select-all so existing characters are removed but none after mouse-down. Bug: 1063161 Change-Id: I3c31d19ce9a7efe129bf95729935634280ee6a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112758Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jesse Mohrland <jessem@microsoft.com> Auto-Submit: Jesse Mohrland <jessem@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753459}
-
David Maunder authored
NonCriticalPersistedTabData. NonCriticalPersistedTabData is for metadata to build new features where the data needs to be persisted across restarts. However, the metadata is not pertinent to the running of the app as CriticalPersistedTabData (tab id, web contents etc.) is. Bug: 1048712 Change-Id: Ibcaa202322746d69065546fc3f7ea1d66b443ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036656Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753458}
-
Gyuyoung Kim authored
This CL moves flex-column-relayout-assert.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, a description of this test, and a title. Bug: 1063749 Change-Id: Ic68aa0b7f4b254ce10f178897a23f0b6171dd788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119460Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#753457}
-
Gabriel Charette authored
This is a prequisite for more additions to ScopedBlockingCall's internal namespace for the IO jank metric. It was getting too big and polluting the header. Extracting an _internal.h header is the common paradigm to work around this. R=fdoray@chromium.org, olivierli@google.com Bug: 1064645 Change-Id: I0b3c49222026d2d98db77eb6075efcf17d9f33e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102588 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753456}
-
Lei Zhang authored
Put the PDFExtensionTest cases that run JS into the PDFExtensionJSTest subclass. Put the service work JS tests into the PDFExtensionServiceWorkerJSTest subclass. Change-Id: Id9bee94508965218cb99c0cd44c75ebddaee638d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119202Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753455}
-
Simon Que authored
These are builders that were migrated from json to Chromium recipe configs, e.g. crrev.com/c/2071293, before Week 1b could be relanded. This group of builders is to migrate those builders separately: - ios-simulator-cr-recipe (inactive since Nov 2019) - ios-simulator-cronet - ios-webkit-tot - ios13-sdk-device Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: I5bea944d63154048b5b5c951336f9d76befd2e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119892Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#753454}
-
danakj authored
The content/test/ dir depends on these but doesn't use them. R=nasko@chromium.org Bug: 866140 Change-Id: I9c42f1cfaf386cbbf41f74a69800cbd9bbb54e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118178 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#753453}
-
Reilly Grant authored
This reverts commit cc673fd0. Reason for revert: Unable to reproduce test flakiness. Original change's description: > Disable WebBluetoothTest.WebBluetoothAfterCrash > > See details in: > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw > > TBR=reillyg@chromium.org > > Bug: 1022321 > Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191 > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Commit-Queue: Hongchan Choi <hongchan@chromium.org> > Auto-Submit: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713544} Bug: 1022321 Change-Id: I8bc50f7c4328cf4da82e6e4230a4a9b1fe1365cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121347Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753452}
-
dpapad authored
Bug: 1026426 Change-Id: I16c53dc810993f9cd1684ee735f5738a8aa91734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119795 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Gabriel Charette authored
|task_is_worker_task| was hard to read as it identified what |task| would become but that variable doesn't exist when BeforeRunTask() is invoked. The answer from BeforeRunTask() is more accurately "should_run_tasks". R=etiennep@chromium.org Change-Id: I9c581c5d4b477dbe06d8c2ecab9f844f649674ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105958 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753450}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If098b90259f38cbe5abf87053e10fa1720779538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753449}
-
Mark Brand authored
Visibility of media/learning/common:interfaces will need to include new generated targets for the MojoLPM fuzzer. See https://chromium-review.googlesource.com/c/chromium/src/+/2115512. Since there shouldn't be anything other than generated targets under media/learning/mojo/public/mojom, adding a blanket whitelist. Change-Id: I64f2aca281fed37e4ecfdfcf901a73860e85c9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120413 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Mark Brand <markbrand@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#753448}
-
Dale Curtis authored
There are cases where we may get multiple canplaythrough events, we need to ensure that ones beyond the first don't trigger crashes. Bug: 1064635 Change-Id: I93ab49a5060e2dbbb39791e2e2193d47b6dd3959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119643 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753447}
-
Haiyang Pan authored
The test FeedNewTabPageTest#testFeedDisabledByPolicy keeps crashing since https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/860 Bug: 1064388 Change-Id: I9885ed704254197cc024857f41e8bd8930656b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121357 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c3eb703583e..34f71abca1a1 git log 4c3eb703583e..34f71abca1a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 ehmaldonado@google.com git-cache: Also bootstrap in the case that there are 0 pack files 2020-03-25 ehmaldonado@google.com depot_tools: Split gclient_smoketests. Created with: gclient setdep -r src/third_party/depot_tools@34f71abca1a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I148867c14f8012a22fa94f87618f38adb85766ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121224Reviewed-by:
-
Tom Anderson authored
R=pkasting Bug: 1056950 Change-Id: Ibf068118a6f6b1710be4d291884f5c227206f460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121495 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#753444}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bccb5f3b3896..71cb6fda55ac git log bccb5f3b3896..71cb6fda55ac --date=short --first-parent --format='%ad %ae %s' 2020-03-25 robertphillips@google.com Initialize all the SkYUVAIndex fields in the wacky_yuv_formats GM Created with: gclient setdep -r src/third_party/skia@71cb6fda55ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5631e6aedec7de06ad76f5841d07abc8fc07ce66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121226Reviewed-by:
-
Curtis McMullan authored
This commit disables resize for the virtual keyboard. BUG=1019990 Change-Id: Ifc602df0e41885518ac8f5e54fd1ea604e24c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120674Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#753442}
-
Becca Hughes authored
This adds the feed items to the WebUI. You can select a feed to show the content. BUG=1058187 Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#753441}
-
Caleb Rouleau authored
It's best to have multiple owners in the event of OOO, so I have nominated John as an additional owner of load_library_perf_tests and Frank as an additional owner of media_perftests. Owners are responsible for understanding how these tests are important for the product. They do not need to understand how the tests are run or how the infrastructure works. I am leaving Google. TBR=johnchen@chromium.org Change-Id: Id217cf0364285f6d09a4e8eba25ea61789ab08fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121034Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#753440}
-
- 25 Mar, 2020 20 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/94584718d2c2..3ca8bc5a4a86 git log 94584718d2c2..3ca8bc5a4a86 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kahinds@microsoft.com Ignore theme stylesheet application in high contrast mode 2020-03-25 brgoddar@microsoft.com Screencast: Add accessible text for the Screencast Nav Bar Controls Created with: gclient setdep -r src/third_party/devtools-frontend/src@3ca8bc5a4a86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1048378,chromium:1064733 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie89abcd2e3ccf5b94bc6e09e73ea3a427949c275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121223Reviewed-by:
-
Jeff Yoon authored
This reverts commit f039e78b. Reason for revert: The wrong bot was migrated here. Original change's description: > [ios] ios-simulator-cronet tryjob src side Chromium config > > ios-simulator-cronet under chromium.fyi has already been migrated. > Missed migrating the trybot with it. > > Bug: 1055164,912681 > Change-Id: Ia58340308ba719dc6f39cf65ab40f73c4c89929b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120051 > Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753391} TBR=agable@chromium.org,jbudorick@chromium.org,jeffyoon@chromium.org Change-Id: I09d5cfeab541bbaf6f7d1b8382e273e5d621601b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1055164, 912681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121420Reviewed-by:
-
Haiyang Pan authored
The following tests starts failing consistently since the build https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-fyi-rel/838 Bug: 1064367 Change-Id: Ibfae8da42da2cbdc44fb8e70ada0f50ee8cd3b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119386 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753437}
-
Kenichi Ishibashi authored
This CL temporary adds some CHECK to make sure that a ServiceWorkerVersion doesn't have any controllees when it becomes redundant. These CHECKs will be removed once we identified the cause of some crashes. This CL also add DEBUG_ALIAS_FOR_CSTR in ServiceWorkerVersion::AddControllee() to put how a ServiceWorkerVersion became redundant on the stack so that we can retrieve the information from reports. Bug: 1021718 Change-Id: I5c62e475d85aa327852b72d577faf8c5ccafb53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114478Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753436}
-
Gayane Petrosyan authored
Add downloaded file to completed dowwnloads for pre-Q versions and add to MediaStore.Downloads for Q+ versions. Bug: 993920 Change-Id: I9c4f88c218276ca59a2e1ebf14603af2e080eca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106672 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753435}
-
Livvie Lin authored
Bug: 1061576 Change-Id: Ie3c6fcf924e8e08282fd710ccb69f5551fe4c1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120454 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
extensions/browser/api/declarative_net_request:declarative_net_request depends on extensions/browser:browser_sources. However some sources in extensions/browser:browser_sources also depend on extensions/browser/api/declarative_net_request:declarative_net_request causing a cyclic dependency. This dependency is necessary since DNR needs to hook into the installation flow. This dependency is not declared which can cause problems (e.g. configs won't be propagated correctly). Fix this by creating a new leaf target on which both extensions/browser/api/declarative_net_request:declarative_net_request and extensions/browser:browser_sources can depend on. BUG=1064163 Change-Id: I536567bb1c3ca03117bd779fd205fb49b1af4849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117450 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753433}
-
Oriol Brufau authored
r708735 made the language list scroll to the very top when typing in it, to avoid the effect of getting momentarily stuck while scrolling up. However, this prevented users from scrolling with the PageDown or PageUp keys. So this patch excludes them. Fixed: 1064190 Change-Id: Iba3a134444ccae7afa31076666e6cbcc3d932c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121255Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#753432}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/54f9ec739967..d6f84edeb857 git log 54f9ec739967..d6f84edeb857 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 wuwang@chromium.org Fix a flag, and call InitDependencyManager before call FetchPath. Created with: gclient setdep -r src/third_party/catapult@d6f84edeb857 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: skyostil@google.com Change-Id: Iefd7062d717c54f65eec29aac3e7e954c690750a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121220Reviewed-by:
-
danakj authored
R=avi@chromium.org Change-Id: I82773ba75a97887d57ccbbb21b54c45193da0729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121082Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#753430}
-
Thomas Anderson authored
This reverts commit 838eb034. Reason for revert: Build failure on android-archive-rel: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/10360 Original change's description: > VulkanImage: support create from GpuMemoryBufferHandle on Android > > VulkanImage::CreateFromGpuMemoryBufferHandle() is added to replace > VulkanImplementation::CreateVkImageAndImportAHB(), and will replace > VulkanImplementation::CreateImageFromGpuMemoryHandle() as well. > > Bug: None > Change-Id: I7c6e3cea685f1ec305790f4a6d7bb66164f26e55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114587 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753394} TBR=penghuang@chromium.org,rjkroege@chromium.org,vasilyt@chromium.org Change-Id: I08dcc519da5e693fc08e0323036dc691b6eaff7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121418Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#753429}
-
Peter Williamson authored
This reverts commit 781b45f9. Reason for revert: It seems that the experiment name needs to match the flag name, so we'll revert the experiment name change, and instead change the experiment name that we use on the Finch side. Original change's description: > Rename experiment to FeedSendFeedback. > > The experiment name needs to match finch instead of matching the > name of the flag we use in chromium. > > Bug: 1045246 > Change-Id: Ie64379eb275d3a0c51c9d3237d9e12602003cc8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117914 > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753222} TBR=petewil@chromium.org,asvitkine@chromium.org,harringtond@chromium.org Change-Id: I37cb062deda3f30f457300a9b7bf4437c75475af No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121496Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#753428}
-
Peter Kasting authored
A number of different tests want this, so provide it all the time. Bug: none Change-Id: I04b49b955621594b47ab74305c98abeb206532c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121335 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753427}
-
Nicolas Arciniega authored
Doing this cleans up an undesirable ConfiguredProxyResolutionService usage pattern where code that primarily works with a ProxyResolutionService must currently cast to the specialized class before setting the right PAC quick check value. Bug: 1032820 Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#753426}
-
Shimi Zhang authored
Pointing the related code to the newly added doc. Bug: 1063189 Test: No logic change. Change-Id: I5fa3bdebe521b49a8f32241e4406ac9c072ec302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107569Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#753425}
-
Devlin Cronin authored
Typically, extension parsing errors should not be localized (for a number of reasons), but icon validation errors were. Change them to be simple strings, and also link to the manifest key where the icons were specified. Bug: None Change-Id: I89cd43b4cc895559a55f346b27399029fe116f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081015 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#753424}
-
Trent Begin authored
The parameter name passed to the DoSomethingAndReply example function does not match the name of the callback given to PostTask. Bug: none Change-Id: I7899a22880adb0ea98f717e6415a3ce562853ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121349 Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c4c61eeb38f..bccb5f3b3896 git log 5c4c61eeb38f..bccb5f3b3896 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 csmartdalton@google.com Add a simple FPS meter to CanvasKit viewer 2020-03-25 brianosman@google.com SPIRV: Track function signatures by SpvId(s), rather than display name Created with: gclient setdep -r src/third_party/skia@bccb5f3b3896 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I55ac3e7f950e00fc3cedf71c6a2020c8efb1058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121219Reviewed-by:
-
Mitsuru Oshima authored
This is a follow-up CL for crrev.com/c/2104457. Bug: 1057024 Test: covered by unittest Change-Id: I0733a19c08deeec2ca43f5930c3c185451fe39ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113911Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#753421}
-
Becca Hughes authored
Factor out the media data table. BUG=1059352 Change-Id: I1ffc498d270491eeb3a433de1e7e6c3fc722e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116783Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
