- 13 Aug, 2020 40 commits
-
-
Miguel Casas authored
crrev.com/c/2340365 recently landed a DCHECK() in VaapiWrapper ctor, but erroneously used |decoder_task_runner| ISO |decoder_task_runner_|. This CL fixes that. Bug: b:162962069 Change-Id: I374a42b61ca9c182915baab909006a70991df6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354590 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#797743}
-
Yann Dago authored
This reverts commit 70cab0ca. Reason for revert: setup_install_details_unittest.cc compilation error Original change's description: > Handle "--channel" switch in chrome setup to allow channel switching > > In order to support channel switching on the main installation of > the browser, A switch flag "--channel" that specifies which channel of > the browser is about to be installed is added to the setup's command > line. This flag will be used to store the right channel value in the > registry so the browser knows which channel is running. > The supported values are {stable|dev|beta}. This new switch will be > ignored for if any of "--chrome-beta", "--chrome-dev" and "--chrome-sxs" > is found in the command line. > > Bug: 1102927 > Change-Id: Ib7bd622e906f8f4af067307c90d0caffc73afc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2172210 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797688} TBR=grt@chromium.org,ydago@chromium.org Change-Id: I383a82cedfa209a1570cc3743982e87cc2818702 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354673Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#797742}
-
adoneria authored
Bug: 1109373 Change-Id: Id5b4251253c97884384ed4bdf4d10b38a5bd4d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353553Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#797741}
-
Takumi Fujimoto authored
Has been flaky on linux-chromeos-chrome. TBR=achuith@chromium.org Bug: 1116058 Change-Id: Id1f75d2118efac23db9ed07fa6957ebb6d34f649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354227Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#797740}
-
Kramer Ge authored
In tab dragging, when dragged window snaps to a tab strip, the corresponding WaylandWindow is destroyed. The corresponding buffer queue in gpu process is expected to be destroyed soon, so omit upcoming overlay commits should be safe. Change-Id: I38923f461e9c1eb3ac63d72237989194b2f887d5 Bug: 1114767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353554Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#797739}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic3c997f2166da4668308a2d0a242fd79bf787e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797738}
-
Charlie Hu authored
|layout_size| behaves differently depending on platform: - Win/Linux: |layout_size| already factors in device pixel ratio. - Mac: |layout_size| does not factor in device pixel ratio. This CL solves this platform difference for oversized images policy downscale ratio calculation. Web test document-policy-oversized-images-edge-cases.html is modified to verify that the fix works. Bug: 1112784 Change-Id: Ie21445bcc63d1b0624e305e14720a8f3a835fe99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316621 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#797737}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008130800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/fX1CZHk_Z55AAvLsAiH1mQ6Dr6f33Mf7P1iCopozfbEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159964708 Tbr: help-app@grotations.appspotmail.com Change-Id: Ib773515ba26f737d1359d535daff0affcb756262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797736}
-
Kyle Horimoto authored
Bug: 1106937 Change-Id: If91dfd2c87abee709d61176f36a8751c0062fd70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353526 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797735}
-
Justin Cohen authored
Bug: 11160121 Change-Id: I8f09af4ca2310d68f296eab1a4ccee1e8329880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354410 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#797734}
-
Alexander Alekseev authored
This Cl permanently exposes HUD controls and adds tabbed controls as a preparation to adding more data. Tabbed UI: https://screenshot.googleplex.com/uQSuqEps8s8.png - First tab active. https://screenshot.googleplex.com/YdMcrG74OiP.png - Second tab active. https://screenshot.googleplex.com/7t5ZSVU2fWB.png - Third tab active. https://screenshot.googleplex.com/MtoB750fA4C.png - Settings UI. Bug: 1075612 Change-Id: Ic5101f302b071e060ab54de6f8fb6b510e0250ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348337 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#797733}
-
Lan Wei authored
AddressViewControllerTestCase/ testAddressesViewControllerContainsManageAddressesAction fails on ios-simulator-full-configs, https://ci.chromium.org/p/chromium/builders/ci/ ios-simulator-full-configs/b8872074450009779120 disable it for now until it is fixed. TBR= javierrobles@chromium.org Bug: 1116043 Change-Id: I76372c15e5031b4c4d8d5a1681eb0dfc1f041e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354413Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797732}
-
Guillaume Jenkins authored
Adds two new experimental settings to help manual testing of CBCM on iOS: 1) EnableChromeBrowserCloudManagement to force enable CBCM infra 2) CloudManagementEnrollmentToken to provide an enrollment token This change also creates a new "Enterprise Settings" section in the experimental settings, since there are now three Enterprise-related experimental settings. Bug: 1066495 Change-Id: I8b88c408c5866cb130373712af6201269be39c36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353394 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797731}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bca9dcdf05aa..35492ebf6ba2 2020-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-13 bpastene@chromium.org deploy_chrome: Deprecate '--to' and replace it with '--device'. 2020-08-13 sidereal@google.com packages: Allow for stable and unstable ebuilds in VM uprev handlers 2020-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-13 yupingso@chromium.org cros flash-ap: Add puff configs 2020-08-12 cjmcdonald@chromium.org cbuildbot: Disable 'separatedebug' in all stages 2020-08-12 kevinruvalcaba@google.com Added script to extract data for the DepVisualizer class 2020-08-12 kevinruvalcaba@google.com Corrected design of the DepVisualizer class 2020-08-12 mikenichols@chromium.org chromeos_config: Remove references to Release and CQ 2020-08-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-12 erikchen@chromium.org Fix a bug in deploy_chrome.py where ui is not started. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib3ccea537512ae5cc35cf03652aa405c6d8b231c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354469Reviewed-by:
-
Mason Freed authored
See [1] for context. This CL adds the shadowRoot attribute to ElementInternals, which allows custom elements to access their own shadow roots, including in the case that the shadowRoot is closed. Without this capability, custom elements that use closed declarative shadow roots would have no ability to retrieve the contents of their own shadow root. Bug: 1042130 [1] https://github.com/w3c/webcomponents/issues/871#issuecomment-672082936 Change-Id: I33606144bec3c27600d2e67f108d0344f7696dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350739 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797729}
-
Robert Sesek authored
Bug: 1116003 Change-Id: I00455a78b94ac614ee5015a2be68f8c8bc5e855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354152Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797728}
-
Adithya Srinivasan authored
Currently, we reset the DevTools session before portal activation and create a new session with the activated portal's WebContents. We dispatch the portalactivate event and run any event handlers in the interim while there are no agents active, and as a result, existing breakpoints do not work. This CL waits for DevTools to point at the portal WebContents before actually swapping the WebContents, thus making sure that the portalactivate is dispatched after the main target has been reattached. Bug: 1025761 Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#797727}
-
Marc Treib authored
This CL adds the recording logic for AccountPasswordsConsent to the SigninReauthUI. This requires: * Collecting the relevant strings in JS and sending them back to C++. * Maintaining a mapping between strings and GRD IDs in C++, to convert the strings from JS back into IDs. * Putting the IDs into a AccountPasswordsConsent proto and sending that to the ConsentAuditor. Bug: 1111252 Change-Id: Ic06533fdb361b415398923b12fbc3c289a47e989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352789 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797726}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b19e07ebf92c..78d7b4b8250e 2020-08-13 treehugger-gerrit@google.com Merge "[RELAND] tp: move thread state implementation to trace processor" 2020-08-13 fmayer@google.com Remove deobfuscation from HeapGraphTracker. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:159987908 Tbr: perfetto-bugs@google.com Change-Id: Ibf5ef6ffee3e187de9585a518938fae7faf83f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354471Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/31e5a5d45d5d..07ae53f59079 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from b60e067b4374 to d253278f9865 (1 revision) 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 13a65b1aee42 to df859f77dab3 (7 revisions) 2020-08-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e930c45863c6 to 6b0de7007af5 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibd4343c141db9c3619c203add09b83875f3d8928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354222Reviewed-by:
-
Rouslan Solomakhin authored
TBR=harringtond@chromium.org Bug: 1115137 Change-Id: I212b3279f81948a0964de8985d8c9ccea1fa4e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354416Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797723}
-
chrome://managementTina Wang authored
- Add enterprise icon to the page. - Adjust text color, font size and line height. Bug: 1108981 Change-Id: Iefac85146019f3a4b5a60fcc8812340cae5ddfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352526Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797722}
-
Yicheng Li authored
In the in-session auth dialog, show PIN view only if PIN is set, and show fingerprint view only if fingerprint is set. icon are not shown. Delete PIN, verify that PIN pad is not shown. Bug: b:156258540 Test: On Nami, delete fingerprint, verify that fingerprint prompt and Change-Id: I55604aeb9e66f04a2f49ffbb5e5160b6158a40d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351120 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797721}
-
Andrew Grieve authored
This reverts commit 5e31951c. Reason for revert: Broke monochrome_apk_checker on android-pie-arm64-rel Original change's description: > Restore CQ coverage for proguard, errorprone and lint > > * Removes these from android-pie-arm64-rel (currently offline). > * Adds proguard to android-marshmallow-arm64-rel > * Adds errorprone & lint to android-lollipop-arm-rel > > Spread across two different bots to share the load. > > Bug: 1111436 > Change-Id: Ieac924ccae06aa4bc01b52bf795d1a174616a799 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342575 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796688} TBR=agrieve@chromium.org,bpastene@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111436, 1115164 Change-Id: I81ee42d31410176e157be2edced7b5eb4fb25025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354449Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797720}
-
Mohamed Heikal authored
It is usually not clear what exactly is failing when this script fails. This CL improves the error messages to be verbose about the problem. Change-Id: I1fa6f41520cfac8cdc4180f66d84d4dcff5e48b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354512 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Bug: 1038002 Change-Id: Ib53fe65d5a36af3146ad1f0c61cefbe9afcd8dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354151 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#797718}
-
Yicheng Li authored
The fingerprint view consists of a fingerprint icon and a prompt text. A follow-up CL will enable/disable the fingerprint view based on whether fingerprint is set and available. Bug: b:156258540 Change-Id: I602a4d63abadeab735cae0bd6da27c50b2ef27d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350999Reviewed-by:
-
Sammie Quon authored
It's no longer hooked up to anything, also shuffle some features to make alphabetical. Test: compiles Bug: 903486 Change-Id: I0326a069f00dcf0cc9fa557feb672e4610d36650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352218Reviewed-by:
-
Marijn Kruisselbrink authored
1) Adds a UserAction for drag&drop so read access can be auto-granted for directories when dropping. Without this websites would have to explicitly request access after dropping a directory. 2) Adds a CanRequestReadPermission method that lets us block file dialogs if read permission would be denied anyway. Currently read access can't be denied yet, but enterprise policy might change that, so we should at least deal with it properly. Bug: 1053363, 1080811 Change-Id: I2a03c6d1c7d804de2eadc84a7aa13a0515d3d5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353193Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797715}
-
sczs authored
Bug: 1085419 Change-Id: I1bcc74618fa1f0716643f0979ac1f27a7b2d627c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352429 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#797714}
-
harrisonsean authored
Add remaining icon assets needed for safety check Apply the new and existing icon assets to safety check Bug: 1078782 Change-Id: I769bd3903edd31288da4a1e77b09a0d6e50775c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350420Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#797713}
-
Andrew Grieve authored
When they are not marked as outputs, incremental builds will not know that they are stale when failure files have been cleared. Bug: 1115118 Change-Id: I529a5d7d536903a01d94682bb4db92cc6d9a5e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348421Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#797712}
-
Caitlin Fischer authored
The test was re-enabled in crrev/c/crrev/c/2350231; however, fixing the original error uncovered an additional one: [FATAL:network_context.mojom.cc(9680)] Check failed: !connected. \ NetworkContext::ClearHttpCacheCallback was destroyed without first \ either being run or its corresponding binding being closed. It is an \ error to drop response callbacks which still correspond to an open \ interface pipe. Bug: 1096047 Change-Id: Ia4702463ab41fba49827baa93b9f15b74af21125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354290 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Danila Kuzmin authored
Bug: 1108862 Change-Id: If36f057d4724f10f41558affe3900aee0d65a89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322827 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797710}
-
Yuke Liao authored
A few test suites are stable, remove the experimental label so that they're watched by sheriffs to prevent regressions. Bug: 1111979 Change-Id: I5076314717607fef7768d466ad24c79c487ae280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351385Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797709}
-
Chris Harrelson authored
Remove PaintHolding to make room, since the file was too big for Windows command-lines otherwise. Bug: 1115577 Change-Id: Ib2dda288cce960a1c0c43eda99487327004f4fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353707Reviewed-by:
-
Caitlin Fischer authored
The test case is AddSyncedUserBirthYearAndGenderToProtoData, and it's being re-enabled on Android. Bug: 1102746 Change-Id: Ie02597dc1704ba0d5efb13eb297f7e87ef0865d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329920 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Karel Král authored
Implement initializer list support for creating arrays and dictionaries in TracedValue::Build. Thus speed up adding debugging tracing of multiple parameters, including container types. Follow-up of: crrev.com/c/2263160 Bug: 1043616 Change-Id: I2d3205d550e6ce6328ea253e6b94f9cc2cbe3098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346286Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#797706}
-
Lambros Lambrou authored
This CL fixes the host process so that the client can successfully select a different codec after SDP offer/answer exchange is restarted during an active connection. This comes in 2 parts: 1. The current encoder in WebrtcVideoStream is reset, so that captured frames are routed to the new encoder. 2. The WebrtcVideoEncoderSelector logic is slightly tweaked so that a call to SetPreferredCodec() resets the cycle of encoders returned by repeated calls to CreateEncoder(). This is done so that the correct encoder is returned after WebrtcVideoStream changes the preferred codec. This tweak does not break any existing unittests. This CL fixes crashes which occur when the host tries to use a different encoder than what WebRTC created via the WebrtcDummyVideoEncoderFactory class. These crashes can only be triggered when SDP (or ICE) is restarted via the recently-implemented control messages, which are not supported in older versions of the host. Bug: 1113499 Change-Id: Idd1e388252c4359e1edc62ac4a51d71be0ae77cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353672 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#797705}
-
Victor Hugo Vianna Silva authored
Assertions made by MultiStorePasswordUiEntry/MultiStoreExceptionEntry when merging two entries [1] are failing in some cases. This causes an exception to be thrown when the list of saved passwords is being updated, which in turn results in some passwords not being shown. In this CL, we treat merge failures more gracefully, namely: - Instead of assertions, we now have merge() return whether it succeeded. - The constructor of the multi-store entries can now only have 1 argument since we can't "return a failure" when calling the constructor. - When a merge fails, we just create separate items in the UI for the entries we were trying to merge. - We rename merge() to mergeInPlace() to make its side-effect clearer. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/resources/settings/autofill_page/multi_store_password_ui_entry.js;l=51 Bug: 1114697 Change-Id: I588af43cba874510b4d685a42434aa988c90b189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351911Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#797704}
-
