GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7491c965b291..b628aaf43bd1


Created with:
  gclient setdep -r src-internal@b628aaf43bd1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I53eb6e965983951077133fb96ac168a7cbf43b33
Reviewed-on: https://chromium-review.googlesource.com/c/1326742Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606531}

In TouchActionFilterTest, there is a function named ScrollingTouchAction,
and this CL changes the name to ActiveTouchAction. It is called
ScrollingTouchAction because the corresponding variable in the
TouchActionFilter was named |scrolling_touch_action_|. Now that this
variable is renamed to |active_touch_action_|, we should change the
function name to ActiveTouchAction.

Bug: None
Change-Id: I34d51bba4b5604dbeab743f3ce6f6a27d315c7e9
Reviewed-on: https://chromium-review.googlesource.com/c/1323622Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606530}

- Properly suffixes BigInt constants with 'n'
- Fixes stringification of constants into valid .js syntax
- Improve default values handling in structs which was only partially
  implemented previously

Bug: 883496
Change-Id: Id270d2f34dd40fa970d58448c1002c691db35a87
Reviewed-on: https://chromium-review.googlesource.com/c/1321577
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606529}

SVGTextLayoutEngineSpacing checking if the current and last characters
were non-nuls before attempting to apply word-spacing. This would mean
that we'd never add word-spacing at the beginning of a text box.
Remove the checks for non-nuls.

Bug: 902839
Change-Id: I751e1bd1317f7411960d137b7e55a3b83e8cb0df
Reviewed-on: https://chromium-review.googlesource.com/c/1326156Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#606528}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib2089db12d37b7da709909dd797a695a2f1e8a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1324872Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606527}

Bug: 714231
Change-Id: I441067d621effc11fbd8d497716d6693e7bb5971
Reviewed-on: https://chromium-review.googlesource.com/c/1320200
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#606526}

This is a reland of b43c6fca

Cannot reproduce the failures locally, nor in CQ.

Try to reland the same CL to see if it was a flake.

Original change's description:
> Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
>
> This patch allows computing NGOffsetMapping for legacy inline
> formatting context.
>
> For an experimental project "Invisible DOM"[1][2] to support
> the find-in-page feature, it is needed to compute the text
> content with whitespace collapsing applied, along with the
> mapping to the DOM offset. This patch adds an API to compute
> NGOffsetMapping even when the LayoutBlockFlow is not laid out
> by LayoutNG for that purpose.
>
> Note that the project is still in the early phase. We may
> revisit the design as it moves forward.
>
> [1] https://github.com/rakina/searchable-invisible-dom
> [2] https://www.chromestatus.com/feature/5105291213406208
>
> Bug: 636993, 873057
> Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
> Reviewed-on: https://chromium-review.googlesource.com/c/1322184
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606292}

TBR=yoshin@chromium.org, eae@chromium.org

Bug: 636993, 873057
Change-Id: I241c6e9163add4000fa078c5d70a62b89acea9ac
Reviewed-on: https://chromium-review.googlesource.com/c/1326343Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606525}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=morlovich@chromium.org

Bug: 766678
Change-Id: Ibbaf0d854d2c8fb08b515e3fe8a3c7614630ab62
Reviewed-on: https://chromium-review.googlesource.com/c/1325203Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606524}

https://skia.googlesource.com/skia.git/+log/6d1df6d9c128..1379508a3a57


git log 6d1df6d9c128..1379508a3a57 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 caryclark@skia.org some pathops fuzz fixes
2018-11-08 caryclark@skia.org Check every word in docs


Created with:
  gclient setdep -r src/third_party/skia@1379508a3a57

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: I499f2e5b16e8a6f58c10e4b1f1964324aed6f8c1
Reviewed-on: https://chromium-review.googlesource.com/c/1326328Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606523}

The 'dlog' SSH channel appears to trigger a bug that causes the package-
upload step to fail on ARM64 under QEMU.

Bug: 900790
Change-Id: Ie5871cef98e94deb936ae591c87a5c90a960b092
Reviewed-on: https://chromium-review.googlesource.com/c/1325529Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606522}

This was causing extensions_unittests to fail under UBSan, see bug.

Bug: 903339
Change-Id: Ie7d80297d85668e3ba72d0c92467bcf6975fce19
Reviewed-on: https://chromium-review.googlesource.com/c/1326508
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606521}

A bluetooth enum was putting some common names like "SUCCESS",
"UNKNOWN" and "FAILED" in the content namespace. A recent
clang (I think) added new warnings when these got
got shadowed by other uses of the names. See full error below.

This enum was always intended to be in an enum class judging from
how it's used, so just use enum class to avoid further clashes.

This primarily affected jumbo builds but could happen to any build
which happened to include two conflicting headers in the same file.

../../content/browser/histogram_synchronizer.h:54:5: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
    UNKNOWN,
    ^
../../content/browser/bluetooth/bluetooth_metrics.h:228:3: note: previous declaration is here
  UNKNOWN = 5,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:170:
In file included from ./../../content/browser/devtools/devtools_instrumentation.cc:16:
../../content/browser/frame_host/navigation_request.h:68:5: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
    FAILED,
    ^
../../content/browser/bluetooth/bluetooth_metrics.h:229:3: note: previous declaration is here
  FAILED = 6,
  ^
In file included from gen/content/browser/browser_jumbo_1.cc:247:
In file included from ./../../content/browser/download/drag_download_file.cc:5:
../../content/browser/download/drag_download_file.h:53:37: error: declaration shadows a variable in namespace 'content' [-Werror,-Wshadow]
  enum State {INITIALIZED, STARTED, SUCCESS, FAILURE};
                                    ^
../../content/browser/bluetooth/bluetooth_metrics.h:223:3: note: previous declaration is here
  SUCCESS = 0,
  ^

TBR=jyasskin@chromium.org

Change-Id: I2f35c1c11262e4f071cf1d64348c9bc30c76351b
Reviewed-on: https://chromium-review.googlesource.com/c/1326507Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606520}

This enables VaapiVEA to encode DMABuf-backed video frame. Because the
va surface format is NV12, NV12 format is only acceptable.
This change is tested by crrev.com/c/1295636

BUG=chromium:895230
TEST=VEA unittest --native_input

Change-Id: Ib3c09363936cdf3099bb9ed9fc14eb24bd0e70fe
Reviewed-on: https://chromium-review.googlesource.com/c/1306944
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606519}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I0738957fbcdb63da03152d852cf20e02603f7924
Reviewed-on: https://chromium-review.googlesource.com/c/1325429
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606518}

aura::client::kResizeHandleInset was added in 779ce514
but until now, never actually applied. This should fix the linked bug
(for Mash at least) as well as standard browser windows and frameful
app windows.

Bug: 891068
Change-Id: Iedd512bafd9f0ef7f0ecce05afcf942defba8249
Reviewed-on: https://chromium-review.googlesource.com/c/1325289Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606517}

This is now unused.

R=tbarzic@chromium.org
TBR=droger@chromium.org

TBRing David for the removal of EnsureAPIBrowserContextKeyedServiceFactoriesBuilt() from chrome_browser_main_extra_parts_profiles.cc.

Bug: 899324
Test: none
Change-Id: Ife19019fd8b05dfcd627e92167f485e96401662b
Reviewed-on: https://chromium-review.googlesource.com/c/1319340Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606516}

Change-Id: Ib28560cfbb9c550770da138236a9af8fa9152f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1325560
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606515}

This change removes //chrome/installer/mac/app. This directory contained a
cancelled project from 2016 to build a standalone installer and has never been
shipped. Since its tests are broken on 10.14, we can just delete it rather than
fixing those.

Bug: 892172
Change-Id: Ib3d9e9c072a12e66cb7863a3e40eed8a13e948d6
Reviewed-on: https://chromium-review.googlesource.com/c/1315954Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606514}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=sergeyu@chromium.org

Bug: 766678
Change-Id: I769a4567e23b45976732ec447889eeb683faf68b
Reviewed-on: https://chromium-review.googlesource.com/c/1324917Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606513}

Right now the lifetime of AwGLFunctor (and that of associated objects)
roughly matches the lifetime of AwContents. This is not necessary, and
we only need to ensure it's alive when functor is in use. This better
matches the APIthat the vulkan functor will have. It also has the up
side of converting CleanupReference usage to explicit destroy, which
is always nice.

Bug: 901554
Change-Id: Ib1126d1ddfeacc7b8c689aeb51bb897cf839b41c
Reviewed-on: https://chromium-review.googlesource.com/c/1320749Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606512}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/82a57102..f69f7d51

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8ff74522b8c79c1cc0ee950c93ab80903425f9ef
Reviewed-on: https://chromium-review.googlesource.com/c/1326622Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606511}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Idc3b7e4bb138d0c81066f6e32af97bd67979e8c4
Reviewed-on: https://chromium-review.googlesource.com/c/1325349
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606510}

If you include both net/ftp/ftp_directory_listing_parser.h and
net/quic/quic_chromium_client_session.h you get an error
about an UNKNOWN shadowing another UNKNOWN. I don't think this
is a new problem but something we got with a new clang version.

This renames the net::UNKNOWN to net::UNKNOWN_CAUSE so that
net::FtpDirectoryListingEntry::UNKNOWN and other unknown
UNKNOWNs can stay.

net/ftp/ftp_directory_listing_parser.h:21:5: error: declaration shadows a variable in namespace 'net' [-Werror,-Wshadow]
    UNKNOWN,
    ^
net/quic/quic_chromium_client_session.h:83:3: note: previous declaration is here
  UNKNOWN,
  ^
1 error generated.

TBR=zhongyi@chromium.org

Change-Id: I96c6c8ba3b923a691537debbfe468874c767b939
Reviewed-on: https://chromium-review.googlesource.com/c/1326494Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#606509}

Feature was enabled by default in M64. Flag isn't required anymore.

Bug: 310450
Change-Id: I5e6bd409ad9fc874cd2e9401e10707be9af1e6a8
Reviewed-on: https://chromium-review.googlesource.com/c/1324136Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606508}

This CL sets the different margins and paddings such that the bottom bar
has a fixed size most of the time.

Change-Id: I2bcd51c0badcb7d09f029fc823f7eb725c167978
Reviewed-on: https://chromium-review.googlesource.com/c/1319671
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606507}

NOPRESUBMIT=true
BUG=898522

Change-Id: I05888104ce8a6651014ee17555d1ed80fcf00615
Reviewed-on: https://chromium-review.googlesource.com/c/1324410
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606506}

Bug: 902517
Change-Id: Ie5121198b9ce41e2d72ea696570b05de0071aafa
Reviewed-on: https://chromium-review.googlesource.com/c/1321156Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606505}

Since the ContainerView size is now dependent on the InfobarView
(The ContainerView autolayout constraints are anchored against the
InfobarView, and we set the containerView to match the InfobarView height),
there's no need to pass the ContainerView frame to layout the InfobarView.

Because of this InfobarContainerVC no longer needs to import InfobarIOS
and its moved to the infobars_ui BUILD.gn source_set.

Bug: 892376
Change-Id: I44ca8c470b0ededbd34fe2f1564c2d651f200317
Reviewed-on: https://chromium-review.googlesource.com/c/1315987Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606504}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/491b15b4a4a0..63924982b3fd


git log 491b15b4a4a0..63924982b3fd --date=short --no-merges --format='%ad %ae %s'
2018-11-08 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@63924982b3fd

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9331a75b8d87389b1bfae97f45efc99680f05847
Reviewed-on: https://chromium-review.googlesource.com/c/1326332Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606503}

This just duplicates documentation from
base::subtle::ScopedTimeClockOverrides but I thought it was worth adding
it here, as ScopedMockClockOverride doesn't currently fix any of the
limitations.

Also, because of this limitation we can't use ScopedMockClockOverride as-is
in Blink tests. We create a task scheduler and a thread pool before running
tests on the main thread (and also call TimeTicks::Now from one of the
threads created).

Bug: 866930
Change-Id: If7b081bd980b8ac8780c892c21b082923edd1a29
Reviewed-on: https://chromium-review.googlesource.com/c/1324103Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606502}

Using wpt-import in Chromium 96395f60.
With Chromium commits locally applied on WPT:
270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: If2a09c7a955f8f16123c6a0b791c5ced96b7f5fd
Reviewed-on: https://chromium-review.googlesource.com/c/1326422
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606501}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: Ib749683f19dad9fad2e0917673f319acb8bb3983
Reviewed-on: https://chromium-review.googlesource.com/c/1325310
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606500}

BUG=902032

Change-Id: Ia733b78e28f454420e1a176746451967c5aaebbf
Reviewed-on: https://chromium-review.googlesource.com/c/1321731Reviewed-by: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606499}

Fetches started from non top level frames should begin in a paused
state, even if the permission is granted.

Bug: 903248
Change-Id: Ia8583b23735fa865089979c0159259142225cd30
Reviewed-on: https://chromium-review.googlesource.com/c/1326148Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606498}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowSyncPrimitives in non-test files
 * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=kylechar@chromium.org

Bug: 766678, 902653
Change-Id: I30a5956028c8d7bca56be07433b2b2f31592ae9f
Reviewed-on: https://chromium-review.googlesource.com/c/1324395Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606497}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I500b7249e5d7d87b028c1446cfb28f4d4159f7df
Reviewed-on: https://chromium-review.googlesource.com/c/1325215
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606496}

With this CL in place, --gtest_shuffle no longer breaks on
blink_heap_unittests.

BUG=899757

Change-Id: Ic1524b2c131d5629796c24bfe0d8903878540cae
Reviewed-on: https://chromium-review.googlesource.com/c/1310313Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606495}

While we're here, also use the default (preferred) constructor of
IdentityTestEnvironment. With this, there's no need anymore to create
TokenService, SigninManager, SigninClient, etc manually.

Bug: 859874
Change-Id: I765e0898ac232c70255a19bd05f2d2e694e6639e
Reviewed-on: https://chromium-review.googlesource.com/c/1326506Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606494}

On 10.14, a file selection dialog whose default path doesn't exist will default
back to ~/Documents, which breaks this test. To avoid this issue, have this
test use /private/var, which is always present.

Bug: 892174
Change-Id: I3f50a74566bdc5a3bf4eb14433138e65d1cfe2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1316109Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606493}

Following bot results are included.
11543 11546 11548 11551 11555 11562 11567 11573 11577 11579
11582 11584

15 lines were removed and 4 lines were deflaked by consecutive
results since 11543.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Change-Id: I2bffbfa93bb633b2c99d7f710c08889330d29525
Reviewed-on: https://chromium-review.googlesource.com/c/1322336
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606492}