- 20 Jul, 2020 40 commits
-
-
Alexander Dunaev authored
A recent improvement of memory usage in ozone/x11 clipboard [1] introduced a regression: copying the text stopped working because the standard MIME type for the UTF-8 encoding was not inserted into the map. This CL fixes that. [1] https://crrev.com.com/c/2292396 Change-Id: I5cedb36253a4f2be392e937f62781417eead8ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306252 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789947}
-
Sebastien Marchand authored
This NetworkServiceClient owns a MemoryPressureListener and it's necessary to ensure that this listener gets destructed at shutdown to avoid UAFs in tests (see crbug.com/1081151). Bug: 1081151 Change-Id: Ia72a4fd35e17effe00f71018f032f2bd62118182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293162Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789946}
-
Yann Dago authored
Bug: 1095206 Change-Id: I12d69fa120c1114700e947c4f56e39c0e39c13c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300401Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#789945}
-
Mugdha Lakhani authored
Move prerender_util to components so WebLayer code can eventually use it. Bug: 1057771 Change-Id: I3b608212c12f951ae5b0a79986dd3f19e9432ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235619Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#789944}
-
Maksim Moskvitin authored
This reverts commit 9b0c684e. Reason for revert: likely the culprit for unit_tests failures on multiple builders (see crbug.com/1106339). Original change's description: > Reland "Reland "Turn on Media History by default"" > > This is a reland of c670ba45 > > Original change's description: > > Reland "Turn on Media History by default" > > > > This is a reland of ccf0e2f9 > > > > Fixes TSAN issue in the constructor of sql::Database > > by moving it to the main thread. > > > > Original change's description: > > > Turn on Media History by default > > > > > > BUG=1024351 > > > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#787954} > > > > Bug: 1024351 > > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788312} > > Bug: 1024351 > Change-Id: Ie371d56df987c19a10017050ead02922a530f2ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300224 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788721} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024351 Change-Id: Ie255e6d2b0a88efa130e15019c2d6e5e4049b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306095Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789943}
-
Victor Hugo Vianna Silva authored
Before this CL, no SyncPrefs[1] were sent via the sync-prefs-changed WebUI event if the user was signed-in but had Sync disabled. This CL changes this, relaxing the early exit checks in PushSyncPrefs(). The change is safe because checking IsEngineInitialized() is enough to guarantee the existence of the SyncUserSettings used to fill the JS object. The CL also fixes an aspect overlooked in crrev.com/c/1718425. PushSyncPrefs() had the undocumented side-effect of setting the configuring_sync_ member, which makes no sense when the method is called in HandleSyncPrefsDispatch(). So the assignment is now moved out of PushSyncPrefs() and copied to the other callsites. [1] https://source.chromium.org/chromium/chromium/src/+/9cff09c426fb0436ce35f7c571f555e576534aaf:chrome/browser/resources/settings/people_page/sync_browser_proxy.js;l=94 Bug: 1106350 Change-Id: I9d3167d534957f10dcd878eda918bdd1510c2973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302852Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#789942}
-
Philip Rogers authored
Change-Id: Ifd72366f13def1a12c2f16392ff378c58b23b907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307366 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789941}
-
Jose Dapena Paz authored
For certain cases where a div with RTL direction is set to be LTR, the algorithm for determining if bidi runs should be recalculated and reshaped was not properly ran. This is a regression introduced by https://chromium.googlesource.com/chromium/src/+/25d80f4bead925c2d9071b59a4f32146432d3e9e The solution is merging the two conditions introduced in the original patch (NeedsReshape and NeedsCollectInlines) in one that has been named NeedsReshape. Bug: 1009654, 1104827 Change-Id: I32fceb75f83b9cf2aac3ef982675a96a3ef4d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297432Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#789940}
-
Tina Wang authored
This reverts commit 4977ba83. Reason for revert: Cause tree closure: https://ci.chromium.org/p/chromium/builders/ci/GPU%20Win%20x64%20Builder/16259? Original change's description: > Roll Skia from 3ba1777cebcd to 0c5bb2f776a5 (1 revision) > > https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..0c5bb2f776a5 > > 2020-07-20 robertphillips@google.com Clean up some GrContext in tests > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC robertphillips@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: robertphillips@google.com > Change-Id: Iffb5c6989a63db91bae17759a4db4ce058212eb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307365 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789930} TBR=robertphillips@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I0bd1f105862dc551470c72d009d320e7697568ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307411Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789939}
-
Bartek Nowierski authored
It should've been part of https://crrev.com/c/2306131 Bug: 1092288 Change-Id: I873c8cc804ad15e6970fb00ed0b083c490c10d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307390 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789938}
-
Eric Seckler authored
Bug: 1105001 Change-Id: Ifbd9d8c16d7cf9f9571125207e9543d9f3705e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304749 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789937}
-
Francois Doray authored
This feature no longer exists and is not needed for tests. Change-Id: I5f5bb7e6ae3a4b90c0ea5638737e13eb4b20c5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305513Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#789936}
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/d585128c..3028c6a4 3028c6a4 [apple] Remove support for frameworks in libs 1e3fd10c [rust] Write {{sources}} ninja variable for Rust targets 46ad4c45 [xcode] Fix running XCTests and XCUITests with New Build System Change-Id: Idf49e9d103835214bd51775ed706ca8f65e952e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307213 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789935}
-
Wez authored
Various of the tests in the suite have been individually disabled due to flakiness, but according to flake-portal most if not all of the tests in the suite are flaky, so disable them all. The individually disabled tests should be reviewed when re-enable this suite, since at least some look to be instances of the same general issue with tests flakily timing-out. TBR=pfeldman Bug: 1107396 Change-Id: Ie6540e92999503c2c83bd132f447860b4c2c8b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307216Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789934}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I974bd644b14af88b753c29258f56968572501e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295707Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789933}
-
Bo Liu authored
Missing a null check that's similar to the one in DemandDrawHw. Bug: 1104821 Change-Id: I4a1199171edee81220d59f6bc42a06f88df18e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305919 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789932}
-
Yuki Shiino authored
There are two ExecutionContexts; one of the creation realm, and the other of the document tree. Explains the difference in a document. Change-Id: I9aa90c1d57fa4cb8528629f69e4209d1554a2109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307389Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#789931}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..0c5bb2f776a5 2020-07-20 robertphillips@google.com Clean up some GrContext in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Iffb5c6989a63db91bae17759a4db4ce058212eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307365Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789930}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ia2649c3aa4b105607eed3efd38e0e1b7c6615000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295710Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789929}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c3cb2d92..343030c9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I374386622d6a58d45583b050ece351f5a8742400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306578Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789928}
-
Maksim Moskvitin authored
This reverts commit 982dfeb9. Reason for revert: new tests are extremely flaky. Original change's description: > [Autofill][SlimShady] General Hybrid Structure Component. > > The CL introduces a data structure to manage address components that > must support the duality of an structured and unstructured > representation. > > Change-Id: I435d82f608718c29821671dd1fa303c5fb3caa24 > Bug: 1099202 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238191 > Commit-Queue: Matthias Körber <koerber@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789886} TBR=battre@chromium.org,dvadym@chromium.org,koerber@google.com,schwering@google.com Change-Id: If50e7a0ab480b96734d6325f1a7104197174aee3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099202, 1107419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307489Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789927}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I3744931b8d0dd72b1b9a60db1d4890a057a245b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295709 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789926}
-
Peter E Conn authored
Change-Id: Iaf465c19c4478af20538722def8133c63af13239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302759Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789925}
-
Andrey Zaytsev authored
When the latest version on the Omaha server matches the installed one, the server doesn't return a version string; instead, status="noupdate" is returned. Bug: 1070620 Change-Id: I114b3b67f0461f65d5db7f05009cd7dfa106a8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307210 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#789924}
-
Antonio Gomes authored
... and use WTF::Vector instead, where possible. Note that the left-over use of std::vector happens because it is used as parameter to media::MockGpuMemoryBufferVideoFramePool(). BUG=704136 R=guidou@chromium.org Change-Id: I2fcaa54a7888ad4a30fa69f16e705da4391f2837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307409 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#789923}
-
Bartek Nowierski authored
This test is based on MTECheckedPtr implementation that supports offset from the beginning of the allocation. Bug: 1073933 Change-Id: Ifc5ff61c4a75d9073525da2b13f6ee5b9178f543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306126 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789922}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ic16373bc593270e42f6f1881aa7c47dae4f6346b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295711 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789921}
-
Wei Lee authored
Bug: None Test: Manually Change-Id: I74060c929b5887092b1a850941484ec5319da6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306133 Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789920}
-
Antonio Sartori authored
The logic checking the X-Frame-Options header in the AncestorThrottle was manually parsing the Content-Security-Policy headers for finding out whether the 'frame-ancestors' directive was used (since the X-Frame-Options header should be ignored if the 'frame-ancestors' CSP directive is being used). With this change we use instead the already parsed Content-Security-Policy in parsed_headers for checking that. This avoids unnecessary additional parsings of the CSP headers in the AncestorThrottle. Bug: 1032139 Change-Id: Ibe0c64cd7eb1e6f8ff0fa915a81db6248399da1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292051Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#789919}
-
Luca Hunkeler authored
Currently when we have an error we go into the stopped state and we destroy the controller. However this means that if we have a tab showing an error message and we switch away from it and switch back the error will not be showed again because we rely on the controller to rebuild the UI on tab switched. With this CL, when an error happens, we keep the controller and we destroy it only when the UI is destroyed (by navigating away or tapping on the close button). Bug: b/152949732 Change-Id: I92d443ca433052a8a4e0fe7cb28e27463d752c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296080 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789918}
-
Mikel Astiz authored
Some users have a huge amount of bookmarks (>100K) and ordered STL containers can run into performance issues. To reduce UI jank during browser startup, let's trivially adopt unordered containers. This can help reduce the time spent in SyncedBookmarkTracker::InitEntitiesFromModelAndMetadata(). Change-Id: Id789a1d8f0aa14a94aa0974b939568b966be6300 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306253 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#789917}
-
Mugdha Lakhani authored
Write equivalent tests to verify task manager behavior for NoStatePrefetch and delete them from the Prerender test suite. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ibdb1d1996cfcb6866ee6cc257e5992e32e3bcd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299235Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#789916}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595224759-e1768d31ec00790ba2a6883a1e8e7f5013b1d5d0.profdata to chrome-mac-master-1595246042-98b0c1a3c65c5614c7a736e7fb083fada959e352.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ib3ee6e1718f21f0b5ea0cd5376178285aab2efd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307362Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789915}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/741a98d1bbcf..fd5df6887258 2020-07-20 landrey@webrtc.org Reduce time that video analyzer holds the frame in pc level framework If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia4e97d136a5f8123d03ccbc634064d5f1127c02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307358Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789914}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0997f358ce07..1dcc3cfc0639 2020-07-20 eseckler@google.com processor: No indents when exporting JSON 2020-07-20 treehugger-gerrit@google.com Merge "Port the queuing delay computation over to TraceProcessor." 2020-07-17 khokhlov@google.com Merge "trace processor: Override thread names based on priorities" 2020-07-17 lalitm@google.com tp: bump versions of tp and traceconv 2020-07-17 lalitm@google.com Merge "Build without -Wno-implicit-int-float-conversion." 2020-07-17 lalitm@google.com Merge "Update jsoncpp to remove deprecated API usage" 2020-07-17 lalitm@google.com tp: parse tracing_started event and drop ftrace packets before it 2020-07-17 treehugger-gerrit@google.com Merge "ui: Add a dedicated Info page for errors, metadata and stats" 2020-07-17 treehugger-gerrit@google.com Merge "Add in scroll causes query so we can easily add in new causes." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:154156099 Tbr: perfetto-bugs@google.com Change-Id: I50313de10cfad4d9c2520e74c7abd1147ebfb379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789913}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic97947afc3c246adf825f08ba5dfbc3121767e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789912}
-
arthursonzogni authored
The initial patch was making hundreds of navigation. This was reaching a timeout on Android + ASAN. The reland split the test into many smaller parts. 1. Initial: https://chromium-review.googlesource.com/2279767 2. Revert: https://chromium-review.googlesource.com/2288430 3. Reland: This patch Bug: chromium:1090273 Revert "Revert "[COOP] Test allow-popup vs virtual-BCG."" This reverts commit 651e82f5. Change-Id: Iee600ba78cfe255002999387e8b58faad80ea662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306042 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#789911}
-
Miyoung Shin authored
This CL uses VisualStateRequest Mojo API in FrameWidget mojo interface introduced at https://crrev.com/c/2178480 since WidgetMsg_WaitForNextFrameForTest has the same implementation with VisualStateRequest Mojo API notifying that the frame swap has occurred. Bug: 1071588 Change-Id: If317b98320ec3fb85fcf7a5d1e39f0fa202d4cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216145 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789910}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d0dd661f1805..92ebe87b74f1 2020-07-20 xinghua.cao@intel.com Vulkan: Set apiVersion dawn targets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0e0bcec28a6d4af84a60639ae67a833f2b8d8304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307138Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789909}
-
Tim Volodine authored
Disable failing MediaCapture tests on Lollipop and Marshmallow Tablet Tester bots. Tests: MediaCaptureTest#testMediaCapture_basic MediaCaptureTest#testMediaCapture_rememberPermission MediaCaptureTest#testMediaCapture_twoStreams MediaCaptureTest#testMediaCapture_twoStreamsNotification Also adds a dependency on //ui/android:ui_java_test_support for the weblayer_private_java_tests test target. BUG=1107380 TBR=estade@chromium.org Change-Id: Id682278331e379d7165f3a9801353977faae8185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306043Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789908}
-