GitLab

BUG=394028
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/405933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284426 0039d316-1c4b-4281-b951-d872f2087c98

Inlining the assignment and copy constructor for a class
like ExplodedFrameState exploded the machine code in stl::vector.

gcc:
Total change: -14969 bytes
==========================
  2 added, totalling +504 bytes across 1 sources
  1 removed, totalling -3387 bytes across 1 sources
  0 added, totalling 0 bytes across 0 sources
  3 shrunk, for a net change of -12086 bytes (14716 bytes before, 2630 bytes after) across 2 sources

It also helps for clang which normally ignores programmers hints to inline anyway:
clang:
Total change: -918 bytes
========================
  1 added, totalling +263 bytes across 1 sources
  3 removed, totalling -1098 bytes across 2 sources
  2 grown, for a net change of +161 bytes (1822 bytes before, 1983 bytes after) across 1 sources
  1 shrunk, for a net change of -244 bytes (1401 bytes before, 1157 bytes after) across 1 sources

BUG=

Review URL: https://codereview.chromium.org/400923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284424 0039d316-1c4b-4281-b951-d872f2087c98

This change:
- allows for proper docking testing (including toolbox);
- removes all test friends from DevToolsWindow;
- unifies testing approach to use load callback instead of notifications;
- adds simple toolbox tests.

BUG=393566

Review URL: https://codereview.chromium.org/395783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284423 0039d316-1c4b-4281-b951-d872f2087c98

(No semantic change.)

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284422 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284421 0039d316-1c4b-4281-b951-d872f2087c98

Please reply to the V8 sheriff svenpanne@chromium.org in case of problems.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/407733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284420 0039d316-1c4b-4281-b951-d872f2087c98

> Move default user profile images strings and resources out of src/chrome.
> 
> BUG=387614
> R=bauerb@chromium.org, oshima@chromium.org
> TBR=tony@chromium.org
> 
> Review URL: https://codereview.chromium.org/400973002

TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/408833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387614
R=bauerb@chromium.org, oshima@chromium.org
TBR=tony@chromium.org

Review URL: https://codereview.chromium.org/400973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284417 0039d316-1c4b-4281-b951-d872f2087c98

There had some CLs landed before to try fixing the flakiness of those webrtc tests on Android bot. But since the flakiness only happens on bots but not locally, so I enabled it again to see if those CLs help or not.

If any of the WebRTC tests still flake on bots, this CL should be reverted.

BUG=343604
TEST=bots

Review URL: https://codereview.chromium.org/408463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284413 0039d316-1c4b-4281-b951-d872f2087c98

Blink doesn't use the arguments anymore, the promise is always resolved
with undefined.

BUG=162827

Review URL: https://codereview.chromium.org/406883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284412 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This patch seems to break CastStreamingApiTestWithPixelOutput.EndToEnd.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32598/steps/browser_tests/logs/EndToEnd

Original issue's description:
> Cast: Log playout delay from receiver
> 
> The last refactoring in RTCP handling dropped the playout delay from
> receiver. This change adds it back.
> 
> TBR=miu
> BUG=393042
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395

TBR=miu@chromium.org,hclam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=393042

Review URL: https://codereview.chromium.org/401273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284411 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284410 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178532:178539&mode=html
TBR=johnme@chromium.org,pkasting@chromium.org
BUG=

Review URL: https://codereview.chromium.org/405083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284409 0039d316-1c4b-4281-b951-d872f2087c98

Believe it or not, but the extraneous whitespace is confusing the JNI
generator resulting in UnsatisfiedLinkError at runtime.

TBR=jdduke@chromium.org

BUG=395574

Review URL: https://codereview.chromium.org/408833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394028
TBR=eugenis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/408823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284407 0039d316-1c4b-4281-b951-d872f2087c98

This target was initially defined in mojo_public.gypi, but
it depends on code outside of mojo/public. Move it to
mojo.gyp, where the target for code in the adjacent directory
(mojo/bindings/js) is defined.

BUG=None
TEST=trybots

Review URL: https://codereview.chromium.org/403803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284405 0039d316-1c4b-4281-b951-d872f2087c98

Alter Label's API to support a RenderText implementation.
This has minimal functional changes to Label for now.
The Label rewrite to use RenderText will land separately.

Remove the generally unused Label::SetDirectionalityMode.
We should always use the text's directionality anyway.
(it seems like this was the case even for *FROM_UI...)

Also remove views::LabelButton::SetDirectionalityMode.
Fix LabelButton mutli-line preferred sizing and layout.

Add RenderText flag to swap newline chars for symbols.
(We don't want that for multi-line views::Label layout)
Add GetCurrentHorizontalAlignment ALIGN_HEAD helper.
Expose ElideBehavior and ShadowValues accessors.
Set the styles of the argument FontList in SetFontList.
(this is how Label transmits style information for now)
Fix partial-pixel treatment for centered alignment.

Update Message Center's InnerBoundedLabel Label subclass.
(minimal changes to keep it working with older paint path)

BUG=240037
TEST=Negligible appearance changes (better multi-line label centering).
R=sky@chromium.org,asvitkine@chromium.org

Review URL: https://codereview.chromium.org/23228004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284401 0039d316-1c4b-4281-b951-d872f2087c98

This adds a Connect method to SerialService and a new partly complete
Connection interface. This change includes methods for:
- setting connection options
- getting connection info
- setting host control signals
- getting device control signals
- flushing buffers

BUG=389016

Review URL: https://codereview.chromium.org/401563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284398 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178530:178531&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/401223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284397 0039d316-1c4b-4281-b951-d872f2087c98

This is for compliance with ScreenOrientation
(https://w3c.github.io/screen-orientation).

When unlock screen orientation, it should lock the orientation
to default orientation.
Previous implementation is to set the orientation to "unspecified",
which is not fully aligned with spec.

Instead, read the configuration from the activity metadata in
AndroidManifest.xml and set the orientation accordingly.

BUG=394214

Review URL: https://codereview.chromium.org/399553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284396 0039d316-1c4b-4281-b951-d872f2087c98

The last refactoring in RTCP handling dropped the playout delay from
receiver. This change adds it back.

TBR=miu
BUG=393042

Review URL: https://codereview.chromium.org/401213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284395 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284394 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/249171e7d29b5559f3eefe9dbd437030bfad3fda..3d533ac917eaadf2fb3561f57d7266d8c0e665fd

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/400333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284393 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284390 0039d316-1c4b-4281-b951-d872f2087c98

It was forced to unregister power handler from power profiler service when
detached, unfortunately, GetInstance() of singleton method initialized the
service without intention. This change makes the handler unregister itself
only when it has registered.

BUG=394609

Review URL: https://codereview.chromium.org/401703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284388 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/397743005/)

Reason for revert:
Suspected for Invalid Write / Unadressable / Uninitialized errors in 
Linux Tests (valgrind)(3) via ProcessManagerTest.ProcessGrouping and others starting 
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/38965

Errors like

Invalid write of size 8
  ObserverListBase<autofill::PersonalDataManagerObserver>::AddObserver(autofill::PersonalDataManagerObserver*) (base/observer_list.h:162)
  autofill::PersonalDataManager::AddObserver(autofill::PersonalDataManagerObserver*) (components/autofill/core/browser/personal_data_manager.cc:225)
  ...
  extensions::ProcessManagerTest::ProcessManagerTest() (extensions/browser/process_manager_unittest.cc:39)

and a range of uninitialized reads/jumps.

Original issue's description:
> Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead.
> 
> BUG=354046
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284366

TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=354046

Review URL: https://codereview.chromium.org/407883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284387 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284386 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178526:178529&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/407863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284385 0039d316-1c4b-4281-b951-d872f2087c98

The `const` was removed in http://crrev.com/283945 for the other
native widget types.

BUG=366007, 382301

Review URL: https://codereview.chromium.org/399133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=true

No-try since it's the presubmit bot complaining about monsoon.py, which I didn't change.

Review URL: https://codereview.chromium.org/400873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284383 0039d316-1c4b-4281-b951-d872f2087c98

Disabled in r283311 to get a measurement on the effect on the bots.
Re-Enabling because we've collected the data we need.

BUG=356804

Review URL: https://codereview.chromium.org/408753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284382 0039d316-1c4b-4281-b951-d872f2087c98

BUG=84556
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/398083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284381 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284380 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/3f376a55002c205aacacc4cb16ed745e3afbad31..249171e7d29b5559f3eefe9dbd437030bfad3fda

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/403293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284379 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Possibly-uninitialized local variable

These are the warnings that have appeared in the codebase since I began
uploading my first cleanup pass a few weeks ago.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/400313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284378 0039d316-1c4b-4281-b951-d872f2087c98

Include bold and italic styles in Fontconfig queries.

BUG=125235,395313

Review URL: https://codereview.chromium.org/403923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284376 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178525:178525&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/403283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284375 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388016
TBR=armansito@chromium.org

Review URL: https://codereview.chromium.org/395633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284374 0039d316-1c4b-4281-b951-d872f2087c98