- 10 May, 2019 40 commits
-
-
Sunny Sachanandani authored
Frame tokens are provided by the client and the only guarantee that's enforced is that they're non-zero. Therefore, we should not DCHECK other invariants like not receiving two PresentationFeedbacks for the same token. Also add a deserialization error if the client sends a zero frame token since we have DCHECKs for that anyway. Bug: 958310 Change-Id: I4ffad483b46999c084f88ca62a0bb824522e6d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594070Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#658802}
-
Christopher Cameron authored
In SharedImageFactory::GetFactoryByUsage, only require the interop factory for OOP-raster. This side-steps a number of not-quite-yet supported situations. In SharedImageBackingFactoryIOSurface, add support for opening GpuMemoryBuffers of basic types (R, RG, and RGBA). Bug: 952063 Change-Id: I9261fdb50d4ba8dd7ffe01e44ff6079c15e30bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604329Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#658801}
-
Alison Maher authored
This change adds unit tests for ITextRangeProvider::Move for the Format unit type. The functionality for ITextRangeProvider::Move (TextUnit_Format) came automatically along with ITextRangeProvider::MoveEndpointByUnit (TextUnit_Format) (https://chromium-review.googlesource.com/c/chromium/src/+/1584596), as the Move code simply calls into MoveEndpointByUnit. Bug: 928948 Change-Id: I8b7a14158cc73bc580686f1b075125db6250c278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602381 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658800}
-
Martin Kreichgauer authored
Bug: 961818 Change-Id: I160878b36492ed5adde3a110661bd082df0301c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606961 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#658799}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee8d4aca..fd99d6f2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I345d25f1d2cd0a33fdf8236dcaa60ce74d5e554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606108Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658798}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/059f26bcb422..cd862e37ea29 git log 059f26bcb422..cd862e37ea29 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 raul@tambre.ee gclient_scm: Decode Git output centrally for better Python 3 support Created with: gclient setdep -r src/third_party/depot_tools@cd862e37ea29 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: Id2148c1b37ad4db40972a8168f8ae1d0bb8d10ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658797}
-
chrome://downloadsXing Liu authored
This CL adds a metrics for click events on the URL in chrome://downloads for Chromenav. Bug: 957346 Change-Id: I7460f5c2268c375b32c7fbede050c194a57f3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601691Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658796}
-
Min Qin authored
With the introduction of SimpleDownloadManagerCoordinator, it has 2 stages. In the first stage, OnDownloadsInitialized() will be called for in-progress downloads. In this stage, clients should be able to access all the in-progress downloads. In the 2nd stage, OnDownloadsInitialized() is called for all downloads. However, if InProgressDownloadManager is passed to a DownloadManagerImpl, the DownloadManagerImpl will not return the in-progress downloads on GetAllDownloads() unless it is fully initialized. As a result, this causes a wierd issue that after stage 1, calling GetAllDownloads() sometimes may not return all the downloads until stage 2 completes. BUG=942770 Change-Id: I44e589ee1bd174c5fef86ec9c8170ac94e6e1b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603208Reviewed-by:
-
Matt Wolenetz authored
MseBufferByPts was enabled by default in M75. This series of changes (in M76) removes: 1) the tests for the old "LegacyByDts" MSE buffering logic (this change), and 2) the old "LegacyByDts" MSE buffering logic and the associated feature gating Later changes will refactor the resulting "NewByPts" logic to remove residual complications such as templating SourceBufferStream by range buffering implementation and clean up confusing usage of DecodeTimestamp where it really contains a presentation timestamp within and below FrameProcessor. Reduces media unittests count (roughly from 5635 to 5056). Also, removes the LegacyByDts portion of each mediasource_*_pipeline_integration_fuzzer BUG=771349,760264,718641,639144 R=sandersd@chromium.org CC=mmoroz@chromium.org Change-Id: I0aca7e72abbf5353294c46876751884886382d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574608Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658794}
-
Tim Song authored
When the pop-up is expanded to show inline settings, the new height can overflow the work area. Deleting the pop-up in this scenario triggers a crash as we're still in the same call stack. BUG=957033 Change-Id: Ie8d4db393893b662b72f9c04317f9ca640a25607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600155 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#658793}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3fa919347bc7..6f8388801226 git log 3fa919347bc7..6f8388801226 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 thestig@chromium.org Remove impossible code related to CPDF_Type3Font. 2019-05-10 thestig@chromium.org Fix nits in CPDF_Pattern and related code. Created with: gclient setdep -r src/third_party/pdfium@6f8388801226 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I5a98794e854c9082d9ddecd36f0ce6ce29193eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606621Reviewed-by:
-
Kristi Park authored
Move common constants for the maximum number of NTP tiles, Most Visited, and Custom Links to a separate file. This fixes issues where the number of tiles/items in metrics do not match the current maximums (i.e. in ntp_user_data_logger.h and metrics.h). Bug: 856853 Change-Id: Ic339f2e5f44ab36a35c53abe44a0c1ab678e3060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558579 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658791}
-
Maksim Ivanov authored
Remove the "GaiaAuthHost" definition, which was an alias to the "Authenticator" class. This removal completes the TODO from 2014, since the old iframe-based authentication has been removed from the code, and only the webview-based authentication exists. Bug: 470893 Test: existing tests Change-Id: I4e174598755799e1416dbcd764ef7c83965a20e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605919Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#658790}
-
Matt Falkenhagen authored
Per blink-dev thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/O7R4YwyPIHc/1SXD1UCOCAAJ Change-Id: I2d1d7079394449d369f6520de0fa73f98ee2e239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530501Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658789}
-
Antoine Labour authored
In some cases, to avoid a copy we directly wrap a VideoFrame texture into a SkImage to use with Canvas. This patch ensures that when we do so, we don't cache the SkImage if we will release the VideoFrame, as otherwise we won't synchronize correctly, and might overwrite the recycled VideoFrame before the Canvas is done accessing it. When the PaintCanvas passed to Paint() is in software mode, we may need to read back the VideoFrame texture, in which case Skia will internally cache the read back pixels, keyed on the SkImage. We still want to take advantage of that cache, so in this case we force the copy path so that we can keep the SkImage. Bug: 958907 Change-Id: I4159646988b1298761cb24209a2d5f72c83f25e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595294 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Bug: 961455 Change-Id: I4688d7ab7faccefb5814de7e08430f143cb39b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603843Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#658787}
-
Jonathan Metzman authored
Bug: 961748 Change-Id: I1d7067e8c2142abeb9497b1ac2c096fad2bcd157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605166 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658786}
-
Darwin Huang authored
This reverts commit 9f2e13b9. Reason for revert: Regression https://crbug.com/959765 Removal of SystemClipboard::ReadPlainText logic checking and passing through |buffer_| resulted in a regression where attempting to middle click paste an X11 selection clipboard would incorrectly paste the copy/paste clipboard. The change was incorrect because blink::ClipboardCommands::ExecutePasteGlobalSelection() did indeed change the active clipboard buffer. Original change's description: > Clipboard: Remove unnecessary ClipboardBuffer argument > > of mojom::ClipboardBuffer::kStandard. While it could be useful > to allow this argument to have other values, perhaps to use > for ClipboardBuffer::kSelection in X11, this is currently not > used and always has the same value, so let's remove the unnecessary > checks and passing around of this buffer value. > > SystemClipboard: :Read{Image,PlainText}() have an argument, > mojom: :ClipboardBuffer buffer, which always has the same value > Change-Id: Ide1d9ecb5b8f2869b14232dc2acbfe4c681419e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576184 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653521} TBR=pwnall@chromium.org,huangdarwin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I5870d6e8d81e5e412848e6d39be1015980b94ab3 Bug: 959765 Change-Id: I5870d6e8d81e5e412848e6d39be1015980b94ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606425Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658785}
-
Avery Musbach authored
In split_view_utils.cc, the "Ms" suffix in the names of the TimeDelta constants does not make sense. The TimeDelta class abstracts away the unit, and does not even use milliseconds internally. The values are created from numbers of milliseconds, but this fact is clear enough from just the function name "FromMilliseconds." Test: manual Change-Id: Ic9973375fd07b22faf97332e82c2227a05bce3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598920Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#658784}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4faae213dfd..29f4ba7d6eb8 git log e4faae213dfd..29f4ba7d6eb8 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 jonahr@google.com generate_stats filters duplicate neighboring rows. Created with: gclient setdep -r src/third_party/angle@29f4ba7d6eb8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Ib9767cfcb5844adc4a84eac219f8e745f7383928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606340Reviewed-by:
-
John Budorick authored
This reverts commit 10107c8f. Reason for revert: wrong cpu. Original change's description: > Add compile and luci configs for android-cronet-marshmallow-perf-arm64-rel. > > Bug: 861983 > Change-Id: I1404f93c0592c4e7c14d6194f5963f0618f27e43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604308 > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658768} TBR=martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: Icee52669d4aa64905e8041a42f811b85df8cf05f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606597Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#658782}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7de0e5708798db249dc1cd9372372e122fdd6ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606623Reviewed-by:
-
Wei Li authored
Add a semi-universal way to handle enum type conversions in MetaData. In this CL, two enum properties from ImageViewBase were converted to demo the usage. BUG=938501,957272 Change-Id: I7e9df7fc7ec10bfff1303f1b0f537cab4d5068d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600858 Commit-Queue: Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658780}
-
Yuwei Huang authored
Previously Chrome Remote Desktop uses GOOGLE_API_KEY_REMOTING_FTL and GOOGLE_API_KEY_REMOTING_FTL_MOBILE. This internal CL defines a GOOGLE_API_KEY_REMOTING macro for each of the platform: https://chrome-internal-review.googlesource.com/c/chrome/google_apis/internal/+/1283134 This CL updates google_apis and existing code to use the new GOOGLE_API_KEY_REMOTING. I'll remove GOOGLE_API_KEY_REMOTING_FTL(_MOBILE)? once this CL is checked in. Bug: 961541 Change-Id: I03073acb23950fe0d361081b1bbf2c2fdfe750f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605159Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#658779}
-
Lukasz Anforowicz authored
Bug: 937451 Change-Id: Ia65a0a90e9befd37f7abbd86e859570265ed7cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554886 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#658778}
-
Avery Musbach authored
kSplitviewAnimationDurationMs is unused. Test: manual Change-Id: I3206f1a4cbb777ed4b30ca30d4d58acd47aa217f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601422Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e407986cd3b..ab32f656538d git log 6e407986cd3b..ab32f656538d --date=short --no-merges --format='%ad %ae %s' 2019-05-10 bsalomon@google.com Add SkSurface::asyncReadPixels() Created with: gclient setdep -r src/third_party/skia@ab32f656538d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Change-Id: Ia1962c581803b2467fdad53114700d00ccf22bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604192Reviewed-by:
-
Frank Poole authored
Currently, BrowserAccessibility::GetInlineTextRect may receive negative inner text offsets which later induce an access violation when retrieving character offsets. These negative inner text offsets are the result of unnecessary searching through sub-trees which do not contain the queried text offsets. This change resolves this bug by adding additional validation of inner text bounds. Any inner text offsets passed to GetInlineTextRect are pre-validated by GetInnerTextRangeBoundsRect. Bug: 960452 Change-Id: I4de0f23fcde2319874805141d396f576b176d796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605150Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Frank Poole <frpoole@microsoft.com> Cr-Commit-Position: refs/heads/master@{#658775}
-
Vlad Tsyrklevich authored
Enable GWP-ASan for PartitionAlloc support in chrome if the newly introduced enable_gwp_asan_partitionalloc flag is set. CQ-DEPEND=CL:1601972 Bug: 956824 Change-Id: I38ebf62c11449813b71691053597d76ee7006a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602317Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#658774}
-
bsheedy authored
Makes the first (and thus fatal) failure from JavaScript more clear in the XR browser tests. This is achieved by adding logging to point the user towards the failure and stack that are actually useful for debugging. This is a workaround for a limitation of browser tests in general. FAIL() and other fatal macros provided by gtest only abort the current function. Since all the JavaScript execution is handled by helper functions, this means that even if we catch a failure in JavaScript and report it as a failure, the browser test will continue to run. This can then cause debugging issues because errors/stack traces from later on in the test end up getting printed as well since the test is continuing to run in a bad state. Bug: 961378 Change-Id: Iafd4892dc7d5307fa35848a855d5f1c76bd27095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605340 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#658773}
-
Jeffrey Kardatzke authored
This gets set here and then also by debugd when we request it to generate more log data for feedback. The invocation in debugd is more specific and covers more cases and would have been overwriting this one anyways, so let's remove this one. Bug: 961857 Test: Builds Change-Id: I0581954708287689def01fdb53c18a2a4d2da5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606781 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#658772}
-
Michael Thiessen authored
Renames TouchlessUiController to TouchlessModelCoordinator, and introduces TouchlessUiCoordinator to abstract touchless UI logic out of NoTouchActivity to be re-used by ChromeActivity et al soon. Bug: 961734 Change-Id: I8f3d815067d314166f9777b954fc8b410c4dfa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605633Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#658771}
-
Siddhartha S authored
BUG=925151 Change-Id: I8f8e48eb34de990cf0abb7e95b55c808d758b124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606189Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#658770}
-
chrome://discardsSigurdur Asgeirsson authored
This is in preparation for pushing favicons for pages out to the graph, plus this exposes transient graph nodes reliably. Change-Id: Iee06bcf2e87c2c28c4119b70a8b4ddb9b05ff943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600362 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658769}
-
John Budorick authored
Bug: 861983 Change-Id: I1404f93c0592c4e7c14d6194f5963f0618f27e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604308 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#658768}
-
Kyle Milka authored
If an image tile is selected clikcing the done button applies the image and closes the dialog. screencast: http://go/scrcast/NTkxNjIzNDcwMDgxNjM4NHxmNzRjYzQ4YS1iZg Bug: 937570 Change-Id: I15fd616f79908708d6c3cb6b3a55cafed80b59e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606187Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c827dc29b351..782cc0e47030 git log c827dc29b351..782cc0e47030 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 oysteine@google.com Merge "Assert if the SMB stalls for 100 counts waiting for a chunk" Created with: gclient setdep -r src/third_party/perfetto@782cc0e47030 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I71f382576fb169c31b19efdd8b68bdfa7ba0e40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606342Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d29b3945d69..1643e6b61293 Created with: gclient setdep -r src-internal@1643e6b61293 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I3ca24853136a07c5ff1f741fb0836942794901b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605634Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658765}
-
Oriol Brufau authored
Before this change, a repeat() notation with an integral number of repetitions was expanded at parse time. This was observable when reading declared values using JS APIs. This patch makes the parser preserve that notation, like it was already happening when the number of repetitions was automatic and not integral. The resolved value in getComputedStyle() will still be expanded, though, as required by the spec. BUG=716114 TEST=external/wpt/css/css-grid/grid-definition/grid-support-repeat-002.html TEST=fast/css-grid-layout/grid-element-auto-repeat-get-set.html TEST=fast/css-grid-layout/named-grid-line-get-set.html Change-Id: I2d1286bf32aacc9e4fe0b0e8cf14f9f3871d0b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605401Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#658764}
-
Kristi Park authored
The transition was removed by changes in https://crrev.com/c/1591954. Technically, the transition is a regression from pre-M69 behavior, but is now considered accepted. Change-Id: I832263f37f29b01c8c8e8bd699240ed21431bc6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604426 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658763}
-
