GitLab

It works for me on my Linux box. It only supports binary tests, not
Python. :/

R=darin@chromium.org

Review URL: https://codereview.chromium.org/217043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260321 0039d316-1c4b-4281-b951-d872f2087c98

1. Rename a folder name if it is a normal folder.
2. Maximum folder name length.
3. Folder name not editable for oem folder.

BUG=354627
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260320 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 357703

TESTED=try jobs passed
NOTRY=true

Review URL: https://codereview.chromium.org/216693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260319 0039d316-1c4b-4281-b951-d872f2087c98

Processed 357 files (out of 414 files) in 01:13:43s
Result : 232959 => 168148 bytes (64811 bytes : 27 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/216483010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260317 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step towards moving APIDataSource to DataSourceRegistry

BUG=275039
NOTRY=true

Review URL: https://codereview.chromium.org/216943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260316 0039d316-1c4b-4281-b951-d872f2087c98

Chrome Shell shows a black screen when we play a video.
Some parts of the fullscreen video feature was changed recently, but the changes were applied to only Content Shell.
Please refer to https://codereview.chromium.org/182493003.

Review URL: https://codereview.chromium.org/212663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260315 0039d316-1c4b-4281-b951-d872f2087c98

R=teravest@chromium.org
TBR=binji
BUG=330851,353717

Review URL: https://codereview.chromium.org/212023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342317

Review URL: https://codereview.chromium.org/211973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260313 0039d316-1c4b-4281-b951-d872f2087c98

Processed 88 files (out of 301 files) in 00:19:24s
Result : 90523 => 36274 bytes (54249 bytes : 59 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/217883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260312 0039d316-1c4b-4281-b951-d872f2087c98

For features that need to be determined if used in the browser,
keep all the logic on browser side rather than duplicating it
in the renderer.

BUG=354449

Review URL: https://codereview.chromium.org/212003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260311 0039d316-1c4b-4281-b951-d872f2087c98

Add commands similar to WebKit text editing commands.
Translate key events to commands for textfield execution.
Consolidate key handling and command execution code.
Fix unit tests.

Modify Windows behavior for CTRL+SHIFT+[BACK|DEL].
(now behaves the same as CTRL+[BACK|DEL], not no-op)

BUG=319437
TEST=No behavior changes except for CTRL+SHIFT+[BACK|DEL] on Windows.
R=oshima@chromium.org, erg@chromium.org

Review URL: https://codereview.chromium.org/211593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260310 0039d316-1c4b-4281-b951-d872f2087c98

Canary connection attempts occur on network changes, and are capable of
bypassing backoff (without resetting it). As such they happen immediately
if no connection attempt is already in progress, but if they fail backoff
will be increased accordingly.

BUG=355126
R=asvitkine@chromium.org, jianli@chromium.org

Review URL: https://codereview.chromium.org/213693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260308 0039d316-1c4b-4281-b951-d872f2087c98

Processed 72 files (out of 76 files) in 00:13:33s
Result : 36076 => 25724 bytes (10352 bytes : 28 %)

BUG=357833
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/212103014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341275
NOTRY=true

Review URL: https://codereview.chromium.org/213673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357683

NOTRY=true

TESTED= try jobs passed

Review URL: https://codereview.chromium.org/217303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260305 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/217403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260304 0039d316-1c4b-4281-b951-d872f2087c98

Document the "remote get nexe <path>" and
"remote get irt <other-path>" commands.
Also document the --nacl-debug-mask=<pattern_set> flag.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3765
NOTRY=true

Review URL: https://codereview.chromium.org/217683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260303 0039d316-1c4b-4281-b951-d872f2087c98

TODO: Add a regression test to cros repository or figure out how credentials.json
can be used for a unit test.

BUG=308757
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/205763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260302 0039d316-1c4b-4281-b951-d872f2087c98

Include the disk serial number as a factor that is neither easily predictable nor known to the server side as well as a quantized time stamp, so the identifiers become invalid after a while.

BUG=chromium:352599
TEST=Forced re-enrollment still works.
R=joaodasilva@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/212653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260301 0039d316-1c4b-4281-b951-d872f2087c98

> Give localserver time to shut down
> 
> On machines with slow I/O, the localserver might not shut down immediately,
> wait for it if necessary.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/145873004

TBR=sigbjorn@opera.com

Review URL: https://codereview.chromium.org/217913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260300 0039d316-1c4b-4281-b951-d872f2087c98

Still trying to track down cause of MultiProfileFileManagerBrowserTest failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22674


> Separate audio player tests from special file test of Files.app (2nd)
> 
> I have a plan to add more audio player tests. Before that, make audio player tests
> separated for readability.
> 
> This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.
> 
> BUG=none
> TEST=browser_test passes
> TBR=hirino@chromium.org
> 
> Review URL: https://codereview.chromium.org/212123008

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/217743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260298 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1

Original issue's description:
> Rename PrivateMode enum values:
> 
> kPrivacyModeDisabled => PRIVACY_MODE_DISABLED
> kPrivacyModeEnabled  => PRIVACY_MODE_ENABLED
> 
> To match the chromium style guide:
> 
> Though the Google C++ Style Guide now says to use kConstantNaming for enums,
> Chromium was written using MACRO_STYLE naming.  Continue to use this style for consistency.
> 
> R=mef@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281

TBR=mef@chromium.org,zea@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/217053010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98

to QuicStreamFactory.

Review URL: https://codereview.chromium.org/209413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260295 0039d316-1c4b-4281-b951-d872f2087c98

Bonus Fix:
fillFromChromeLocalStorage now handles undefined defaults correctly.

BUG=353703
R=rgustafson@chromium.org, skare@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jam@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/211383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260293 0039d316-1c4b-4281-b951-d872f2087c98

The link is not underlined and there is 10px padding between the link and the right edge.

BUG=354893

NOTRY=true

Review URL: https://codereview.chromium.org/208643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164681, 171271

Review URL: https://codereview.chromium.org/211543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260288 0039d316-1c4b-4281-b951-d872f2087c98

Enable the brightness keys unconditionally (i.e. also on
systems that lack internal displays).

BUG=chromium:315371
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/214643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260287 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/214593010/ is missing 200 percent resource. This CL replaces it.

BUG=357351
TBR=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/217593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260286 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that this caused the VerifyEncryption failure here:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%283%29/builds/25821


> Relanding Switched main WebRTC browser tests to use a more realistic video
> 
> > Switched main WebRTC browser tests to use a more realistic video.
> 
> > After switching to fake device flags instead of software webcams, we
> > noticed a ton of video-related metrics changed. This is because the
> > spinning green ball is an unrealistic encode/decode example. This patch
> > will use the new fake device file flag to play a more realistic video.
> 
> > BUG=352261, 343504
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259887
> 
> TBR=tommi@chromium.org
> BUG=352261, 343504
> 
> Review URL: https://codereview.chromium.org/216773002

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/217553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260284 0039d316-1c4b-4281-b951-d872f2087c98

[ RUN      ] VideoCaptureDeviceTest.FakeCaptureVariableResolution
Received signal 11 SEGV_MAPERR 000000000000
...
06:57:35 memcheck_analyze.py [ERROR] FAIL! There were 2 errors:
InvalidRead
Invalid read of size 4
  FontNameCacheNodeProc(DLCacheTree const*, void*, void*, void*, unsigned char*)
  FindInDLCacheTree
  FindEntryInNameCache
  _eFOFindName
  FindNameAsCFString
  ATSFontGetPostScriptName
  TBaseFont::GetPlatformFont() const
  CTFontRef_to_SkFontID(__CTFont const*)
  NewFromFontRef(__CTFont const*, char const*)
  NewFromName(char const*, SkTypeface::Style)
  create_typeface(SkTypeface const*, char const*, SkTypeface::Style)
  SkFontMgr_Mac::onLegacyCreateTypeface(char const*, unsigned int) const
  SkFontMgr::legacyCreateTypeface(char const*, unsigned int) const
  SkFontHost::CreateTypeface(SkTypeface const*, char const*, SkTypeface::Style)
  SkTypeface::create_default_typeface(SkTypeface::Style)
  _ZL12sk_once_slowI10SkSpinlockPFvN10SkTypeface5StyleEES2_EvPbPT_T0_T1_PFvvE
  void SkOnce<SkSpinlock, void (*)(SkTypeface::Style), SkTypeface::Style>(bool*, SkSpinlock*, void (*)(SkTypeface::Style), SkTypeface::Style, void (*)())
  void SkOnce<void (*)(SkTypeface::Style), SkTypeface::Style>(SkOnceFlag*, void (*)(SkTypeface::Style), SkTypeface::Style, void (*)())
  SkTypeface::GetDefaultTypeface(SkTypeface::Style)
  SkScalerContext::MakeRec(SkPaint const&, SkDeviceProperties const*, SkMatrix const*, SkScalerContextRec*)
  SkPaint::descriptorProc(SkDeviceProperties const*, SkMatrix const*, void (*)(SkTypeface*, SkDescriptor const*, void*), void*, bool) const
  SkPaint::detachCache(SkDeviceProperties const*, SkMatrix const*) const
  SkAutoGlyphCache::SkAutoGlyphCache(SkPaint const&, SkDeviceProperties const*, SkMatrix const*)
  SkAutoGlyphCache::SkAutoGlyphCache(SkPaint const&, SkDeviceProperties const*, SkMatrix const*)
  SkDraw::drawText(char const*, unsigned long, float, float, SkPaint const&) const
  SkBitmapDevice::drawText(SkDraw const&, void const*, unsigned long, float, float, SkPaint const&)
  SkCanvas::drawText(void const*, unsigned long, float, float, SkPaint const&)
  media::FakeVideoCaptureDevice::OnCaptureTask()
Address 0xd11a5aaa is not stack'd, malloc'd or (recently) free'd

BUG=344108
TBR=mcasas@chromium.org
NOTRY=TRUE

Review URL: https://codereview.chromium.org/217503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260282 0039d316-1c4b-4281-b951-d872f2087c98

kPrivacyModeDisabled => PRIVACY_MODE_DISABLED
kPrivacyModeEnabled  => PRIVACY_MODE_ENABLED

To match the chromium style guide:

Though the Google C++ Style Guide now says to use kConstantNaming for enums,
Chromium was written using MACRO_STYLE naming.  Continue to use this style for consistency.

R=mef@chromium.org

Review URL: https://codereview.chromium.org/215023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260281 0039d316-1c4b-4281-b951-d872f2087c98

current input method.

BUG=335368

Review URL: https://codereview.chromium.org/187313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260280 0039d316-1c4b-4281-b951-d872f2087c98

- Creates repack_pack.gypi action
- Updates all the call-sites of repack.py
- Removes chrome_repack_pseudo_locales.gypi to instead use
  chrome_repack_locales.gypi
- Remove unused repack_locales_cmd list

BUG=338759
R=tfarina@chromium.org, thakis@chromium.org
TBR=asargent@chromium.org, benm@chromium.org, blundell@chromium.org

Review URL: https://codereview.chromium.org/216013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160900
R=creis@chromium.org, joi@chromium.org, thestig@chromium.org, tsepez@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/185393012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260276 0039d316-1c4b-4281-b951-d872f2087c98

This is a Windows-specific stat tracking mechanism that uses the Windows
registry and update mechanism. It isn't appropriate on Linux. We already
have UMA stats for the App Launcher (including Linux); see
app_list_service_impl.cc.

BUG=357447

Review URL: https://codereview.chromium.org/216163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351836
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/217493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260274 0039d316-1c4b-4281-b951-d872f2087c98

R=vandebo@chromium.org
BUG=343968

Review URL: https://codereview.chromium.org/215433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260273 0039d316-1c4b-4281-b951-d872f2087c98

The only dependency here is on some static methods that
are only used by ExtensionPrefs. These should live inside
the ExtensionPrefs module.

(clang_format also applied, pardon the dust)

BUG=357634,162530
R=scheib@chromium.org

Review URL: https://codereview.chromium.org/217053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260272 0039d316-1c4b-4281-b951-d872f2087c98