- 10 Jun, 2014 40 commits
-
-
jamesr@chromium.org authored
This is the GN equivalent of public/all.gyp's all_blink target which defines all test targets that blink contains. As more test targets start linking in the GN build they should be added to this file. For now, this just includes wtf_unittests and the /platform/ and /core/ components. Review URL: https://codereview.chromium.org/324963007 git-svn-id: svn://svn.chromium.org/blink/trunk@175917 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eroman@chromium.org authored
The meaning of a secure origin is defined by: http://www.chromium.org/Home/chromium-security/security-faq#TOC-Which-origins-are-secure- In essence, "secure origins" are those that load resources either from the local machine or over the network from a cryptographically-authenticated server. For example these are considered secure origins: * chrome-extension://xxx * https://xxx * wss://xxx * file://xxx * http://localhost/ * http://127.0.0.1/ Whereas these are considered insecure: * http://foobar * ws://foobar crypto.subtle itself is visible from insecure origins. However all of its methods will fail by returning a rejected Promise for NotSupportedError. BUG=373032, 245025, 362214 Review URL: https://codereview.chromium.org/299253003 git-svn-id: svn://svn.chromium.org/blink/trunk@175916 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
abarth@chromium.org authored
This case can never occur. This function is now only called from a full compositing update, which cleans out all the dirty bits in the z-list. I ran all the LayoutTests with a CRASH() in this codepath and it never hit. Review URL: https://codereview.chromium.org/329613002 git-svn-id: svn://svn.chromium.org/blink/trunk@175915 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
ojan@chromium.org authored
We need to store a bit on the RenderStyle as to whether it needs to be accelerated due to the plugin having a layer so that when we recalc style on it, we actually get a different style and call setStyle. This is needed so styleChanged gets called and we get a NormalLayer RenderLayer. This is better than the current hack because we'd like it to be an invariant that setStyle is only called when the style actually changed. Revert "Psuedo revert "s/scheduleLayerUpdate/setNeedsCompositingUpdate in setWebLayer."" This reverts commit 2c54e3cf4c74a20c2319bc3bae26904fbb462330. Review URL: https://codereview.chromium.org/328553004 git-svn-id: svn://svn.chromium.org/blink/trunk@175914 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
brettw@chromium.org authored
This makes the bindings basically run although not all of core links so there may be some items left to do. R=nbarth@chromium.org Review URL: https://codereview.chromium.org/319983003 git-svn-id: svn://svn.chromium.org/blink/trunk@175913 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
svillar@igalia.com authored
Sometimes grid children are wrapped into an anonymous blocks to become grid items. Those anonymous blocks could be eventually removed by RenderBlock::removeLeftoverAnonymousBlock() (called for example when adding a new child to the grid). That method does not notify the hierarchy about the removal since those anonymous blocks are not part of the DOM. This means that further accesses to the m_grid contents will trigger invalid accesses to the already deleted RenderObjects (the anonymous blocks). To fix it we invalidate the contents of m_grid by setting the dirty flag in the grid. Based on the previous work in r161127 by <jchaffraix@chromium.org> BUG=313293 Review URL: https://codereview.chromium.org/302083005 git-svn-id: svn://svn.chromium.org/blink/trunk@175912 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
instead of anchorPoint. The hack is no longer necessary because transformOrigin is an additive offset, as opposed to a multiplicative one. BUG=372837 Review URL: https://codereview.chromium.org/329553003 git-svn-id: svn://svn.chromium.org/blink/trunk@175911 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
chrishtr@chromium.org authored
TBR=abarth BUG=382129 Review URL: https://codereview.chromium.org/328783002 git-svn-id: svn://svn.chromium.org/blink/trunk@175910 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dcheng@chromium.org authored
Revert of DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. (https://codereview.chromium.org/320933003/) Reason for revert: event-listener-breakpoints.html always timing out on Mac 10.6 (dbg): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20(dbg) Original issue's description: > DevTools: Expand protocol to allow setting DOM event breakpoints on a given event target. > > This will allow debugger to pause on "load", "error" and etc. event breakpoints only > when they happen on XHR event targets. > > BUG=381470 > R=yurys, pfeldman@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175882 TBR=pfeldman@chromium.org,yurys@chromium.org,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=381470 Review URL: https://codereview.chromium.org/322893006 git-svn-id: svn://svn.chromium.org/blink/trunk@175909 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jam@chromium.org authored
Fix InternalsGeolocation::setGeolocationClientMock to actually set the test client for all GeolocationController. This was caught by kenrb. It didn't manifest itself because it's a test-only method, and none of the geolocation tests which use this do so for an iframe. Review URL: https://codereview.chromium.org/322583002 git-svn-id: svn://svn.chromium.org/blink/trunk@175907 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rob.buis@samsung.com authored
Avoid branching in createAttributeEventListener, also it should not be needed to test for SVG specific stuff in this spot. Review URL: https://codereview.chromium.org/321023002 git-svn-id: svn://svn.chromium.org/blink/trunk@175902 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
amikhaylova@google.com authored
BUG=376194 Review URL: https://codereview.chromium.org/324013005 git-svn-id: svn://svn.chromium.org/blink/trunk@175901 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
zerny@chromium.org authored
R=haraken@chromium.org BUG= Review URL: https://codereview.chromium.org/323873007 git-svn-id: svn://svn.chromium.org/blink/trunk@175900 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jbroman@chromium.org authored
These represent the same concept, and having two separate enumerations is redundant. BUG=382916 Review URL: https://codereview.chromium.org/328453004 git-svn-id: svn://svn.chromium.org/blink/trunk@175899 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
Timeline front-end used to assume that if call stack is present, it contains at least one call frame. Let's not break that expectation when transitioning to trace-based instrumentation and return null, not empty array, for the absent stack. BUG=361045 Review URL: https://codereview.chromium.org/327793002 git-svn-id: svn://svn.chromium.org/blink/trunk@175898 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/323503002 git-svn-id: svn://svn.chromium.org/blink/trunk@175897 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
BUG=361045 R=loislo@chromium.org Review URL: https://codereview.chromium.org/324963002 git-svn-id: svn://svn.chromium.org/blink/trunk@175895 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
dominikg@chromium.org authored
When creating a new GraphicsContextState the constructor initializes the state with various default values. In GraphicsContext::realizePaintState we immediately overwrite these values after creation. This patch adds a copy constructor to GraphicsContextState to avoid that. Even though this seems like a clear win, the benefits are not visible when profiling. Looks like the overhead of the redundant initialization is not very large. Still seems worth fixing though. BUG=377687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174985 Review URL: https://codereview.chromium.org/303613002 git-svn-id: svn://svn.chromium.org/blink/trunk@175894 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
Timeline: move TracingTimelineModel.reset() call from startRecording() to _startRecordingWithCategories() This is a follow-up to https://codereview.chromium.org/326693002/ (r175810) BUG=361045 TBR=yurys Review URL: https://codereview.chromium.org/324913003 git-svn-id: svn://svn.chromium.org/blink/trunk@175893 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
highlightQuad method is added to TimelineMode.Rectord. The method encapsulates logic specific to timeline events and trace events. BUG=361045 R=caseq@chromium.org Review URL: https://codereview.chromium.org/326063004 git-svn-id: svn://svn.chromium.org/blink/trunk@175892 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
This prepares inspector for switching chromium-side trace events used for building timeline to the category names consistent with the rest of timeline trace-based instrumentation in blink. BUG=361045 Review URL: https://codereview.chromium.org/328723002 git-svn-id: svn://svn.chromium.org/blink/trunk@175891 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
eustas@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/323063002 git-svn-id: svn://svn.chromium.org/blink/trunk@175890 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
yurys@chromium.org authored
BUG=361045 R=loislo@chromium.org Review URL: https://codereview.chromium.org/321113003 git-svn-id: svn://svn.chromium.org/blink/trunk@175889 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
loislo@chromium.org authored
result declaration was moved close to the usage: TypeBuilder::HeapProfiler::HeapSnapshotObjectId out_heapSnapshotObjectId; - RefPtr<JSONObject> result = JSONObject::create(); if (protocolErrors->length()) { reportProtocolError(&callId, InvalidParams, String::format(InvalidParamsFormatString, commandName(kHeapProfiler_getHeapObjectIdCmd)), protocolErrors); return; } ErrorString error; + RefPtr<JSONObject> result = JSONObject::create(); m_heapProfilerAgent->getHeapObjectId(&error, in_objectId, &out_heapSnapshotObjectId); if (!error.length()) { result->setString("heapSnapshotObjectId", out_heapSnapshotObjectId); BUG= Review URL: https://codereview.chromium.org/326013005 git-svn-id: svn://svn.chromium.org/blink/trunk@175888 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
c.shu@samsung.com authored
This should avoid memory leaks when the program exits gracefully. Review URL: https://codereview.chromium.org/324813002 git-svn-id: svn://svn.chromium.org/blink/trunk@175887 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rego@igalia.com authored
In RenderGrid::placeAutoMajorAxisItemOnGrid if the empty grid area does not fit in the minor axis direction we should discard it. That way we will avoid to grow in that direction at this moment, as this was previously done at RenderGrid::populateExplicitGridAndOrderIterator(). A simple use case to reproduce the problem would be a 2x2 grid with grid-auto-flow property set to "row", where the only empty cell is at row 2 and column 2. If you try to place an item with the following properties: grid-row: auto; grid-column: span 2; It should be inserted in a new row, however before this patch it was inserted at row 2 using columns 2 and 3. As even when the empty grid area does not fit in the minor axis direction, it was still being used later to insert the item. Updated layout test to include similar cases that don't work without this patch. BUG=353789 TEST=fast/css-grid-layout/grid-item-auto-placement-automatic-span.html Review URL: https://codereview.chromium.org/314993002 git-svn-id: svn://svn.chromium.org/blink/trunk@175886 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rego@igalia.com authored
Now it's called RenderGrid::ensureGridSize and it allows to grow both directions at once. Remove checkings before calling it as they are not needed anymore. Review URL: https://codereview.chromium.org/319593002 git-svn-id: svn://svn.chromium.org/blink/trunk@175885 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jochen@chromium.org authored
BUG=none R=haraken@chromium.org Review URL: https://codereview.chromium.org/311053004 git-svn-id: svn://svn.chromium.org/blink/trunk@175884 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
behara.ms@samsung.com authored
It was added as a part of this patch https://codereview.chromium.org/13937017 The patch was reverted here https://chromiumcodereview.appspot.com/23072015 Review URL: https://codereview.chromium.org/322103003 git-svn-id: svn://svn.chromium.org/blink/trunk@175883 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
aandrey@chromium.org authored
This will allow debugger to pause on "load", "error" and etc. event breakpoints only when they happen on XHR event targets. BUG=381470 R=yurys, pfeldman@chromium.org Review URL: https://codereview.chromium.org/320933003 git-svn-id: svn://svn.chromium.org/blink/trunk@175882 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
caseq@chromium.org authored
Just moving things around, no actualy logic change, though dropped unused FrameAdded event. BUG=361045 Review URL: https://codereview.chromium.org/320953002 git-svn-id: svn://svn.chromium.org/blink/trunk@175881 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kouhei@chromium.org authored
|m_elementDependencies| had raw ptr to |SVGElement|s. This was to avoid reference cycles, but we can convert this to strong references in oilpan. If the whole document is dead, rebuild code is not called. This means that rebuildElementReference is not called for referencing element, but the referencing element must be in the same document and is going to die anyway. If the whole document isn't dead (== the part of the document tree is going away), the unregister/rebuild code is guaranteed to be called from removedFrom, and rebuildElementReference is guaranteed to be triggered from there. BUG=357163, 370834 Review URL: https://codereview.chromium.org/327473002 git-svn-id: svn://svn.chromium.org/blink/trunk@175880 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sergeyv@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/322793003 git-svn-id: svn://svn.chromium.org/blink/trunk@175879 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
nhiroki@chromium.org authored
These are accidentally added by r175288. BUG=n/a TEST=n/a Review URL: https://codereview.chromium.org/320423006 git-svn-id: svn://svn.chromium.org/blink/trunk@175878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
loislo@chromium.org authored
and reduce binary footprint by 5% ~25kb of 587k (clang x64 release) BUG=382569 R=yurys@chromium.org Review URL: https://codereview.chromium.org/325833002 git-svn-id: svn://svn.chromium.org/blink/trunk@175877 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tkent@chromium.org authored
- We need to add Persistent<Element> in ImageLoader in order to follow the current behavior by manual ref/deref. Also, the manual ref/deref is replaced with RefPtr<Element>. - ImageLoader was the last off-heap user of EventSender<T>. Now all of EventSender<T> users are on-heap. We can trace EventSender::m_dispatchSoonList and m_dispatchingList. - HTMLImageElement and SVGImageElement had ImageLoader as part objects. This CL makes them OwnPtr / Member because using on-heap objects as part objects are dangerous. - Add HTMLImageElement::create and SVGImageElement::create. BUG=357163 R=haraken@chromium.org Review URL: https://codereview.chromium.org/320253002 git-svn-id: svn://svn.chromium.org/blink/trunk@175876 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
Go the whole hog and use (non-const) bare pointers for the conversion constructor and assignment operator. R= BUG=340522 Review URL: https://codereview.chromium.org/329463004 git-svn-id: svn://svn.chromium.org/blink/trunk@175875 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
mostynb@opera.com authored
According to this GCC bug/patch, a user-specified constructor is required for the emulated C++11 nullptr_t class if we want to be able to create const nullptr_t objects without an explicit initializer, a la: "const std::nullptr_t nullptr;" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42844 This fixes a build failure in GCC 4.5. BUG=374431 Review URL: https://codereview.chromium.org/322913002 git-svn-id: svn://svn.chromium.org/blink/trunk@175874 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
tasak@google.com authored
BUG=337618 TEST=fast/dom/shadow/getComputedStyle-with-distribution.html Review URL: https://codereview.chromium.org/240293007 git-svn-id: svn://svn.chromium.org/blink/trunk@175873 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
sigbjornf@opera.com authored
R=dmazzoni@chromium.org,haraken@chromium.org,tommi@chromium.org,tkent@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/315133004 git-svn-id: svn://svn.chromium.org/blink/trunk@175872 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-