- 15 Oct, 2019 40 commits
-
-
Mohammad Refaat authored
Bug: 987646 Change-Id: Ic834aac16e4e78a3da0983d4ec2a2f719315e8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860107Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#706063}
-
Monica Basta authored
The profile name and avatar icon will not be syncable prefs anymore. We have decided that the user will need to customize their profile once per device if they wish to. We also change the strategy for showing the avatar icon of the profile to the following: * For profiles that are not signed in, on events like sign in or enable sync, Gaia avatar wins. * If the user customizes their profile while having a butter account or a primary account on this device, the customized avatar wins. * If the profile has a butter account A with customized avatar, if the user decides to start syncing with account A, the customized avatar wins. We do not want to change the state of the profile given that it is the same account. * If the profile has a butter account A with customized avatar, if the user decides to start syncing with account B, the Gaia avatar wins. Bug: 1013597 Change-Id: Ic60cca56d31e20a31d010e9f8995a03ca7819623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855968 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#706062}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 6 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-04-12. Change-Id: Id3a9f34effe97a5a8d556e9b23621b248eb37a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863199 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#706061}
-
David Tseng authored
In ARC++, we send the entire tree from inside the Android container out to Chrome. As a result, each time the AXTreeSerializer is asked to serialize, we rely upon it to compute the incremental tree update starting at the event target. This can exercise the serializer in various ways not seen on other platforms. In order to ensure we always serve a fresh tree to Chrome OS extensions, that listen on the other end of AXTreeSourceArc, set |node_id_to_clear| on each AXTreeUpdate sent to the extension. This has the advantage of forcing re-computation of unignored child count and index in parent which have been buggy given corner cases of tree update permutations. This change also makes a few cleanups/improvements: - PopulateAXRole gets moved into ArcAccessibilityDataInfoWrapper::Serialize. This was done to ensure tests that only call Serialize get the *entire* serialized AXNodeData. Previously, we were omitting role population due to the special casing of the root node. - removed logic surrounding assigning root node role from AXTreeSourceArc. This was done previously because the tree may or may not contain ancestor windows from ARC++ (i.e. AccessibilityWindowDataInfoWrappers were not being used). We can now safely assume we have windows in the tree. This change also relaxes the role assignment on the root *Node* (not window). We now compute its role as normal as any other node, but still assign it as modal. This is to cover strange cases in in tests where we have just one node in the node tree (one window with a child node). That node might be a staticText, but we were assigning it arbitrarily as a genericContainer. (see test change). Bug: b:142544528 Test: unit_tests --gtest_filter=AXTreeSourceArc*.* Change-Id: I9c14d9c7fdc10cfffd9ce734921276fd503eac33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856830 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#706060}
-
Mikhail Khokhlov authored
The following benchmarks are added: - jetstream2, uses the new AddMeasurement API - octane, uses the old AddHistogram API (but values are also recorded as histograms) - blink_perf.css, a non-press benchmark also using AddMeasurement. output formats for these will now be handled by results processor. Bug: 981349 Change-Id: I08c3cf9c878a32389fa81912020922ff652593f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863293Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#706059}
-
Peter Boström authored
Replaces OnBoundsChanged overrides. While here also replaced GetCenterPoint() implementation to return GetLocalBounds().CenterPoint() instead of using width()/height(). Bug: chromium:1007546 Change-Id: I4e821cd1b9a07c5352b6d34301e9fa0928aafb39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861281Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706058}
-
Christian Dullweber authored
Record user actions and uma for cookie controls usage. The uma histogram is recorded in addition to ukm to allow measurements for regular+incognito mode. Bug: 967668 Change-Id: Ibbb8a75d7f03c42c824967bfdfd752fa258d10a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855920Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#706057}
-
Nate Fischer authored
This changes AwActivityTestRule to use ScalableTimeout instead of hardcoding the timeout. This should have no effect (bots don't appear to set this value), but gives devs the option of scaling the timeout if they use tools like valgrind. Bug: 1013465 Test: N/A Change-Id: I05100f36a96cb21ac989c7c5e1f12abbaca16ffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861048Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706056}
-
Devlin Cronin authored
ExtensionBrowserTests look for paths beginning with "_test_resources" in extension resources being loaded, and redirect them. The original motivation for this was to allow us to re-use common utility files between loaded test extensions. We want to use this in the PDF extension tests. For this, we want to load resources that aren't part of the extension itself as if they were - specifically, for the sake of exercising module code. Beef up the _test_resources handling by: - adding support for subclasses to specify their own parent directory through ExtensionBrowserTest::GetTestResourcesParentDir(). This allows PDF tests to load resources from chrome/test/data/pdf instead of chrome/test/data/extensions. - adding browser test coverage, including the basic case, a component extension case (which the PDF extension is), and the customized resource parent. This is needed to unblock the PDF extension's use of modules, which in turn is needed for the Polymer 2 -> Polymer 3 migration. Bug: 1005029 Change-Id: I8a998eebf38bb680ffde72f512b962d83fe75989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850779 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706055}
-
Min Qin authored
This is part of on-going modulization effort. Chrome/browser/android/download should be under the download/ feature. BUG=1013759 Change-Id: Ife04a391d22799d8bcdcfa979ea04874b20e4a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857544Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706054}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ac0a4cbbd850..6841d25d45ac git log ac0a4cbbd850..6841d25d45ac --date=short --no-merges --format='%ad %ae %s' 2019-10-15 sprang@webrtc.org Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" 2019-10-15 srte@webrtc.org Cleanup: Replacing set extension status bool with CHECK. 2019-10-15 saza@webrtc.org AEC3: Add support for logging warnings on delay buffer changes 2019-10-15 sprang@webrtc.org Revert "Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const"" 2019-10-15 phoglund@webrtc.org Put the resources_dir flag into its own target. 2019-10-15 sprang@webrtc.org Reland "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" Created with: gclient setdep -r src/third_party/webrtc@6841d25d45ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If46e242a6503e5c750485651b0e3a2b7c14a4d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706053}
-
Peter Boström authored
Replaces path generation in ::OnBoundsChanged. Bug: chromium:1007546 Change-Id: Icfb148443fe61578953bced671cc8f482fabe9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861042 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d061254d2f4..12dc10e0278c git log 8d061254d2f4..12dc10e0278c --date=short --no-merges --format='%ad %ae %s' 2019-10-15 dproy@google.com Merge "Larger click target for expanding track groups" Created with: gclient setdep -r src/third_party/perfetto@12dc10e0278c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I76d83ee7780194f27784ed391c3ac2ac5a85d7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862240Reviewed-by:
-
Akihiro Ota authored
This changes ChromeVox language switching behavior to alert users if we do not have an available voice for the current language, instead of failing silently or butchering pronunciation with a different voice. This change: 1. Adds logic in LanguageSwitching.js to check if there is a matching voice for a language before making a language assignment 2. Modifies the accessibilityPrivate.getDisplayLanguage() api to take an additional parameter (the desired output language) 3. Adds a LanguageSwitchingTest to confirm new behavior. 4. Modifies existing API tests to confirm new behavior. Bug: 1008481 Change-Id: I5537c916a0e6b435c5c833b8e7fe7a9e530df65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829547 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706050}
-
Eric Robinson authored
This change adds a variable to ChildProcessPriorityLauncher to indicate whether the associated process is only used to run tasks for ad frames (low priority frames). That variable is then used by the RenderProcessHost to background the frame in those cases. Notification happens in the RenderProcessHost via new UpdateFrameWithPriority. Note: Identification of ad frames is done as per the AdTagging project. Frames that have been marked as ads remain ads, and thus the RenderProcessHost will remain low priority if the frame is navigated to any other non-ad URL within the same process (same domain). Currently this is behind a feature which is off by default. We will be experimenting with this to determine its impact on both ads and in the browser as a whole. TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org Bug: 979234 Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706049}
-
Elly Fong-Jones authored
When navigating to the tab as an accessible pane (via F6), focus currently gets dropped at the first tab, which is not as useful as it might be. It is easy to get to the start (via Home) or end (via End) of the strip but not to get to the active tab. As such, focus should land on the active tab by default instead. Bug: 910687 Change-Id: I0d70e171557d5591745c117bdca067f77c4feaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857303Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#706048}
-
Xing Liu authored
This test is failing on some Android builder. TBR=miu@chromium.org Bug: 1014540 Change-Id: I33aad07c462a892a0b2bd5545bf1a8f1a7f5eae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863552Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706047}
-
Xing Liu authored
Currently it's failing on an Android O builder. TBR=tbansal@chromium.org Bug: 1014213 Change-Id: I4d22e177e2ffdc76040be0be623883dfd0124a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862248Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706046}
-
Ahmed Mehfooz authored
This change ensures that the message center collapses to just have the notification bar visible when there is less than kMessageCenterCollapseThreshold space available. Bug: 1002710 Change-Id: Ia0d15b0686788905fd8757366e405227851f1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846235 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706045}
-
Lukasz Anforowicz authored
Casting a raw integer (e.g. an integer deserialized from session restore files, from a protobug, or coming from the other side of JNI boundary) to an enum class value may potentially cause the following problems: - Invalid enum values may cause Chromium code to misbehave. - It is not entirely clear if C++ spec allows such casts (i.e. if such casts may lead to undefined behavior). Because of the above, this CL replaces: static_cast<network::mojom::ReferrerPolicy>(raw_integer) casts with calls to a new content::Referrer::ConvertToPolicy static helper method, which tries to ensure that the cast is done in a safe way. Bug: 1006409 Change-Id: I2a660c4caf961ca52503b084a7c0abe93e9d5eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816134Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#706044}
-
Michael Liao authored
DevTools [Common - Flame Chart]: Making flame chart keyboard accessible in memory and javaScript profiler tool Changes: - Adding keyboard navigability to JavaScript and Memory profiling flame charts - CPUProfileNodes with source links are enter-clickable - Flamechart's focused CPUProfileNodes will turn gray (from blue) when flamechart loses focus CPUProfileNode selected (with and without focus): https://imgur.com/a/e6JkqYW Bug: 963183 Change-Id: Icb00d5b53dab6cd5f83e5602a7d3834afdb7eab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663021Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706043}
-
Darwin Huang authored
Bug: 1013400 Change-Id: I1dcdff204890c060ea243d3be846aa211a39e468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859879Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706042}
-
dpapad authored
There are no other usages of PageManager and Page. Given that these are old WebUI UI elements that are no longer encouraged, moving them guarantees that no new dependencies to those elements will be introduced. This is also in preparation of eliminating HTML Imports from bluetooth_intarnals/. Moving these elements simplifies things, since there is no need to auto-generate JS Modules version of such elements at build time, if no other usages exist. Bug: 937747 Change-Id: I73152dab8dae65ee8ad465e5d0d018420df18f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860780 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706041}
-
Javier Ernesto Flores Robles authored
Some modifications has been made to make all the manual fallback tests more robust. As it can be seen in the bots of the CQ these test are not failing anymore. Bug: 1007421, 1007455 Change-Id: I30b2c454a42925dc64a6226788a26db3f760ef5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859967 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Deepanjan Roy authored
The script can now write out histogram set json. Currently we're using a json config file to specify details in the histogram that are not available in trace processor metric result, but this will likely change soon. No support for diagnostics yet. Bug: chromium:1012687 Change-Id: I8654bdb8ea6a596f899b919d0884bee25ed7af1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860334 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
-
Kai Ninomiya authored
This allows us to have our own variants list, so we can split test files into smaller parts for more fine-grained suppression. Bug: 984818 Change-Id: Id9a12491d592ddaf0899d40c89d01139396a92d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860508Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706038}
-
Matt Mueller authored
Record debug data from net::CertVerifyProcMac, plumb it into TrialComparisonCertVerifier error reports. Bug: 991247 Change-Id: I59227f0544b4d05312eaab3df09a8121fa39c3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856625Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#706037}
-
Istiaque Ahmed authored
ExtensionFunction can appear after a worker has already stopped. Trying to execute the ExtensionFunction results in EFD::CheckPermissions failure. As the worker is stopped, we can safely ignore this extension function. Subsequent CL will add tests for this once crbug/999027 is completely fixed. related patches. Bug: 999027 Test: Locally trying UpdatePackedExtension test few thousand time with Change-Id: I6e8d8716d4bec349034502233782ada8674d1325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832465 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Shawn Gallea authored
Allows 4hz framerate on headless devices with kReduceHeadlessFrameRate feature Bug: b/139299756 Test: Compile cast_shell for headless device Change-Id: I13a36cbc2225c20367188375518b34baf585f2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815049 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#706035}
-
Maciek Slusarczyk authored
Fixes ChromeOS.SAML.APIUsed and ChromeOS.SAML.Scraping.PasswordCount metrics that were not populeted correctly. For PasswordCount the main case (exactly 1 password scraped) was missed whereas APIUsed did not distinguish between SAML login flow with principals API and pure GAIA-based authentication. The corresponding histograms were renamed to ChromeOS.SAML.APILogin and ChromeOS.SAML.Scraping.PasswordCountAll. Bug: 976230 Change-Id: I94a1e903664ba9d6b11e97ebd750cadba7edf82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835576Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: Iaeaf5ba584d6592a64226d9b57c37e6c9d5544a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863021Reviewed-by:
-
chrome://appsElly Fong-Jones authored
This change adjusts the color scheme on chrome://apps: * The webstore link is now Blue 600 and has no hover effect, to make it look like the link it is * Other text in the footer is #666 so it's readable on the background * The background is white instead of a near-white translucent gradient * The logo image is now an image without text, since the text was not contrast-y enough Bug: 957393 Change-Id: I3b3f08554222b23f63d167b54875004a4ddb5c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856541Reviewed-by:
-
Peter Kasting authored
These should be ints per our style guide, and were both set and used as ints (via implicit and explicit casts, respectively). Bug: none Change-Id: I815879e38e5ec363a50bb2f58a0b607f716ad8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855198 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706031}
-
Xiaohan Wang authored
External Clear Key is a test key system. This CL updates the comment to explain what it is used for and how it's supported in different cases. Change-Id: I955a6bb2db039069122ecf98ebe944628526e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863111Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706030}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df18296f9844..fb6a1abe4567 git log df18296f9844..fb6a1abe4567 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 mtklein@google.com try un-teaching TSAN about Mac semaphores Created with: gclient setdep -r src/third_party/skia@fb6a1abe4567 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I5b8244727d408b0cb1c5466fa74d8ee6bc8a41c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862242Reviewed-by:
-
Jeremy Roman authored
Change-Id: I661ebde62fbe9b010d923a4948ecb942a214cb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862625 Commit-Queue: Andreas Haas <ahaas@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8e512c1e9ab..14df22429d27 Created with: gclient setdep -r src-internal@14df22429d27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1005965,chromium:None Change-Id: I469ea22a0741a670033f0aeceb48e00549e85e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706027}
-
Yuwei Huang authored
Mojave users might have already granted a11y permission to the old helper script. In order not to unnecessarily break them, this CL implements a fallback logic in the host service executable to always delegate to the old script if the script exists and the user is on macOS 10.14. Bug: 10142116 Change-Id: I301585cf25ca3c37ac1ebedac8b4dee6c1251c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861278Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706026}
-
Xing Liu authored
This test is failing on some Android builders. Disable it for now. TBR=ricea@chromium.org Bug: 1014556 Change-Id: Iad4dbb959199476e08c90848ebd325143d6eeb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862717Reviewed-by:
-
jonross authored
Update the example usage of --local-run for pixel tests. This is a follow-up to a change of how the argument is used: https://chromium-review.googlesource.com/c/chromium/src/+/1860677 Bug: 1013358 Change-Id: Id1ccdd5b55c89e976ff77853925c0db9c7bcd835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862624Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#706024}
-
