GitLab

This takes the device scaling into account when drawing
the progress bar in the omnibox icon.

Bug: 986265
Change-Id: Ib01c2496b86b9ab2860d1ad826ab8e67ed11b8bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712572Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679916}

This reverts commit bd0cae50.

Reason for revert: Cause failures in DirectCompositionSurfaceTest.*
Builder: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29?limit=200
First build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/22377?blamelist=1#overview-tab

Crash example:
Test 'DirectCompositionPixelTest.DCLayersDisabled' completed with the following status(es): 'CRASH','CRASH','CRASH'

Test 'DirectCompositionPixelTest.DCLayersDisabled' had the following logs when run:

================================================================================

[ RUN      ] DirectCompositionPixelTest.DCLayersDisabled
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	RtlAcquireSRWLockExclusive [0x774C4188+24]
	base::internal::LockImpl::Lock [0x72EEA36A+106] (o:\base\synchronization\lock_impl_win.cc:36)
	base::Lock::Acquire [0x73AA4B5A+26] (o:\base\synchronization\lock.h:50)
	base::internal::BasicAutoLock<base::Lock>::BasicAutoLock [0x73AA4663+35] (o:\base\synchronization\lock_impl.h:84)
	gl::VSyncThreadWin::RemoveObserver [0x73B41033+51] (o:\ui\gl\vsync_thread_win.cc:84)
	gl::DirectCompositionSurfaceWin::Destroy [0x73B2089A+42] (o:\ui\gl\direct_composition_surface_win.cc:406)
	gl::DirectCompositionSurfaceWin::~DirectCompositionSurfaceWin [0x73B1DF75+37] (o:\ui\gl\direct_composition_surface_win.cc:185)
	gl::DirectCompositionSurfaceWin::~DirectCompositionSurfaceWin [0x73B217D5+37] (o:\ui\gl\direct_composition_surface_win.cc:184)
	base::RefCounted<gl::GLSurface,base::DefaultRefCountedTraits<gl::GLSurface> >::DeleteInternal<gl::GLSurface> [0x0137B3B2+50] (o:\base\memory\ref_counted.h:356)
	base::DefaultRefCountedTraits<gl::GLSurface>::Destruct [0x0137B377+23] (o:\base\memory\ref_counted.h:323)
	base::RefCounted<gl::GLSurface,base::DefaultRefCountedTraits<gl::GLSurface> >::Release [0x0137B351+49] (o:\base\memory\ref_counted.h:347)
	scoped_refptr<gl::DirectCompositionSurfaceWin>::Release [0x013BD545+21] (o:\base\memory\scoped_refptr.h:298)
	scoped_refptr<gl::DirectCompositionSurfaceWin>::~scoped_refptr [0x013BD525+37] (o:\base\memory\scoped_refptr.h:210)
	scoped_refptr<gl::DirectCompositionSurfaceWin>::operator= [0x013BD7E8+40] (o:\base\memory\scoped_refptr.h:230)
	scoped_refptr<gl::DirectCompositionSurfaceWin>::operator= [0x013BE275+69] (o:\base\memory\scoped_refptr.h:224)
	gl::`anonymous namespace'::DestroySurface [0x013BE12A+250] (o:\ui\gl\direct_composition_surface_win_unittest.cc:66)
	gl::`anonymous namespace'::DirectCompositionSurfaceTest::TearDown [0x013BBA1F+127] (o:\ui\gl\direct_composition_surface_win_unittest.cc:128)
	gl::`anonymous namespace'::DirectCompositionPixelTest::TearDown [0x013C95A3+67] (o:\ui\gl\direct_composition_surface_win_unittest.cc:602)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0141637B+107] (o:\third_party\googletest\src\googletest\src\gtest.cc:2507)
	testing::Test::Run [0x014162F1+257] (o:\third_party\googletest\src\googletest\src\gtest.cc:2532)
	testing::TestInfo::Run [0x01416DCD+253] (o:\third_party\googletest\src\googletest\src\gtest.cc:2701)
	testing::TestSuite::Run [0x01417A6D+301] (o:\third_party\googletest\src\googletest\src\gtest.cc:2827)
	testing::internal::UnitTestImpl::RunAllTests [0x01421415+1013] (o:\third_party\googletest\src\googletest\src\gtest.cc:5284)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x01420FF0+112] (o:\third_party\googletest\src\googletest\src\gtest.cc:2505)
	testing::UnitTest::Run [0x01420E44+292] (o:\third_party\googletest\src\googletest\src\gtest.cc:4873)
	RUN_ALL_TESTS [0x0172FC3F+15] (o:\third_party\googletest\src\googletest\include\gtest\gtest.h:2453)
	base::TestSuite::Run [0x0172F26F+143] (o:\base\test\test_suite.cc:316)
	base::internal::FunctorTraits<int (base::TestSuite::*)() __attribute__((thiscall)),void>::Invoke<int (base::TestSuite::*)() __attribute__((thiscall)),(anonymous namespace)::GlTestSuite *> [0x013DDCBC+28] (o:\base\bind_internal.h:499)
	base::internal::InvokeHelper<0,int>::MakeItSo<int (base::TestSuite::*)() __attribute__((thiscall)),(anonymous namespace)::GlTestSuite *> [0x013DDC0F+79] (o:\base\bind_internal.h:599)
	base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<(anonymous namespace)::GlTestSuite> >,int ()>::RunImpl<int (base::TestSuite::*)() __attribute__((thiscall)),std::__1:: [0x013DDB65+85] (o:\base\bind_internal.h:672)
	base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)() __attribute__((thiscall)),base::internal::UnretainedWrapper<(anonymous namespace)::GlTestSuite> >,int ()>::RunOnce [0x013DDA14+84] (o:\base\bind_internal.h:641)
	base::OnceCallback<int ()>::Run [0x01737480+80] (o:\base\callback.h:99)
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x01735358+440] (o:\base\test\launcher\unit_test_launcher.cc:158)
	base::LaunchUnitTests [0x01735168+232] (o:\base\test\launcher\unit_test_launcher.cc:354)
	main [0x013DC8CB+171] (o:\ui\gl\test\run_all_unittests.cc:78)
	invoke_main [0x01839F5E+30] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:78)
	__scrt_common_main_seh [0x0183A0C7+343] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
	__scrt_common_main [0x0183A19D+13] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331)
	mainCRTStartup [0x0183A1A8+8] (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x740E8654+36]
	RtlGetAppContainerNamedObjectPath [0x774E4A77+311]
	RtlGetAppContainerNamedObjectPath [0x774E4A47+263]


Original change's description:
> gpu: Sync to primary monitor's vblank (windows)
> 
> DWM composition is limited to primary monitor's refresh rate.  Prior to
> GPU vsync we would use DWM composition rate to drive begin frames.
> 
> With GPU vsync we started using per monitor vblank to limit begin frames
> in case primary monitor had higher refresh rate, but this might be
> causing draw duration and omnibar latency regressions.  MS platform team
> also suggested syncing to primary monitor only.  In any case the correct
> approach would be to further limit begin frames based on event queries
> from 2 frames back.
> 
> This CL makes the GPU vsync begin frames sync to primary monitor, and
> also makes the vsync thread a singleton since it doesn't have per-window
> state any more.
> 
> Bug: 953970
> Change-Id: Id3d3f043cb847172b1d6ba4bd38b087ceb2d8631
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711215
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679832}

TBR=zmo@chromium.org,sunnyps@chromium.org

Change-Id: If4a762325952dd33283bf41a13321e759de51025
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953970
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713510Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679915}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53ed763ca009..e22412aeb9a3


Created with:
  gclient setdep -r src-internal@e22412aeb9a3

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com

Change-Id: I4f1fe72f2b941b34e424330267178eb94a1e4e43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714767Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679914}

The test now includes a back navigation, and validates that the URL is
properly updated.

I found while working on navigation code that I was able to subtly break
the behavior without failing any tests, this closes the gap I found.

Bug: 976697
Change-Id: Ib739b5e2e21665f7877db7d708fbfceaff141d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700057
Commit-Queue: Lowell Manners <lowell@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679913}

After the IdentityManager code restructing into public and internal APIs
was fixed in https://crbug.com/952788, this CL fixes both build
dependencies and presubmit checks in //ios.

TBR=jochen@chromium.org

Bug: 970268
Change-Id: Id51b9a1f69bc8b62d3e66e8f53ed302c69511233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710313
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679912}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/76b75c40a1e2..3855447d93eb


git log 76b75c40a1e2..3855447d93eb --date=short --no-merges --format='%ad %ae %s'
2019-07-22 greg@lunarg.com Bindless Instrument: Make init check depend solely on input_init_enabled (#2753)
2019-07-22 kevin.petit@arm.com Validate storage class OpenCL environment rules for atomics (#2750)
2019-07-22 51214578+jmacnak-nv@users.noreply.github.com Allow LOD ops in compute shaders with derivative group execution modes (#2752)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@3855447d93eb

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng
TBR=radial-bots+chrome-roll@google.com,jmadill@chromium.org,jmadill@google.com

Change-Id: I38e09cd951848e766dcf97800bbb7404f9f09b85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714678Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679911}

This CL introduces IDLs for NFCReadingEvent and NFCReadingEventInit
interfaces, and updates the baseline of relevant wpt tests.
http://w3c.github.io/web-nfc/#dom-nfcreadingevent

The corresponding spec changes were introduced in
https://github.com/w3c/web-nfc/pull/179
https://github.com/w3c/web-nfc/pull/227

BUG=520391

Change-Id: If2090d73ce746208a9e535fe31b6d52a9940d2fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655092
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679910}

This CL implements the StyleCascade, which can take any number of
incoming CSS declarations, prioritize them according to criteria defined
in css-cascade, and apply the output of the cascade to ComputedStyle.

Example:

  const CSSPropertyName& name = ...;
  const CSSValue* value1 = ...;
  const CSSValue* value2 = ...;

  StyleCascade cascade(state);
  cascade.Add(name, value1, Priority(Origin::kAuthor));
  cascade.Add(name, value2, Priority(Origin::kUA));
  cascade.Apply(); // value1 is applied, value2 is ignored.

Brief Overview of the StyleCascade
==================================

The StyleCascade contains a HashMap from CSSPropertyName to
StyleCascade::Value, which represents the current set of cascaded
values. New values can be added to the cascade, using StyleCacade::Add,
and the incoming value will either be accepted (become the new cascaded
value for that property), or rejected, depending on its Priority.

Once all values have been added, a call to StyleResolver::Apply will
resolve dependencies between the values in the cascade (e.g.
var()-references), and apply the final values to the ComputedStyle.

The various parts which together constitute the StyleCascade are:

  --------------------------------------------------------------------
   Value      One Value is stored for each property in the
              StyleCascade's HashMap.
  --------------------------------------------------------------------
   Priority   Each Value contains an inner CSSValue and a Priority.
              The Priority is a composite of origin, importance, tree
              order and 'cascade order'.
  --------------------------------------------------------------------
   Resolver   A stack-allocated object which exists during an Apply
              call. Its main job is to handle cycles in the
              dependencies between cascaded values.
  --------------------------------------------------------------------
   Animator   An object passed to the Apply call which knows how to
              apply values that are undergoing interpolations.
  --------------------------------------------------------------------
   Filter     A kind of secondary cascade required to resolve
              situations where values must be applied in the order of
              appearance because they share the same field on
              ComputedStyle.
  --------------------------------------------------------------------

Each of the above represents an inner class of StyleCascade. Please see
the documentation for each individual class for a more detailed
explanation.

Changes in this CL
==================

(Note that this section is intended as a reference; when reading the
code and find some part of it that you want to learn more about, it
might be explained here).

 * StyleResolver: the application of low-priority properties has been
   separated into a separate function. All functions that begin with
   "Cascade" are new, and represents new code.

 * StyleBuilder: The DCHECK which checks that initial/inherit is not
   applied has been removed. Previously, initial/inherit were *only*
   transported via CSSCustomPropertyDeclaration (hence we never expected
   to see the "real" initial/inherit values here). However, we now
   *also* support applying the real initial/inherit and unset values for
   custom properties. This makes dependency resolution more neat, as we
   can simply apply 'unset' in all cases where something is 'invalid at
   computed-value time' [1].

 * MatchedProperties: This class gained a new 'tree_order' field, in
   order to implement cascading of declarations from different shadow
   trees correctly. See comment for details.

 * CustomProperty: The most important change here is that we now
   absolutize the value during CustomProperty::ApplyValue, like we're
   supposed to. Previously we would use ComputedStyle as a "buffer" for
   unresolved and un-absolutized variables, and then resolve them later
   once all the unresolved variables were added to the ComputedStyle.
   Now, unresolved variables exist in the StyleCascade only, and only
   *final and absolute* values enter ComputedStyle.

   Another change here is the handling of the CSSInvalidVariableValue.
   (This class exists on master already, but was unused). This value is
   applied by the StyleCascade for custom properties that are in a
   cycle. We can not use 'unset' in this case, since applying 'unset'
   means we may get a value from the parent style or the initial style,
   and properties in cycles should not get any value at all.

 * CSSPendingInterpolationValue: This is a "placeholder" value for
   properties with active interpolations. It does not carry the actual
   interpolation, but instead represents an interpolation effect that
   *will* be applied in the future. See comment near 'Animator' in
   style_cascade.cc for details.

 * CSS[VarCycle,]InterpolationType: where we would previously use
   CSSVariableResolver to resolve dependencies, we now use the
   StyleCascade (via CSSInterpolationEnvironment).

 * CSSDefaultInterpolationType: this interpolation type was actually
   missing CSSVariableResolver resolution on master, so the resolution
   via StyleCascade is new. CSSDefaultInterpolationType handles
   "interpolation" between values that can't be interpolated. This
   includes keyframe animations of unregistered custom properties from
   e.g. '--x:var(--y)' to '--x:var(--z)'. We would previously not
   resolve those var()-references in CSSDefaultInterpolationType at all;
   we'd simply apply the value 'var(--y/z)' as-is, with the reference
   unresolved, and then hope that something else would resolve the
   reference in-place on ComputedStyle later. However, since it's no
   longer allowed for custom properties to exist in an unresolved state
   on ComputedStyle (see bullet point for CustomProperty), we must now
   resolve the value here.

 * animation_test_helper.cc is unfortunately doing a "stand-alone" style
   resolution outside the normal code paths, plus a "manual" application
   of ActiveInterpolations on top of that. There is not really anything
   wrong with this, except that it results in some unattractive
   boilerplate code in the form of TestAnimator.

   Interpolations must now be applied through the StyleCascade. In order
   to create a valid CSSInterpolationEnvironment, it needs a reference
   to a StyleCascade::Resolver, and such instances are only created only
   during StyleCascade::Apply calls.

   This is to force the use of a single StyleCascade::Resolver instance,
   which in turn ensures proper cycle detection along the code path that
   can re-enter StyleCascade via StyleAnimator ->
   InvalidatableInterpolation::ApplyStack. (This complicated re-entrant
   behavior was already there with CSSVariableResolver, but we'd
   sometimes use a separate CSSVariableResolver instance, which is error
   prone as each instance has its own cycle detection state).

   Anyway, since EnsureInterpolatedValueCached does not register
   animations in the normal way (see nearby TODO), we can't use
   StyleAnimator to extract the ActiveInterpolations, and hence we need
   the TestAnimator to apply the interpolations.

   There's nothing very wrong there, it's just ... verbose.

 * CSSVariableReferenceValue: The previous DCHECK here is invalid, as
   there is no way for callers to know whether a CSSParserContext is
   present or not. The cascade code path tries to get the context from
   the CSSVariableReferenceValue more eagerly, hence our existing tests
   exercised the DCHECK. (The old code path didn't, accidentally.

   A crash on master was discovered because of this, see issue 986710
   for more information.

Cycle Detection & Reentrancy with Interpolations
================================================

Ideally I would have like to propagate the cycle state as a return value
from the StyleCascase::Resolve functions, however, this is too difficult
to do because of how InvalidatableInterpolation::ApplyStack (itself
called from StyleCacade::Apply via the Animator) re-enters the
StyleCascade via the public StyleCascade::Resolve function. We need to
detect cycles that cross this boundary, hence the cycle state is stored
on the Resolver itself.

See also the issue regarding a const violation that happens in relation
to this reentrancy [6].

Note that this (const violation & reentrancy) is not new behavior;
we do the same thing on master with CSSVariableResolver, and fixing it
is not in scope for this CL, or even the StyleCascade project as a
whole.

Testing
=======

This CL adds a virtual test suite with the prefix virtual/cascade. The
test suite consists of (exactly) 800 tests (at the time of last run).

Note that, at the time of writing, *all* tests are passing (not just
tests in the virtual test suite). However, since I can't add all the
tests to the virtual test suite, I've added a carefully chosen subset.

Note also that the expectations added here are inherited from the main
expectations, and not unique to the CSSCacade feature.

Phase 1
=======

The StyleCascade project has three phases. Two preparatory CLs have
landed previously (addressing the visited-link issue, and removing the
special code for overriding effective zoom on foreignObject). This CL
completes Phase 1.

Phase 1 involves cascading:

 * CSSPropertyPriority::kResolveVariables
 * CSSPropertyPriority::kAnimationPropertyPriority
 * CSSPropertyPriority::kHighPropertyPriority
 * Animation effects for custom properties.

Additionally, this CL uses a separate StyleCascade instance for the
animation effects of standard properties. This was originally not
planned until Phase 3, however it is more convenient to do this right
away, since it then allows us to DCHECK that the CSSVariableResolver
held by CSSInterpolationEnvironment is unused if the CSSCascade feature
is enabled.

Phase 2
=======

Phase 2 involves cascading the remaining CSSPropertyPriority:

 * CSSPropertyPriority::kLowPropertyPriority

In order to do that, we must find a solution to these issues:

 * Eliminate CachedUAStyle, which caches intermediate partial
   ComputedStyle state in order to figure out if the author applied a
   style which would disable default -webkit-appearance behavior.
 * A way to deal with css-logical properties. This will probably be the
   the StyleCascade::Filter introduced in Phase 1, although it would
   need to be ribbonized [3].

Phase 2 also involves:

 * Getting performance to an acceptable level.
 * Enabling the feature.
 * Removing obsolete code paths: (Apply* functions in StyleResolver,
   CSSVariableResolver, and more).

Phase 3
=======

Phase 3 involves having animation effects for standard properties
participate in the main StyleCascade. This is hard, as StyleAdjuster is
standing between the main cascade and the animation cascade.

This phase will fix the bugs regarding cascade order of animation
effects [4] and responsive 'em' units in the base computed style [5].

References
==========

[1] https://drafts.csswg.org/css-variables/#invalid-at-computed-value-time
[2] https://drafts.csswg.org/css-scoping/#shadow-cascading
[3] https://crbug.com/985043
[4] https://crbug.com/552085
[5] https://crbug.com/437689
[6] https://crbug.com/985023

Bug: 947004
Change-Id: I8c3af4859fe176cbe46b5d211a48c7117cd9ef28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605418Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679909}

Bug: 516866
Change-Id: I0dac03563ad4d5e620131f8fa10d337071754313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1240303Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679908}

https://chromium.googlesource.com/catapult.git/+log/8a8a2710f861..0c0d6d8e6b38


git log 8a8a2710f861..0c0d6d8e6b38 --date=short --no-merges --format='%ad %ae %s'
2019-07-23 dberris@chromium.org PinpointScheduler: Post cancellation comments


Created with:
  gclient setdep -r src/third_party/catapult@0c0d6d8e6b38

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:977488
TBR=skyostil@google.com

Change-Id: Ic0db440ac23640f61e94d3941b8a621c9bb67092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679907}

https://webrtc.googlesource.com/src.git/+log/2ac9503910ee..85ef3eab9407


git log 2ac9503910ee..85ef3eab9407 --date=short --no-merges --format='%ad %ae %s'
2019-07-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4bcccabe..54f75614 (679778:679885)


Created with:
  gclient setdep -r src/third_party/webrtc@85ef3eab9407

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I69cb1278cf0b8ae1e0a971f4d30f703941bb245d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714672Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679906}

This histogram was added 4 years back to investigate what was causing
excessive disk writes to the HttpServerProperties cache, and is no
longer needed.

Bug: 904672
Change-Id: I3ee4405bb537e19220558f47f7e646b1f911f2c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707029Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679905}

Currently there is a DCHECK in WebState::~WebState that checks all
ScriptCommandCallbacks are removed by calling
WebState::RemoveScriptCommandCallback. This DCHECK is only useful for
those clients that live shorter than WebState, and for other clients
(mostly tab helpers) this DCHECK is unnecessary.

Here is a doc about this:
https://docs.google.com/document/d/1scLiCVBSE46i_9UrwpF-fyhS13AQqJ0penSu09xuqLw/edit?usp=sharing

Use base::CallbackList for WebState::AddScriptCommandCallback can
make the API contract simpler. Clients that call
WebState::AddScriptCommandCallback need to store the
base::internal::CallbackListBase::Subscription object in their classes.
When the Subscription is destroyed with the class before WebState is
destroyed, it will unregister ScriptCommandCallback automatically, so
the ScriptCommandCallback will not be invoked on destroyed class. If
client class is destroyed after WebState being destroyed, nothing
will happen.

Remove WebState::RemoveScriptCommandCallback as clients can
reset their subscription if they want to stop receiving JS
messages.

Bug: 956516
Change-Id: I62a66f4521a8f4004a8dacc4313bc17b7ef986ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702427
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679904}

They're much better placed there than directly under platform/

Bug: 919385
Change-Id: I8e466604d42b7a3a66025b74cebe35310faae391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713164Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#679903}

This CL adds more constraints to the Web App testing system. Web App
unit tests will now be notified when they attempt to alter subsystems
outside of the correct part of the lifecycle (between construction and
Start()).

This CL now also requires all tests to call Start() on the provider
manually before accessing any WebAppProvider subsystems.

Bug: 973324
Change-Id: I60db6562f0b478fa6ce074014397220488e3f549
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703535
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679902}

The option has been broken for a long time; there is no test coverage
for it, so it has lead to code rot.

Bug: 985725
Change-Id: Ibf16b7a07cb4eebed85cdfe98f72821d4b88b9fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709579Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679901}

https://skia.googlesource.com/skia.git/+log/c76bf2a3b565..fc854c30fb5c


git log c76bf2a3b565..fc854c30fb5c --date=short --no-merges --format='%ad %ae %s'
2019-07-23 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9ec3f51d11d9..02407743bd72 (12 commits)
2019-07-23 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps


Created with:
  gclient setdep -r src/third_party/skia@fc854c30fb5c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:None
TBR=borenet@google.com

Change-Id: Iaa1f1be59b11e67d02979ed1382899c16291e0a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679900}

This fixes `browser_tests --enable-features=AppServiceAsh
--gtest_filter="WebAppUiServiceMigrationBrowserTest.SettingsSystemWebAppMigration"`.
It fails before and passes after this commit.

Note that `browser_tests
--gtest_filter="WebAppUiServiceMigrationBrowserTest.SettingsSystemWebAppMigration"`,
without AppServiceAsh enabled, passes both before and after this commit.

BUG=826982

Change-Id: If924768e8c599c9053d5bf9ae64a9561f828f7b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708691Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679899}

GcmApiTest.* tests are failing at
HeaderModificationDelegateOnUIThreadImpl::ProcessRequest when
NavigationLoaderOnUI is enabled.

Bug: 978617
Change-Id: Ie483c0b392a4c706848dbbcb14726b31c82f8e72
TBR: kinuko
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714392Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679898}

Implement CountQueuingStrategy and ByteLengthQueuingStrategy in C++.

Implementing in WebIDL leads to some changes in semantics:

1. highWaterMark is now a getter on the prototype rather than an
property on each object. This is because adding properties directly on
objects is not usual practice in WebIDL, and is problematic to implement
in Blink.

2. size() is now a function returned by a getter. This is because a
methods in WebIDL must be called with |this| set to a valid object of
the appropriate type, but size() is called with |this| set to undefined.
See https://github.com/whatwg/streams/issues/1005 for more discussion.

These aren't expected to change behaviour of code in the wild, but the
count-queuing-strategy.any.js and byte-length-queuing-strategy.js
tests detect it.

Also add tests that subclassing of CountQueuingStrategy and
ByteLengthQueuingStrategyworks works properly. A previous iteration
of this change broke it.

Bug: 981333
Change-Id: Ifc18a469a58f73d54563ca549a1c8db0e001303b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692108Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679897}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f680135e592..53ed763ca009


Created with:
  gclient setdep -r src-internal@53ed763ca009

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=tinazwang@google.com,horo@google.com,yigu@google.com

Change-Id: Ic42a7c63ab8a095c297574223dbac353a327540c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714115Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679896}

The corresponding spec changes were introduced in:
https://github.com/w3c/web-nfc/pull/240

BUG=520391

Change-Id: I50ff37d69ef1e79c32682493d3133f639226aac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684664
Commit-Queue: Leon Han <leon.han@intel.com>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679895}

https://chromium.googlesource.com/catapult.git/+log/1855bc3168ee..8a8a2710f861


git log 1855bc3168ee..8a8a2710f861 --date=short --no-merges --format='%ad %ae %s'
2019-07-23 dberris@chromium.org PinpointScheduler: Tighten cancellation semantics
2019-07-23 crouleau@chromium.org Revert "[Telemetry] Upload detailed os version string as histogram diagnostic."


Created with:
  gclient setdep -r src/third_party/catapult@8a8a2710f861

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:977488,chromium:980256
TBR=zhanliang@google.com

Change-Id: I94811d0c7b4828237a4b82ca736f8f67607459cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714116Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679894}

This reverts commit 2a1633d4.

Reason for revert: Short-lived observer may unregister during dispatch on observers causing UB.

Original change's description:
> heap: Provide one implementation of HeapObserver
> 
> Implement HeapObserver in terms of ThreadHeapStatsObserver and adjust its
> usages.
> 
> Bug: 982754
> Change-Id: I41295d24b0039edaf33722d463d152f2d3576460
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712567
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679577}

TBR=haraken@chromium.org,mlippautz@chromium.org

Change-Id: I0f1b7efaf1c86752d0b08b5d267dfedf45e9faa2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 982754, 986395, 986619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713626Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679893}

CL:1617041 made removable volume tree row labels and the .eject button
position: absolute, using left: 52px; for the label, and right: 0; for
the button. This assumed LTR rendering: neither could possibly work in
RTL rendering (bug) and Files app is an LTR/RTL aware app.

Fix this: since these label and button are position: absolute; set the
left: _and_ right: values to the same value. Provided the value is not
0, and there is no auto margin, then correct rendering in both LTR and
RTL results [1].

Note: directory-tree CSS rules in file_manager.css are specific to the
#directory-tree and generally never use the element type in a rule. So
the CSS rules added CL:1617041 did not conform to that scheme - change
them back so they match the scheme.

No change in behavior, no new tests. I manually tested that the button
scroll behavior documented in crbug.com/979162#c25, is the same before
and after this CL.

[1]: https://developer.mozilla.org/en-US/docs/Web/CSS/left

Bug: 979162
Change-Id: I7fa435d31da7d15364551072ac2527c0056102aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714391Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679892}

https://webrtc.googlesource.com/src.git/+log/8fcf354fa1c8..2ac9503910ee


git log 8fcf354fa1c8..2ac9503910ee --date=short --no-merges --format='%ad %ae %s'
2019-07-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 753411f0..4bcccabe (679672:679778)
2019-07-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 868676c2..753411f0 (679562:679672)


Created with:
  gclient setdep -r src/third_party/webrtc@2ac9503910ee

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia7d92b66fa5aab266fff1c806de633dca90c5eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679891}

The header is included in headless/public/headless_browser.cc line 10.

Change-Id: I13ddbae35def6c6876433ed0b2ba049ebe485f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713282
Auto-Submit: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679890}

Bug: 986688
Change-Id: I8f669c43120fea64dc7b856934e4f2e3198b998d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712954Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679889}

This CL switches following builders.
- chromeos-amd64-generic-asan-rel (CI)
- chromeos-arm-generic-rel (CI)
- linux-blink-heap-concurrent-marking-tsan-rel (CI/CQ)

Bug: 954450
Change-Id: I993d0d8b14d5dacc4e96906b55b1ead698cf34ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710895Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679888}

https://skia.googlesource.com/skia.git/+log/8a5759d99021..c76bf2a3b565


git log 8a5759d99021..c76bf2a3b565 --date=short --no-merges --format='%ad %ae %s'
2019-07-23 csmartdalton@google.com Revert "ccpr: Unblacklist Radeon in MSAA mode"


Created with:
  gclient setdep -r src/third_party/skia@c76bf2a3b565

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@google.com

Change-Id: I76aa3a3cfb7d09d14d8c5802b136ccd4d08b385c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714353Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679887}

Add default values of throttled hashes if one is not
provided using finch config. This makes it easier to
test using command line (without having to muck
with params using command line).

The list matches the one currently in use in the finch config.

Change-Id: I9ae3d4b107233f214297dc265366f19138ad603d
Bug: 913424
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711216Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679886}

This reverts commit 38b443b6.

Reason for revert: Build failures on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf, etc.

Original change's description:
> ProGuard: Move -checkdiscard for Log.* into @RemovableInRelease annotation
> 
> Strictly a refecator to cut down on number of explicit rules.
> 
> Change-Id: I3afad5ccd63d2347c69343df15014118780f512e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711978
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Sam Maier <smaier@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679849}

TBR=agrieve@chromium.org,smaier@chromium.org,crouleau@chromium.org
Bug: 986693

Change-Id: I8a9849ff22206f4d4b320a25c47426980ee8a15c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714217Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679885}

https://chromium.googlesource.com/catapult.git/+log/a71ec4632a12..1855bc3168ee


git log a71ec4632a12..1855bc3168ee --date=short --no-merges --format='%ad %ae %s'
2019-07-23 dberris@chromium.org PinpointScheduler: Add a job cancellation dialog
2019-07-23 perezju@chromium.org [Telemetry] Remove references to CreateTimelineBasedMeasurementOptions
2019-07-23 dberris@chromium.org PinpointScheduler: Link to jobs in queue


Created with:
  gclient setdep -r src/third_party/catapult@1855bc3168ee

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:977488,chromium:921000,chromium:977488
TBR=zhanliang@google.com

Change-Id: I0684d95a924cb674c16255eebad781b1b7d1202a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679884}

Bug: 986666
Change-Id: I0d45131ea62877e45b3151cf07d58c18f859282e
Notry: true
Tbr: nhiroki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713150Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679883}

BUG=chromium:984442

Cq-Depend: chromium:1702346
Change-Id: Ifb96c0a69d5b1612445ae0f02e866bf466bf4643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703688
Commit-Queue: Julian Watson <juwa@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#679882}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b451020e5f76..1f680135e592


Created with:
  gclient setdep -r src-internal@1f680135e592

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=tinazwang@google.com,horo@google.com,yigu@google.com

Change-Id: I4577f3d3d13bd2baa6bd68d58d55721c3ef6f0e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714352Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#679881}

GTURN is no longer supported in M77 hosts and clients. This CL removes
some dead code I found that handles GTURN candidates.

Bug: 983282
Change-Id: I99d2b180ef000d5676df4db7865d4b2cfe9da407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710087
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679880}

Bug: N/A
Change-Id: I0e9d9a5c757e1c0615d62871c9424030fd62e44f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714388
Auto-Submit: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679879}

Buildbot is being turned down but is not fully dead yet.

Bug: 986488
Change-Id: Ibc44a0ebfe82d5f2949ddf7f62de4eefe778617c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713869
Commit-Queue: Erik Chen <erikchen@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679878}

BUG=866622

Change-Id: I8cb848db6547e3095a10fd9b63fbda5006707d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712042
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679877}