- 11 Nov, 2020 40 commits
-
-
Ian Kilpatrick authored
Due to a HTML specification change, the default UA stylesheet for modal dialog elements has changed: https://github.com/whatwg/html/pull/5936/files https://chromium.googlesource.com/chromium/src/+/be7281e188f22856bf9084d9f5c74a0f48eee1da Specifically for this bug - position:fixed and position:absolute have slightly different behviour when printing. This switches the internal <dialog> element back to position:absolute. Bug: 1147394 Change-Id: I8a41ef869cd6a17db0c79ba42ca3d5a5eb247d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531215Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#826116}
-
Jeremie Boulic authored
This reverts commit 17c5fc75. Reason for revert: Due to a mistake when rebasing, 2 CLs were submitted at the same time. Relanding those 2 CLs properly. Original change's description: > Audio player: Convert dependencies in //ui/file_manager/image_loader/ > > In //ui/file_manager/image_loader: > - load_image_request.js > - image_loader_client.js > - image_loader_client_unittest.js > > Bug: 1133186 > Change-Id: If1fa276446e2ae5a8763ca1a9bb728cb0c7ce2b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529649 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826095} TBR=lucmult@chromium.org,jboulic@chromium.org Change-Id: I11e659413196563811d843635a829d0b1a642b2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531438Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826115}
-
Sammie Quon authored
Only for tablet mode. Like other capture mode entries, not available for login/lock/oobe. Bug: 948120 Test: manual Change-Id: I37ece1da0a48268507907fed4a713d2c4fb882fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530980 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826114}
-
Aleks Totic authored
LayoutTableSectionInterface::PrimaryCellAt was no longer used, and was removed. Bug: 958381 Change-Id: I53ca91c87db0025d077c969e75d1c66a53aa6e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528829 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826113}
-
Dana Fried authored
CTRL+RIGHT with keyboard focus on a tab will now always move the current tab right, and CTRL+LEFT will move it left. Likewise, CTRL+SHIFT+RIGHT will always move the current tab to the right end of the tabstrip, and CTRL+SHIFT+LEFT will move to the left end. Prelude to fixing the attached bug. Bug: 1110426 Change-Id: Ib29d539db982b9b970ea192ca9edb13b18ca7d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528179Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#826112}
-
Moe Ahmadi authored
- takes 4px off the top padding of the tile and gives it to the bottom padding. - takes 4px off the top margin of the title pill and gives it to the top/bottom padding of the title pill. before: screenshot/4aAFKmpkL76Qjam after: screenshot/8MXKqLJgqyFSxz7 Fixed: 1147217 Change-Id: I59fcfa419c725b5c2f7ddbfefda6d233595494e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530202 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826111}
-
Tommy Li authored
In 2015, we ran an experiment called KeywordRequiresPrefixMatch = false, where we experimented with a query "wikipedia.org" being able to trigger the "en.wikipedia.org" keyword mode search engine. This experiment has been dormant since then. The TemplateURLService has a reasonably extensive amount of infrastructure to support the non-prefix matches to domain name, and this CL removes that. We are removing this to simplify the code and unblock a larger issue where we are trying to solve Sync conflicts and duplicate search engine proliferation, e.g. "amazon.com" => "amazon.com_" duplicates. Bug: 1022775 Change-Id: I9cc92f06c2fe955ddc655bdef23955ab33418faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523726 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#826110}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4f4226d153e..cf49cb8206ba 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Owners-Override is +1 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Bot-Review is +1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093627 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia73086dd8f57646d67b704f31d921597d821440f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530225Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826109}
-
Yi Zhang authored
//chrome/browser/devtools/ This CL is the 2nd part of converting base::Bind to Once/Repeating in //chrome/browser/devtools/ Bug: 1007635 Change-Id: I1c9db10b9e93ac5f57e6da8c3714367e5da33709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525900Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#826108}
-
Peter Boström authored
Replaces GridLayout with BoxLayout. This will allow dynamically adding and removing fields. Between-child spacing and dialog margins are dynamically updated using kMarginsKey as fields are added. This is tested by resolving a TODO to use OnFieldAdded() repeatedly in AddInitialFields(), which also paves the way for dynamically adding fields. Bug: 1106422 Change-Id: I7111978cbb55546802e61709833ca6cfbe38a0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518777Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#826107}
-
Takuto Ikuta authored
use_debug_fission=false doesn't split debug info. Change-Id: Ib8def944dfcea1345f41284e9d125c082071848c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526826Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#826106}
-
Bartek Nowierski authored
Until now, the functionality of requesting pages that are committed and PageInaccessible existed only on Windows. |AllocPages(..., PageInaccessible, ..., true)| led to |VirtualAlloc(..., MEM_RESERVE|MEM_COMMIT, PAGE_NOACCESS)| which would allocate memory charges without really backing virtual address space with physical pages. https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualalloc This is inconsistent with |base::SetSystemPagesAccess| where |PageInaccessible| always leads to |VirtualFree(..., MEM_DECOMMIT)| Outside of unit tests, |AllocPages(..., PageInaccessible, ..., true)| was used only in a couple places in code, likely accidentally. Change-Id: I657787b4785e889984c5895518e9abbc26b50a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522934Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826105}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/434681c2378b..c80cb7a957ea 2020-11-11 johnchen@chromium.org [Telemetry] Update doc about running on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I8add9eedb7400bed89c5f2a09b6fb8b90286c872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531234Reviewed-by:
-
David Black authored
Moving forward, the logic of when the holding space tray is visible will be updated such that we need to handle the case where the tray is shown but no previews are available. Bug: 1142572 Change-Id: Ifae93a7506f3b8a6ce26d3210b9804b2ebf33d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531061Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#826103}
-
Hajime Hoshi authored
It is fine to ignore the presence of WebGL usage when putting a page to BFcache. Memory consumption is the only concern, but the memory eviction (context lost) should work in the same way as regular background pages. Bug: 1146922 Change-Id: I06e041aab8aaf235a6f6115a31f5bf325d8bfae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525469Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826102}
-
Zhenyao Mo authored
for DirectCompositionForceFullDamage This is because if we check finch first, then a user is assigned to a finch group, say, Enabled, but they could end up not getting this optimization if their device doesn't support BGRA overlays. If we check cap first, we make sure every user in the finch groups have BGRA overlays. (I just learned this yesterday.) BUG=1117185 TEST=bots R=sunnyps@chromium.org Change-Id: I366518548f28bac3c744f50ef94f95f553809cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530177 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826101}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit crbug.com/1147680. Reason for revert: <INSERT REASONING HERE> Original change's description: > LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) > > The change is mostly mechanical replacing defined(OS_CHROMEOS) with > BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash > with some special cases (For those cases please refer to > http://go/lacros-macros). > > The patch is made in preparation to switching lacros build from > target_os=linux to target_os=chromeos. This will prevent lacros from > changing behaviour after the switch. > > Bug: 1052397 > Change-Id: I95c93df05b77c03b3686d7bd9430dfde74229761 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461547 > Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825716} TBR=ajwong@chromium.org,wez@chromium.org,thakis@chromium.org,hidehiko@chromium.org,ythjkt@chromium.org Change-Id: I73ddc678f970b05f1805fc728f6ceb6169cc2c71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052397, 1147680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530958Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826100}
-
Yuichiro Hanada authored
It's used only by arc::ArcSessionManager. Change-Id: I2bc0844ed29c12571f21cd8bc67e3ac81e3bd62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531153Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#826099}
-
David Roger authored
Bug: 1076880, 1147433 Change-Id: I3cb974e6ebde1cd0c37a9e462092dd5d6f4ef313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523185 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826098}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dbcdc10..82f6a0e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie278b7b1edfa19de7a20f0929694c2cddab1b773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531173Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826097}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605030922-18cb72684b061f022a5308434494a6442ca4475e.profdata to chrome-linux-master-1605052680-ed4774a484c0c8ad9370f02f991851fc9df93a6f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia4fc0dd39107c2cdc54fd85317f506c5dab13673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530622Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/image_loader: - load_image_request.js - image_loader_client.js - image_loader_client_unittest.js Bug: 1133186 Change-Id: If1fa276446e2ae5a8763ca1a9bb728cb0c7ce2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529649 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#826095}
-
Dana Fried authored
Follow up to followup: https://chromium-review.googlesource.com/c/chromium/src/+/2503407 Potential concerns: Non-top-level widgets will not inherit their parents' settings. However, as far as I can tell all surfaces which use this feature are in fact top-level widgets (they'd have to be in fact, because the previous version of this functionality would not have worked otherwise) and most subordinate widgets are e.g. menus which already support arrow key navigation by default. I will definitely test on Ash before submitting however. Change-Id: I80c6fe6d8c351ba94d22a8029c5f46d2249b0f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508182Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#826094}
-
Ben Goldberger authored
Bug: 1146184 Change-Id: Icd0eaf6c465898bab3e4aa35df74fc40ffccb0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521235 Commit-Queue: Ben Goldberger <benwgold@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#826093}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Icd7219097be6efd1113aace8dfd2e80adfcb7dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530180Reviewed-by:
-
danakj authored
This converts to using the skia::mojom::Bitmap serialize functions to turn an SkBitmap into a string and back for putting into a base::Value and sending over IPC. This is a reland as the original CL would fail to serialize correctly for large bitmaps, due to Bitmap mojoms trying to use a shared memory handle, which does not encode/decode correctly as a string. Switched to using InlineBitmap which will always serialize to bytes in the string itself, and added a unit test for this. Also a bonus browser test for the setIcon path from the extension process. R=reillyg@chromium.org TBR=senorblanco@chromium.org Bug: 1144462 Change-Id: Idc2cfb0d70335557464be2abdeaa0bad11d38e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527518 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#826091}
-
Josh Simmons authored
The button will launch an Assistant voice search if OmniboxAssistantVoiceSearch is enabled and will fall back to a normal voice search otherwise. This button is gated by the VoiceButtonInTopToolbar Feature and is disabled by default. This work is based on the Share optional button, which will take precedence if both Features are enabled. Design doc: https://docs.google.com/document/d/1dmsDrpBRn_zfWKCmme0UWaz2I4zB2dNGx5ypVz468tY/edit Bug: 1140581 Change-Id: I8ab918c91d7333597214ff7fdbeebfdadccda76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496031Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#826090}
-
Michael Hansen authored
Removes calls to SetAdvertisingInterval() from NearbySharingServiceImpl to prevent a Bluez crash on certain devices. We will eventually want to restore this functionality by waiting on the asynchronous calllbacks, or use a new API mentioned in the bug which allows setting the interval on a per-advertisement basis. Fixed: b:171154876 Change-Id: I358e9b754ba0f63c4fa294a9d701701a5f6cd363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530592 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#826089}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1605030922-b2dd02f147eae1531539bc87edf6753129e66078.profdata to chrome-mac-master-1605052680-4bcc95392c674b4241fea3539716bd9698469487.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11eaffc259568e2cb7c57f5e90dc711f658f5afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530224Reviewed-by:
-
Toni Barzic authored
The home_launcher_transition_state is used to determine target home launcher visibility during transitions from/to home launcher UI. Current usages of the public getter do not really care about home launcher transition state - they use it to infere target app list visibiltiy. The same information can be retrieved using AppListControllerImpl::GetTargetVisibility() in a cleaner way, that also covers wider set of transitions. BUG=None Change-Id: I3b00f24762dc0be2791fd08a6e51ec0cd192dd41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523698Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826087}
-
Jarryd authored
This change uses an if statement instead of a DCHECK to handle cases where ExecutionContext is null. There is already a web platform test meant to catch this case, but the test only fails flakily. A clusterfuzz check would also fail flakily. This change should remedy the failures in each. related test: third_party/blink/web_tests/external/wpt/storage/quotachange-in-detached-iframe.tentative.https.html Bug: 1144626 Change-Id: I5089fffae4bb438e6d9619792c952c73888010a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529615 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826086}
-
Yuheng Huang authored
Bug: 1147412, 1099917 Change-Id: I121bd2ac5b0377e74e717bfecdf97884e217ac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527533Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#826085}
-
Noel Gordon authored
Files app SWA main.js will set window.isSWA true when running FilesApp in a C++ SWA container. Closure define the window.isSWA property. Bug: 1113981 Change-Id: Ibe0253c83fc91661a837e88087b51cd55c997125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531077Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/7b750dc7337d..dbcc1e0e804e 2020-11-10 rharrison@chromium.org [inspector] Extract Sampled Texture data 2020-11-10 dsinclair@chromium.org [hlsl-writer] Emit texture types 2020-11-10 dsinclair@chromium.org [spirv-writer] Hash names 2020-11-09 bclayton@google.com wsgl parser: Have Expect & Maybe operator-> deref 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Maybe<T> 2020-11-09 bclayton@google.com wsgl parser: Add ParserImpl::Expect<T> 2020-11-09 bclayton@google.com wsgl parser: Migrate more code to use expect & match 2020-11-09 bclayton@google.com wsgl parser: expect for storage_class 2020-11-09 bclayton@google.com wsgl parser: expect for variable_ident_decl 2020-11-09 sarahmashay@google.com [validation] relax rule v-0002: return is mandatory for non-void functions 2020-11-09 bclayton@google.com wsgl parser: Remove pointless nullptr checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sarahmashay@google.com Change-Id: Ie9c4ae8f0af8baacbe90d08aaba4e9cac233a22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530974Reviewed-by:
-
Noel Gordon authored
Move files app feature strings to AddFileManagerFeatureStrings() which lives in the same file as GetFileManagerStrings(). This so Files app SWA, which has no chrome extension context, can also call it to populate its load time data with files app strings. No change in behavior. Bug: 1113981 Tbr: Bo Change-Id: Ia87bc8808bd1d7e50431b8529c27831e7de02770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526866 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/008d63e23dab..1fe2b80dc782 2020-11-10 michaelludwig@google.com Revert "Reland "Draw image filters directly under non-axis-aligned transforms"" 2020-11-10 reed@google.com Recompute the last-move-to inside addPath() 2020-11-10 tdenniston@google.com [svg] Use new parsing for gradient classes 2020-11-10 michaelludwig@google.com Reland "Draw image filters directly under non-axis-aligned transforms" 2020-11-10 robertphillips@google.com Fix UMR (valgrind) bug in GrDrawingManager 2020-11-10 mtklein@google.com use SkFourByteTag to squelch warnings 2020-11-10 johnstiles@google.com Fix flipped array dimensions in SkSL. 2020-11-10 robertphillips@google.com Disable both preservefillrule _big and _little for the *ooprddl configs 2020-11-10 herb@google.com cull glyphs that have far out positions - try #2 2020-11-10 johnstiles@google.com Limit struct nesting depth to a maximum of eight levels. 2020-11-10 johnstiles@google.com Limit arrays to a maximum of eight dimensions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1134474 Tbr: jlavrova@google.com Change-Id: I49341ea87d3e31da8e91d8b03f7328b963198677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530247Reviewed-by:
-
Xida Chen authored
This is a reland of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1944633 The problem of the above CL was that it incorrectly handles sticky position offset in non-ltr containers. This CL added a virtual test case for FractionalScrollOffsets flag to have more test coverages. Bug: 1010961a Change-Id: Ic51a1e812372ee97f4d5bc8a503d3be5bd282b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528572 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826080}
-
Aaron Colwell authored
Moving the Run() logic from MessagePumpUI into the MessagePumpForUIStub because it is the only class that actually uses it. Added a CHECK as the MessagePumpUI::Run() implementation since this function should never be called in production code. Run() implementations must be nestable and the implementation in MessagePumpUI is not safe to nest because the looper code is not reentrant safe. This change simply makes this more explicit and helps prevent accidental misuse. Change-Id: I36e1891abd8b1aa107b0e4264f4a3952a17819c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527601 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#826079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5aa93984e043..15391ed19263 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com,yuzhehan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645,chromium:1134178,chromium:1142017,chromium:1145287,chromium:1147364,chromium:912681 Tbr: yoichio@google.com,yuzhehan@google.com Change-Id: I08c73ee0d8fc9aa69f11a9261f48c6b3eecc0466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530188Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826078}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4643cf651889..09ecef60e829 2020-11-10 vmiklos@collabora.co.uk Add FPDFAnnot_GetVertices() API 2020-11-10 tsepez@chromium.org Replace CFXJSE_FormCaclContext static methods. 2020-11-09 tsepez@chromium.org Simplify CFXJSE_Engine::RemoveBuiltInObjs() 2020-11-09 nigi@chromium.org Enable FPDFAnnotEmbedderTest.BUG_1206 for Skia/SkiaPaths. 2020-11-09 nigi@chromium.org Add method CFX_WindowsRenderDevice::DebugVerifyBitmapIsPreMultiplied(). 2020-11-09 tsepez@chromium.org Return v8::Local<> from CFXJSE_Context::GetGlobalContext() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: If0385329917b815ca6cb047f6e364242fdea4912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530615Reviewed-by:
-
