- 05 Sep, 2020 23 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599268416-e9e5e521103b7f619801137d1d698f8d2cc8207a.profdata to chrome-win32-master-1599309595-ae97a4aff55df83107c138cc410c0c87680bf195.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I047e0ba8284e669969f5e940ef88948ab113f05f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6349d6f5495c..80c7c539fdd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia5a7b990bfb0e0d72eeb92681dbb21174e9d640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804608}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f005191db5ba..50704dc30951 2020-09-05 lehoangq@gmail.com Metal: Implement EXT_occlusion_query_boolean. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I6e170364fe5f5cbc3562185c54240ab9ebe047e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394226Reviewed-by:
-
Jose Dapena Paz authored
../../chrome/common/qr_code_generator/qr_code_generator.cc: In member function ‘unsigned int QRCodeGenerator::CountPenaltyPoints() const’: ../../chrome/common/qr_code_generator/qr_code_generator.cc:977:40: error: ‘floor’ was not declared in this scope 977 | penalty += 5 * static_cast<unsigned>(floor(deviation)); | ^~~~~ Bug: 957519 Change-Id: Ibf428161deeea35111edcbc9085459ec4966a50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394160 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#804606}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599198987-f51a65ad37e561beab550a72f46d734c30300605.profdata to chrome-win64-master-1599300422-2c2fc1b392c9713a3c01669b8f8bed908ec60b03.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie6b6737a6a63980c313fe98a5b180ad3c66ab656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394225Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599282836-e6293831dfeb6cd81bb29f56ab04e461de37f447.profdata to chrome-mac-master-1599300422-cd7adf1e6566364068197983fd37641733b0e03c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I36e3e27dc78878495f1864844ae3ec37165f0355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394224Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3c6b8af7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I3ee9332a2ebcae2cfa382ae5317e97ebbdd0577a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394068Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804603}
-
James Hollyer authored
The Geolocation Bubble is a SimpleBubbleModel which sets a message. When asking for System Location permission there is no message. Therefore I set up a simple way to clear the message and cleared it when needed. Bug: 1051591 Change-Id: Idcfe468a5a49b961da25741550aab7f350da0586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393522Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804602}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009040800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/xGtAyO3MHh3FTI42sQnyAcjnTN8GyCxFOE1Y7ysQ0NkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Id6311159081cab1cb88a1a11bf975ca18dcc77cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393708Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599238768-890631f1cae9605b1ad1e7550117ecfa0ab467fc.profdata to chrome-win32-master-1599268416-e9e5e521103b7f619801137d1d698f8d2cc8207a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9efecb7e5300462a29dcb1f35d9cdb314d881984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394216Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1124161 Change-Id: I436e37dd4c40ef60558bdbdf01cd72977ecd99db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389640 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#804599}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/87fb11b83d04..fe00a9e9cf53 2020-09-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79f57c5ec506794f080d7e654500ed1d444e6113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394217Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599198987-d991dddb2c00d3ed866518be68c89430502fa377.profdata to chrome-mac-master-1599282836-e6293831dfeb6cd81bb29f56ab04e461de37f447.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3df453c2d60c4eef33cdb464e720ed15438c9757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394219Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f6ea6dd..ef9e56c6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I601c00d65e35a6a58a8acd65571ea3b9b66ec86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394064Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804596}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/77ed48ad2159..87fb11b83d04 2020-09-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ide5b74d896d69a83eb7b15898553968b52581341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394095Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts PrintHostMsg_AccessibilityTree message to SetAccessibilityTree() in mojom::PrintManagerHost. Bug: 1008939 Change-Id: I8f21acd96b472da4e7312805ed7fd51f44162405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377666 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#804594}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I6b6f9f86f92aaec6a6869f6901e24314d43a1870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393630Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804593}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd27c491a3e5..6349d6f5495c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iaff65ae082cee3898c81041bf7158fe0793efc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393848Reviewed-by:
-
Gyuyoung Kim authored
crrev.com/c/2259537 made ChromeWebUINavigationBrowserTest use RenderFrameHostImpl directly for testing instead of using the existing content::PwnMessageHelper::OpenURL(). But, it's a layer violation. So this CL restores OpenURL() in content::PwnMessageHelper in browser_test_utils.h again, then makes it use content::PwnMessageHelper::OpenURL() to fix the layer violation. Additionally, all test methods of PwnMessageHelper start to use Mojo methods instead of IPC method. So, this CL updates the comments properly. Bug: 1093920 Change-Id: I8608cb7bc5a3e84628c741020ed2515d28445e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387541Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599233269-ad0a59aeec97d7e67c694f68778391acd96b7ff1.profdata to chrome-win32-master-1599238768-890631f1cae9605b1ad1e7550117ecfa0ab467fc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I4ace1d1627bac3ad49b7a6049d374378b095d139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393845Reviewed-by:
-
Andres Pico authored
This cl adds the capability to prevent the premature uninitialization of the COM library in ScopedCOMInitializer. Premature uninitialization usually occurs in the presence of unbalanced CoInitialize/CoUnitialize pairs. While we can prevent this from ocurring in first party-code, there is no mechanism that protects us when executing third-party code in a COM enabled thread such as in the case of the Quarantine process. Bug: 1075487 Change-Id: Ibb3cf304c6bbabc126867de47e963a52c9409248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378270Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Andres Pico <anpico@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804589}
-
Hoch Hochkeppel authored
Adding a class to represent the Windows DataTransferManager APIs within tests, as well as basic unit tests to validate the test class behaviors. Bug: 1035527 Change-Id: Id0fcc1c1f98abfa74648e459dc420ca9aad4fecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392443Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804588}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 69317269. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0c51c566e3aa5a9bd6b6e0078357c83c4881ebd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392971Reviewed-by:
-
- 04 Sep, 2020 17 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/428383edfcf2..cd27c491a3e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1124945,chromium:912681 Tbr: Change-Id: Ie4f899bdb93628e4b53faffad652249dcfc93b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393842Reviewed-by:
-
Alison Maher authored
As resolved by the CSSWG [1], we should respect system color rules set by the author/user in Forced Colors Mode. This CL is the first of several changes to make this happen. Currently, in order to force colors in Forced Colors Mode, we revert the related properties at the author origin. This logic is now removed from the spec [2]. To accommodate the above changes, the plan is to simulate a revert at the end of the cascade, but only if the computed value for a given property is not already a system color and forced-color-adjust is set to auto. This CL moves the forced background-color logic from StyleAdjuster to StyleCascade to allow for easy access to the forced color rules (as defined in forced_colors.css). Since we are moving the adjustment of background-color to StyleCascade, we no longer need the -internal-forced-background-color-rgb property. As such, this CL also removes the code that was added to support this internal property [3]. [1] https://github.com/w3c/csswg-drafts/issues/4178 [2] https://github.com/w3c/csswg-drafts/commit/7c154ddc7f196df9b40a34a5f63bf6d157b1011b [3] https://chromium-review.googlesource.com/c/chromium/src/+/2189974 Bug: 970285 Change-Id: Ic91a009a380820b41b355770acbe4de57c0787ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376666Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804585}
-
Christopher Cameron authored
This relates to the following two classes used when capturing content on macOS: - AVCaptureDevice which does the actual capturing from the device into IOSurfaces - AVCaptureVideoDataOutput takes those IOSurfaces and wrangles them into CMSampleBuffers that are handed to us Bug 1: Not telling AVCaptureDevice our preferences When Chrome wants a specific (width, height, framerate) combination, we request that, along with a pixel format, to AVCaptureVideoDataOutput. While we indicate our preferences to our AVCaptureVideoDataOutput, we do not indicate them to our AVCaptureDevice. As a result, the AVCaptureDevice will often have a completely different format that it's using, and the aforementioned "wrangling" will involve a format conversion and maybe even some downsampling(!). In bad cases, this can burn 10% of a CPU core on its own (fortunately bad cases are rare). Bug 2: Using an unsupported pixel format We currently prefer "422YpCbCr8" aka "UYVY" aka "2vuy", and request it regardless of whether or not it is supported by the capture. Most devices don't actually support it, and so the wrangling starts up again. The fix for these bugs is to trawl through the list of supported pixel formats to find the one that best matches the requested format, and then specify this to our AVCaptureDevice when we start capture. Do this by adding a FindBestCaptureFormat to do the trawling. Also don't prefer the "422YpCbCr8" aka "UYVY" aka "2vuy" format above supported formats. The consequence of this is that many Facetime cameras will now be outputting "422YpCbCr8_yuvs" aka "YUY2" aka "yuvs", and will hopefully use less CPU. When we do get an exact match between input and output, we also gain access to the IOSurface that the camera's data is being thrown into. This could allow a zero copy path all the way through to the compositor. Eventually. Bug: 1124884 Change-Id: I33b4b62e152ba9f3b2be04dc3a5f3084d6ee9438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391767 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#804584}
-
Avi Drissman authored
1. Creating a CFDictionary with null callbacks is almost certainly not something you want to do. It is not bridgeable with NSDictionary, and the normal semantics of retain/release do not apply. It is *unsafe* to put autoreleased items into such a dictionary. There is no guarantee that the items won't be deallocated out from underneath the dictionary. 2. CFDictionarySetValue does *not* take ownership. No matter if the dictionary has retain/release semantics or not, assuming ownership takeover will leak. Bug: none Change-Id: I6e3cae093e61ab2a42af7b0052231d00fa4a71b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391208Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 00883a56. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ib0abe0367340a2833a1b59e874967e133949f6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392967Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599213075-8de6fbfad2c0ba88366e24b5675f87337bc4120e.profdata to chrome-win32-master-1599233269-ad0a59aeec97d7e67c694f68778391acd96b7ff1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I1821defcb40ae21128a54960da985dc0fecbcfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393714Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5966c3d2..2f6ea6dd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1723aefc1f85a75cda50f578953ce3c6cfeb61c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392965Reviewed-by:
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: I8d7fee0a71ab8d167c0a525d91be4c8be60779d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392754Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#804579}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ada084561668..428383edfcf2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1124945 Tbr: Change-Id: I408ff3f4003977c83bf74c6184db82cc42c8d72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393711Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If677f2f7df5ee6e0f3f6c9d7b7c9f32ec5709d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393777Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#804577}
-
Evan Stade authored
Bug: 1016938 Change-Id: I4e259c8782382305d38834a68f5225b92d28ec2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386835 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804576}
-
Michael Checo authored
• Wait for printers to load before rendering nearby/add printer sections. Bug:1108294 Test:manual inspection Change-Id: I098fcc5307993c14866bcadab81096ea09dbd041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364189 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#804575}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7f7d543. With Chromium commits locally applied on WPT: b7f7d543 "[mathml] Fix dictionary category for unknown operators with explicit form" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I5a0dad383bc9a5af7e19d4990426307e1cd9b59f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392962Reviewed-by:
-
Henrique Ferreiro authored
The referrer policy is only used when dragging a link out of the WebView results in a download. This is handled on Windows when the mime type is 'downloadurl'. This CL avoids storing the policy unconditionally when converting the DragData Mojo type to DropData. Bug: 1039255 Change-Id: Id0b94a7bddb274b53aba2e5c163407f0c875d95c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391068Reviewed-by:
-
Frédéric Wang authored
Add links to existing bug entry and update the comments to better reflect the current MathML status and plan. Bug: 6606 Change-Id: Ia89c4ab1e576033ecafb8c7828362dc3f30894ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390918Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#804572}
-
Yuly Novikov authored
Missed in initial switch in https://chromium-review.googlesource.com/c/chromium/src/+/2302923 TBR=kbr Bug: 1078489 Change-Id: I57b2fe92b74e96990ee0a2bafef27b5267008c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393625Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804571}
-
mark a. foltz authored
This adds a fake Origin header to DIAL HTTP requests to mitigate security issues. Bug: 1055608 Change-Id: I72148bd81ef1804735feff9ec9fcfc0270c1500b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391761Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804570}
-
