- 23 Apr, 2019 40 commits
-
-
Aditya Keerthi authored
The Windows Thread Pool API provides a CallbackMayRunLong method to indicate that a callback may not return quickly. The thread pool can use this information to better determine when a new thread should be created. This CL teaches PlatformNativeWorkerPoolWin about ScopedBlockingCall in order to determine whether a callback will return quickly. A BlockingObserver is registered before running a task in the work callback. If the task contains a ScopedBlockingCall, the observer is notified, and will call CallbackMayRunLong on the appropriate PTP_CALLBACK_INSTANCE. Bug: 756547 Change-Id: If04d2c5e01b00960dc510e94ff89525036c2ae67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574229 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653252}
-
Oleh Lamzin authored
Subscribe on UsbPowerShare local state prefs and pass it to ChromeOS side. BUG=b:130014793 TEST=chromeos_unittests && ash_unittests Change-Id: I6cf3f65923693206b3c004078e7ada74153a27fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569015 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#653251}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8aa2edb1. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." aff3c8fe "Add tests for crbug.com/363609 and crbug.com/954591" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8be51b06ae54a62eae2e16b74fd4a18771b0b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576335Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653250}
-
Daniel Bratell authored
Since we had a bug because of this missing check, let's not repeat it. Bug: 949535 Change-Id: Ic3ef619403dfcc3ecb8ffecd5f1e2cc80681dc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552830Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Auto-Submit: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#653249}
-
Ryan Hansberry authored
Change-Id: I38b452c7d5ff9a634e91453e2cee3e0e99fe2b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578585 Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#653248}
-
Sujie Zhu authored
Extract IsCreditCardSupport function to payments_util so that later Upstream and migration can share this util function. Bug: 954367 Change-Id: Ib598ba8eea230ee741706b2bf17b0dd8a1746ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574885 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#653247}
-
Victor Hugo Vianna Silva authored
Removing code in Wallet USS that is no longer necessary. Final step in solving https://crbug.com/880735. Bug: 880735 Change-Id: Ie316eee735dd4b586eed1b90a1541c986e485c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570035Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#653246}
-
Pavel Yatsuk authored
On touchless devices context menu should be shown through ModalDialogManager. Mechanism of triggering for context menu is also different. This change adds functionality to ContextMenuManager to display context menu given ContextMenuManager.Delegate of the item in focus. It is part of a bigger change described at doc/1JUcJNyVM3qNCIl2BMmfVu4d_ctQELhjQq8Rn4K_jxgk In this CL: - Extract handling code from ItemClickListener to be reusable between the two methods of showing the menu. - Add code to build menu item and menu PropertyModel - Add code to show menu and handle interactions - Cleanup: remove public closeContextMenu and adjust callers. - Cleanup: Fix the issue where item's OnAttachStateChangeListener#onViewDetachedFromWindow was causing redundant calls to closeContextMenu when the item was scrolled out of view. BUG=937445 Change-Id: I6e4942fed0f7702dcef4cb5e4e252dec9667e3a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574689 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#653245}
-
Elly Fong-Jones authored
Bug: None Change-Id: I54182aba33401292d5df0c382a6715a9cc76dc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577936 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#653244}
-
Eric Karl authored
Ensure that resources locked via LockForExternalUse are passed to SkiaOutputSurface::ReleaseCachedResources, allowing SkiaRenderer to clean up its cache. This avoids runaway cache growth / memory leaks we were seeing. Also adds test coverage. Bug: 954595 Change-Id: I4d86ee59096f08c7e876a1aeee0f40d042683e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576024Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#653243}
-
Wez authored
This reverts commit 0da11cae. Reason for revert: This change was reverted down-stream, so reverting it here to keep things consistent. Original change's description: > Use CastSysInfoDummy for fuchsia > > This is a temporary solution until we implement a Fuchsia version of > CastSysInfo. The only downside to using the dummy is that the strings, > such as serial number, model, build, etc are all faked out. > > Bug: internal b/126768956 > Test: CQ > Change-Id: I3364d87c57d7f40dbe2d1e80b19bb2f02532512b > Reviewed-on: https://chromium-review.googlesource.com/c/1496419 > Reviewed-by: Yuchen Liu <yucliu@chromium.org> > Auto-Submit: Aidan Wolter <awolter@chromium.org> > Commit-Queue: Aidan Wolter <awolter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636644} TBR=yucliu@chromium.org,awolter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/126768956 Change-Id: I2d5017748da975de8516888f24ac62b9e8e00bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578185Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#653242}
-
Raymond Toy authored
Remove BreakConnection() function. It was only called from ReleaseActiveSourceNodes, which is only called Uninitialize from the main thread. Thus BreakConnection is never called from the audio thread, so it always called BreakConnectionWithLock (after getting the graph lock). So, just change ReleaseActiveSourceNodes to get the graph lock and call BreakConnectionWithLock directly instead of call BreakConnection. This method is now unused, so remove it. This also means that AddDeferredBreakConnection is never called so remove that too. And that implies that we never add anything to deferred_break_connection_list_ so that can be removed too. This is a first step in breaking connections on the main thread. Bug: 942128 Change-Id: I712f55558e15a80aadd90573cc292355bb83bef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524692 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#653241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11c47f6e5f74..5c2db7bce046 Created with: gclient setdep -r src-internal@5c2db7bce046 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=chcunningham@chromium.org,loyso@chromium.org,clamy@chromium.org,flackr@chromium.org Change-Id: Ic941b81e733146fa4f3e48efb04efdfb9966d5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653240}
-
Nicolas Ouellet-payeur authored
Bug: 955441 Change-Id: I00bf4a10d8849d0e30045b616fb6f7bc69694ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578940Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#653239}
-
Camille Lamy authored
This CL adds support for passing a custom Origin to be used at commit time in NavigationSimulatorImpl. Bug: 728571 Change-Id: Ieaef85f7add5de633187635152a7e081917b6215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578750 Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#653238}
-
Stephen Martinis authored
They currently aren't being parsed correctly, due to the additional args looking like command line arguments the merge_results.py script wants to process. This changes it to require a JSON serialized array of strings, which won't be consumed by the parser. We can't use nargs='*' because we already use that to receive the list of input test results. Bug: 923711 Change-Id: I5709ffdcdce653e8f46b4ef6c3b8ae2cc9579127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572805Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#653237}
-
Mohamed Abdelhalim authored
This is the second part of splitting https://chromium-review.googlesource.com/c/chromium/src/+/1554767 Next steps: Move the remaining members from NavigationHandleImpl to NavigationRequest, and merge NavigationRequest::NavigationHandleState into NavigationRequest::NavigationState. Bug: 916537 Change-Id: Iff2193f6167f12301b84ae35be5ba6cdb1c5356b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578543Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653236}
-
Charlie Harrison authored
This CL also deprecates similar metrics that depend on the "SubresourceFilterConsiderRedirects"feature. Bug: 954571 Change-Id: I768581216362f0a693af36b4c3c14f32670bff46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574279Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#653235}
-
Maggie Chen authored
Chrome renderer process crash if we allocate more than 4 Gb of memory. Allow a bigger memory size in Windows sand box if the system has enough memory. Bug: 756834 Change-Id: I2da53b885049f94c05f0fdf6ff27db8033f55243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570633Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#653234}
-
danakj authored
This will allow us to convert more Callbacks in the bluetooth component over to OnceCallbacks, which will let us convert Callbacks in content eventually. R=reillyg@chromium.org Bug: 953861 Change-Id: I9b42c51d54147817fefd5e80b262d51c37eb02f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574605Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#653233}
-
Suman Kancherla authored
Existing indicators' transience depends on code both in UiSceneCreator and VrUiHostImpl. The functionality also had a bunch of issues like all old indicators showing up after exiting from an external prompt, a currently shown indicator suddenly vanishing before the timeout period when a new device becomes in-use and its indicator is displayed etc. This change removes all time-out/triggering logic from UiSceneCreator on Windows. Instead, VrUiHostImpl controls all the logic from its end. A newly added CapturingStateModelTransience class handles the logic to turn flags on based on state differences between consecutive active CapturingStateModel. Since the flags are set immediately, the corresponding indicator is shown/updated immediately. The class also handles turning off indicators gracefully when all the corresponding flags are ready to be turned off together based on time-out period. Bug: 951581 Change-Id: I90df766f7f2c488cc47773d7cc1c647bafe675ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575173Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#653232}
-
Peter Mayo authored
One of the potentially many element IDs shouldn't have special meaning to an animation. The equivalent previous value is available indirectly. This was also only used in testing. Bug: 900241 Change-Id: Icce6688a8e1d9321c635bb932f32424ef74d8d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572277Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#653231}
-
Kevin Ellis authored
This patch prevents getting into a state where draw is starved due to perpetually having an active tree mutation in the queue. This should prevent early draw deadlines, but not prevent draw. Bug: 937975 Change-Id: I9ed9ffdc2ec90981560689344e9cf79e8bc964fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554738Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#653230}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/776c917fd501..de445983dd92 git log 776c917fd501..de445983dd92 --date=short --no-merges --format='%ad %ae %s' 2019-04-23 evanhernandez@chromium.org artifacts: Warn if no pinned images found. Created with: gclient setdep -r src/third_party/chromite@de445983dd92 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I54e05b8f2fcc7db4c04199549dda6d65452446fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578436Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#653229}
-
Maks Orlovich authored
This is almost entirely based on Mike West's preliminary version: https://chromium-review.googlesource.com/c/chromium/src/+/1528244 The new enforcement blocks the setup portion of some existing WPT tests, which verified read behavior, so the helper they use was changed to always set them in a same-site context by PostMessage'ing to a helper window. Bug: 837412 Change-Id: Iba95d65ec4d0916fb4dfa581efaede50654792d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534237 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#653228}
-
Anders Hartvoll Ruud authored
HTMLImageElement::CustomStyleForLayoutObject modifies the inline style of children during style recalc. This causes the ancestor chain to be marked with child-needs-recalc, which triggers (D)HECKs. Ultimately we should rewrite HTMLImageElement to avoid this behavior, but for now work around the issue by always using OriginalStyleForLayoutObject() when ensuring the style for HTMLImageElement. BUG=950299,953707 R=futhark@chromium.org Change-Id: I0af7b4ebbf1f378be188751df46bcc8ddfdc71cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578542 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#653227}
-
Matt Mueller authored
This is in preparation of making CertNetFetcher an explicit dependency of CertVerifyProcBuiltin & CertVerifyProcAndroid, which requires calling a method on the CertNetFetcherImpl. Bug: 829029 Change-Id: I15b7ca863ed3720b9d89d55e7660ae9864138adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573005Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#653226}
-
Sean Gilhuly authored
|gpu_feature_info| is constructed from the command line and then discarded, and the member |gpu_feature_info_| is default constructed. Connect these variables. Change-Id: Id96e9f48d1372fdb68d38a70365734ec1fde2b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577933Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#653225}
-
Claudio DeSouza authored
//services/device/public/mojom provides interface for a great number of project that have their specific demands. This has caused, indirectly, for //services/device/serial:serial to start depending on blink. This CL changes //services/device/public/mojom:mojom in order to allow for all serial specific code to be specified as a sub-dependency of both serial, and the public interface project. Change-Id: I83f77c38316ed8f5cb4622f0ecaeb3ea13464b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571701Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#653224}
-
Dana Fried authored
Since ImageSkia is a value type which wraps a refcounted pointer, there is no reason to have a smart pointer to an ImageSkia. This removes the only remaining instance in the ImageSkia API which returns a unique_ptr rather than an instance. There is an open question of how to pass ImageSkia in general: 1. instance (preserving value semantics but incurring the cost of AddRef and ReleaseRef) 2. const reference (losing value semantics but avoiding refcount changes) Right now we're going with (1) but I am willing to switch to (2) - I'm not deeply committed to either. Bug: 953845 Change-Id: Ie8b0a4b6720742d61e39413bd98e03256e234a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562757Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#653223}
-
Azeem Arshad authored
Add a CellularMetricsLogger class that observes networks states and logs key metrics. See go/cros-cellular-key-metrics for key cellular metrics that will be added to this class. This CL includes implementation for Network.Cellular.Usage.Count metric that tracks the usage count of cellular network. Other metrics will be added in follow-up CLs. Bug: 951528 Change-Id: I6c4e856ffcfa66afd7396b64f0f1ca461c0edda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562510Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#653222}
-
Jacob DeWitt authored
Add Gamepad to XRInputSourceState mojo struct to send device gamepad data to Blink WebXR code, which updates the associated XRInputSource Gamepad on each frame. Changing shared_with_blink in device/gamepad/public/cpp/BUILD.gn from a source_set to a component and exporting the device::Gamepad and device::Gamepads classes is necessary to make the component build pass with no linker errors. Code changes to populate the Gamepad struct before sending it through mojo will come in later CLs for platforms such as WMR and Oculus. Bug: 944880 Change-Id: I2bf372cfd34c3250aeae13670056315f04e23bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566683Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#653221}
-
Richard Knoll authored
This raises the task runner priority from BEST_EFFORT to USER_VISIBLE as we always post to the UI thread with USER_VISIBLE anyway. Bug: None Change-Id: I9e31b7880bb7dbe6cad5e61213d3b35ea84289dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573740Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#653220}
-
Yi Gu authored
By spec [1] the ctor of Worklet Animation should use the Document that is associated with the window that is the current global object. However the code takes the Document from the target of the first effect which is not spec-compliant. e.g. the target is an iframe, In addition, there may be security risks behind it. [1] https://drafts.css-houdini.org/css-animationworklet/#creating-worklet-animation Bug: 953466 Change-Id: I13ed9a44e5a77f359e4075f1bd147d7e7163804a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570628 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#653219}
-
Ahmed Mehfooz authored
Test: Manual UI Test Bug: 954934 Change-Id: Iafa3867f7780be11697137f899097cfb202daa07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577972Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#653218}
-
Aaron Krajeski authored
For dragging and printing operations gpu-composited canvases should still get drawn to their parent layer. Bug: 932405 Change-Id: I8a59345fa856876118c04fc446865f7837f09a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573650Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#653217}
-
Nate Fischer authored
No change to logic, only docs. This extends Android emulator docs to address two issues: 1. x86 emulators don't work with arm-compiled APKs. Although this is, in some sense, obvious, it's worth calling out since ARM-compiled APKs are fairly common due to the popularity of the architecture. 2. Make it easier to find "Google APIs" images in the AVD creation wizard. This explains you need to go to the "x86 Images" tab in the wizard. Bug: 955135, 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Id87efe8c8b8c96dc01f72819bd8c31199507c416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578071 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#653216}
-
Daniel Bratell authored
Both leveldb::Status and inspector_protocol_encoding::Status are pulled into the global namespace as aliases. In certain non-default jumbo builds that causes problems. Since there are many-many usages of leveldb::Status as Status but only one usage of inspector_protocol_encoding::Status as Status, this changes only inspector_protocol_encoding::Status to not use an alias. This also touches an inspector_protocol_encoding::cbor to not conflict with another patch. Change-Id: If663fa8c7d14ab1cb11a88a037a588b0c4b2d5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578559 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#653215}
-
Adam Langley authored
This is relatively harmless, but can hit a NOTREACHED. This change makes the CTAP2 parsers follow the stricter, IsStringUTF8, result. Bug: 955317 Change-Id: If7f8b8a0c1e85566bb035b21626d52fd91038a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576337 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#653214}
-
Gabriel Charette authored
R=fdoray@chromium.org Bug: 951388 Change-Id: I66354e187f2c51bf73a0bcf42e6f9b4124450df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578943 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#653213}
-