- 06 Jul, 2020 40 commits
-
-
arthursonzogni authored
Disabled tests: org.chromium.chrome.browser.keyboard_accessory... ...AutofillKeyboardAccessoryIntegrationTest #testSelectSuggestionHidesKeyboardAccessory__default ...ManualFillingIntegrationTest #testAccessoryHiddenAfterTappingAutoGenerationButton #testAccessorySheetHiddenWhenRefocusingField #testInfobarReopensOnPressingBack #testInfobarStaysHiddenWhenOpeningSheet #testKeyboardAccessoryDisappearsWithKeyboard #testKeyboardAccessoryHiddenUntilKeyboardShows #testMovesUpSnackbar #testPressingBackButtonHidesAccessorySheet #testSelectingNonPasswordInputDismissesAccessory ...ManualFillingUiCaptureTest #testCaptureKeyboardAccessoryV2WithPasswordsRTL #testCaptureKeyboardAccessoryWithPasswords #testCaptureKeyboardAccessoryWithPasswordsRTL ...sheet_tabs.PasswordAccessoryIntegrationTest #testPasswordSheetDisplaysProvidedItems TBR=fhorschig@chromium.org Bug: 1102302 Change-Id: I537c30a59dd01e9de9e0abb93e1e367cc58dfdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282802Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785329}
-
Maksim Ivanov authored
Move the ScopedAllowBlockingForTesting into the TestCertificateProviderExtension class where needed, so that its consumers in tests don't have to worry about it (and also so that the scoped IO allowance is used in the smallest possible scope). This is a pure refactoring CL. Bug: 1067683 Change-Id: I164bd520c3ea9191a58838412628336147029eaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280000Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785328}
-
Maksim Ivanov authored
Create a test mixin ExtensionForceInstallMixin that helps in testing of force-installed extensions. In this initial version, only device policy faked via DevicePolicyCrosTestHelper is supported; the extension has to be already packed into a CRX file. The mixin hosts the CRX file in an embedded test server, generates and hosts an update manifest XML and configures the device policy. Also partially migrate signin_profile_extensions_policy_browsertest.cc to the new mixin. Bug: 1090941 Change-Id: Ic2b82dc15d0bfcf18e68d267d78312ce2311789f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277812Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#785327}
-
Richard Knoll authored
This component will render a preview of the to-be-shared content. This might be an image or some text for example. For now it renders a placeholder image and a title text below it. This component will be used from the confirmation-page and discovery-page. Bug: 1099710 Change-Id: I6331fa196a54d02662cd621e3c28ef15cb65de5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277734Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785326}
-
Javier Ernesto Flores Robles authored
Removes DCHECK as success = false is now expected sometimes. Logs the error to UMA to be analyzed in the future. Bug: 1091927, 1095620 Change-Id: I64e1a662d9f936d8891c3e31eb2e2c14573829c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275896 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#785325}
-
Eugene Zemtsov authored
Apparently macros don't support histograms with suffixes, and we need to use a function for roughness, otherwise it triggers a DCHECK when the name changes. Bug: 1101907 Change-Id: Ie64da90f3a1929653f5c1a6453b680aad4646990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280465Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#785324}
-
Philipp Hancke authored
BUG=chromium:894057 Change-Id: Ibeb60e70c08fccc45886476ed4f459cd09ae9b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282921Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#785323}
-
Stephan Hartmann authored
'-Wdelete-non-abstract-non-virtual-dtor' is a clang-only flag. Switch pragma diagnostic from GCC to clang. Bug: None Change-Id: Ic4488d9f95b351bcf74eeb4dba5bf568405948e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279981Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785322}
-
Bartek Nowierski authored
The USE_PARTITION_ALLOC_AS_MALLOC check encompassed too code in AllocFromBucket, effectively disabling memset(kUninitializedByte). This CL makes it more precise so that it only disables cookies and nothing else. Rename Partition*FreePointerAdjust -> Partition*PointerAdjustSubtract while at it, for consistency with the rest of the functions. Bug: 998048 Change-Id: Id0615de9537caf5274ce38a344a07af68c98fd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279269 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785321}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7231d11baf46..4efe8f9cce59 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in sources/watchExpressionsSidebarPane.css 2020-07-06 sawallner@chromium.org Fix stylelint-config-standard issues in ui/viewContainers.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9ce287f13db240fc2db515a3f231d06756094786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785320}
-
Stepan Khapugin authored
Cleans up a few more now-unused methods in guts protocols. Bug: 1045660 Change-Id: I244ef31eb8ea7ef413f64328c3515a0dac7de9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279884Reviewed-by:
-
Carlos Caballero authored
Defer cache lookup to until sandbox checks have been performed. Bug: 1051491 Change-Id: I8f31e8301b7270050bf324c04bcd853f4638670e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277882 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785318}
-
Sigurd Schneider authored
The new unittest is here: https://crrev.com/c/2282504 Bug: chromium:1060613 Change-Id: I258aa87e3637322eb4aa7b7c2a5d4b2374142a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282923Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#785317}
-
Maggie Cai authored
This CL creates an app service file tasks to allow the files app to query sharing task from app service intent handling backend. This is for testing the backend and it is behind a flag. It might need to be modified after link up with unified sharesheet UI. BUG=1092784 Change-Id: I4ba54f7b2ee9e9ae3fd89184b808c1040a01c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279411 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#785316}
-
Ella Ge authored
Bug: 1007635 Change-Id: I49ae4220e8b139025e14c63500faff75db75db5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276480Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#785315}
-
Andy Paicu authored
Bug: 1094356 Change-Id: Ie49d2e0d59e851b3b9792370cff2dfeeacf880fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282743Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Swapnil authored
UploadExtensionInstallReport and CancelExtensionInstallReport methods are used in event based reporting for policy based extensions in CloudPolicyClient. This CL adds unit tests for these methods. Bug: 1101714 Change-Id: Id0322508fc1e67456658a982172e4171d45c2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279210Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#785313}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/59ccb1f6de17..80f927d76321 2020-07-06 jiawei.shao@intel.com Implement buffer lazy initialization before writeBuffer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4185f072901443894d58cdd514c4ebacbed3c501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282701Reviewed-by:
-
Swapnil authored
ExtensionInstallEventLogManager class ties together collection, storage and upload of extension logs. This is used for event based reporting for policy based extensions. Add unit tests for this class. This CL add unit tests for ExtensionInstallEventLogManager. Bug: 1101709 Change-Id: Iff4ef1a5af9f979336fba5073426cb6313912f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277817Reviewed-by:
-
arthursonzogni authored
This test fails on Android N. It has been added very recently by: https://chromium-review.googlesource.com/c/chromium/src/+/2265236 TBR=wychen@chromium.org,yuezhanggg@chromium.org Bug: 1102288,1099037 Change-Id: Ie98a7e1771f11934a132e8b7fd9ed7111bde8ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282561Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib6ad08130aa92c8b80c08b475cb94ac3d58fc881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282278Reviewed-by:
-
Hiroki Nakagawa authored
Callback: Convert base::Callback to base::OnceCallback for chromeos::file_system_provider::AbortCallback Bug: 1007635 Change-Id: I04d535ff9ce08c122f9ee0643d0f57e3b49ae639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281799 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#785308}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61570250a193..7231d11baf46 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in timeline/timelineStatusDialog.css 2020-07-06 bmeurer@chromium.org [wasm-debugging] Drop experimental out-of-progress language plugin 2020-07-06 alexrudenko@chromium.org Fix stylelint-config-standard issues in ui/toolbar.css 2020-07-06 kimanh@chromium.org Fix stylelint-config-standard issues in network/networkTimingTable.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1083146 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf7a21d92732677989f8aeca980d88e5f85ce56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282279Reviewed-by:
-
Rob Buis authored
Properly initialize StretchyOperatorShaper::Metrics in the struct, instead of having to initialize the struct at point of use. This comes out of a discussion of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/2270448 Bug: 6606 Change-Id: I1f00753ea25ce8de18e853729cb90e72a7e04e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275954Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#785306}
-
Quang Minh Tuan Nguyen authored
I tried to convert it to OnceCallback, but had problem with circular_deque https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8875545102440823552/+/steps/compile__with_patch_/0/logs/raw_io.output_failure_summary_/0 I guess we should go with RepeatingCallback here Bug: 1007685 Change-Id: I16a77c2f9a19f982249220adad1a9fb2dbbf7507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282143Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#785305}
-
My Nguyen authored
Both emoji and personal info suggestions require +2 elevation Current View: http://screen/rnfGzOx97Nw Emoji Specs: http://screen/qgE7xnf2LhN Personal Info Specs: http://screen/nbDgNJ3gdRZ Bug: 1099454 Change-Id: I6e7e8ed4ef0f91ed0ec1413430f9f5059bc918ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281768 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#785304}
-
Jason Lin authored
If plugin vm is installed, we show it in settings page even if policy does not allow it so that the user can still uninstall it. But we should not show it if the user logs in as a non-primary user because they can still uninstall it when re-login as a primary user. Bug: b/155954630 Test: manually Change-Id: I34ca261c929f5d3e1d3c2b1dc145e679fd6d30f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275978 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#785303}
-
Alice Boxhall authored
Bug: 1102116 Change-Id: If6a66d5b0b53dbffd0d56d63fd8d1a13003fc992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279268Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#785302}
-
Sigurd Schneider authored
Bug: chromium:1011811 Change-Id: Ic95ddf1f4df61f312aa3707c477a69152ef8a386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279191 Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Nico Weber authored
-Wmax-tokens coverage on mac/intel should be sufficient for now. We just need to remember to switch this when we turn down the intel mac bots in a decade or so. ../../content/public/browser/content_browser_client.cc:12:31: error: the number of preprocessor source tokens (902784) exceeds this token limit (860000) [-Werror,-Wmax-tokens] #pragma clang max_tokens_here 860000 ^ Bug: 1098899 Change-Id: I5ddefd30b39cffb0a9aacd2838847c9c06d3fe93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281319 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#785300}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e2f33ada858c..61570250a193 2020-07-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I11cdd6b36f29741156c1633c2276fbb2bf69a801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282268Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b24a8db8..e5f1009d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I82ea15218e51377f5e058dd128ed35e438cd220d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282104Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785298}
-
Owen Rodley authored
Follows the current Gatekeeper config - tree closing enabled for all builders, with a handful of builders that close the tree regardless of which step fails. Bug: 1094768 Change-Id: I03ddc4fbd7a02654146b93a9b1387b97a942c238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279267 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#785297}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593993254-dbbaa6aa1e1e0b6f79ccb648844aec2deeff08b4.profdata to chrome-mac-master-1594014961-7d45cb9775a1becec1c537c70e86c3de2e101ea0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I42c39694df1fe4145a403abe86a7b68b2d143172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282269Reviewed-by:
-
Jing Wang authored
This list from https://docs.google.com/spreadsheets/d/1VELTWiHrUTEyX4HQI5PL_jDVFreM-lRhThVOurUuOk4/edit#gid=0, which is confirmed by laurentt@ For some google internal website, we are comparing hash instead of plain text to prevent internal url from leaking through binary. For convenience, we are now using package name for arc++ apps, because they are more readable and easy to obatin. However, for system apps, we need to use app id since they don't have package name. Currently allow lists for emoji and personal info are the same, but they may be different in the future. Bug: 1101616 Change-Id: Ied2884b8fadc38dc68f693565d5d20abe07aa906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278910Reviewed-by:
-
Qijiang Fan authored
For Python3 compatibility. Converting [module.StructField] into set requires StructField to be hashable, but module.StructField has __eq__ defined only not __hash__. $ python3 ./mojo/public/tools/bindings/mojom_bindings_generator.py generate $(pwd)/mojo/public/mojom/base/time.mojom --bytecode_path . -d $(pwd) Traceback (most recent call last): <stacktrace partially trimmed> File "/ssd2/chromium/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py", line 961, in <genexpr> for param_count in param_counts) File "/ssd2/chromium/src/mojo/public/tools/bindings/generators/mojom_cpp_generator.py", line 205, in __init__ self._params = set(params) TypeError: unhashable type: 'StructField' Bug: 941669 Change-Id: I1ca8f67d86754cbad668a47a6f0ddd513e5ce896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277687 Commit-Queue: Qijiang Fan <fqj@chromium.org> Auto-Submit: Qijiang Fan <fqj@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#785294}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1593993254-590c1c6949804f5c7fc0a1e827a031b5cd1d9e34.profdata to chrome-win32-master-1594004320-2e826e0a02d03f5d95b06057ee6fb0c871fea712.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ied1f7c9a75f288b9189266f5ab66509842e989f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282262Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b19fe438d6bf..fb0275a7e102 2020-07-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bae95f817a59 to 465a912582bb (12 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I41e64424b15df4a0a15cbf1aa37670fcf95ec01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282265Reviewed-by:
-
My Nguyen authored
- Press "Enter", open settings when Learn More button is chosen. - Press "Up" from first candidate/ no candidates chosen, highlight Learn More button. - Press "Down" from last candidate, highlight Learn More button. Bug: 1101195 Change-Id: I7900cef2ea361f777b6d6586d396541f10234946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280751Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785291}
-
Hiroki Nakagawa authored
Bug: 1007635 Change-Id: Ibe143f64d27e93c034125f4d5f7b92cb5ede5318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280973 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#785290}
-
