- 17 Jul, 2020 40 commits
-
-
Kramer Ge authored
OzonePlatformGbm::AddInterfaces() sets the DrmDevice mojo binder callback to run on the calling thread. It takes 2 thread hops before mojo endpoint arrives at DRM thread. This is causing deadlocks when the calling thread is blocked on DRM thread while DRM thread doesn't have the mojo endpoint (so it does not have a DRM device yet). This CL makes AddInterfaces check if in DRM thread is running, and set the callback to run on DRM thread, skipping the extra thread hop. In multi-process mode AddInterfaces is called from VizMainImpl::CreateGpuService, and DRM thread is started right after sandbox entry. Thus deadlock can be avoided. Also change the running thread of binder callbacks to be gpu thread if drm thread is not started. Previously it runs on the calling thread of AddInterfaces and it can introduce cache incoherency on |drm_thread_started_|. Bug: 1090071 Change-Id: I9b0d3918889e4eaa54d3ae231c94402ee5368dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288335Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#789603}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cc5513855cc5..5a4af4624777 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 7221ccf85e26 to 680c77fa6c81 (2 revisions) 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4f72970ed3e0 to f3cb1896971f (1 revision) 2020-07-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7548cbeabfa7 to 412b1b7dd18c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: Iad02c929ddcac1a4c40c16058e13997431e65fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304674Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789602}
-
Alex Cooper authored
Though the vr_pixeltests were previously removed from Windows 7 bots, this didn't remove them from all known Windows 7 bots nor new Windows 7 bots. Given that VR is not supported on Windows 7, we don't need to run these tests there, so simply skip them if we're not running on Windows 7. Bug: 1106809 Change-Id: I65d74d4f4c02c25cb37b7488880f78f6dcb27fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304097 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789601}
-
Evan Stade authored
Bug: 1071603 Change-Id: Icbb428e40d2dad8b807ce2298da0a3c01ffcf11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288328 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789600}
-
Evan Stade authored
Bug: 1071603 Change-Id: Ib53af1b0ed6ca217b0e3b78a5fd41c5eefe240af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304136Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789599}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47d86db05ea3..0d8628ddce9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com,seblalancette@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106750 Tbr: atotic@google.com,seblalancette@google.com Change-Id: I5fed5445088d94270365f34b26dead4e61be3337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304801Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789598}
-
James Long authored
A new component has been made for class details, similar to how the package graph has a panel for package details. This component contains the link to the class' package and a list of the class' build targets. Bug: 1106496 Change-Id: I71b34fa973256cf43984b351769ca95b2fb6bb93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303985Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#789597}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit ed8ef709. Reason for revert: space after "," is buggy Original change's description: > Amend dom-distiller script for bug ID handling > > "None" would be ignored, and add space after ",". > > Bug: None > Change-Id: I85167f2e9ba0cea7affd754825fd34e817568bd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304337 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789569} TBR=dmazzoni@chromium.org,wychen@chromium.org Change-Id: I9be25d3af31be50e0ee3a608091c31a5b1c2ff6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304960Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789596}
-
Aya ElAttar authored
Changed PolicyMap::Set to the newer version, which passes value as base::Value instead of unique_ptr. Bug: 2270317 Change-Id: I206b53f5a055ca97fa3077db5990d2b5a0f32b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301771 Auto-Submit: Aya Elsayed <ayaelattar@google.com> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789595}
-
Torne (Richard Coles) authored
setBackgroundColor and setLayerType were using PostTask instead of adding their tasks to the mFactory queue like the other WebViewChromium methods; make it consistent. Change-Id: I37c92eb764079121443401676b4f762599a6a5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302947Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789594}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit 033b5754. Reason for revert: introduced an uninitialized variable when pushing to dist is skipped Original change's description: > Use code review in DOM distiller dist repo > > Before this CL, this script builds DOM distiller, pushes the compiled > artifacts to the dom-distiller/dist repo, and generates a local commit > for rolling. The local commit needs to be uploaded as a CL. > > In order to avoid pushing without reviewing, we want to generate a CL > in the dom-distiller/dist repo instead of directly pushing to it. > > When reviewing the CL in the dom-distiller/dist repo, the reviewer > needs to run update_domdistiller_js.sh in validation mode to make sure > the artifacts in the CL are identical to local output. > > Bug: None > Change-Id: Ia29c1686106c3516f341e4d826aca69842ac5668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304338 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789575} TBR=dmazzoni@chromium.org,wychen@chromium.org Change-Id: I6cc088d43d5e2d18a5e744a9239e4c44cb1c88e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304100Reviewed-by:
-
Eric Ye authored
BUG=b/156411764 TEST=Flash to device, check sysfiles Change-Id: I8f6b4fa0d937bc584dd32718bd2cf3cca42d2877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298319 Commit-Queue: Eric Ye <ericye@google.com> Auto-Submit: Eric Ye <ericye@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789592}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/233589f2e73f..320ceb93a21c 2020-07-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie6d5988705811ad8901ebb5fd51640e50bdeb6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304805Reviewed-by:
-
Scott Violet authored
These were marked obsolete long ago, but never actually removed. TEST=none BUG=1097644 Change-Id: Ia79bcacfc1de72876f78553e1b4436d969156f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300233 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789590}
-
Josh Nohle authored
Bug: b/154863110 Change-Id: Iad98d2a12dd07e596ea97f361abe3aaaf2a6dabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280596 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#789589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15a3a6c5..9109ad22 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id45a9942b439aa20f8fb9d72a287bb0f4ac69d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302815Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789588}
-
Nicolás Peña Moreno authored
Change-Id: I823ea7b854598a7f8d908c917f02105c2f31f1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304771 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789587}
-
Sammie Quon authored
This is a reland of 44052b91. Original is in patch set 1. Use a ImplicitAnimationObserver, which probably has more of these edge cases handled. Original change's description: > overview: Animate the clip header while the window animates. > > This was previously animated after the main animation for performance > reasons. With the improvements to overview, we think we run this > animation at the same time as the window animation, and add it to the > exit animation as well. > > Since we now need to animate removing clipping (clip rect = gfx::Rect()), > this CL adds an observer which first animates the clip rect to the size > of the layer, and the removes the clip. Otherwise the animation will > contract hide everything before reshowing on the last frame. To help > with this, windows with no clip in overview will have a clip the size > of the window (visually equal to no clipping). This will avoid us > changing to and from real no clip (clip = gfx::Rect()) which would > make the logic more confusing and we would need to create more self > deleting observers. > > Also refactors some logic so that this clipping, and the aspect ratio > clipping (clips windows that will open in splitview so they have the > same ratio as a splitview window), so they share more code. > > Test: manual > Change-Id: I900f9a1801f9dd2e9847101e4c52d54f0ba41292 > Fixed: 952158, 1103621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277331 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787412} Change-Id: Ia957d13237f3516b1dd1a4d097bad184c293e89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296251Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#789586}
-
W. James MacLean authored
This CL adds unit tests to make sure SiteInfo's comparison operators work as expected, and that SiteInfo functions correctly as a key for std:;map and std::set. Bug: 1067389 Change-Id: I736b53908689517252ca5bdeaa4b79e1eec10760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304159Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789585}
-
David Black authored
Bug: b:161161492 Change-Id: Ib57a9e04d20e5f43a67a3ff9ef6832199b324603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300502 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789584}
-
Xianzhu Wang authored
Previously to avoid paint and raster invalidation on subpixel movement of composited layers, we excluded the subpixel accumulation of the composited layer from the visual rects of the contents, and added the subpixel accumulation back when mapping the visual rect into the layer space. This avoided change of visual rects on such movement. We also needed to ignore subpixel paint offset changes during paint invalidation, which actually mistakenly also ignored non-composited subpixel movement which might cause change of painted results. Because now we have moved paint invalidation away from depending on visual rects, we don't need the visual rect subpixel accumulation exclusion logic, so it's removed. Also create more accurate logic for ignoring subpixel paint offset changes under composited layer. PaintPropertyTreeBuilder calculates the paint offset subpixel delta of the directly composited container, and if a descendant has the same paint offset delta, the paint offset change will be ignored for paint invalidation. We reset the paint offset subpixel delta when crossing objects that don't propagate subpixel accumulation, so that the descendants under these objects won't ignore any paint offset change. Bug: 1104064, 833083 Change-Id: I9c640a180a1b6d7718de264443e444f43d579854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298725 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789583}
-
Liquan (Max) Gu authored
Change: * Move some UI members of PaymentRequestImpl into PaymentUIsManager; replace their instances in PaymentRequestImpl with setter & getter. Bug: 1102522 Change-Id: I86c0c646132a0a8d94181fff193eb007d0a83648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304095Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789582}
-
Jonah Ryan-Davis authored
This CL changes the helper function in gl_test_utils from InitializeEGLGLES2 to the more general InitializeGL which will pick either EGLGLES2 or EGLANGLE depending on which implementations are available. Fixes crashes on linux passthrough for GpuOESEGLImageTest and GpuMemoryBufferTestEGL. Bug: chromium:1099766 Change-Id: Id17eca294b6cecf7f76f2ec8c4f895ff1fb13fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285245 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#789581}
-
Michael Ludwig authored
DrawRPDQParams now just holds on to an SkShader that represents the mask image and the local matrix that needs to be applied to it. This removes a use of SkShaderMaskFilter that tried to combine the mask shader into the SkPaint of the draw. Instead, the mask is always applied by using SkCanvas::clipShader, which helps unify the code between a layer-needing RPDQ, an image RPDQ, and a solid color RPDQ. Having a mask image also no longer impacts whether or not a saveLayer() is needed because it is applied last (as desired), so skia_renderer no longer has to juggle the order that effect is applied in. Change-Id: I3d9ce085d498fabec42e112b0cb36e9707b96c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303672Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#789580}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b228a72cf564..2d7afd4824c6 2020-07-17 nifong@google.com fix heap-buffer-overflow by not returning string from reportBackendType 2020-07-17 brianosman@google.com fuzz: Add 'loops' option to run multiple times 2020-07-17 westont@google.com Add updated provisioning_profile_ios that includes iphone 11s. 2020-07-17 herb@google.com create SkAtlasSubRun API subclass SkMaskSubRun 2020-07-17 herb@google.com make prepareGrGlyphs private If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ie5bd4de3c532d880305b65acc66fadbffe2fc2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304800Reviewed-by:
-
Kartik Hegde authored
Now that cros_healthd collects system information, use it to fetch and report this information in DeviceStatusCollector. BUG=chromium:1057495 TEST=./out/Default/browser_tests --gtest_filter="DeviceStatusCollectorTest.*" ./out/Default/chromeos_components_unittests --gtest_filter=ProbeServiceConvertors.* Change-Id: I401eadb02c39354d4308667e0f1c0cd24aa15481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271157 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789578}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0cd3a6cae361c5c20fe4b47222266d6b5de91db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304444Reviewed-by:
-
Evan Stade authored
It doesn't appear to have an effect outside of instrumented tests. Bug: none Change-Id: If90c21806a5aff8b7380d06cfccfe0d8ce70a555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302731Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#789576}
-
Wei-Yin Chen (陳威尹) authored
Before this CL, this script builds DOM distiller, pushes the compiled artifacts to the dom-distiller/dist repo, and generates a local commit for rolling. The local commit needs to be uploaded as a CL. In order to avoid pushing without reviewing, we want to generate a CL in the dom-distiller/dist repo instead of directly pushing to it. When reviewing the CL in the dom-distiller/dist repo, the reviewer needs to run update_domdistiller_js.sh in validation mode to make sure the artifacts in the CL are identical to local output. Bug: None Change-Id: Ia29c1686106c3516f341e4d826aca69842ac5668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304338Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#789575}
-
Kevin McNee authored
We already reject activation for error pages, so we now treat a renderer crash the same. This also resolves a browser crash when attempting to activate in this state. Bug: 1106490 Change-Id: I569a24e27ce0128e6204c539a8e7c41041b3ae81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303562 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789574}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/89b37f84e65c..2bcf0b808628 2020-07-17 changhaohan@chromium.org Add e2e test for computed tab's "Show all" functionality 2020-07-17 sigurds@chromium.org Link to related panels from the frame details view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093247,chromium:1106251 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I72e7aea3fdeb6be253cf53bde8b1960e2919a231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304795Reviewed-by:
-
David Maunder authored
Bug: 1101760 Change-Id: I0c7c11662aac96d7e0b1ccda09e98d73472a852f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299853Reviewed-by:
-
W. James MacLean authored
Try to reduce usage of GURL::is_valid for ProcessLock. Bug: 1067389 Change-Id: I7a88814bb95bf8aa7e28524c40499234b6c95ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300769 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
The metrics was off by 1 in the dashboard. Bug: 1049200 Change-Id: Iec92bb88e3a745e9a0d68269042e55c3cabf2ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302996 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#789570}
-
Wei-Yin Chen (陳威尹) authored
"None" would be ignored, and add space after ",". Bug: None Change-Id: I85167f2e9ba0cea7affd754825fd34e817568bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304337Reviewed-by:
-
Tao Bai authored
The event sequence was changed by the previous patch https://chromium-review.googlesource.com/c/chromium/src/+/2296487 The AUTOFILL_VIEW_EXITED is only expected on Android o platform, and will be removed for others. This issue wasn't uncoverred because we don't have O trybot by default. Bug: 1106457 Change-Id: Id838f7085ae49fd8d968929a7a08d7918c818770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302743 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#789568}
-
Victor Hugo Vianna Silva authored
Implementation: http://go/chrome-prsc/44462b2636bd411cd843d38282745059c3ca56ca Mock: https://screenshot.googleplex.com/pGV0iMTQBxw Bug: 1102294 Change-Id: I94a34dd5576bbeb1afd467f3160292e33cd4b7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290734 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Matt Reynolds authored
media::VideoFrameCompositor uses two base::RetainingOneShotTimers to handle Start/StopForceBeginFrames and background rendering. base::RepeatingCallback is correct because the timer is meant to retain and reuse the callback after a reset. BUG=1102651 Change-Id: I7c028cc08ba0d07c1f7e85518f9346a279313469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284148 Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#789566}
-
K. Moon authored
Instead of directly creating and binding pp::Graphics2D in PaintManager, delegate these operations to PaintManager::Client. This provides several benefits: 1. Allows the PaintManager::Client to return a different pp::Graphics2D implementation in the future. This will be useful especially once we replace pp::Graphics2D with a Pepper-free API. 2. Eliminates the need for PaintManager to interact with pp::Instance. Bug: 1099020 Change-Id: I46ce18cfb3ced088afdf6581fc335aa56b8be195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303989 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#789565}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ib9c0b7ec8b7639a006ac2c6a80f93817fd53dc22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304799Reviewed-by:
-
