GitLab

With the introduction of wm_public_export.h by commit 3b086a00:
("ui: extract ui/wm/public from aura target"), it now makes sense
to have a more specific name for this export file.

BUG=654078, 308710

Change-Id: I5ebbb50b09a7129b1ac23d1b0da877171551f3d3
Reviewed-on: https://chromium-review.googlesource.com/520762Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thiago Farina <tfarina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476205}

This change adds third_party/openvr so we can target OpenVR on desktop.

As said in README.chromium, this is a copy of files from the OpenVR git repository.

BUG=644793

Review-Url: https://codereview.chromium.org/2754253003
Cr-Commit-Position: refs/heads/master@{#476204}

When issuing raster invalidation, try to pair clients' old visual
rects and new visual rects. If paint invalidation reason is
kIncremental, issue raster invalidation for the difference between
the old visual rect and new visual rect.

BUG=644358

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0b4058a24b868b541b222e579ab093f6b6498631
Reviewed-on: https://chromium-review.googlesource.com/513589
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476203}

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2912273002
Cr-Commit-Position: refs/heads/master@{#476202}

This patch wires up the correct message text for modal permission
prompts in the PermissionRequestManager code-path.

BUG=606138

Review-Url: https://codereview.chromium.org/2897223002
Cr-Commit-Position: refs/heads/master@{#476201}

Original tests are flaky because they rely on unwarranted order how
Chrome issues network requests.

New test does not check expectations in an expected order, but
just check if cache control flag is expected one for each resource.

BUG=726364, 728060

Change-Id: Idb2367a259f22779581ac59b0c0017cd1256f3b9
Reviewed-on: https://chromium-review.googlesource.com/519283Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476200}

https://pdfium.googlesource.com/pdfium.git/+log/9c6b37c469e3..5be0b291bce2

$ git log 9c6b37c46..5be0b291b --date=short --no-merges --format='%ad %ae %s'
2017-05-31 wileyrr Add public #defines for line cap and line join values.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Icb4fd033da77edbaf82f7a4732dd196f7fa5d751
Reviewed-on: https://chromium-review.googlesource.com/520667
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476199}

NaClIPCAdapter has a ref count and a NaClDesc retains the reference to
it, and an IPC::Channel has a raw pointer to the NaClIPCAdapter as a
IPC::Listener without retaining a reference.

When NaClDesc releases NaClIPCAdapter and it's being destroyed, it
schedules a task to destroy the channel. However, there's a gap between
the NaClIPCAdapter destruction and the channel destruction, and a chance
for the channel to call OnChannelError on NaClIPCAdapter, that causes
an UAF.

After this CL, NaClDesc closes the channel before it releases NaClIPCAdapter.

BUG=719942
TBR=dschuff@chromium.org

Review-Url: https://codereview.chromium.org/2876493002
Cr-Commit-Position: refs/heads/master@{#476198}

BUG=717442
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2914773002
Cr-Commit-Position: refs/heads/master@{#476197}

When an Element is set as the root scroller, it's overflow clipping
rect may differ from its border box. This is done so that hiding the
URL bar doesn't change the contents in any way but does reveal
overflowing content. Currently, this is done by returning the viewport
size from LayoutBox::OverflowClipRect.

IFrames work somewhat differently than other LayoutBoxes as they don't
just have a simple overflow clip. This patch adds a special case for
when the root scroller is an iframe. In that case, we set the iframe
to be in non-LayoutSizeFixedToFrameSize mode which is the mode the
main Frame currently operates in. We then ensure that the FrameRect and
LayoutSize are kept in sync with its parent Frame.

Bug: 505516
Change-Id: I9625da4c49cf5db478c60787f0fdb78116a92200
Reviewed-on: https://chromium-review.googlesource.com/518426
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476196}

BUG=727566
TEST=none
TBR=nharper,mattm

Change-Id: I4755bcab5dda2c908b420b9db933351b2c1e9a56
Reviewed-on: https://chromium-review.googlesource.com/520732Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476195}

BUG=727989
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2919703002
Cr-Commit-Position: refs/heads/master@{#476194}

is invoked instead of relying on comments.

BUG=716563

Review-Url: https://codereview.chromium.org/2914853002
Cr-Commit-Position: refs/heads/master@{#476193}

Previously, NotifyError was called before delegate_ was assigned to
which meant that the delegate was not notified of any errors.

Review-Url: https://codereview.chromium.org/2918663002
Cr-Commit-Position: refs/heads/master@{#476192}

Remove duplicates from translate_manager_unittest and translate_ui_delegate_unittest.

BUG=727436

Review-Url: https://codereview.chromium.org/2906233004
Cr-Commit-Position: refs/heads/master@{#476191}

Also enable media_blink_tests on Android bots to prevent this from
happening again.

Note that platform Opus is only supported on Android L and above.
Therefore some tests may fail on older devices (e.g. KitKat). This
difference isn't really interesting to KeySystemConfigSelectorTest
though.

In a future CL, I will fix the test further to make it work on older
devices.

BUG=727783
TEST=Fixes existing tests and enable tests on more bots.

Change-Id: I93becd70216575122e149bd89fb77e4d506d332f
Reviewed-on: https://chromium-review.googlesource.com/518626Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476190}

Review-Url: https://codereview.chromium.org/2921523002
Cr-Commit-Position: refs/heads/master@{#476189}

https: //chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#Unnamed-namespaces
Review-Url: https://codereview.chromium.org/2909543003
Cr-Commit-Position: refs/heads/master@{#476188}

This change removes the static method interface from CSSVariableResolver.
Users of the class now need to instantiate an instance of it to use its
functionality.
This change is in preparation for making variable resolution co-recursive
with registered custom property animation application. The object interface
is required to be able to persist variable resolution state throughout the
recursion.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2878853002
Cr-Commit-Position: refs/heads/master@{#476187}

This enum is only used by TextMatch markers and should be defined in
TextMatchMarker.

BUG=707867
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2907643004
Cr-Commit-Position: refs/heads/master@{#476186}

renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //net

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2894863002
Cr-Commit-Position: refs/heads/master@{#476185}

https://codereview.chromium.org/2897833002 unintentionally broke WebMidi for
insecure origins. This CL fixes that and adds a test.

BUG=727699

Review-Url: https://codereview.chromium.org/2914963002
Cr-Commit-Position: refs/heads/master@{#476184}

https://pdfium.googlesource.com/pdfium.git/+log/26cb2fa42b1a..9c6b37c469e3

$ git log 26cb2fa42..9c6b37c46 --date=short --no-merges --format='%ad %ae %s'
2017-05-31 tsepez Rename FXJPEG_Context and use unowned ptr
2017-05-31 tsepez Put all CCodec_PngModule state into its context.
2017-05-31 tsepez Move all of ccodec_bmpmodule state to its context
2017-05-31 wileyrr Add missing public APIs to API test.
2017-05-30 tsepez CFXJS_Engine::GetObjDefnID is a static method
2017-05-30 tsepez Fix OnDestroy method for scroll bars

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iccda0225162fbae4d6e5224639c59e64908e736b
Reviewed-on: https://chromium-review.googlesource.com/520568
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476183}

Migrating all remaining tests:

DuplexSettingsTrue
DuplexSettingsFalse
PrinterChangeUpdatesPreview
NoPDFPluginErrorMessage
CustomPaperNames
AdvancedSettings1Option
AdvancedSettings2Options
InitIssuesOneRequest
InvalidSettingsError
GenerateDraft

BUG=726536

Review-Url: https://codereview.chromium.org/2920593002
Cr-Commit-Position: refs/heads/master@{#476182}

Revert of Remove a frame of delay on main-thread FlingStart. (patchset #1 id:1 of https://codereview.chromium.org/2908073008/ )

Reason for revert:
Possible cause of flakiness in fast/events/touch/gesture/pad-gesture-fling.html ; see e.g. https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/8992 .

Original issue's description:
> Remove a frame of delay on main-thread FlingStart.
>
> Main-thread flings were waiting for the first frame of animation to
> populate the start timestamp, and only on the second frame would they
> start animating.  But the start timestamp is included in the FlingStart
> event, so there's no need for this (perhaps it was written that way for
> historical reasons when the event timestamp wasn't populated properly).
>
> This problem was extremely noticeable in prototype of middle-click autoscroll
> that issues a FlingStart on every MouseMove to change velocity, but
> the fix should also benefit touchscreen and touchpad flings slightly.
>
> BUG=727964
>
> Review-Url: https://codereview.chromium.org/2908073008
> Cr-Commit-Position: refs/heads/master@{#475984}
> Committed: https://chromium.googlesource.com/chromium/src/+/3562f1b7410b884e07bbd2fc75cfee7e96ed2a41

TBR=jbroman@chromium.org,dtapuska@chromium.org,aelias@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=727964

Review-Url: https://codereview.chromium.org/2917823003
Cr-Commit-Position: refs/heads/master@{#476181}

Moving the observed attributes is faster than allocating a new set.

Bug: 710184
Change-Id: If6c6ba636f91a90666eaff53adc8b545fa71bc87
Reviewed-on: https://chromium-review.googlesource.com/517451Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Cooney <dominicc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476180}

This change refactors the storage of active animation interpolations
during a style resolve update by whether it targets a custom property
or a standard property. This makes it consistent with active transition
interpolations.

This change is necessary to process custom property animations separately
from standard properties in future patches.

This patch introduces no changes in behaviour.

BUG=671904

Review-Url: https://codereview.chromium.org/2831273002
Cr-Commit-Position: refs/heads/master@{#476179}

We currently have some logic (dating back to 2005) to not show the selection
highlight if we're also showing a composition underline. We're not 100% sure
why this (probably to avoid some sort of interaction between the selection
color and the underline), but we think it's unnecessary. There are already
certain interactions we don't do anything about, for example the composition
underline matching the background color of the text.

This CL removes this logic so we can show the selection highlight while the
Android Voice IME (which keeps an underlined composition range open) is
active.

BUG=628670
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2896273003
Cr-Commit-Position: refs/heads/master@{#476178}

Bug: 712963
Change-Id: Ie0cd96ec38a027ef6e62ef93debc7f6e93ca31c4
Reviewed-on: https://chromium-review.googlesource.com/520822Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476177}

In preperation for moving PageOverlay to core I also changed it to use
WebFrameWidgetBase rather than WebFrameWidgetImpl.

Bug: 712963
Change-Id: Ic20f42c7bb9cdbab82ddb9e940c08b185d7c6c46
Reviewed-on: https://chromium-review.googlesource.com/518602Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476176}

This CL adds a base::SharedMemoryHandle getter to
gpu::TransferBufferInterface. The getter will be used by
TransferBufferInterface users when OnMemoryDump is called to create
base::SharedMemory dumps.

This is part of work for exposing SharedMemory usages on tracing
memory-infra dumps.

Design doc: https://docs.google.com/document/d/16Mi5_puxKgQ-9IX7ANfbji0WiqBCK3yrnJ0Qi2wa3w0/edit#heading=h.lofdeze1a2hr

BUG=604726
TEST=gpu_unittests --gtest_filter=TransferBufferTest.*
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2910093004
Cr-Commit-Position: refs/heads/master@{#476175}

Design doc:
https://docs.google.com/document/d/1-q-vrxqNZDnwajpOwMWB_Z1YlzQUiApJZmSUzGkojv4/edit#heading=h.3bxjhvo21dyq

Integration Steps:
https://docs.google.com/document/d/1es1cCRFhdag4ljGSPfXfSMlEx5lMgFZ3SGHMaBcU_D8/edit#

BUG=

Review-Url: https://codereview.chromium.org/2911603002
Cr-Commit-Position: refs/heads/master@{#476174}

The edge cases include:

(1) Adjust drop down menu position to avoid going beyond screen border.
(2) Adjust 'Add supervised user' z-index to prevent being blocked by
the scroll bar.
(3) When hiding bottom empty area, check screen size instead of virtual
keyboard status as the latter may not be updated in time.
(4) Add animation for switching main pod.
(5) Add animation for drop down menu button.
(6) Adjust the position and style of sign-in banner.
(7) The border of 'more settings' in header bar is adjusted to be square.
(8) Adjust scroll bar style to prevent it from occasionally flicking.
(9) Add Oobe.clearErrors() in several places, basically error bubbles
will be cleared as long as there's user click event, or orientation
change, hiding / showing virtual keyboard or user removal. This part
is subject to further evaluation.
(10) Add outline to avatar.
(11) Old codes unrelated to the new design are removed.
(12) Add an additional safety check to see if the screen height is large
enough for the current pod padding choice, and switch to scrollable
container case if it's not large enough.

The new login screen is testable after this CL, though the following
work is still blocked by not having assets yet:

(1) Public session pod.
(2) Badges for supervised user, signed-in user, etc.
(3) Caps lock icon and smart lock icon.

In addition, codes for a very hacky way of testing is added. We may have
to remove them in the future but I'd like to keep them for now.

BUG=718159
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2910203003
Cr-Commit-Position: refs/heads/master@{#476173}

Wake Lock is a Mojo interface that wraps PowerSaveBlocker. As part of the
creation of standalone Device Service, all browser-side clients of
PowerSaveBlocker should be converted to be clients of the Wake Lock Mojo
interface instead.

BUG=689415

Review-Url: https://codereview.chromium.org/2891293002
Cr-Commit-Position: refs/heads/master@{#476172}

Bug: 678481, 697971
Change-Id: If541578be54d0bdec51adfc8096850d03dda1e3f
Reviewed-on: https://chromium-review.googlesource.com/517024Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476171}

BUG=546208

Review-Url: https://codereview.chromium.org/2822753002
Cr-Commit-Position: refs/heads/master@{#476170}

BUG=546208

Review-Url: https://codereview.chromium.org/2819903002
Cr-Commit-Position: refs/heads/master@{#476169}

BUG=546208

Review-Url: https://codereview.chromium.org/2824543002
Cr-Commit-Position: refs/heads/master@{#476168}

r474547 regressed PerformanceTests/DOM/modify-element-classname.html. This CL
fixes it by skipping hash lookup.

Before r474547: Average 148.5ms
After r474547:  Average 158.8ms
This CL:        Average 133.3ms

Bug: 727467
Change-Id: I1f382514b06dd3a7209df67781f20e9415556372
Reviewed-on: https://chromium-review.googlesource.com/517616Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476167}

Sync ShelfModels between ShelfController and ChromeLauncherController.
(allows synchronous access to ShelfModel/ShelfItem in Ash and Chrome)
This brings us much closer to a functional Shelf in Mash.
Implements step (2Bd) of my Mash Shelf Model and Control plan:
  docs.google.com/document/d/1wD0W2VKAEyeslXxc4L-QpOxZlIyaSZ74oSMndmrF120

Extend ShelfController interface to support ShelfModel modifications.
Extend ShelfObserver interface to report ShelfModel modifications.

Add/restore old ash::ShelfModelObserver::ShelfItemDelegateChanged.
Make mojom::ShelfItem::image optional (for tests and async load).
Make ShelfController and ChromeLauncherController observe and sync.
Avoid cyclically reporting remote changes with a flag.

Add RemoteShelfItemDelegate; to delegate between Ash and Chrome.
(allows ShelfModel to own/use ash::ShelfItemDelegate instances)
Add a binding and helper function on ash::ShelfItemDelegate.

Remove Mash's workaround code in ShelfWindowWatcher.
Remove unused/deprecated ash::mojom::ShelfController functions.

Add AppList item in model ctor and its delegate in controller ctor.
(avoids item ordering problems on init, Ash owns item delegate)

Add missing type mapping for ash::ShelfID and ash.mojom.ShelfID.
Add a stream output operator for ShelfID testing/logging.

Change chromeos::GetAshConfig to support --mash and --mus flags.
(This allows unit_tests to run in simulated mus/mash configs).

Add and update shelf controller, model, and CLC tests.
Replace a CLC panel test with ShelfWindowWatcherTest.ItemIcon.

TODO: Fix context menus, AppList's PinToShelf, etc.
TODO: Ensure that windows like QuickLaunch get shelf items.

BUG=557406
TEST=No Chrome OS changes; mash shelf shows pinned items, etc.
R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org,

Review-Url: https://codereview.chromium.org/2833173002
Cr-Commit-Position: refs/heads/master@{#476166}