- 10 Apr, 2020 40 commits
-
-
Matt Menke authored
We want to remove the single argument version of the method, rather than have consumers assemble a header in the form of "foo: bar" by joining two strings. Having AddHeaders itself do this in only one place is safer and allows it to validate the key and value arguments are reasonable. Also, the single argument overload places limitations on the implementation of AddHeaders works, unless we want to have AddHeaders potentially parse the single string (that many consumers just merged from two separate strings) into a name/value pair, so ideally we can just remove it, once consumers are all converted to use the two-argument overload. Bug: 1068194 Change-Id: Ida6ec5cf190a397d9f0f896da0d6f876580bf761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144821Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#758330}
-
Aaron Gable authored
This tester runs three kinds of tests: * chromium_mac_gtests, which are completely swarmed * chromium_mac_rel_isolated_scripts, which are also swarmed * chromium_mac_scripts, which are identical to chromium_linux_scripts, and which run on linux just fine This means that the OS of the Mac10.15 Tests builder shouldn't matter, all that matters is the OS of the hosts running its triggered swarming tasks, which this CL doesn't change. Assuming this goes well, I will also convert the other Mac testers (10.10, 10.11, 10.12, 10.13, and 10.14, all on the main waterfall) to also use Linux hosts. This will both free up some mac capacity to use for compilers and testers, and make these builders "builderless" which should help with capacity and scheduling. Bug: 1061582 Change-Id: I307db015865288136e7fec0921942e051547be90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146053 Commit-Queue: Aaron Gable <agable@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#758329}
-
Yue Zhang authored
For some devices in landscape mode, the IPH entrance might not be completely showing on the screen and thus Espresso cannot correctly perform a click. This is causing the test to fail on x86 Pie trybots. This CL fixes this issue by making it scroll to a position where the view is completely showing for Espresso to click. Bug: 1069809 Change-Id: I7ec8b5f43ebdfb318472ae923bce4080c917f7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144455 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758328}
-
Reilly Grant authored
This test appears to be flaky. Disabling the test on ASan to reduce noise on the waterfall. Bug: 1047723 Change-Id: Iace17cdb214d851ffe4fecde2a715aa80f0b2a77 Tbr: brucedawson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145958Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758327}
-
Carlos Knippschild authored
Also addresses other issues with the archive publishing code and fixes one DCHECK that would trigger when it shouldn't. Bug: 1010916 Change-Id: Ie6d47201260d86f8ecca944c2655c967803440d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138633Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758326}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: Ib925c0fdd2ea15bc5eca2da14b7260f48e156190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140929 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#758325}
-
Daniel Rubery authored
This was functionally incorrect (unregistering the wrong tokens) and is causing crashes in M83, blocking the WebProtect release. Since it was only added to support privacy requirements for APP scanning, simply remove this functionality and I'll correctly re-introduce it in M84. Bug: 1068732 Change-Id: I38ac3ba3a39564f1342c3cb4f9f57794bf2aeace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144467Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#758324}
-
Bettina authored
Based on the custom attributes sent from update client, if there is a key that describes the extension as malware, disable the extension. The custom attributes are stored in an extension-specific pref. An extension is disabled if a "_malware" key is found otherwise it checks if it needs to be re-enabled if it was previously disabled remotely. Bug: 1038797 Change-Id: I6aa72bac49417778df7b723b462752a7c0e6a560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073064 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#758323}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95c26efc9049..daf94c56bcb3 git log 95c26efc9049..daf94c56bcb3 --date=short --first-parent --format='%ad %ae %s' 2020-04-10 bsalomon@google.com Fix attrib order with local coords in AALinearizingConvexPathRenderer 2020-04-10 egdaniel@google.com Reland "Split apart flushing and submitting in the GrGpu classes and GrDrawingManager." Created with: gclient setdep -r src/third_party/skia@daf94c56bcb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Id3fc04ca45447199629f8e8b598083181307fd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145915Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758322}
-
Bill Budge authored
- Adds kCodeCacheDeduplicationStudy feature. - Adds kCodeCacheDeduplicationThreshold feature parameter. Bug: chromium:936107 Change-Id: Ibb9f2cca2b14c4dccba59c1194560f84f2ba906c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124972Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#758321}
-
David Bertoni authored
The CL adds a synchronization point between the browser and the renderer at the transition from incognito mode disabled to enabled. Bug: 1015136 Change-Id: Id29f5dc115f318cd5a7e08beac85d50d4793aa01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039595 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758320}
-
Bettina authored
The if statement for change_password_button was reversed and used the object when it was null. Bug: 1068396 Change-Id: I13fce75f5aaeee0749a59de08bd439362d93b4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145677 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I1605422bd71e8712547ab93a29dff20e2f54c5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144457Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758318}
-
Reilly Grant authored
This test appears to be flaky. Disabling to reduce noise on the CQ and waterfall. Bug: 1048623 Change-Id: Ib103cf4bc7d2cbc61e355f9ffea2b68052b03291 Tbr: vakh@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145682Reviewed-by:
-
Sam Bowen authored
Bug: 1064748 Change-Id: I74627723099d1b09359cd6fa7575136a39b0d01a Binary-Size: The binary size of the generated code was reduced as much as possible in https://crrev.com/c/2144773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137514 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#758316}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68353dd74e3e..3431cbde4e5a Created with: gclient setdep -r src-internal@3431cbde4e5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046880,chromium:1058152 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I6b3191fd5ddc060cb9b60ecbb79d2b49df254c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145914Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758315}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib65dd541d00deed6c72dcf5596358c00974b4b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145382Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#758314}
-
Jian Li authored
Bug: 1044139 Change-Id: I1ecaf8f68dd047353ea746fa94f73004a5a35205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142952 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cf9ec0ae80a4..b36549d189fb git log cf9ec0ae80a4..b36549d189fb --date=short --first-parent --format='%ad %ae %s' 2020-04-10 brgoddar@microsoft.com Network: Update Search to Activate Requests when clicked Created with: gclient setdep -r src/third_party/devtools-frontend/src@b36549d189fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068747 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I15a2a576a693f60226b00cc28f5f85fe468134fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145918Reviewed-by:
-
ssid authored
The experiment is not launched yet due to few bugs and the current release delays. So, extend till 86. BUG=1068217 Change-Id: Ia1562665588d7fa6872e929990905381e1000051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143887Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#758311}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I2aa3940ad452f340d6d50361fb742f9d653e5e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145374Reviewed-by:
-
Robert Sesek authored
Also removes all the unused #includes for the types. Change-Id: I50b28c65bf132d8bf970863f9375bc4316781bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138504Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#758309}
-
Gang Wu authored
This reverts commit 3f46dedb. Reason for revert: The test is still flaky Original change's description: > Increase the timeout for criteria check > > From previous enabled test run, > https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_shell_test_apk&tests=ClipboardTest%23testCopyDocumentFragment > It seems most of failure happened on slow devices, like x86. > So increase the timeout for CriteriaHelper.pollUiThread(). > > Bug: 791021 > Change-Id: I89430d2fbf89196a3813b1e175d2fd56090e079b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144814 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Gang Wu <gangwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758050} TBR=yfriedman@chromium.org,gangwu@chromium.org Change-Id: Ie5e138111645d19193b319ae1210b863fe721000 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146073Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758308}
-
Rakib Hasan authored
This reverts commit d8f56276. Reason for revert: The original CL should not have been reverted. That was a planned outage. CL's post Chrome internal roll are compiling correctly. Original change's description: > Revert "Remove ImmersiveModeManager and related code." > > This reverts commit b5fff4e4. > > Reason for revert: Causing android perf builders to fail compiling Clank. crbug.com/1069913 > > Original change's description: > > Remove ImmersiveModeManager and related code. > > > > BUG=949819 > > > > Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928 > > Reviewed-by: Matthew Jones <mdjones@chromium.org> > > Commit-Queue: Theresa <twellington@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758248} > > TBR=twellington@chromium.org,mdjones@chromium.org > > Change-Id: I2dbc931d813fbbdf804f505632508caff373e439 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 949819 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144470 > Reviewed-by: Rakib Hasan <rmhasan@google.com> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#758306} TBR=twellington@chromium.org,mdjones@chromium.org,rmhasan@google.com Change-Id: Ie955c8aff2adb2573b8d62ced97228f4abbc3836 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145962Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#758307}
-
Rakib Hasan authored
This reverts commit b5fff4e4. Reason for revert: Causing android perf builders to fail compiling Clank. crbug.com/1069913 Original change's description: > Remove ImmersiveModeManager and related code. > > BUG=949819 > > Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758248} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: I2dbc931d813fbbdf804f505632508caff373e439 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144470Reviewed-by:
-
Rakib Hasan authored
This reverts commit d60e79d1. Reason for revert: CL is causing 40+ rendering.mobile benchmarks to fail for webview on nexus5x and pixel2. crbug.com/1069834. Original change's description: > Limit access to gpu thread in DisplayResourceProvider > > This CL makes sure that DisplayResourceProvider return resources only > when GPU Thread is available to make sure ReleaseImageContexts will > complete in finite time. > > This doesn't change anything for Chrome where GPU Thread is always > available, but on webview RenderThread that used for gpu access during > composition is available only during specific times (init, dtor, > DrawAndSwap) > > Bug: 1068716 > > Change-Id: I8fa482ab7399d6ce7639c1d76187be86ce152059 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138551 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757967} TBR=backer@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1068716, 1069834 Change-Id: Ibc08eb8ce77d8cb620b6f3c249211e4f425802ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145953Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f0b36c4610d..fdabfbc3349a git log 9f0b36c4610d..fdabfbc3349a --date=short --first-parent --format='%ad %ae %s' 2020-04-10 marinaciocea@webrtc.org [InsertableStreams] Pass ssrc on TransformedFrameCallback registration. Created with: gclient setdep -r src/third_party/webrtc@fdabfbc3349a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065838 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2b69cad7cc40f0211532dd42a7a016d5977ec83e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145789Reviewed-by:
-
Rakib M. Hasan authored
We want to create a layout-test-results folder and put the json results file in there. The bot will be changed so that it creates a storage bucket where the results file can be retrieved by the rebaseline tool. TEST: Look for the "archive results for weblayer_shell_wpt (with patch)" step in trybot. Check for full_results.json file in downloadable archive. TBR=robertma@chromium.org Bug: 1050760, 1050754 Change-Id: If0912629053b4972e1426af6ea3bb3f061fbb128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140095 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Andrew Luo <aluo@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#758303}
-
Lukasz Anforowicz authored
This CL modifies tests that expect that a request is blocked by CORS. Before this CL, such tests would only verify that the request errored out (which can happen for non-CORS related reasons - see https://crbug.com/1051594#c9). After this CL, such tests also verify that CORS emitted an error message to the console. Bug: 1051594 Change-Id: I0230e915e56398a70cd511fc7febe39d264e4a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137851 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#758302}
-
Lukasz Anforowicz authored
Fixed: 1069593 Change-Id: I43566687b2631634529b0f41e49f3ba92bcd04ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144680 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Roberto Carrillo authored
R=chanli,nodir,bpastene Bug: 1027762 Change-Id: I39a7ed5a098566e28bd4c13345c1e5a2495ad15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144462Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#758300}
-
Daniel McArdle authored
Change-Id: Ie79129dc38ac5c85388c7875e969b19d3a7e4e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143863Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#758299}
-
Matt Menke authored
Also convert all of net/ to use it instead of the one-argument constructor. The one argument constructor takes arguments in the form of "foo: bar", which results in a bunch of code redundantly merging keys and values into a single string to pass it in. Also add a SetHeader convenience method which is a combination of RemoveHeader and AddHeader. Having AddHeader itself do this in only one place is safer and allows it to validate the key and value arguments are reasonable. Also, the single argument overload places limitations on the implementation of AddHeader works, unless we want to have AddHeader potentially parse the single string (that many consumers just merged from two separate strings) into a name/value pair, so ideally we can just remove it, once consumers are all converted to use the two-argument overload. Bug: 1068194 Change-Id: I19734b9e597799234c0f50b2312540be559dc302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140553Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 1032328 Change-Id: Id2c69183598d01f08f8fd20f4134b0c3cba863ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145599 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#758297}
-
Chris Thompson authored
Before we required Organization, Country, and Locality to be set, but EV certificates require Organization, Country, and at least one of Locality OR State. This updates the check in PageInfoBubbleView to only check the fields that are actually used in the UI, and adds a regression test (and certificate) exercising this case. Fixed: 1069113 Change-Id: I5a5eff339eb875fa4d36c61f0e5ffc1d4ba95ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142714Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#758296}
-
Garrett Beaty authored
This will provide a more helpful error message than what some users have already experienced where it just complains about an undefined symbol. Change-Id: I9dabe2333650b29d2dd585efd386edef8ff84d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144466 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I45649ec0896194dbbb7ad9753046d655ae0b88f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140927Reviewed-by:
-
Reilly Grant authored
This test appears to be flaky. See the attached bug for details. Bug: 1069870 Change-Id: I12f20a5261ae0e5e5888904c409d399f655a06d9 Tbr: afakhry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145864Reviewed-by:
-
Collin Baker authored
This is intended to show redundant layouts occurring on the switch between touch and non-touch mode. Especially, traces produced by perf bots will be easier to debug. See the bug for a motivating case. Bug: 1054489 Change-Id: I108053677429b2b9c6c62c5f97ba81b4e63e8e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134699Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#758292}
-
Esmael El-Moslimany authored
This CL uses the same approach to update the OneGoogleBar theme as the following CL. https://chromium-review.googlesource.com/c/chromium/src/+/605951/ After the theme and OneGoogleBar are loaded, a message is posted to the OneGoogleBar iframe to turn on/off dark theme based on the theme. When a background is selected in the customize dialog, the OneGoogleBar is also updated by setting dark theme when previewing an image. Bug: 1039913 Change-Id: I7d420be98006185e0d55d5d41fdbe0f267c08875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145818 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
